From nobody Mon Apr 6 23:14:25 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F87C344DB0 for ; Tue, 17 Mar 2026 19:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773776691; cv=none; b=mbtCCKmV0iOejcjmqYWTEM7ohEJWyPkpZs0fUX+tVC/Pt9sUcxGRZKZ9v2Dr5nXDxjGzQjMy8IPTsxP2S0iGZta2dETzRlWzJ0Re/EApBPXSARh5E2qqibv0zAlalp4dCDFGt/80tY/Cz+bgOL9FlGyox2Hb6poAjb6s6eKhumk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773776691; c=relaxed/simple; bh=iUjasimP5+ky9qKqqpISytS+Xv3jTe4n2zAFs2FsfCs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=g3pBXgS06HMqYG9U0FrYeM02TUBqLeJQconahWcUrjtneptOlK0csB+pa9zVGQ1YG5GVFxQZb83ObbZY1zWrMydCjJRT9gt7I6beBoOsmM4NtyyLG4Tx2kgzqGKgBtaIuOBmpZS/AIJ5m9ejimTOJ0nmoHDzsMkw3XisTf+6Op0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hSL4k57X; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hSL4k57X" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-439af7d77f0so4557048f8f.0 for ; Tue, 17 Mar 2026 12:44:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773776689; x=1774381489; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=X3fwT/mI+98cVYuLBwkfIUddmcoX9bFrR6d/WpZ9rik=; b=hSL4k57X30xYn5Bx8cEntlolE4PY72JXdZm3sAyMmn1XK8YG0BzHPTjoyJvrmS6ght dHN0bn4uth9T9CYpTq8DabOSE0BLUmVwvhpaosTOg0bhSeNcajyxp6g2dlvxkTVKXio3 DFDApIUX1NfaqvhC7dd7yd6y/tt7/Zcd0RGSxfQ8o4ZN7T3QoYbHdKt8nqZ7igr56ond zGeZas8DGHXcyzt+WJ/ogEVa11uwoHlF57DSaVBKu6qVt46hNhx+QrHf62mkTEt7Hn2C 4d+0xBj3hRuhzNY7NYnywR1Md4l+KRd+V62DsLHSCOoMNqjBAEDzWjsCstL3oV2gh4G1 7sgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773776689; x=1774381489; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X3fwT/mI+98cVYuLBwkfIUddmcoX9bFrR6d/WpZ9rik=; b=SOxJ4/3TUNPuz2RETn3rAQP2vFdJ39TowsHOq2OBfpaRgDcxmmDMkNpu+tJnwzofZW nf2zirFeH49Ke11JFegsC4utFrdgqTQHeHNSTYzQf1CbY+/xbz2qqq4pClHZUkgSQsqh 7fcESonifrR77tHoiGSF1I/0VvjGtCt3xHf+UTyQ8gd7XfX41zXLuRiua7wMDpdya/1k FrJ5V8h2VRe7z5+lG1gMrDrKYUzaHRmx7P4UDMtZg+UoASfAyOHF0hduFx2a95GfGoPE +dEtaVNDPGzxPEFklKawGMZEobTEUbb8hRB4JCHtuFpT6YleNXsRwYk3jSlVLn3XFX08 /vqA== X-Forwarded-Encrypted: i=1; AJvYcCX6IhRc1e7+SUfqOwNDF1FXRJcLqWew2TkehFzvf3dKTRxatQstCKKEydq5YrOPxsC5W6mRENPC4z9il+8=@vger.kernel.org X-Gm-Message-State: AOJu0YwNXlJIgH3CgL+sz870AAqBR56ReXJnL1buCbfKz+NzzucrmWdX 85LopPmqvIOt393Oc5QdxvF+GvS74jihb/+z/Q0swugkCdmJg5eEu2Mc X-Gm-Gg: ATEYQzxlxSRQCiML241gmJgxU/2o9+yONEjuMqySXYHRfczL4WVlWxeyvl/fC1xzAPa X7z/I+EY1cZoQZx2s2nzt5jlN5zufg63BI1ptZnWkJciwnD1HxPSzqLx0zuwa1MI94/0Ah0WXOe yZ9glsm0Y0lcg5bCP0hZD1C3jBtXj7nAczT+IMzPUP9pUjtC+qTvjbPrQuaUEaCTZJ5Ivx4rXjh QGveRyPJdEvvB9QH51h/H7S+iM35kkIaiMj5RMjcFu9QPK99XU3kkQFhXvJ1kEuAgb6sIXt7bp6 42BTQh7rhYSA58ciLkjaqyU5HmZ0nttpyWmCrVgrWImVCTLuYKiFaa20go4HKOYGyMNDYqtmhrY PUd7zUfKCAqv8Fx94AMfi8vvj3GMD96tADqAWl0Pjs8X61+JTReORMtCrNpnaBXcGH28DWT56U+ trS0Mzps+JMY5yVdvJJwwGGmluHoSqwWpU0yZj6uZiJpdB6Qvv X-Received: by 2002:a5d:5d0b:0:b0:439:df60:f87a with SMTP id ffacd0b85a97d-43b527c7b4amr846878f8f.46.1773776688697; Tue, 17 Mar 2026 12:44:48 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:e16b:fc56:e220:9aa9]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b51892161sm1788235f8f.21.2026.03.17.12.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 12:44:47 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Geert Uytterhoeven , Michael Turquette , Stephen Boyd , Philipp Zabel Cc: Biju Das , linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v4 2/9] clk: renesas: rzg2l-cpg: Add support for critical resets Date: Tue, 17 Mar 2026 19:44:29 +0000 Message-ID: <20260317194442.468147-3-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260317194442.468147-1-biju.das.jz@bp.renesas.com> References: <20260317194442.468147-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das Some reset lines must remain deasserted at all times after boot, as asserting them would disable critical system functionality with no owning driver to restore them. This mirrors the existing crit_mod_clks mechanism which protects critical module clocks from being disabled. On RZ/G2L family SoCs, the DMA reset must be remain deasserted for routing some peripheral interrupts to CPU. Add crit_resets and num_crit_resets fields to struct rzg2l_cpg_info to allow SoC-specific data tables to declare reset IDs that must never be asserted. Introduce rzg2l_cpg_deassert_crit_resets() to iterate over all critical resets and deassert them. Call it both at probe time and during resume to ensure critical peripherals are held out of reset after power-on and suspend/resume cycles. Signed-off-by: Biju Das --- v4: * Moved this patch from [1] as it is boot-dependent [1] https://lore.kernel.org/all/20260306134228.871815-1-biju.das.jz@bp.ren= esas.com/ --- drivers/clk/renesas/rzg2l-cpg.c | 33 +++++++++++++++++++++++++++++++++ drivers/clk/renesas/rzg2l-cpg.h | 7 +++++++ 2 files changed, 40 insertions(+) diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cp= g.c index c0584bab58a3..8165c163143a 100644 --- a/drivers/clk/renesas/rzg2l-cpg.c +++ b/drivers/clk/renesas/rzg2l-cpg.c @@ -1765,6 +1765,15 @@ static int __rzg2l_cpg_assert(struct reset_controlle= r_dev *rcdev, dev_dbg(rcdev->dev, "%s id:%ld offset:0x%x\n", assert ? "assert" : "deassert", id, CLK_RST_R(reg)); =20 + if (assert) { + unsigned int i; + + for (i =3D 0; i < priv->info->num_crit_resets; i++) { + if (id =3D=3D priv->info->crit_resets[i]) + return 0; + } + } + if (!assert) value |=3D mask; writel(value, priv->base + CLK_RST_R(reg)); @@ -1802,6 +1811,21 @@ static int rzg2l_cpg_deassert(struct reset_controlle= r_dev *rcdev, return __rzg2l_cpg_assert(rcdev, id, false); } =20 +static int rzg2l_cpg_deassert_crit_resets(struct reset_controller_dev *rcd= ev, + const struct rzg2l_cpg_info *info) +{ + unsigned int i; + int ret; + + for (i =3D 0; i < info->num_crit_resets; i++) { + ret =3D rzg2l_cpg_deassert(rcdev, info->crit_resets[i]); + if (ret) + return ret; + } + + return 0; +} + static int rzg2l_cpg_reset(struct reset_controller_dev *rcdev, unsigned long id) { @@ -2051,6 +2075,10 @@ static int __init rzg2l_cpg_probe(struct platform_de= vice *pdev) if (error) return error; =20 + error =3D rzg2l_cpg_deassert_crit_resets(&priv->rcdev, info); + if (error) + return error; + debugfs_create_file("mstop", 0444, NULL, priv, &rzg2l_mod_clock_mstop_fop= s); return 0; } @@ -2058,6 +2086,11 @@ static int __init rzg2l_cpg_probe(struct platform_de= vice *pdev) static int rzg2l_cpg_resume(struct device *dev) { struct rzg2l_cpg_priv *priv =3D dev_get_drvdata(dev); + int ret; + + ret =3D rzg2l_cpg_deassert_crit_resets(&priv->rcdev, priv->info); + if (ret) + return ret; =20 rzg2l_mod_clock_init_mstop(priv); =20 diff --git a/drivers/clk/renesas/rzg2l-cpg.h b/drivers/clk/renesas/rzg2l-cp= g.h index 55e815be16c8..af0a003d93f7 100644 --- a/drivers/clk/renesas/rzg2l-cpg.h +++ b/drivers/clk/renesas/rzg2l-cpg.h @@ -276,6 +276,9 @@ struct rzg2l_reset { * @crit_mod_clks: Array with Module Clock IDs of critical clocks that * should not be disabled without a knowledgeable driver * @num_crit_mod_clks: Number of entries in crit_mod_clks[] + * @crit_resets: Array with Reset IDs of critical resets that should not be + * asserted without a knowledgeable driver + * @num_crit_resets: Number of entries in crit_resets[] * @has_clk_mon_regs: Flag indicating whether the SoC has CLK_MON registers */ struct rzg2l_cpg_info { @@ -302,6 +305,10 @@ struct rzg2l_cpg_info { const unsigned int *crit_mod_clks; unsigned int num_crit_mod_clks; =20 + /* Critical Resets that should not be asserted */ + const unsigned int *crit_resets; + unsigned int num_crit_resets; + bool has_clk_mon_regs; }; =20 --=20 2.43.0