From nobody Mon Apr 6 21:35:23 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07B1A342177 for ; Tue, 17 Mar 2026 19:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773775986; cv=none; b=IFF6WS5qlRNc5odC8yjgBJpaEB06nV3yQS3XzcAuXDwx8C71Ob9IfTvjsQzzn5KtYoVGO0Tzhet6fD2kyBb5k/4rYB5P05K4F21YsXouZokY8zEybSAgQho6w+old/v/80VIskpzjTMWIeUKfdJ3S2DeJz2wFMNuxk7ak3DjjJY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773775986; c=relaxed/simple; bh=dqp1zvmx65EDKVVEH6MHWp/Qx+PR2wL3UG9MY8FVJQQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=XawNj/+cnUaXtpiQk4JH+jqm73a6OXkx9cqnKRr28HH4FBERTPl2BAf0+4jAay3F5FMJEYEdftcR1wFaSfbkHXs/kMRwxhKy4prZCZrY0/km7FXW6ogwuoZULwAPEP+dV5CFLCm61qIg4iofbgugM1TqXjN6w+yYvcpBkXNfUMQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hhL+DQxO; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hhL+DQxO" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48534237460so66072045e9.3 for ; Tue, 17 Mar 2026 12:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773775983; x=1774380783; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Hglc4bApGbsTPm3VNAsufBTglatoDFtPjLPG0pQ/WOA=; b=hhL+DQxOPzN+IH6Jd7pet6G2VSbk1lENSofHr/BDEzptrrmmURgMhXh1tX16a/RMse bBzbpitQUWILbRNlt5ND9nQFILWAdB6FMC/q7mhEWbIro7sQAhFrFUCMAxZfDxJFB3Y5 b2/QgTb7oyZYHHnsHpnqYBZcct5RidFWrhuJ0G6OWdmKJvq1ZF0f5YEjM81zCwhokDzi U9tSWTA6IuJuha7/4tP43KFu+zUsCb8asMk8oO1l6NEe3oPzjQoaRlpd/H3PSIemidaY SsDPgfgb+p/A7/dVtgZFpCMBC10BynN9vHi9bUhHyOKkkGsrZ8S4rNjblw4DcWuKFqWq dqpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773775983; x=1774380783; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Hglc4bApGbsTPm3VNAsufBTglatoDFtPjLPG0pQ/WOA=; b=CtKFJKk35HAnav8KOqtAtrukRD7xzSajUDjBd5tW7/00yO3867IsZQphkp0zmJbf4X sSs2wkytWwDJY9ejBfzgJU4doG8dCOAraCWJJU3g/v1PnXs42wg790R9NV6J3hic+RhE W6SXSviRjP6FNTwLbsR+fBpZWgfJYSCqGyBqBIsSIVaC5MRH95arjq2AMrAMEHdNE3Ir yRTFGPe1PA+06b8DmyZLCUr58BWHJP6kVLqNCthyw0QcDuLiCdJXwbI8qcx9t79NnPCH PpLhPJHVfedOz+Vq01O8saau7B8qfGyc4WL8R46PHdObqlXotOG93qQShmEsjfFXVE4d u3zQ== X-Forwarded-Encrypted: i=1; AJvYcCVZ6l6dx77FWLQYw4S3+W2OJu8c1wnHWTi2Hiq9EWUZCsCXLtOa25UeKJlGq7RHiDT281vUG5aYQsn6ABw=@vger.kernel.org X-Gm-Message-State: AOJu0YxDwuqjD1ch252MqoT3jDmdgiqDFYScL8MVHUZMbc9sD0S8ias+ CoZV/ZSkj0B/nEHFZrg2rl7LSg7TSX1kqA9/pURrJgzzL3PyqVmJP50E X-Gm-Gg: ATEYQzym9QLGEhhKHYdo9vGGEma0Kcx81H9r+5ZO9jccYw42THq00bXn0CWPsiIMcIF 3UNCAhn3t+ilEnXdtyD/dnCNpbuyfMtYl8Jf8FPZnb6i4fP7fa4QBIX10OuDwfjYXxySXiVg8Uq E5TO3SAe6FFKgw54u6RwOF92q0/6vbxjMAie/9lxTIB6UQ0mupTLG3WnDLJkcGxRW/So9qVl24M T7UX/sBhssBGLXlUBFSQ1HNV0W0K4kZbjSzmzBRarJ7ki/dxrIPfjqkvo1xwiF68e3bzGPAAnIa sxme4zLZYIVflO6r1VJ6Wb+aUvwurRgRpKrgUexK9LYNCE84pHbSudMtSLIwjOyNOtB9wY9eQkt URmY0rCTYPdYBHoVdFH0yCU1qyhziVqtBciWyLsUGpBdraESCBbupH0MMXVcTJN3yVR3H7PMmof WzZ1987xVKtgLoqh7DznEjUxYwRRT+6bRP4Q== X-Received: by 2002:a05:600c:34d5:b0:485:40fd:8390 with SMTP id 5b1f17b1804b1-486f4457b0fmr12446185e9.26.1773775983122; Tue, 17 Mar 2026 12:33:03 -0700 (PDT) Received: from debian.lan ([171.22.84.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48634a7ac93sm70833395e9.2.2026.03.17.12.33.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 12:33:02 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Garc=C3=ADa=20Casado?= To: Andreas Hindborg , Jens Axboe Cc: Boqun Feng , Miguel Ojeda , rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Adri=C3=A1n=20Garc=C3=ADa=20Casado?= Subject: [PATCH v4] rust: block: rnull: update to Pin> for PinInit Date: Tue, 17 Mar 2026 20:32:57 +0100 Message-ID: <20260317193257.13848-1-adriangarciacasado42@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Utilize the pin_init! macro for QueueData initialization to correctly suppo= rt in-place initialization patterns. This aligns the driver with standard R= ust-for-Linux pinning practices for driver-specific queue data. Signed-off-by: Adri=C3=A1n Garc=C3=ADa Casado --- drivers/block/rnull/rnull.rs | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/block/rnull/rnull.rs b/drivers/block/rnull/rnull.rs index 0ca8715fe..11ea0696d 100644 --- a/drivers/block/rnull/rnull.rs +++ b/drivers/block/rnull/rnull.rs @@ -54,7 +54,7 @@ fn new( ) -> Result> { let tagset =3D Arc::pin_init(TagSet::new(1, 256, 1), GFP_KERNEL)?; =20 - let queue_data =3D Box::new(QueueData { irq_mode }, GFP_KERNEL)?; + let queue_data =3D Box::pin_init(pin_init!(QueueData { irq_mode })= , GFP_KERNEL)?; =20 gen_disk::GenDiskBuilder::new() .capacity_sectors(capacity_mib << (20 - block::SECTOR_SHIFT)) @@ -65,16 +65,21 @@ fn new( } } =20 +#[pin_data] struct QueueData { irq_mode: IRQMode, } =20 #[vtable] impl Operations for NullBlkDevice { - type QueueData =3D KBox; + type QueueData =3D Pin>; =20 #[inline(always)] - fn queue_rq(queue_data: &QueueData, rq: ARef>, _is_l= ast: bool) -> Result { + fn queue_rq( + queue_data: Pin<&QueueData>, + rq: ARef>, + _is_last: bool, + ) -> Result { match queue_data.irq_mode { IRQMode::None =3D> mq::Request::end_ok(rq) .map_err(|_e| kernel::error::code::EIO) @@ -87,7 +92,7 @@ fn queue_rq(queue_data: &QueueData, rq: ARef>, _is_last: bool) Ok(()) } =20 - fn commit_rqs(_queue_data: &QueueData) {} + fn commit_rqs(_queue_data: Pin<&QueueData>) {} =20 fn complete(rq: ARef>) { mq::Request::end_ok(rq) --=20 2.47.3