From nobody Mon Apr 6 23:17:38 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4515158DA3 for ; Tue, 17 Mar 2026 19:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773774990; cv=none; b=FPQIzY40alM5p1LFFlL+cjwTGqBsrsGmS7BmqpqO1crxTnUTCJerSD1jU4IyUDk3/tLSRXGWOg+7VEPZDPgFfVcdpxF8xDp3waXnyGBIXL0E1NIAGIYB49jQYtYZWeoJV0Uxg0v4HunGTYfguv9XDhbgRFMdUv0HJuAhrlywrd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773774990; c=relaxed/simple; bh=AusvSwUyo/ia4o9pnKiDXYbXSTW8aHRzRq2lgMTLrHc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Uv5JSmGVxL5j34k7Lg/+h4S7UOnEwXa4YSwUMal7Ubvs+7ALhhtbE1P+stpmUkL50D0/88GvibGWI/2XpmoH+pBFKBh+z8ZMYznLqWfhoViXtkIbQMt7Y7i1rTLtedzLlGcQSvZh+3lQWn1X3HVufoiYvVEFYgbR2MsFhg4tTsA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=C9SBvEDU; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C9SBvEDU" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c739561f0d3so3933888a12.3 for ; Tue, 17 Mar 2026 12:16:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773774988; x=1774379788; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xNksHD/Ia/lI3PwtOgNwKe8s7JojbqFZYiYVCtaCE+Q=; b=C9SBvEDUs8rTeSlEIG7B2b6A4TbCXxLDC83A/ewC0A8dH9gpUomZCd/CGgR2mhoaO1 VmNt0NT/AfBPiiVCAhjYSDjv2lMVKQJ7PbHJV+YaaO3jVA841zSrG56TbYz34gcsFXje wi4ns6vQNxjFEr0STLBmEW/+KhdQxhkQ7vwHxuxZkIv/4RhGnEhtjPbYHTiwvCyHI1hn XSObpxBb8wnAeaQcyey/1xb54k3JhiMRRcab2Lo2NgdVgsBrlycxj7NsnBdGpor5UH5V ril7xrcCLTTbQG6DzxFpyXNFxesuBBzDGHydtq+LDTQ7rdOdWkqsMqaXwz/kpFP3o+X8 ma8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773774988; x=1774379788; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xNksHD/Ia/lI3PwtOgNwKe8s7JojbqFZYiYVCtaCE+Q=; b=hY7LCxhK1Kq5s8CNg+2LwIlwaTGkRGQsOwIUE9hwTNJi5uER8j4wflK9wKXWlKkznb LHTqkU+tzEellGmRsxfuOcAZqjlI6MH9+e7jDEAx92C8MmFFllj7U+7qXhu3IGcMe62c cA9fEB4q0goQfW2f6eA71pR+KW87/Srgdsa9KnyQcHZhkxLm+FUjLqodxaXsLDBam5dm 3BuXhAPs9JFyAxmWNFwwu95F5r0nSAnQOmCCcfS1jgInQsPEI8QJ1nvpKQWA7MuncfmC GhtJjCHkw5HKKtJc26Xuh4urwMP2w9Xbsv8QXiT+E8N7E1hK3HXjAj6n43K3EqJuNo+8 BBKw== X-Forwarded-Encrypted: i=1; AJvYcCVjm/ztPIAWQlYvFuB52GUVR3jNx9rPRn4BTtye8TEvxIn8DGbLwQThEiORuuW2sT0dePTmADF2xa03710=@vger.kernel.org X-Gm-Message-State: AOJu0YwmvHrElhrk7ZKt3veISL0LXfc07qQtCKvsKbygLfW2tjt+BRnL BFtiEX04ajvLmwtxairliafOg7GEpenK0qz7ADKoqpgAGtIqhAFny20D X-Gm-Gg: ATEYQzxu9ukDINQ0Avik4pHeair9IC9bNceFzlCEKGnwCJwoDnNkQYJ76ejfoGEzBJ7 e59tBKP6/ZfMBRQd27dqZP0cXntGXIFed4JNF/LPBNdwozOEJ+VtWVrIc7eiHWEo5CLJHNfgRix /pj7g5XU01/mydZzjfu+rycgaFc0FMOriEjbVUzHjU6iUP9YeIGJEhJuUn9z8adp2pKxUskgDo/ k0iidS6eWdA4cuqfZC55GK+zlhxApKpf12PhLZlPbMg0QoIsYvhVIGpNQRjJt6AFJr8G8NWOeh3 P0g7HUI1Z9cLVLdy9+H13FdocmwKTEJucZFmuUXvPYYnNXpOaifmXiEwlPdqlBW67KR+8FRg1cz nRHU+c8/3KXc4R3CnyyTPpZhD+LHRsPIu/fn5rOPfv8lxuCZLo9MYByF4kJ3yTeA4MIdOG3Hfsl kopaJxuZNsfbfbS2IYLq/GW8m07e2jOS/qk0k2MKMREBTAtq1Q/WdB88xPoy8IAfCMYTARB9NQm UzrmLbArM+GzGnkqlFliD9NQGIZNIBZPoU9cL4pcoVqsNO6FqWTfRkM7VECbGVhHbLhIKLRmOOw P+Hf X-Received: by 2002:a05:6a21:398d:b0:39b:7f5f:d591 with SMTP id adf61e73a8af0-39b9a0c86ddmr341476637.63.1773774988182; Tue, 17 Mar 2026 12:16:28 -0700 (PDT) Received: from 2045D.localdomain (76.sub-72-110-123.myvzw.com. [72.110.123.76]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c741e546b01sm334350a12.21.2026.03.17.12.16.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 12:16:27 -0700 (PDT) From: Gui-Dong Han To: gregkh@linuxfoundation.org, dakr@kernel.org, rafael@kernel.org, jani.nikula@linux.intel.com, rodrigo.vivi@intel.com, joonas.lahtinen@linux.intel.com, tursulin@ursulin.net, airlied@gmail.com, simona@ffwll.ch Cc: gustavo.sousa@intel.com, demarchi@kernel.org, jouni.hogander@intel.com, luciano.coelho@intel.com, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, akaieurus@gmail.com, me@ziyao.cc, Gui-Dong Han Subject: [PATCH 4/4] drm/i915/display: initialize string params to empty strings Date: Wed, 18 Mar 2026 03:15:38 +0800 Message-ID: <20260317191538.43535-1-hanguidong02@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260317185920.43387-1-hanguidong02@gmail.com> References: <20260317185920.43387-1-hanguidong02@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Passing NULL to debugfs_create_str() causes a NULL pointer dereference upon reading, and is no longer permitted. Change the default values of dmc_firmware_path and vbt_firmware to empty strings (""). Existing code that consumes these parameters already verifies both pointer validity and string length, so empty strings are handled correctly. Furthermore, heap allocation is not required here: these debugfs parameters are created with strictly read-only permissions (0400). As a result, the debugfs write operation is never invoked, meaning the static empty string will not be erroneously freed by kfree(). Fixes: e9913f0bd2e1 ("drm/i915/display: move dmc_firmware_path to display p= arams") Fixes: 29292bc6cc37 ("drm/i915/display: Move vbt_firmware module parameter = under display") Signed-off-by: Gui-Dong Han --- drivers/gpu/drm/i915/display/intel_display_params.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/= gpu/drm/i915/display/intel_display_params.h index b95ecf728daa..0a8cad98d480 100644 --- a/drivers/gpu/drm/i915/display/intel_display_params.h +++ b/drivers/gpu/drm/i915/display/intel_display_params.h @@ -23,8 +23,8 @@ struct drm_printer; * debugfs file */ #define INTEL_DISPLAY_PARAMS_FOR_EACH(param) \ - param(char *, dmc_firmware_path, NULL, 0400) \ - param(char *, vbt_firmware, NULL, 0400) \ + param(char *, dmc_firmware_path, "", 0400) \ + param(char *, vbt_firmware, "", 0400) \ param(int, lvds_channel_mode, 0, 0400) \ param(int, panel_use_ssc, -1, 0600) \ param(int, vbt_sdvo_panel_type, -1, 0400) \ --=20 2.43.0