From nobody Mon Apr 6 23:08:41 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D3C126463A for ; Tue, 17 Mar 2026 19:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773774674; cv=none; b=Cq6LqESOjeTCcn+nh3M/3gKiNMvyISTFQo2LFjDpXF6DhRSZv798fps0F3732078ugEZJu4o9hMi/ckaDyUN7PwxvuVMGEhHykV09/n4+KIv4m4GPObdqaPgRzDzPyLTtGcuvIJvdnJ6BmyhjlHMrw/v+w64ONiWNkJvlhxOT+U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773774674; c=relaxed/simple; bh=e5D0ZDzECFt+AZZ7v2CLoTCt3POSgLt/y3yjbm312SA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EHADmHSq29Vj6yKEii2OyTDq1R+SHYkAaQ4S7B/T1rc2P2MGRjBJgoqg3Aw4I2V9S+KFGKACok7BipM4Z2STa2TVsDamUQFbHAfWhthvJitOIRd121cYp37qHdjScwe7JQHLWLDtLHe3tmVDvPrXcvYSpFYmEDUvFGxVCeTPNMY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gV5dcVMC; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gV5dcVMC" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-829a27414a3so3769847b3a.3 for ; Tue, 17 Mar 2026 12:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773774672; x=1774379472; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ey5xOspEF8t8qpOzkawTxCYiw1oiTsiTR8cXxAAxS3s=; b=gV5dcVMC6KJYTCRJRjO903BDZIYiDP6cZY8Os1k4p36+TNM7iNKcUsMuUe+fiszy5m cKb6ZtShZiA8BH0+8esPUwWU2sdTThGlEnqwHymwAr6rnBb6vpQUAiYYxl8Zu9FMaytn FgmO3dT3QshxAVAdoSyv/j8BxWBJZEkbt0wnE9iaCG2GdAddo96ztgEAmgUHQX8eQTGS epZmlXIpc7hBPzRFfEJ8T2P445AtzCV1XXJcC3zb80koxN8rk2qic5iDUsAnCPRGBCku LUIHgsmpSWPBmHq9Ed8M8VV53pIv7BgxyI143fsJEDGzin2Tjbw7CYnub2u4Jc/535vj NBDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773774672; x=1774379472; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Ey5xOspEF8t8qpOzkawTxCYiw1oiTsiTR8cXxAAxS3s=; b=M4++EF73x2eKlb80ZaydV+MKJ3zVvoLXI7I0B3TA43M/f9ILI6cGFPc1C0z8NMZkRq OsPvaduv9rI90jYK2NJUweT8VjYRHumG+jazj0lLagvsq+E5oesaJKbUSeKRM0CJ2u+V jb57Scafy3QNnfyYZJFLeeqxb127g3bLdY1nj1bD5LMw2kaa8LhjAyNKuWSSkU/2k10A zpxhKb9SrfHgjX33/oaWXvy4WEn5TfzJvPsRqroruzhDs5LsDgqmpSKUZd3CUT9nkf7u gJcfM8BoiBtpDOBeYN5e41U0zgG8ezjtqiECAVbJ+s3XvjNpV3+t0SWox96ZLsia8H0B Ggig== X-Forwarded-Encrypted: i=1; AJvYcCUTSaJwY/9E3q1BHjkX2MtUBNqEN1nCch+P/te5kYTTudm0BES5FG7d6syymcfaaMFE7caYU5T85DLPmYI=@vger.kernel.org X-Gm-Message-State: AOJu0YyDLx6rO3HWO3o/9CgkO2m1vpzcQCcveG1+fFSHou/OZydeLB8t 942Ri1X7J1WQmRIqWKLpyc146uUVIb0dI3yjFfqFlKZLSvjYa7N3h+G+ X-Gm-Gg: ATEYQzy+j7sC9isO1n1aE/PVaWkzPezxNBY5Y7Tk2YDz9gmkbenccrmKjy3lPeygWHe 7TXKH/mB8200Rfze1JslrmRQJR2O/M54zecMuPrCYPIlRYiGaVtLhHQViF6tq5kB0WavxEFtlCj AT3lAigzBFIffmVm2/ALe4s5hGsUOnGOQBXLTwAd5f89QuWQtv7PWFjUL9GANI2frzaJEjotxpz +CqkH7bKseosMzwtz5Yy8lSj+P92+wqigHO3/byMF9QAUoms+eBomBncs2kzOcZtHaXcOX3/q4b AmdHiak15GkCgEv4Yep43OfneB4Ct0YOksAeRYI7oOTSCXkrUDcd8RzCtMFnKdNM8kZUzyCvJEK nLat0ltQt91yq78EXb04nXSgPidBM+/XHThPm8V+OaHwJPcyIUKWnQkp+bCBtDAPfZOf7CoAFSF 694YzjxscxBbdCdE83pjOoUGS9q982cjVQHBe39K0gxlw1xF8iM8ZOSjGpCN2z7Hb26gbZGjILM cPpL1LZAKgyDjPN4F6eTt1RIdSsuFd07WDF+YVwI1pz5tRx6N+Ffo4G7Rvgegtfxmpx5Q== X-Received: by 2002:a05:6a00:1ca3:b0:81f:4ce8:d64b with SMTP id d2e1a72fcca58-82a6ae4f234mr356985b3a.44.1773774672367; Tue, 17 Mar 2026 12:11:12 -0700 (PDT) Received: from 2045D.localdomain (76.sub-72-110-123.myvzw.com. [72.110.123.76]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a6bf0cf5fsm224612b3a.61.2026.03.17.12.11.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 12:11:11 -0700 (PDT) From: Gui-Dong Han To: gregkh@linuxfoundation.org, dakr@kernel.org, rafael@kernel.org, vkoul@kernel.org, yung-chuan.liao@linux.intel.com Cc: pierre-louis.bossart@linux.dev, rander.wang@intel.com, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-sound@vger.kernel.org, akaieurus@gmail.com, me@ziyao.cc, Gui-Dong Han , yangshiguang Subject: [PATCH 3/4] soundwire: debugfs: initialize firmware_file to empty string Date: Wed, 18 Mar 2026 03:10:29 +0800 Message-ID: <20260317191029.43515-1-hanguidong02@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260317185920.43387-1-hanguidong02@gmail.com> References: <20260317185920.43387-1-hanguidong02@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Passing NULL to debugfs_create_str() causes a NULL pointer dereference upon reading, and creating debugfs nodes with NULL string pointers is no longer permitted. Change the initialization of firmware_file to an allocated empty string. Existing driver code using this field handles empty strings correctly. Fixes: fe46d2a4301d ("soundwire: debugfs: add interface to read/write comma= nds") Reported-by: yangshiguang Closes: https://lore.kernel.org/lkml/17647e4c.d461.19b46144a4e.Coremail.yan= gshiguang1011@163.com/ Signed-off-by: Gui-Dong Han --- drivers/soundwire/debugfs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c index ccc9670ef77c..d4abe8bfca76 100644 --- a/drivers/soundwire/debugfs.c +++ b/drivers/soundwire/debugfs.c @@ -358,8 +358,9 @@ void sdw_slave_debugfs_init(struct sdw_slave *slave) debugfs_create_file("go", 0200, d, slave, &cmd_go_fops); =20 debugfs_create_file("read_buffer", 0400, d, slave, &read_buffer_fops); - firmware_file =3D NULL; - debugfs_create_str("firmware_file", 0200, d, &firmware_file); + firmware_file =3D devm_kstrdup(&slave->dev, "", GFP_KERNEL); + if (firmware_file) + debugfs_create_str("firmware_file", 0200, d, &firmware_file); =20 slave->debugfs =3D d; } --=20 2.43.0