From nobody Mon Apr 6 22:00:24 2026 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BB553EC2CA for ; Tue, 17 Mar 2026 16:41:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773765708; cv=none; b=ZFVjMUSYgeVQ+VRP7RdBmjvCQvmGAPJbQWgRYVJJ0B8nffMq/t/UdmR+Rh/HENQjbHByrfBB3i2GjPpYjF0LOWDU1OEkDBIj+LNU5ZnVSPiNB3CzTS619b3vt4rySa4fvCC5ziBQmXdM1/8YSnmrwXC8+zyqgRN4e/1UH1eTDvQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773765708; c=relaxed/simple; bh=yG/wTxLVGo4fK4lShhEwuhQlcqhJGOFHPNlz8muz4yE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IPsSubK4+MnYjxB27iffrGl2Fao5f7xycuaQHDpGBX/VSVe1UI00b/+L4Zf8R6JybxUggO0ZzrYpW2sJ2uIk5TmahCvWCw0SoFMXmP3Zq6wl06CpWxRysfjXhKjhjBdlu4/eQSIOTCmXu3L5F7V5rSAe6ie2twvJAP+WUqP+ZL4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f00+8VUm; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f00+8VUm" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c73874b3ae2so213002a12.3 for ; Tue, 17 Mar 2026 09:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773765706; x=1774370506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oi7WFKnjnbvtaDtJnnUDWWC7u3TXz7txHxrui19e8QU=; b=f00+8VUmD73knD4JILjSYGK1K0kg+tmb4L2pYKXsLFxPJaBQp0MljwpO0IZnkMWZeu HZW4ezFydJmKCR5m7Mwfi9uxM0ANspLuxu4jJ8eKJDN56gU7pQGQdWdbRNgS/2dXqIrJ SydVP59XHVKfHHiiK7t7Eck5e1L98bFuxsmIfS0n3lDji2VhONRGbIPIRyQAgB+p/6a0 X0hmRER5bm6GxIKeQV0UdPl3JYElmoiACjgT+Ms5tFce3cq4r82HmywFbW8qRZJmVB21 IoshfEC3JeNQQd8VWdRfjpUdztQvQB4ymgM0DxhLXw+qH3+q8CtwoLGYOXVssA/h3lf3 FWDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773765706; x=1774370506; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oi7WFKnjnbvtaDtJnnUDWWC7u3TXz7txHxrui19e8QU=; b=U0x2+vyC/g5BOQangAMMduEMeNpW3hrIg/RRfxOFc1j3hA/Hy4S6XMzshnG28h3nNq sDpPdQ6Jjf91QjVdtUyF8FLGjqFJzOIxWWE6NKqtpaxGywHjyJ8lNBVuu7nk6AYi/T5L erq9PRt0yhBpoOBaLbHtBvB/0da5yKfMr4WNfNJMasR+qFxMwII9/DQhonSbLXK9f0Kx wMYsiPO077SNnl+4VexmLqRCH/J4dS9zgduEbjiCbFSPSeYTSXhbiRsZsIgJckigqd3E F6WAhdAlzAIXhdXMR9tradJOIizofzaCmTlRGXBixJGpsLJSXnM/UWYA05qh13ODlTiW Usjg== X-Forwarded-Encrypted: i=1; AJvYcCUy+NC095qrQNPIsj2ibiJyME6UlZmdaycscYT87H2Y97HWyg6Wb8/FWfn0xryObPYJxxWkoxZ5VgdV4zg=@vger.kernel.org X-Gm-Message-State: AOJu0YyKEUUSCEVNAuK20iWVZBtKoBU+oUs9BmaNlCbH9l/bqrQI2q1j 8liWShxuZfLg8HQpBaiVTBdf8WCwE23J2HkmPBhsguMyWOixld2VKpZV X-Gm-Gg: ATEYQzz0tq0030QOTVb/gBAs37vwRSmsujcvS52vI4aoTQz5JHuzLV3udgahEqNp6rC yUmbbnOGr/vBSibTX/VQ/K2+Zz64bJw3W9KTUOl0YZNE39VLNIy9nEyQhoeXLDSv3NSHU908oBR yQdSRTNN0zVVcpPGLOZPWWGGws0U/HTAo/Gm4JIXc+O2UbY90gJaHAmyKJ32ZxeU6TVufREItGW G25Xtfod1KIj+kqEJTZ6tkC1kv4MbdrDdOD7+IWlAY/0I7I0xwf7kLLx57ypwG8b0MyZ1FWAG35 e41zHEAjTaicC6IysldOemKTbtlmgKaqNWcHI9EsqLwotuzxLQ4b0KxYStBK+TlNvx7Xx4H3mzb pYwb8R2j63f4eYcfqoTCjfnmiyPvFXi7cYLmQrKZXvzXvit/Z7r0OyY+85+rSXIl9f7OLhUTV1k XlRvKenKO66oryoWxZHlswJx4iBm8UghQntfaQccFvZCsi9NM8+Y0s8Nq4qCJAOFCuG/PYcvU8O CD9WLZhqMiQVMcY7J0O0l88yCrd75bpZxS1YNtp6P5HXK8= X-Received: by 2002:a05:6a21:32a4:b0:356:3b05:2955 with SMTP id adf61e73a8af0-398ecda31ebmr11679125637.6.1773765706320; Tue, 17 Mar 2026 09:41:46 -0700 (PDT) Received: from DESKTOP-PU4IGQQ.localdomain ([112.196.126.3]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a1e72cf33sm12998842b3a.37.2026.03.17.09.41.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 09:41:45 -0700 (PDT) From: Utkal Singh To: linux-erofs@lists.ozlabs.org Cc: xiang@kernel.org, yifan.yfzhao@linux.dev, linux-kernel@vger.kernel.org, singhutkal015@gmail.com Subject: [PATCH v3] erofs: validate h_shared_count in erofs_init_inode_xattrs() Date: Tue, 17 Mar 2026 16:41:35 +0000 Message-ID: <20260317164135.24892-1-singhutkal015@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260317152439.5738-1-singhutkal015@gmail.com> References: <20260317152439.5738-1-singhutkal015@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A crafted image can set h_shared_count to a value much larger than what xattr_isize allows. The loop in erofs_init_inode_xattrs() then reads shared xattr IDs far beyond the inode's xattr region, causing an out-of-bounds metadata read. Add a sanity check ensuring: h_shared_count <=3D (xattr_isize - sizeof(erofs_xattr_ibody_header)) / 4 Return -EFSCORRUPTED when the check fails. Signed-off-by: Utkal Singh --- v3: - use local variable sb instead of inode->i_sb in erofs_err() to match existing code style in erofs_init_inode_xattrs() - confirmed compile-tested with make fs/erofs/xattr.o v2: - initial patch with bounds check against xattr_isize fs/erofs/xattr.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/fs/erofs/xattr.c b/fs/erofs/xattr.c index c411df5d9dfc..af16cf634a01 100644 --- a/fs/erofs/xattr.c +++ b/fs/erofs/xattr.c @@ -85,6 +85,15 @@ static int erofs_init_inode_xattrs(struct inode *inode) } vi->xattr_name_filter =3D le32_to_cpu(ih->h_name_filter); vi->xattr_shared_count =3D ih->h_shared_count; + if (vi->xattr_shared_count > + (vi->xattr_isize - sizeof(struct erofs_xattr_ibody_header)) / + sizeof(__le32)) { + erofs_err(sb, + "bogus h_shared_count %u for nid %llu", + vi->xattr_shared_count, vi->nid); + ret =3D -EFSCORRUPTED; + goto out_unlock; + } vi->xattr_shared_xattrs =3D kmalloc_objs(uint, vi->xattr_shared_count); if (!vi->xattr_shared_xattrs) { erofs_put_metabuf(&buf); --=20 2.43.0