From nobody Mon Apr 6 22:11:43 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4AD03E9F93 for ; Tue, 17 Mar 2026 15:20:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773760842; cv=none; b=mE00wDEt3eKAm17kVxO/S6BbTuZZ4iX50Lh27OjDgVo/SrCpBgqXajOVaGzFAby2hx93CDASVIFq7+njbd/0Em1jWMLUR5Z2Ds5Ek261N27cGm7tHZjNPpuaJXAOoAy46huf9Bs7I1qsYbeKNeR0Nw2DLwNMUw04UAih7A5vQfI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773760842; c=relaxed/simple; bh=M9LSS2fCfoYxkAzYpo4dsGfhxH8Ty3OP/dAHd+nrKHc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BCpOnCEn1z1Ne0IGqe8jXMuSn+olvfMeV8fkd0C7KdWrd59TuGYX2+RAPvKTWxqEpdcDcTaOJ7Ob3hcd7npwjVkbp7xmybayvT4o7OJKpxYlAZVFbZgARhT7Hfb+I3AETRcpFpZo3C1V81jzxCpl1yFsG8xMe401ep2kFW7Qbkw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dTwf76Qe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jnF7V7IZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dTwf76Qe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jnF7V7IZ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62HEHpI22188398 for ; Tue, 17 Mar 2026 15:20:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=Z1afFN2wEfnAo/8qo6fKxDOac9rmc4JPnzv xJhNRA3k=; b=dTwf76QezPgqTn+o6ebJVNDpsKLbNL3z8KAmJKVwHjObp7S9htC 55B/jb9DYSu8fZ5hi8adnIamMlElcpR7bpJ8TnCsgrFa3VfXvrmFGMDk9K0uf3nA fZQmpZGg6kGkEsneZtwEfmFk/DrsmRy70xbBPkkNLJGeH2Yv6+AT+ydauYTBA0VF 5sQeKPPrtLueZaQAXVry3Urs07O+6aPQvftOBnw71tJs0bKikq5H1pHPWcbTllac Xmb8CYS29yNtPMcK2ILasQrSpHuudCfhhNKWhJvMDqRX3PkEB6LDaYOQWWTem3uf wCK9b5ZuV4C/DZQGH8bEb6XR32nI/T+Et1Q== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy8kjr8jv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 15:20:39 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd7f6ac239so4085576785a.2 for ; Tue, 17 Mar 2026 08:20:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773760838; x=1774365638; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Z1afFN2wEfnAo/8qo6fKxDOac9rmc4JPnzvxJhNRA3k=; b=jnF7V7IZ9++HRDB4QGWHCAkqvJuc6UDL9DFNHUt4ukXycgkGBTO6y5tZi/Lz7APaZs hEYiQUBlWbgXLibuqmZ07X7bghmyTYWD6zG4UfMUDLnjn8pG+YvzVH6bWSiovOLpEz7O msdrKKbqWpKHcH53o4gV0Xl6uQxiAOY6LAHks+0tdi85CpBcQ4Kwd4QMHAoEhA4vH9xm i6614vGhGZrJQ9+UnCIvwuE9Ir1m0xERrXCW6kYdWLzTzGVb9Ho4nWMzHNLf6PqPQWkA J+U5+QYqTcy+rsNDA0vNPF+e7BPI81YvEWqB/Vmra2IGZsJea/n0Jxjih+u/WtM5UuOs fpvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773760838; x=1774365638; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z1afFN2wEfnAo/8qo6fKxDOac9rmc4JPnzvxJhNRA3k=; b=iCRaFgX470I6j+uQjJ3TnIXWJxwZaEWhQqPfUdzlDX3Pm5RHksnAzblgWyx83MGYGT ru6Os1XC1MC5CiD9bUVC2NfbWjgldJB71g5T7XMnVvtJzSg9d2YrKQ8Kuaked+T2ka9N FXfnjLiKBlSwpXux7sG99h2SeRK3f+DRQTp+vZkz0VOdfYazIqz462ivqbbHXJZnwi/Y xdoDmsIFAcmohtagv3zKVmya40vSqEnYqMQ49pJ25V+BQxfOwlb/6NC6Bdzy1PHCLSbU e9rx5wrOMnYA06yhRV+lpkzdfqEXmkzVmGdgvt+25jnkSLQIgZnZk1vL2bTxaRqFKjQe KbXA== X-Forwarded-Encrypted: i=1; AJvYcCXi7lDweso+XG89q7BxgUqLpPz1j/3pNszcvpfht6QhAFUoWeaO8NiOT2Sz5QmVEVuFOWUjyepaWe54O/g=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7K1gfsKus87Epuy+wh7+qpwANKt+tYSW7yehQEAzBNeeZUtVE 9e/qzt28QMhKynSMRVshZ2EPCgZ5U1VAA0ktglANlh2DoefZemPrds8jsmCzI9Nz71bRb9x83hG 6PfLYV8t/goVy0IaUP4HOMZMGYLIexTwnKVtu8aTZRsB4QqutyY37f6ooX0T/KJj2XC4= X-Gm-Gg: ATEYQzzfvP7eORafetienCSuKHLySsOj0/GPbZlJykgtnwK9h/f35HiVrKimJJDVph5 tidjJEJu/P46KkAtw9Hbf4X6EThGo71Fhrs25s5W2xiHQh+IXaEJ1l2f77+d5r0cCNUZgl1p30M mLu8dS//neKSufGnf+oSZ8DbSpFBepvGK89KkxYRRj96wpP1goN/wLbULdWh91UXRdR41ocqAXG omnqNVglnDwPKV6ueuA4pfBtDker69pimyaCZTu2AQYwekVZ1ZkgvORGswveSedT6KITDIzmYzY qWJNSk2bpiRrOieSNFSUS8KKaBE+9ZY2ygmrRFNDPUTQYg8IFbhSVNxdh6w7keGZ8d3yEb3a0ok w8wDViEIi71h9M0XIWnzXpMvKu2lgJGz2T0l2 X-Received: by 2002:a05:620a:7085:b0:8cd:a99d:ad6a with SMTP id af79cd13be357-8cdb5abdebemr2087270385a.35.1773760837957; Tue, 17 Mar 2026 08:20:37 -0700 (PDT) X-Received: by 2002:a05:620a:7085:b0:8cd:a99d:ad6a with SMTP id af79cd13be357-8cdb5abdebemr2087265785a.35.1773760837490; Tue, 17 Mar 2026 08:20:37 -0700 (PDT) Received: from quoll ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b518a2cd3sm91632f8f.32.2026.03.17.08.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 08:20:36 -0700 (PDT) From: Krzysztof Kozlowski To: Peter Rosin , linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Greg Kroah-Hartman Subject: [PATCH v2] mux: mmio: Zero the allocated memory Date: Tue, 17 Mar 2026 16:20:30 +0100 Message-ID: <20260317152029.274829-2-krzysztof.kozlowski@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1637; i=krzysztof.kozlowski@oss.qualcomm.com; h=from:subject; bh=M9LSS2fCfoYxkAzYpo4dsGfhxH8Ty3OP/dAHd+nrKHc=; b=owEBbQKS/ZANAwAKAcE3ZuaGi4PXAcsmYgBpuXE9kPU8Bur8ODspMb3LYC/iaghmHEzEpZVY7 D/Ro35FlZOJAjMEAAEKAB0WIQTd0mIoPREbIztuuKjBN2bmhouD1wUCablxPQAKCRDBN2bmhouD 1zUsD/95SFCt0+9Cf0ziewcZ3WaS5icCCU5YnAz/khIpU9qcfS8eriy3fra/8m0d8JkyNjdRK8n QKvj03byGVr382f2DFRCAQPaFFa9mKrZ/ZGN/fhd+UnuQWrLQxvD9mHDTSqLT5AWK61bfToprWx LGqvJb3GVS3AUGHCBlNifR+E2USpkmoeGR7kaOqByWtzLt7/HqgcLklf1butEb6kqMK4qS8YyBi j4dRYEEt1sm+riF3eMmB8puwiPK4uOgPyEtFV/ldONxfkqjixS9AaNnB7TJBANcwGwKMwBBPh1Q SOh85z4ndqpmg3jqlpEQIDZ3I9dDKFMtxSE5OS7vEAsu9xPxG2pd3pEe/vHH94hpUJzdimbkWu/ 11eTSpJXJoS5Fp7J86/uXCuDVT9y9n2ya2o7Hmz7AQTsoLROnNZfB5fIeYLzzizgMSeEOslxZLS l2Rn5ivdjprTPsp7nZVHeulsGOZ/LFI2o3l8pnqCQ/Jyu/fDNhZPAu2F7vGSFKyU1gKWr0JCZRp O1cz2ZYKsFHputAH6pfT0CD/PpLp58cArwBSoDd04ufcHJ07Xr6lkhU1hfotPbwR/1AORuDBuIq 03P9XZuIK5rd6R42oGo4jU2QsXknlyPhjG7GKR5AODTjXOfWxCw3zfZJ+Sx5IX9BH6lxOOvBiyz TV7rZrp+MtgnnEA== X-Developer-Key: i=krzysztof.kozlowski@oss.qualcomm.com; a=openpgp; fpr=9BD07E0E0C51F8D59677B7541B93437D3B41629B Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDEzNiBTYWx0ZWRfX9PPIzWBIEuY5 Bm/ETaZAwbKH3SLNZh5f4bwAZP0OfIvy3uO2PzFzJmO5aspl+dUkiKBw6v2COsg4td1e76ZzrU3 mQCliNsF+vY5dghLILS999CXYd5M2d+rfPuI8IaQab9jWEqfPNfv1LTfHzGAqNDBa9m3FjrS1mN rurPHTZ3FABd1kP8balrneg+YXDAIfElTo3fe+q9Us6y7HGTLWt4+rZ9ePVLAXnlxdxEHFMBhMf j4BVVFI+nqVwE0vWu+wZP2AxPu1rWdd3UAvJD3dJpllyY0AtwfPF51jW0CQcJT68kXvCcuN7KvH x1obs+m8Slqp/s+7S5FUizd8wzTgTNQFtKHNAk3O7ryXirAx5k0x+CQUtYfVlC7SZQymb5lbMdt 5TvNTCWwjYeeS0AQ4y1+zQY4H+6/AB+W7nHZXr2rWumOoJK2le6ofnfLvva2ohqsVdUKTqMOnEb nlfO8SJJscsckEMF8bQ== X-Authority-Analysis: v=2.4 cv=P8I3RyAu c=1 sm=1 tr=0 ts=69b97147 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=ag1SF4gXAAAA:8 a=EUspDBNiAAAA:8 a=4qZ8PSK2THTAtlLLyXYA:9 a=bTQJ7kPSJx9SKPbeHEYW:22 a=Yupwre4RP9_Eg_Bd0iYG:22 X-Proofpoint-ORIG-GUID: DtfuSmEnS5zviK5_3Pz2EsRJLKB9I70O X-Proofpoint-GUID: DtfuSmEnS5zviK5_3Pz2EsRJLKB9I70O X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_02,2026-03-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170136 Content-Type: text/plain; charset="utf-8" Zero the allocated memory in probe() for fields and hardware states because: 1. The "hardware_states" array is not initialized in the probe, thus starting the device with uninitialized memory. This not a bug, because pointed memory will be assigned in suspend callback, however it is a discouraged coding practice. The "fields" array is initialized shortly further in the probe(). 2. Linux kernel convention for safer code encourages using zeroed allocations, as expressed in memory-allocation.rst document. Cc: Greg Kroah-Hartman Signed-off-by: Krzysztof Kozlowski --- Changes in v2: 1. Extend commit msg. --- drivers/mux/mmio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c index 0611ef28bb69..b61e590f2ac9 100644 --- a/drivers/mux/mmio.c +++ b/drivers/mux/mmio.c @@ -100,12 +100,14 @@ static int mux_mmio_probe(struct platform_device *pde= v) =20 mux_mmio =3D mux_chip_priv(mux_chip); =20 - mux_mmio->fields =3D devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->fie= lds), GFP_KERNEL); + mux_mmio->fields =3D devm_kcalloc(dev, num_fields, sizeof(*mux_mmio->fiel= ds), + GFP_KERNEL); if (!mux_mmio->fields) return -ENOMEM; =20 - mux_mmio->hardware_states =3D devm_kmalloc(dev, num_fields * - sizeof(*mux_mmio->hardware_states), GFP_KERNEL); + mux_mmio->hardware_states =3D devm_kcalloc(dev, num_fields, + sizeof(*mux_mmio->hardware_states), + GFP_KERNEL); if (!mux_mmio->hardware_states) return -ENOMEM; =20 --=20 2.51.0