From nobody Mon Apr 6 22:15:24 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECB12257448 for ; Tue, 17 Mar 2026 15:06:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773760005; cv=none; b=Pve3i4Zh0rgwHzjQzdQWEyMuXI8+KaXR0s+VMa/+SiDPY/DPKQNPiJ57oW1IJeXADP6wNakwjO2XgENlVDhJVoDpiNqtsYyHnX1ZSBI8C+F5TWQqAtoJeDYglqcttKTw2jM9bJin6fUhm0iXAJdqpNTmRR1WN/32nUd7k6tdU7U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773760005; c=relaxed/simple; bh=Tf4u/feL2rFecDK8Ljf8XsxLEF9SsyjiT6pRsOJ+dz4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QyejIFTmzGiDfjrfdQfmbjZRcABQ8Anw8gEPQkkiTT0uN0wJJXxcFSRgMZ4SHczMRDICkKEZLagJ92QDtftczHHW31GXXPf0UksCmXL6+/nigP5lUUr/9vzUmGlqyMPJQ6tFu+1vibHls8kMx3WHZzY6EXifVcwF1FubwlZjt6I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=iA93SCN8; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iA93SCN8" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48374014a77so64273945e9.3 for ; Tue, 17 Mar 2026 08:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773760002; x=1774364802; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=miVhh9HGtLoup15TsiMQP0oQ+wldWIyRvUd3faygeKo=; b=iA93SCN8isL6aaBDl9CrfK/i3F1v9flhCLQkF5VuVQNVk9GN3q2oOuLax8uTTPX9zP KyFlgdbm38Igyyll4akm4Y6bXTBPoKzGB78TMiy9JyMZn+WKWSuACEcL05g9rK6UM14O b/etpiYZ6JdCqs41owBgugzQaLWCamNkTPq4y5hKOUvN41RuLSmDfyYUireA8iTeg0P5 CG0bXy77ShMIze9nUxOPSQoRO2A1AlA6tmhJ9Le2iJCrdMhb6JA9pAHnKvHYqySd/3FX xEdxk426oWO1RNjr9NWO1fVrakFE/yq97wWc4aVICTzeETpd0Kzp883bSr9vGBwBOaQj Vq1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773760002; x=1774364802; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=miVhh9HGtLoup15TsiMQP0oQ+wldWIyRvUd3faygeKo=; b=geI7Ym0mI2K2LpeKChpRM8lJcx2rfV1jI1FS9hcBGSuK98vnJ3iFbaw0YyGNNOmd4B +5Zm7d6x3U/6QuvKbbP1C/99GIfGNIMxuFaaABKR2boV7i8TCkdXlJb7GQM5F/hy6vjd ElI6ZqgSMPlDewetIw1kTu8sE7wUFBhM0UHQXt6URUeUUlAxrR6i5NRMCx9hti6FDRLX 7pu1qQdPkPI9FN3j1VxW4wVDZPh/1hfxcYIXfMbbytB7VIckbGNzyX0ugidYcp3mFDPT ebm1p6BOdnlbf270S/4kax64y5/PEjAi1TFN102VOSgEcIpC4OZ9VLrpez3vbzZg3ATT Esrg== X-Gm-Message-State: AOJu0YzrmU/o+JGykMqKb5u105HQldiFHLqgbhwErYIXnAbBOYQbgIhT Qmm6jW9/roEs7aKCv1rLxi/OfePstJ7oagU2Y/RZkrKuez0X15cZjaW7 X-Gm-Gg: ATEYQzyWHkKBMbGosOwCU3UTznN2wY87GkLD+giDmDty2rAKkzwjqy7pGO9GiEW4N8m 8Ha85vMppud8nXFt7qxG0uHUsThqpWkr1/ftUnZqZnaCubjHPxobL+fDD/gBuEV/ON4QJS/v4+7 VIPdpEQPS2f9k1OHDQb81lZdLuSov64Cm4VbJV5eFtaDPg/TxtG/4NAgbqqCjKCPTq4zfNWGIiP Zyot9ytIcbL6clwImDHL/oOv5lOQayho2h57uV15IR2ZPZ/npU4qzuQVt1B5IOGVAw1CPfR8/q6 iqMrp6l8lsnHj03Tq0UqzcVn6sIrRZHpGuhBIirdjxe8Sp0Z7BKhQIjBn3cHGDOr4CI0UFlh7iw dRRIfFqk5R1+DRfjI3ZnXreyPEsfsqTqsQ6eNwB2wmE3KdlDxZIXO+/K2BlIibb/9MNN7iNERfa SCgTPt4db/XjzDOM6XQlfCPuMpoEsTXX92y5veJvm0jIKCrx1pAY7XBgQO3niOFHBRPbYBhe42m 3PEJodUojwX X-Received: by 2002:a05:600c:8b45:b0:485:2ce2:4c87 with SMTP id 5b1f17b1804b1-485566cf8abmr300802675e9.4.1773760001856; Tue, 17 Mar 2026 08:06:41 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856ea97af2sm67182325e9.4.2026.03.17.08.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 08:06:41 -0700 (PDT) From: David Carlier To: Andrew Morton , Mathieu Desnoyers , Josh Law , Mark Brown Cc: linux-kernel@vger.kernel.org, David Carlier Subject: [PATCH] lib: skip percpu_counter_tree boundary kunit tests on single-CPU Date: Tue, 17 Mar 2026 15:06:38 +0000 Message-ID: <20260317150638.37438-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On single-CPU topologies, accuracy_multiplier is zero, making both approx_accuracy_range.under and .over zero. The boundary tests in hpcc_test_compare_value_boundaries and hpcc_test_compare_counter_boundaries then degenerate to comparing 0 vs 0, which correctly returns 0 (equal) but the tests expect nonzero results. Skip these boundary tests with kunit_skip() when accuracy is zero, since approximation boundaries are meaningless without multi-CPU carry propagation. Fixes: ebc1ff504f55 ("lib: add kunit boundary tests for percpu_counter_tree= comparisons") Signed-off-by: David Carlier Reviewed-by: Josh Law --- lib/tests/percpu_counter_tree_kunit.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/tests/percpu_counter_tree_kunit.c b/lib/tests/percpu_count= er_tree_kunit.c index 4d058bc78f7d..609992bfaa21 100644 --- a/lib/tests/percpu_counter_tree_kunit.c +++ b/lib/tests/percpu_counter_tree_kunit.c @@ -101,6 +101,9 @@ static void hpcc_test_compare_value_boundaries(struct k= unit *test) percpu_counter_tree_set(&pct, 0); percpu_counter_tree_approximate_accuracy_range(&pct, &under, &over); =20 + if (!under && !over) + kunit_skip(test, "no approximation accuracy on single-CPU topology"); + /* * With approx_sum =3D precise_sum =3D 0, from the accuracy invariant: * approx_sum - over <=3D precise_sum <=3D approx_sum + under @@ -214,6 +217,9 @@ static void hpcc_test_compare_counter_boundaries(struct= kunit *test) */ combined =3D under + over; =20 + if (!combined) + kunit_skip(test, "no approximation accuracy on single-CPU topology"); + /* --- percpu_counter_tree_approximate_compare --- */ =20 /* At boundary: indeterminate */ --=20 2.53.0