From nobody Mon Apr 6 23:17:38 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 166C1340A51 for ; Tue, 17 Mar 2026 11:03:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773745389; cv=none; b=d2icMlQhiEeCi8NhbpDA2K/sSTANpnSK+xbiUGBqNzTXQjGGwvOLLSgUPWROM0l+/Bk3mOdG0J9eJvH4wbAlgTlVYRLLKkpgvqVhB+1ZG1BmvxUGG9D4EagaudWKUQpo/H6HOkQ6dB2q4Vxc1iwTuUvgejQ0U+GEvxtPK2WDcRU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773745389; c=relaxed/simple; bh=u7OttRNb8G9zNYvRXM9DSiND1sHbvu/OmnaG+jxXlvo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GQfoImh2rzeMErWPNReFeavVNfHK4I+i2oQEZCYuvphLaVZaDEDn6QVgOyAaZExkSSj0mORCsTHskgoVVN72ZrpE1ea9Gjs6scZBnFgiA24OQVZe3Cp+fI92N3zwXab5yKReaf3cvp21y/Dm4ZUZTO4CLakfPJpp14iM+Mva89I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M1XCPTUf; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M1XCPTUf" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4853c1ca73aso46997215e9.2 for ; Tue, 17 Mar 2026 04:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773745386; x=1774350186; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6Df0BkW3+WFtbc+05LpOma2mHXyroUqsKpSt0hTLJrY=; b=M1XCPTUfIhfiTB+b7YN8N2+urEE9d0t63no5uj76BOlYiiOXX5BHsLAjI5OicAQlUx yzNYsZEQdgUqj19eCyY+COat1XwRWLoER6geHCb4NytqF2DCD79A2zD4BKU+7sacZioK RXWtp99VYYXny+Iy4tbK5PwxXN1tkKF/QPSsz/iGJfOO433x7wxa9oT+LLkrAQjTQMch DCEsIGghyTSrEYh9YfR9XgGakDvmPDh1WXqlRDSdXOynKCBUZIArfrAh10DHt2RjW+ei 5Q0GY44wDtPbVIfQaMTQaGAwFSwJKswCuwP+DhoOlZGnDbmPEvWTs6I/+OSeDrzl1mpB foZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773745386; x=1774350186; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6Df0BkW3+WFtbc+05LpOma2mHXyroUqsKpSt0hTLJrY=; b=SWoSDwrWMTlW9Qc2Fxybh48F93TLVTmrmAQ0awjurZYJzYf7nuiq/GY7XM6wOR9Csv HF5EKc2YdNUmGGE8tQjEQg/T2k+S83EIYuopS1iiVHtOmeaicJ8tskFvZh44gMxSkcWV 341/JV1v1wn7lSPy5cfw1KLGurLwcWmKg/vf/WLe7QaSjhVXShV1yOoXb4yTpqHg0aKc 9CyJdH/qeDw/duHJeTNIzI6xZEUEc1s1Anwedo/TVtWBFzpaujM2oPOxtD0Mb/WevWiH k4Idzsp3T7CwsId8XGJbhXAE3XamMgHYH4HEoWMf+29HrAmK6VnH+ZSjKu8ZL6WeHPN8 wJCg== X-Forwarded-Encrypted: i=1; AJvYcCWTaBfDiRhg1KO6BbQYbSk+h9TO2fqgfJqYP4sUoYWWV7i7Cx+UnJv7TIpUTc0Lus4xGaYmV0YglRryP/E=@vger.kernel.org X-Gm-Message-State: AOJu0YwoFyGfcM0s77FL6X/SdQOwHm4DJNaF/cM0pJHhJZ1l2ArN2/9Y 7It8yvabnw1ovqauwYM9I/NS4iYgISzfZrmhwZVOTIrWMJsQUNpicbxQ X-Gm-Gg: ATEYQzxDfeyotHmBqYgJD6dAWkaaf4LXyltz4PGRd6i4zULWDGnEkidusLu+0AAxPMA k1Ie6eOEDsuR4urw2tyNYXwvWY1FsatIAOwNvoJiFW/poUvjo0Q6fZ6rEOe9m1w4NSOZT6H8unt Qw4rLqRCV1kINDXN1DzQ1W4UsS17c/1pnLQKdvJAB86aMZBFcOzj8Mbc7Pm6c43jwXthjiGn8e9 mGtSbD4EkW4c+uw5r2U79HXL+7u1JLSMUfNM0EXZaBJYjHE5cltbUEKNEDADb6xkhgEXHpopcjg sNGpZu8SVFc1SiELh6FvGvCXttFeQbmS/18iEGDKuoSK50B9+M3ySqJjmXi2sD2kfzDJIy74oOY TuFw0O4hVpmxrBDgtU3mqKRPIjJtPue1JfT1sIJZELQ/ClHfFHVsPshshbiONTNzp2Fcc8ZFZ30 i1P5RdBLVbvr3rZ52Wbp0= X-Received: by 2002:a05:600c:46d2:b0:485:3c66:e230 with SMTP id 5b1f17b1804b1-48556728c71mr279412485e9.29.1773745385947; Tue, 17 Mar 2026 04:03:05 -0700 (PDT) Received: from luca-vm.lan ([154.61.61.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856e850634sm106157845e9.0.2026.03.17.04.03.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 04:03:05 -0700 (PDT) From: Luca Leonardo Scorcia To: linux-mediatek@lists.infradead.org Cc: Luca Leonardo Scorcia , Sean Wang , Linus Walleij , Matthias Brugger , AngeloGioacchino Del Regno , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] pinctrl: mediatek: common: Fix probe failure for devices without EINT Date: Tue, 17 Mar 2026 11:02:06 +0000 Message-ID: <20260317110249.391552-1-l.scorcia@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some pinctrl devices like mt6397 or mt6392 don't support EINT at all, but the mtk_eint_init function is always called and returns -ENODEV, which then bubbles up and causes probe failure. To address this only call mtk_eint_init if EINT pins are present. Tested on Xiaomi Mi Smart Clock x04g (mt6392). Fixes: e46df235b4e6 ("pinctrl: mediatek: refactor EINT related code for all= MediaTek pinctrl can fit") Signed-off-by: Luca Leonardo Scorcia Reviewed-by: AngeloGioacchino Del Regno --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctr= l/mediatek/pinctrl-mtk-common.c index d6a46fe0cda8..3f518dce6d23 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -1135,9 +1135,12 @@ int mtk_pctrl_init(struct platform_device *pdev, goto chip_error; } =20 - ret =3D mtk_eint_init(pctl, pdev); - if (ret) - goto chip_error; + /* Only initialize EINT if we have EINT pins */ + if (data->eint_hw.ap_num > 0) { + ret =3D mtk_eint_init(pctl, pdev); + if (ret) + goto chip_error; + } =20 return 0; =20 --=20 2.43.0