From nobody Thu Apr 2 09:45:49 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B34BD3A6EF1 for ; Tue, 17 Mar 2026 10:16:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773742601; cv=none; b=bp5VCNysRmTA0foRcYldu8TABhsCwiahf/8hiTAeRa2F75vHUXOs6T5KZQK0honE0hIJE0yGoADH/t4rmO8qIFTK2GlunELBP2mWGgxnI6UmiRydLnKbb2gwUGBB2ExZw+0FPHgAIVytLw9bUOR+sGb6L9DN7mQV7ntWs9d3s6Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773742601; c=relaxed/simple; bh=qlhz/VGAv1fkGq+e51RGRR7QoBeYCZLOXn2/9ebF4NM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BuRfbI6YT/viEfNwekZNp8XfI5CxkjeJpmi0fryNxjBZnLz7KVxVCYQTpO/X5PU2pLeVkbMoDCRT7OryG/BBGLdQUvNZhmB6O9VnnxApgSYjl5m7XEK19bUo+txhvTKn+0EEUEJ+/Ef58Q15BosLqfnsjsYagNwXljJ1DvGzhgU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UaJ72JIp; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UaJ72JIp" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso50474005e9.3 for ; Tue, 17 Mar 2026 03:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773742598; x=1774347398; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1Z8ZDIaZ3WlvwN975EDjweAwKFPsqMXnqigrqm2JI8U=; b=UaJ72JIp9JYk70LYwEErkYSDaQC2tjHBE/T9+rsgDEaOmMw9G+bjLOPeu/LqUjeRSq L5JM68KfGfXSKf/X9JElGs2n1XDqqp7kEbHB/fw+8RlhGKhKz8IDBwMdA3cADi3MbElV Tu+z36ps4BOEYeCrO4y/h0EIgfeF/IgbAY+ffuyJBBM3Hkxiup/YIYloFz7NcyBrvjbo QSDucL+JWVa3Dw7WG/i6glHMXI8lZ3NE43/CqfVVRlBpx8G8QV/nr2nuJwOH5iou0+kq 26Rlv6S+o4FW452Jw4cKF8O7iQBzWD9heNcCYwHTHqLmgkwGc3sMPdiCxcadx+JwNOMP jXNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773742598; x=1774347398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1Z8ZDIaZ3WlvwN975EDjweAwKFPsqMXnqigrqm2JI8U=; b=VS1NmMg0CEwmA5nxxlrFiHXV9LiiKm690bW2ygjeN+cXH5IpQbqM97FXIWZtbdph/s bOlQn8bHUyzP0gUd/N4pc7nIj3Yl2GRe9v8toOKymk6luadT1A9FuIHdSMKSRVS14Bhq AYdEMAjbY62fv/WzNuJBT14HlUKKbSrLrXK7UAhlDoxow6dNEyerIwG/wSzs4yV5SZ6l 4SPWPwh52GdS7m6VOHwVi2625G09puuZgYRgZ/muwawLIKwFIE/tBDlipT5YpslfkskY TFuZFi27D7SvU9pGKT6CXvyzb30/QkSCn/oO1X0oEW9sx89Ct473lzBRuySGuBS1bJAT KcDg== X-Forwarded-Encrypted: i=1; AJvYcCXQPPh6hEJ2BVf9BA8kNTQU7E7kzOzDbjSh6qun9pkPM5eabbWBd7+zKEf36cWefxALeGiRxyYTPohTK6g=@vger.kernel.org X-Gm-Message-State: AOJu0Yygm0ESqwva0A7XA5vvDbu+D9nHJzgCN08SgQcMlbnQNWOqzP7e pa/OSKysRRnXWOn+Bd0rNqyBAA7tJsGX+2DPg0WiT4uuiLSRmE87a1Rl X-Gm-Gg: ATEYQzxkE/pDaE1bpzfCWfBgVOhZn4A8WQdEopOOLYF+zbpIuwTBQkBC9Vf4D3C5uNp 8L/HyljcP7DXlW46F9np4pkYfyiit5B5faBGd2u0cqQa8MD54Cf3XUlt6CegdzOSVGvYmbA6Yzh xLmYynjdItNxpU0+ovlNHTsImdibI4C0dWifiuIK/FWj2g9rvMSXNiVRjo6kiLUDA5QIdx+C7lg UCO6caDL7/n0Mv4fq5f1CoLg5i1MSTPElDj91WwlBYRB80K9THvhjBEqf3Hmywmpza51eVm3Pqy MBvL7idv1YklTLMPAg9j3pmSnrV2ij4z9a6a9kJTCXq4XY4ir4vDy/YufqMaZlyutiskcJ5uNLS aFdR0xk7t/MYSfb/HJPW7oAsBUnw1k93QhNM3LYS4QO+YNJ7rJqCI7ILOayEL7PivXz2KXMlOnN n+byBpipfFD5Mu/SOhTNML29AdSlemUOvX1MWeZw0VEaoOdzEY X-Received: by 2002:a05:600c:8b55:b0:485:3f17:425 with SMTP id 5b1f17b1804b1-485566fd0dfmr262350405e9.21.1773742598015; Tue, 17 Mar 2026 03:16:38 -0700 (PDT) Received: from localhost.localdomain ([2a00:23c4:a758:8a01:e16b:fc56:e220:9aa9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856eaee510sm53903275e9.14.2026.03.17.03.16.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 03:16:37 -0700 (PDT) From: Biju X-Google-Original-From: Biju To: Geert Uytterhoeven , Linus Walleij , Magnus Damm Cc: Biju Das , linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , Biju Das Subject: [PATCH v3 7/8] pinctrl: renesas: rzg2l: Simplify rzg2l_pinctrl_set_mux() Date: Tue, 17 Mar 2026 10:16:20 +0000 Message-ID: <20260317101627.174491-8-biju.das.jz@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260317101627.174491-1-biju.das.jz@bp.renesas.com> References: <20260317101627.174491-1-biju.das.jz@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Biju Das The port and function selectors are evaluated multiple times in rzg2l_pinctrl_set_mux(). Simplify the function by dropping dupicate evaluation storing them in local variables. Signed-off-by: Biju Das --- v3: * New patch. --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/rene= sas/pinctrl-rzg2l.c index 7677751aafd4..3cef8a8d3712 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -681,16 +681,18 @@ static int rzg2l_pinctrl_set_mux(struct pinctrl_dev *= pctldev, for (i =3D 0; i < group->grp.npins; i++) { u64 *pin_data =3D pctrl->desc.pins[pins[i]].drv_data; u32 off =3D RZG2L_PIN_CFG_TO_PORT_OFFSET(*pin_data); + u32 port =3D RZG2L_PIN_ID_TO_PORT(pins[i]); u32 pin =3D RZG2L_PIN_ID_TO_PIN(pins[i]); + u8 func; =20 - ret =3D rzg2l_validate_pin(pctrl, *pin_data, RZG2L_PIN_ID_TO_PORT(pins[i= ]), pin); + ret =3D rzg2l_validate_pin(pctrl, *pin_data, port, pin); if (ret) return ret; =20 - dev_dbg(pctrl->dev, "port:%u pin: %u off:%x PSEL:%u\n", - RZG2L_PIN_ID_TO_PORT(pins[i]), pin, off, psel_val[i] - hwcfg->func_base= ); + func =3D psel_val[i] - hwcfg->func_base; + dev_dbg(pctrl->dev, "port:%u pin: %u off:%x PSEL:%u\n", port, pin, off, = func); =20 - rzg2l_pinctrl_set_pfc_mode(pctrl, pin, off, psel_val[i] - hwcfg->func_ba= se); + rzg2l_pinctrl_set_pfc_mode(pctrl, pin, off, func); } =20 return 0; --=20 2.43.0