From nobody Tue Apr 7 01:02:59 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CDD137FF5B for ; Tue, 17 Mar 2026 08:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773735566; cv=none; b=Ieqx4+Nfo/FD6ki9+s+6WSd+mcyugtI/j4Y8oIFcYDm4j3VcVwLdYUZqHWg8Nrv6EgKpsveW1Z/ecazUHv0JLX7camaCFYU/+TBDjmfO3ABh/JkyikN4AmaMtuAetZAK1UZ+/e6+K2QUmwh9oOLmZ0C1qDZLTRUcbVKlCeFpUXM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773735566; c=relaxed/simple; bh=sDC9oDvc/OJAaa+e5V0XuBgvyMKqaQRilJEckYEabvI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QtL8xOLDJZc5GwWNIsVc03xCKRfXLwzcNd/7zPCZpmyk27YT0Wazsc4H4gYGmxfXJEpTZby35+AeWzILc/daBarvlWyPj3PaFRweaCiLgXCj7LXb9sktgdAB1ajlg/9fxESIOMYB9/wH973qhf8fXgYUzNVOUAP4lkIlHJGQ1DI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=A5/1wnB5; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="A5/1wnB5" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c70e3eb3af1so172635a12.2 for ; Tue, 17 Mar 2026 01:19:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773735563; x=1774340363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dNbJMuxcQ79SI5b8CBURPPEntzzoIjBKKbyDWP6M+iQ=; b=A5/1wnB5bT7W04drVcc0qVR0t2JcezLwCWQUrB2fEH2LyPg8winHumbj63B6lJRPp5 BseOfK1ttf0GnqoAq44PzlJMm01UkGcfbcJhphx7XhphSbYIywKAnFvvzcXy+ebRr2Hh lHht/agtCkItgEtcKArvOUMAjfb4kBH6UElsaCLZA2dWzSwJwxOvMkDmWszyfijhNGoa WameJ5Q3f4TS8t9URKejVAlVfuHZ+W27Xvgk+Ue3kH7cgDm3pg2Fmp84XHKthRycuqF1 uI4c1XhFBririSpgaItD2pkvo3eqgnLg8nPE6K16NiTEFm4af6fk2bWiskn0dLCfZdWd /3Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773735563; x=1774340363; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dNbJMuxcQ79SI5b8CBURPPEntzzoIjBKKbyDWP6M+iQ=; b=q7Fmj3lfuvnlKCK46P23I1Z5RzRItYF85N3CVd9UtWMVu6M2EQLAzDO5rldRp5AA1O 3aKnAwCem1bDz4ngK/MajmZFv+Ev/OD+vrM1LbgpUMVJV6EmITJ9OF4Ru1kItiNJYmz+ S4AxbJehg6w4ViezHUc+WgUBd59QFuHKfJmPob7BhUlRHDqkalC3uVX6Rez90IqcpOko lr007dOcIM0MpmDyFguA6S/soFC6cHRvGWcaR5GMFGvhwJVPeGS133MUF9tXmW02xwVp XWZjtdpSj284v9jbGwuNfgJNNfe+thGYIPSNPDqj28kUlnIof0ZSAlW7G1id3JrjcNDi EjxQ== X-Gm-Message-State: AOJu0YzSUePFLC7ntsGIMd0eIYe1ksJsBtHtGqMWDrn63eDixSuFjF+z GAWDowxO8b13n9k0D0IoB1FYJ2W3xeZbIXpnxSwOJGIIwc+696hhJK/x X-Gm-Gg: ATEYQzxBONcMiajdyqaEVhc3kAuXUYFZRFvL7nPjo5sbiOTwiG3sk37ymSZNHyRp7Ce lrf1gLFimWp+Vdm8PQPdvTj1x5Af2rgd2/lUpVbreHH4aSEaiyC9l+Z6NOv+B0/38la/aCmT9Nw SzeIcF4f3izw4kDRMWNm3X12uceORWr5hNNj7uVWGynS7ULZJtikOcuVuqk6wc6e+/GJSe1LE4G LKlOphN3Si90MUfVzUdMfSJ4YdfvQDv/MoSZPESuH9UvUovcw0JxUqRwrlffS84eId6e4J/4+7d 5TYD37l47doqsbTxqaC3a5Wwk/tSr8P4Ex8agJoNYZbc9dKvF8Vt8ZobPjNkGc52WUGGZA2sImw JYUvyLCzoGwDINEJoQvO0yPLgXLi8bgPoPNW92wow9o1nfXRu36DFgwlehi8GGxwHZgPXwt4I4f nubEiv2mq26ljxkXwENakMOb8zqHvIKprueDTTpYJFpxWzEz/N X-Received: by 2002:a17:902:f70f:b0:2b0:5075:96fb with SMTP id d9443c01a7336-2b050759903mr61350665ad.2.1773735563498; Tue, 17 Mar 2026 01:19:23 -0700 (PDT) Received: from localhost.localdomain ([36.112.120.43]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece81dc18sm134793605ad.69.2026.03.17.01.19.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 17 Mar 2026 01:19:22 -0700 (PDT) From: Ziyu Zhang To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, baijiaju1990@gmail.com, Ziyu Zhang , kernel test robot Subject: [PATCH v2] tty: n_tty: annotate lockless read of ldata->icanon in input_available_p() Date: Tue, 17 Mar 2026 16:19:11 +0800 Message-Id: <20260317081911.24390-1-ziyuzhang201@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" n_tty_poll() calls input_available_p() without holding termios_rwsem to check input readiness for select()/poll(). input_available_p() reads ldata->icanon, which can be concurrently written by n_tty_set_termios() under down_write(termios_rwsem). This is a benign race: poll/select readiness is best-effort, and the actual n_tty_read() path re-checks icanon under down_read(termios_rwsem). A stale icanon value in poll only causes a transiently incorrect readiness result, which is permitted by POSIX poll/select semantics. Since icanon is a bitfield, READ_ONCE()/WRITE_ONCE() cannot be used. Annotate the read with data_race() and evaluate it as a boolean to document the intentional lockless access, bypass __auto_type compiler errors, and suppress data race detector warnings. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202603162328.vY9JOJWL-lkp@int= el.com/ Signed-off-by: Ziyu Zhang --- drivers/tty/n_tty.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index e6a0f5b40..0a0d8d70c 100644 --- a/drivers/tty/n_tty.c +++ b/drivers/tty/n_tty.c @@ -1909,7 +1909,8 @@ static inline int input_available_p(const struct tty_= struct *tty, int poll) const struct n_tty_data *ldata =3D tty->disc_data; int amt =3D poll && !TIME_CHAR(tty) && MIN_CHAR(tty) ? MIN_CHAR(tty) : 1; =20 - if (ldata->icanon && !L_EXTPROC(tty)) + /* data_race: benign race, poll readiness is best-effort */ + if (data_race(!!ldata->icanon) && !L_EXTPROC(tty)) return ldata->canon_head !=3D ldata->read_tail; else return ldata->commit_head - ldata->read_tail >=3D amt; --=20 2.39.5 (Apple Git-154)