From nobody Tue Apr 7 02:36:14 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FBA433F369 for ; Tue, 17 Mar 2026 06:41:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773729686; cv=none; b=LWhk9ZNBW+rOtuO55yzLebvgt73oQEmh1hfARNum8AiVV+pUiOi3L4z5gR0zQgY8EzNG63d4q8KNG1y7+WOQKdNZNYIrxXczuqGS9UBlvMShO8WxNzGtlvPz0HuZFC5lcsKC+GSD45BhQpKb/47ZUv9YH55rzb3jXKIgMS4KEV8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773729686; c=relaxed/simple; bh=K5zbRFeXpdZLY5xv8AuAeuYSYs9BVhm6Sj6nRcTzF6g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=R8v9ShTpRnaY4lCfyURl8Nal8IPPXD6x75Cqir7tyAUq9qJOLs71akl3/P1qRy1yH8PwDmb88u+/cKccW0i1MP4b01CGDbPjQ0G46sUs4zR0P+E5ifV4begrvHBzMpjfCsQrncRnElE1tkeTnkEXYOQHCn0QSjlDMcIkJC85aoc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=fD93E9VG; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fD93E9VG" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2addb31945aso41339655ad.1 for ; Mon, 16 Mar 2026 23:41:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773729685; x=1774334485; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nvknyLemjW45Ap19tt73jCMr/JsVlCyt3yofdVpnnZw=; b=fD93E9VGIkmEaUOXkI631npiW66afm8dE4N6f3b1gfsyXfea9TfLac8MpfkiElBpg0 dDh5YXrgYn9JfOiaQYIpJLNEtljpABf5WQBRGIvcbbeqZhC9w0aiPFtFXACiHyOeocL5 NvnhzMlx/RC37V4/FOwVtRyDk3yt6cc5Wb0N4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773729685; x=1774334485; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nvknyLemjW45Ap19tt73jCMr/JsVlCyt3yofdVpnnZw=; b=bO+Bp2eGdAUu/FisKcz+kTn8o8020knO/C+Gvt93AZqSwAP1xaIFB5I/Eu81nJx2Wp lKMuKT3X2FYjRazRxuRTfGLVoNTo318rG7nFgmMw3msEhXPasAKFsQC9kQDWNhfeIuba pbvMY9qz/PVYqKqkerHthjtVdniRiDseqVXLuMI4hl01ejLt7kYQBKIhD66bfrlIwYxq j7VR7LScMG6YFhS9pi4vRzgVvE6bR1LCitWayLZ6d+ZgvbF0CiE5UuvgO5tMLYL4kyJg wRAGCobR8XyH5d3/gPC5nQ1rBcBnH4qThZXQhQWTqjusVDf+2sOZG0Ljo8eEsRxg9PGJ z8BQ== X-Forwarded-Encrypted: i=1; AJvYcCUONk39avpTvJXinXAlWO0nSkQTaXk8j+sVzqOjE3hTrA26OfgNVxvrNK5NfLrO+PffxXHOwJn98YLNxSs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7/2d5kRKHmZzzkXQi40ve/JPduh4k9KNZqxMUr+5ndmLXUQCM HdVzRqLnz/Bc/nu3wg71lD2U/qIbQkVCSni3nw0cUo0KUcRv0JB6GHVnuCm+0Awsxw== X-Gm-Gg: ATEYQzxdKhW0ObMSD029OWSRFC1RrkTqfEic78Q4UV4Hrqm3uK5yMVCoYrHp84mCy1O YPUmJHDuiMZjzs1higYZQlDij4pyDN2iqgkIzGQ4TXtdGby8VXFHjluZHrDyPyorMHep2Ap9COf 0h7i0MsDoMfwE9tEdv1bBYX8lh65uplBb3h+n2yQ06EKnZPHOjUPOsbOjei75TaX+5knpIVaeqO 5grNbgcz3uQcCik+6zbrLnpKUMTVjpMIQf9cphkb6nYwdNRt+ODfF4wWP/gTaSB3pRxfOcKtUKr oLrVPyDKOeqUaYsXZw6gnIsxP2CEwMXMw/G2gg6qwyrwo77IpgqB0zNaPKp6Tz7m6EyXaE/2pWw uodR4BrBtAYdYxbhUYWaouJuw/nhG+Y/4+D/5ALEMmSYMwuYqk/6ERZw6aXlHcg/H8qpMKT8WC9 QBlom2mX+zbJQ3HOX5e58NSzRF8fxV4C4lrSFk3WX2TQu38BKdE2CCYKMG06uJs2W0WyzP1RF1g AJS7iz9 X-Received: by 2002:a17:903:2a90:b0:2ae:5628:a18a with SMTP id d9443c01a7336-2aeca940e72mr180774555ad.2.1773729684962; Mon, 16 Mar 2026 23:41:24 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:a064:c65d:a199:5cb6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece605231sm124269425ad.27.2026.03.16.23.41.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 23:41:24 -0700 (PDT) From: Chen-Yu Tsai To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Rob Herring , Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, asahi@lists.linux.dev, Chen-Yu Tsai Subject: [PATCH v2 2/4] drm: Introduce DRM_MODE_DUMB_KERNEL_MAP flag Date: Tue, 17 Mar 2026 14:40:44 +0800 Message-ID: <20260317064049.696795-3-wenst@chromium.org> X-Mailer: git-send-email 2.53.0.851.ga537e3e6e9-goog In-Reply-To: <20260317064049.696795-1-wenst@chromium.org> References: <20260317064049.696795-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Rob Herring Introduce a new flag, DRM_MODE_DUMB_KERNEL_MAP, for struct drm_mode_create_dumb. This flag is for internal kernel use to indicate if dumb buffer allocation needs a kernel mapping. This is needed only for CMA where creating a kernel mapping or not has to be decided at allocation time because creating a mapping on demand (with vmap()) is not guaranteed to work. Several drivers are using CMA, but not the CMA helpers because they distinguish between kernel and userspace allocations to create a kernel mapping or not. Update the callers of drm_mode_dumb_create() to set drm_mode_dumb_create.flags to appropriate defaults. Currently, flags can be set to anything by userspace, but is unused within the kernel. Let's force flags to zero (no kernel mapping) for userspace callers by default. For in kernel clients, set DRM_MODE_DUMB_KERNEL_MAP by default. Drivers can override this as needed. Signed-off-by: Rob Herring [wenst@chromium.org: Emit warning if args->flags is not zero] Signed-off-by: Chen-Yu Tsai --- Changes since v1: - Emit warning if args->flags is not zero --- drivers/gpu/drm/drm_client.c | 1 + drivers/gpu/drm/drm_dumb_buffers.c | 4 ++++ include/uapi/drm/drm_mode.h | 2 ++ 3 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c index 46c465bce98c..1a57e7eadc0f 100644 --- a/drivers/gpu/drm/drm_client.c +++ b/drivers/gpu/drm/drm_client.c @@ -404,6 +404,7 @@ drm_client_buffer_create_dumb(struct drm_client_dev *cl= ient, u32 width, u32 heig dumb_args.width =3D width; dumb_args.height =3D height; dumb_args.bpp =3D drm_format_info_bpp(info, 0); + dumb_args.flags =3D DRM_MODE_DUMB_KERNEL_MAP; ret =3D drm_mode_create_dumb(dev, &dumb_args, client->file); if (ret) return ERR_PTR(ret); diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_= buffers.c index e2b62e5fb891..ccdcc401d4dc 100644 --- a/drivers/gpu/drm/drm_dumb_buffers.c +++ b/drivers/gpu/drm/drm_dumb_buffers.c @@ -233,6 +233,10 @@ int drm_mode_create_dumb_ioctl(struct drm_device *dev, struct drm_mode_create_dumb *args =3D data; int err; =20 + if (args->flags) + drm_warn(dev, "drm_mode_create_dumb.flags is not zero.\n"); + args->flags =3D 0; + err =3D drm_mode_create_dumb(dev, args, file_priv); if (err) { args->handle =3D 0; diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index 3693d82b5279..7d5f50e4af70 100644 --- a/include/uapi/drm/drm_mode.h +++ b/include/uapi/drm/drm_mode.h @@ -1272,6 +1272,8 @@ struct drm_mode_create_dumb { __u64 size; }; =20 +#define DRM_MODE_DUMB_KERNEL_MAP (1<<0) /* For internal kernel use */ + /* set up for mmap of a dumb scanout buffer */ struct drm_mode_map_dumb { /** Handle for the object being mapped. */ --=20 2.53.0.851.ga537e3e6e9-goog