From nobody Tue Apr 7 02:35:52 2026 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0F3333CE8A for ; Tue, 17 Mar 2026 06:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773729685; cv=none; b=imbwt1GGEk/hq94ncQCWZGEHOBhUMxczOCoN3TNilWiFxYw9S+gYwrvVtjOMz/0jZg5H+n57GINtZCkaBLLgZA3XT2VVvQrkhnODQRZlVWPkXD0+ot1JItLZ60WNafLuLzuMsZ3CaQvX6ixCLoV7YMbZ5NIR43LnG+fiQ4aCEow= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773729685; c=relaxed/simple; bh=D/gw1r2j34lv0Obpyc96PLFrVbcbQ9vRoATGRk+3awY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BN/AtG6Ps8u2hofh8TbKJ4Sy2kOR94d1w04kqcsuxEH/NpvrrbX/BtoiGfg6WxKaXtkEXosZ1nCijLLKyU0uNP0+PCK91VNEHNtYNIZZWm9G6395/mJB5yxGPAg6hH0aOk4gm4MIPhUjclxNFm8Plj1m2Wz9RL18puJr5HO/E8g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=nO4lbfqP; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="nO4lbfqP" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2b05761bec1so1813595ad.1 for ; Mon, 16 Mar 2026 23:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773729682; x=1774334482; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m1Qal9owEWmx10nMbdaip52xdARaCO/YU8MURG1lRk8=; b=nO4lbfqP6hZ92SvnN+A1LFUZ0xRYkXhSdDwIOuHS63bisYhcO4cAsUPRcMJQiThquX 9OGf6QRw03cLcQlvAsqK6/6tJbF3gMwRsRl7gsHGojXgpYBL4OTlNtMPH6hJ9ABbao8X 4o4Un6DVKXpKqp/uzO/WlRPn7Ve/yXBoAGKxQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773729682; x=1774334482; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=m1Qal9owEWmx10nMbdaip52xdARaCO/YU8MURG1lRk8=; b=Scr+zcFaYVVIp08zqlucmb5COxMfIYrooz7EwNGomdUWIIvPAIhFKLq4b8x0yoWFZ+ jnyesLCLjS1vSW6Dy01EZt9AqrLOHWU5EaTahayP7yH1disE1xH59MdgI4FS8NIWVrK5 FqRJsjX3RjV5PEz2rJcesRsl94H4OwoTxN8Y/7H2PpPqbBZcYf0cUAOwzHR1bqFRhGlk Ffh3FQpolHEM186Qssd6qtctTKJZ6VYcyZN9iKMF3Mofir8AwHvPBVqSInsdAPjzHN9A WJXB71GmbdR+wWvygHb6h/ViWB+iFDK/55TfMMqVAJxDg4bvqphLUu4tLMtWB9s4cm4x QXSg== X-Forwarded-Encrypted: i=1; AJvYcCUSRvvKJIXVy1g8QhonShx+ZwTwCpuZ+wUzxQDdGRCLFEhaW/bQNYGgd2tf8kktoBCuK2KAo9k52ZCRjCQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzDqJopr3KQ1V98my4IsduqFViOqfB6tnM79vDx0Z87p3ded1XS e6CfwgNGOBSeS+DQwcLLTrncbEbL8Zm6XLfRu9vof7AuUjlCMuP06okw42K4lY7t7w== X-Gm-Gg: ATEYQzyFAwVuU1782apI9OGWCs2JvHChD+ZLp5jxoY7amtGzMat/QrcWYie0skOZ0a6 7alXu2gjsw39bgjGBQ4exAWXiLlffH9qj9nigdnBKut4jn1RoDnInU9p5RHZSDThVaYubAULXFH 5ABLmovBVgHlRdIR+QmF+V9pYmIkQVibSFfDnczqdMQdaZ3H4VUkJ623tWpY4n4cXDXoyaOLi2F G6EefIur5FPM4w1jEY89vTRskiFZGroIl4STVl2ExqpDM2tgAidojjXOJiNyhpfE0UtVZ6NFsnw 0EdeZcc3t9Dd+8To3sBjtrn2IgmAc4uYCLtnoJ/W24UqG/w7djNiP2YeN4awSi0bhZqQ9P3ALPu cz5c61Joi3OEle8hKYqQSnzcMWHb8y2c9zeOTvJMRSw3e0IQmMV1ESllFgCGWnA7b4/79lLbNub oTMLPjax0UucWaxgc8GIFJCISYZ4xb8ovVqw+UgSY5VksQrNuJ1x71f/GRsQzauvAUNfZRpm9pL DuOhG1g X-Received: by 2002:a17:903:2411:b0:2ae:cd2c:8f30 with SMTP id d9443c01a7336-2b06357ec34mr19215525ad.1.1773729682153; Mon, 16 Mar 2026 23:41:22 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:a064:c65d:a199:5cb6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece605231sm124269425ad.27.2026.03.16.23.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 23:41:21 -0700 (PDT) From: Chen-Yu Tsai To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Rob Herring , Laurent Pinchart , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, asahi@lists.linux.dev Subject: [PATCH v2 1/4] drm/rcar-du: Use drm_gem_dma_get_sg_table() helper to get scatter gather table Date: Tue, 17 Mar 2026 14:40:43 +0800 Message-ID: <20260317064049.696795-2-wenst@chromium.org> X-Mailer: git-send-email 2.53.0.851.ga537e3e6e9-goog In-Reply-To: <20260317064049.696795-1-wenst@chromium.org> References: <20260317064049.696795-1-wenst@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The rcar-du driver is directly calling dma_get_sgtable() on a drm_gem_dma_object. Not passing the dma_attrs field in may cause problems when DMA_ATTR_NO_KERNEL_MAPPING is added to the GEM DMA helpers gain support later. Instead, use the drm_gem_dma_get_sg_table() helper to get the scatter gather table. Signed-off-by: Chen-Yu Tsai --- Changes since v1: - new patch Not sure if we should add a helper like drm_fb_dma_get_gem_addr(). This seems to be the only driver that is using a scatter gather table to pass DMA addresses. --- drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c b/drivers/gpu/dr= m/renesas/rcar-du/rcar_du_vsp.c index 94c22d2db197..6a62608ee3a9 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_vsp.c @@ -291,10 +291,16 @@ int rcar_du_vsp_map_fb(struct rcar_du_vsp *vsp, struc= t drm_framebuffer *fb, dst =3D sg_next(dst); } } else { - ret =3D dma_get_sgtable(rcdu->dev, sgt, gem->vaddr, - gem->dma_addr, gem->base.size); - if (ret) + struct sg_table *ret_sgt; + + ret_sgt =3D drm_gem_dma_get_sg_table(gem); + if (IS_ERR(ret_sgt)) { + ret =3D PTR_ERR(ret_sgt); goto fail; + } + + memcpy(sgt, ret_sgt, sizeof(*sgt)); + kfree(ret_sgt); } =20 ret =3D vsp1_du_map_sg(vsp->vsp, sgt); --=20 2.53.0.851.ga537e3e6e9-goog