From nobody Tue Apr 7 01:02:03 2026 Received: from mail-oa1-f42.google.com (mail-oa1-f42.google.com [209.85.160.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 061143803E1 for ; Tue, 17 Mar 2026 06:14:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773728102; cv=none; b=FnQd7pRRshJ43h1rJOFgEj5WriPUG2o22PIM1WlcfqHvM/4uu56YiSARVQTU/Ehp5sbPDJn+pysVaiu5dFxqbDcYCSjs+BQw9Z4v8Q/x9xz2uDyZ/KLD7nPEI1zIpY8acOq1MUuQg42nMi17b4AmknECPQ5z45B6Khu9XHsuYrM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773728102; c=relaxed/simple; bh=rNMQauPWAk7SzSMQCtB3by9HDja44AYJRiJjtzFqt7Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O/ySfh4+irP1NYA/FfU1LmMz1cNfJZR7tKPYIsiGLGC3IOSFblFYXjF1jSXpfkZcMtr4O6F7eJ47/bm9Me2UfROlN14NcJJOImatl+v14grEiJ0T4/C+frfV+rARt5vSTOU5L/FVKE2tCk63g859NDXZJYwNbGNkgZg5T6aS86U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Nx53JfTa; arc=none smtp.client-ip=209.85.160.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Nx53JfTa" Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-4043b27ddeaso3386045fac.1 for ; Mon, 16 Mar 2026 23:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773728099; x=1774332899; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YZ6hk3PsIz4TmyUInrYP9VrK7Uxzm9ZqrHL0rQYAi2Y=; b=Nx53JfTaXdhSBF8Vs0sC8OmYJF6Zraq26YYTJ02apePxn44TonXNnD+nO/xtYHbOP7 VeHK7rxnyBcSmbIJOIw48TYcA6zZEqaHAzaEG34+JFDUN9wFitckEwxQOpaGwYhTZ/E7 x5Uy2h6NfFCvx3S0QqraXVAEB7Bo8AXe2akrdpNDeT5o1xLUgYs2kjeI8HCVINTsGLQB ASYsaCQqM/2ZyVdD2kpouyIeU2tIOfWe9ePXbLImdkqlLfajL1sg9+BYraT5X28zCE0S xbCNXKJkL9QPgPgYbsKEck1t+c1i8wNj7Bp458DDGwLSrJjhrvntUB5VvVYt7hdUWUuG dHyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773728099; x=1774332899; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YZ6hk3PsIz4TmyUInrYP9VrK7Uxzm9ZqrHL0rQYAi2Y=; b=sW3nyDSgkKCENbBlfqLf+wh0A0eB8jtkyl73M65SzOwsubzVTCUh82bG2SSttEg+Ff kVfOGT68+Ie2KisWg52S0hLARl42oKZemxyZB5ELAB53FkDlGzIuMME3yYBflIqIY/pv dflXMV+sczdIpBlopd8aONoezdh6utFOsZoI8UWly//QVCBoAAGSvx+VDhMHOVCxgkWi UXMN8J11WeCYthoPpXnenS7d2eq/OHnaBO97PoyUaLSswvtBM1KBJLdRdvu3ichRmb0m 0cBKupOctnC++RES1V15bm6dJmrtzCwppNNH8CJgDdRTCKb/Kr2k6xWtwEOs1VtR8Iwm tUwA== X-Forwarded-Encrypted: i=1; AJvYcCW/5IX/ermjsWmhH4yMUJXypxQo+Qx57e5y7DG7KG58893Py+zXxdrbGSKQjAM2px+H5ut3x5vFKH3UiZg=@vger.kernel.org X-Gm-Message-State: AOJu0YxpzAvFRw5qctqPl4MIC/08TNf+5vyyf3f18hSx+UCqmrofCjqj 9zZLM5NaFnDxbBiDZMTpqnZWavtalKsOQ5WDAmLHjZUFe7S4wr8natdaBsK9MuDStBs= X-Gm-Gg: ATEYQzzRZOy/RSSEy2+gE3TDhQW6zY0iynpvKIhWol0qiwBa/JXEopX4aiJ7lLhHgla 3vEMn7p2dlipHHpcqEA94Hxt5qO+aw4N/2NxIqUD0jtcpMVGWwoAlOxSgp8DHFOzDGYkUgkPw22 8e6FL8rnV3Zs9DPjZ/TZFA896/BXeWDx5E2pmRJmziorgHbzwaapp/wy5zq6AaO/kGXp85dAewh or3uviP2PRCNvgCUm/96DiZgIPLVEAbu3ak5ImTsGK100C5EuF1PTtEJJ5lS6OeLeVHjV1skfmM aAFbHEFQrxz9RbB2cxDTtHqoEDpKsBE0Yru8kWXQXrk9eNrXzcIF10c7mFkL64Cbmnvf1RgdXLF Op1h065xVHN7vrFVcjYAs2w6715Bdz9VtVThNNYmk4bh7XM42Q4JNTF9ZY7pNnwOMdn7uXRE5lU AFJvyGx69zzZDLlcuA1pTlFajdpizfdf1oxJPf73NSj8unBJOnVIB4CAahYUKruHXxyRLHSkFMo LScfqDhS64yjQAkLYEX44Y5O/16A2LBxFoOtq8zCw== X-Received: by 2002:a05:6870:6109:b0:417:6b32:f50 with SMTP id 586e51a60fabf-417b945b989mr9372892fac.50.1773728098865; Mon, 16 Mar 2026 23:14:58 -0700 (PDT) Received: from Atwell-Laptop.. (108-212-132-20.lightspeed.irvnca.sbcglobal.net. [108.212.132.20]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-4177e69c79dsm16985756fac.15.2026.03.16.23.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 23:14:58 -0700 (PDT) From: Wesley Atwell To: kuba@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com Cc: willemb@google.com, daniel.zahka@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Wesley Atwell Subject: [PATCH net] netdevsim: drop PSP ext ref on forward failure Date: Tue, 17 Mar 2026 00:14:31 -0600 Message-ID: <20260317061431.1482716-1-atwellwea@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" nsim_do_psp() takes an extra reference to the PSP skb extension so the extension survives __dev_forward_skb(). That forward path scrubs the skb and drops attached skb extensions before nsim_psp_handle_ext() can reattach the PSP metadata. If __dev_forward_skb() fails in nsim_forward_skb(), the function returns before nsim_psp_handle_ext() can attach that extension to the skb, leaving the extra reference leaked. Drop the saved PSP extension reference before returning from the forward-failure path. Guard the put because plain or non-decapsulated traffic can also fail forwarding without ever taking the extra PSP reference. Fixes: f857478d6206 ("netdevsim: a basic test PSP implementation") Signed-off-by: Wesley Atwell Reviewed-by: Daniel Zahka --- drivers/net/netdevsim/netdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c index 5ec028a00c6200ee6de2e931a2040d56f9523006..3645ebde049a0245febbd454151= 745675ef80b23 100644 --- a/drivers/net/netdevsim/netdev.c +++ b/drivers/net/netdevsim/netdev.c @@ -109,8 +109,11 @@ static int nsim_forward_skb(struct net_device *tx_dev, int ret; =20 ret =3D __dev_forward_skb(rx_dev, skb); - if (ret) + if (ret) { + if (psp_ext) + __skb_ext_put(psp_ext); return ret; + } =20 nsim_psp_handle_ext(skb, psp_ext);