From nobody Tue Apr 7 02:40:31 2026 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF25B3803E8 for ; Tue, 17 Mar 2026 05:53:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773726828; cv=none; b=kNOjPcA9sSlnjhxC9jox0v+W7pZOj72rCdmPUAWm6WbW+lYhsynjotiDa/HTJ4h3OR1BfNCBd8Oy+Zuwz7NCt1fB8skaYEAYytdh1OroeMdNUNJt+azGF6XPoIw2KotyAQEnQz3iGKm05JkxohfAkPMkU5EPh7rXjO5qSmDctto= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773726828; c=relaxed/simple; bh=YnHls8NIVjy5Ei7a4hKc1qV28zK+UaZo7VK2CAN8c3w=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=CpTOsJ+yq+WdsbifLZeP1oVrzPV7FKqk9wo6+uHX8jyRGuekN2jcIWHZthCcwilHRljZBIw9KnJu7xzk2ti5Et3PfYsffU5r+EN6S0EittDp+2T+0j/j0YG+D/5ZKbTem9FuWs+mPeRA7obBekC6zB4yE4eREtGJZ7Xhv9/v6fY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CZaH7B0f; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CZaH7B0f" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-2bdc1b30ac8so81194592eec.1 for ; Mon, 16 Mar 2026 22:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1773726826; x=1774331626; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=4sR/GkKKCK4vlTKAx1HdQnSDfMDIglmN+8LdctHHquI=; b=CZaH7B0f+C3xa/FsGjzd/HvczyHWkhOwyx965AwK3zmQoiBc/JrHWYAd3CCIUY559M 3vlDLuP0SLRA9sLA67mNoOndErkPDHBQCcvHcBuIQsapKb+yudMkJscfxgNsEu/W4rCZ pJ8QYrTeQTgEdXv6aWgP/aI1euy+TwESvLxg9Y68sfg/qXzz/YBiw5xfU/rTpH/gPQUy iPs+4WxLbpOlG+R9H6PgjYDbcONPmTfZBkCbPgE4i3CKM+kX/0cr9sBduLVV9fvKfANC K70a1U/WMO80EylvO10jHUgoaFF4nAxHuG5Iog46I0xTe5hn/2Iy1eMh9C2DBaSGxXjM 9hIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773726826; x=1774331626; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4sR/GkKKCK4vlTKAx1HdQnSDfMDIglmN+8LdctHHquI=; b=I1BCeZuEbCR7MIJdjjD3ISrY6CqhuYYq8ksQNpaMNkAJjHlP8yhA/6GvU/VnUbeP/3 cKPkIoT91dGmu8jshKZXeMp74XIq2mNXPhHaZq++Ew+XEf06qUuEbI9HNRgpA8zhZ5Sg u93PCU2hMTF/SzPTDRul1VnB2Qs8nsvI0V8a3dMwd3iMIzQQA4OpirXiXOx+Aki2CESR Eo1/HiN2Kp9xrr98KoxblQwBXLoxhPQ5qnyAbsSQ2Bu/9yfntXeHvKAV9mLc1cp/OsiY CYkQo6dZRkxy2lOSBx8psJaZ/vYd+QFOYr6ECv3PKGDJuJ6CK7u5dN4lj2MSM9eq9ASN PFTQ== X-Forwarded-Encrypted: i=1; AJvYcCX6b9kpR4ijUfRUxLIHFppwQx01pYh1+sPK7rj3YNRPHUr7QYMc66MucS36JgQkLu9dIsgymhzABlgih4o=@vger.kernel.org X-Gm-Message-State: AOJu0YwAaYFJJxCpJQxR2AU/IFeVsAq31OHqf1MZ6Ks4Qd2ln3CcuwYX ByrTQTNr75Y/3pRvYgz53LcbEigEPw9gCCaFCmsms0T80B4HIXrbABu2nN9mPCPkegtYycdj6DA BqCBGOQfhQQ== X-Received: from dybvz8.prod.google.com ([2002:a05:7301:7a08:b0:2be:2465:40e5]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:4308:b0:2c0:d690:7b8 with SMTP id 5a478bee46e88-2c0d6901e3cmr1075723eec.23.1773726825768; Mon, 16 Mar 2026 22:53:45 -0700 (PDT) Date: Mon, 16 Mar 2026 22:53:32 -0700 In-Reply-To: <20260317055334.760347-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260317030601.567422-1-irogers@google.com> <20260317055334.760347-1-irogers@google.com> X-Mailer: git-send-email 2.53.0.851.ga537e3e6e9-goog Message-ID: <20260317055334.760347-4-irogers@google.com> Subject: [PATCH v5 3/5] perf evsel: Constify option arguments to config functions From: Ian Rogers To: tmricht@linux.ibm.com Cc: irogers@google.com, acme@kernel.org, agordeev@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com, japo@linux.ibm.com, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-s390@vger.kernel.org, namhyung@kernel.org, sumanthk@linux.ibm.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The options are used to configure the evsel but are not themselves configured. Make the arguments const to better capture this. Signed-off-by: Ian Rogers --- tools/perf/util/evsel.c | 20 ++++++++++---------- tools/perf/util/evsel.h | 8 ++++---- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index bd14d9bbc91f..54c8922a8e47 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c @@ -1015,8 +1015,8 @@ uint16_t evsel__e_machine(struct evsel *evsel, uint32= _t *e_flags) return perf_session__e_machine(session, e_flags); } =20 -static void __evsel__config_callchain(struct evsel *evsel, struct record_o= pts *opts, - struct callchain_param *param) +static void __evsel__config_callchain(struct evsel *evsel, const struct re= cord_opts *opts, + const struct callchain_param *param) { bool function =3D evsel__is_function_event(evsel); struct perf_event_attr *attr =3D &evsel->core.attr; @@ -1080,14 +1080,14 @@ static void __evsel__config_callchain(struct evsel = *evsel, struct record_opts *o attr->defer_callchain =3D 1; } =20 -void evsel__config_callchain(struct evsel *evsel, struct record_opts *opts, - struct callchain_param *param) +void evsel__config_callchain(struct evsel *evsel, const struct record_opts= *opts, + const struct callchain_param *param) { if (param->enabled) return __evsel__config_callchain(evsel, opts, param); } =20 -static void evsel__reset_callgraph(struct evsel *evsel, struct callchain_p= aram *param) +static void evsel__reset_callgraph(struct evsel *evsel, const struct callc= hain_param *param) { struct perf_event_attr *attr =3D &evsel->core.attr; =20 @@ -1106,7 +1106,7 @@ static void evsel__reset_callgraph(struct evsel *evse= l, struct callchain_param * =20 static void evsel__apply_ratio_to_prev(struct evsel *evsel, struct perf_event_attr *attr, - struct record_opts *opts, + const struct record_opts *opts, const char *buf) { struct perf_event_attr *prev_attr =3D NULL; @@ -1170,7 +1170,7 @@ static void evsel__apply_ratio_to_prev(struct evsel *= evsel, } =20 static void evsel__apply_config_terms(struct evsel *evsel, - struct record_opts *opts, bool track) + const struct record_opts *opts, bool track) { struct evsel_config_term *term; struct list_head *config_terms =3D &evsel->config_terms; @@ -1445,7 +1445,7 @@ void __weak arch_evsel__apply_ratio_to_prev(struct ev= sel *evsel __maybe_unused, { } =20 -static void evsel__set_default_freq_period(struct record_opts *opts, +static void evsel__set_default_freq_period(const struct record_opts *opts, struct perf_event_attr *attr) { if (opts->freq) { @@ -1490,8 +1490,8 @@ bool evsel__is_offcpu_event(struct evsel *evsel) * enable/disable events specifically, as there's no * initial traced exec call. */ -void evsel__config(struct evsel *evsel, struct record_opts *opts, - struct callchain_param *callchain) +void evsel__config(struct evsel *evsel, const struct record_opts *opts, + const struct callchain_param *callchain) { struct evsel *leader =3D evsel__leader(evsel); struct perf_event_attr *attr =3D &evsel->core.attr; diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 97f57fab28ce..339b5c08a33d 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h @@ -287,10 +287,10 @@ void evsel__set_priv_destructor(void (*destructor)(vo= id *priv)); =20 struct callchain_param; =20 -void evsel__config(struct evsel *evsel, struct record_opts *opts, - struct callchain_param *callchain); -void evsel__config_callchain(struct evsel *evsel, struct record_opts *opts, - struct callchain_param *callchain); +void evsel__config(struct evsel *evsel, const struct record_opts *opts, + const struct callchain_param *callchain); +void evsel__config_callchain(struct evsel *evsel, const struct record_opts= *opts, + const struct callchain_param *callchain); =20 int __evsel__sample_size(u64 sample_type); void evsel__calc_id_pos(struct evsel *evsel); --=20 2.53.0.851.ga537e3e6e9-goog