From nobody Tue Apr 7 01:03:22 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E46822D97AA for ; Tue, 17 Mar 2026 04:00:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773720060; cv=none; b=QZM5UgFHeHQhe9okwJx596pnJ2uffxvMGf2O+GREZl9zQP35Ph6wjIWYYqsjgHzW2pQg4nigcpJiXmcRACg+X+dcwXl0FYiIiGhzp5UXyII+HIZFU587RWSB2nLHOxWncxkX/6YeWnJpGtN6mdgpHimjepT4vyvjqpzr2ZDmRCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773720060; c=relaxed/simple; bh=AWUHAbnMhkzBN/5PALE6ZGnx6pUPyWl+RUNHP7ukVq0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CYBNIe07MlZ/kTJ1z7bDxfwtMPell1FwXAMARqZAsjmnnUzTT7osWSTFlUQK/f2nwtmQPGBGH1A0Ywn/92Fi6zapnOleed3z0SWoC1QVlBbpsLtor/ESVW8OYObpkX111ufpfzZjnnRS8O+uIvsBUFZ74f3kVSW0651AzeKNzo8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=if5xFnM7; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="if5xFnM7" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2b062069f80so6714685ad.0 for ; Mon, 16 Mar 2026 21:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1773720046; x=1774324846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fi+k9jVt6BrKHmKcd0MUUmIWC23KS6caLRUR6qHsl2M=; b=if5xFnM7ch33PckXwUj9KgsgK+ec752QQBad8zsJkV4UuMskV7+vmLs23hSwgUVm7i sFCy+TXb1c8eQ8bdjbSChoBKXggCBk1fpVgHFtgJBuQ8NG9aies2XoHOrorEaE8SAjno omtV0jk27R2jqAjw3dZmo+6SAmwcOYclf03R0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773720046; x=1774324846; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fi+k9jVt6BrKHmKcd0MUUmIWC23KS6caLRUR6qHsl2M=; b=LxAjhMC9vArzEc8ckWqtheUR9iCT/jzkRASCE+SGm720anbDM/e79zI8v75nYYM4Bk C8bDkhlM1FcfJYxTvPZ8JjczTeWrutRfjpwTEwZcYUqN31SuMlh6WnMvjEwTYf44yn4L Bjdr5TH+nLvdGmriM1AeGENezEfVZPDOJ6XDuJ3KJ/SarjJ1yj9iw+mHrmQKaj6p2VNN ILo6oMvII6Afc2GxxsfPQAIfajuFCZNxE7UTQ7lDis6cwYS3FxzFwO+BzNCTGU8OuT0R 3Zp7scTSXm6mOhLe74vGJy3oXfg+gcvjSSFzj1wSHF4eKOBr8Q4Dic2Unh2sstxWEakM Fh3g== X-Forwarded-Encrypted: i=1; AJvYcCUxPr79S0gYGejcaCFEyC8c7QtSLEWTRJLkmlhIZ8K1BWvWcW211pxt8+bPSZ4hNiYH7oXhU8drdawLkm4=@vger.kernel.org X-Gm-Message-State: AOJu0YwkifxoWateXsGIZnj1nVO1a83HHxzIiI3GrxBG3oOFoVugzkeA 5KFSjEiT9C6HK/L2lZxeVwokfeLBFuh4o65qgLM7E766A89w6mioNnHmbEo5gE9xJA== X-Gm-Gg: ATEYQzwmTWfA2s+LPVYvpG/ZXqoZ5AQCFYiJbOFLtSTlaOcMlX8RKkYg1ourR4DUFJV E+G1J9Gfa5cKriD1mE6/fZ7uHFSaqxJW6fCzgh/lXAxvjuAeAK7hQlsd2wewGp1+IVACl3kF/Ga D1A7V3XFKgqaSADXWbDUdL6+Zx6pcVXS1YT9tE3lEXZrNyC45NAdayUR9nfU+4yk4b7yij8pPIj +ar5ywrhVbT971yLuxdsinptwOgUm18wW5kmS40so8kzWqXLLaxorPNtBm1vk93C+mjLVNYboSw kw1ccykpCjInaznzjzpyr5zvtk8z8DQ50JwN5Ojfysewg0ePkYajHLhMXT92ZdfI0cgp+SCfUp3 oWzWef1JauOiiBZlb5wfH++4eo16HFc6AbmBOzxdXVtEqsFaBvB/cSd02E4gH1oZcwKYpB9Baa8 5kRzZ8z8DD8Zx8IyU1vNfrZaZFei0Zc+/BpN3+/4iREIGbTBoG1LBajRX585Pz7CfqvkG6ilTx2 XZxggBN X-Received: by 2002:a17:902:e951:b0:2ae:c5fc:b2ea with SMTP id d9443c01a7336-2aecab1ef18mr170084665ad.30.1773720046451; Mon, 16 Mar 2026 21:00:46 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:a064:c65d:a199:5cb6]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b05f0ab17asm45335195ad.37.2026.03.16.21.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 21:00:45 -0700 (PDT) From: Chen-Yu Tsai To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/gem-dma: set VM_DONTDUMP for mmap Date: Tue, 17 Mar 2026 12:00:32 +0800 Message-ID: <20260317040034.617585-1-wenst@chromium.org> X-Mailer: git-send-email 2.53.0.851.ga537e3e6e9-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When the mmap function was converted from a file op to a GEM object function in commit f5ca8eb6f9bd ("drm/cma-helper: Implement mmap as GEM CMA object functions") some VM flags were not lifted from drm_gem_mmap(): - VM_IO - VM_DONTEXPAND - VM_DONTDUMP VM_DONTEXPAND was added back in commit 59f39bfa6553 ("drm/cma-helper: Set VM_DONTEXPAND for mmap"). VM_IO doesn't make sense since these are memory buffers, while "IO tells people not to look at these pages (accesses can have side effects)". Add back VM_DONTDUMP. This matches the behavior of most other GEM implementations. Signed-off-by: Chen-Yu Tsai Reviewed-by: Thomas Zimmermann --- Cc: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_dma_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gem_dma_helper.c b/drivers/gpu/drm/drm_gem= _dma_helper.c index ecb9746f4da8..1911bf6a6a3e 100644 --- a/drivers/gpu/drm/drm_gem_dma_helper.c +++ b/drivers/gpu/drm/drm_gem_dma_helper.c @@ -534,7 +534,7 @@ int drm_gem_dma_mmap(struct drm_gem_dma_object *dma_obj= , struct vm_area_struct * * the whole buffer. */ vma->vm_pgoff -=3D drm_vma_node_start(&obj->vma_node); - vm_flags_mod(vma, VM_DONTEXPAND, VM_PFNMAP); + vm_flags_mod(vma, VM_DONTDUMP | VM_DONTEXPAND, VM_PFNMAP); =20 if (dma_obj->map_noncoherent) { vma->vm_page_prot =3D vm_get_page_prot(vma->vm_flags); --=20 2.53.0.851.ga537e3e6e9-goog