From nobody Tue Apr 7 01:05:25 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2463029D273 for ; Tue, 17 Mar 2026 03:13:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773717230; cv=none; b=Gi7HsCpcyXM7yQJ027UKkl6TrD7RzOhbK5vUgS0TokB+Pr0l3M7/ePvVmr2vA1BWIqtBqreA+iE8IJiCOQmR/rdQH4NCAUoaQ4p05QGu+tjlJWHiB0S8PTQYfuUK/KqGYBk0iCEBg7Qjkk3P4narM9KV6HbkZwpS5RTsid+DzmA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773717230; c=relaxed/simple; bh=Yybj2ls8W42h/0OzWfEEkmKjjvmjH+XERsG6pbI8eg4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=orJJNYgnv/r5VEhfMm4EFs0qbGfWxOOW0xYBcnI67ENWMmF+9niPRZSLCdSk61caofGHNPzAyS/qOqHAaj3ynMlz/uR54xWs5YdnmA5scGvRK253f1OB4Ldt0/6pjcHm2I3sPO5WE24DnPSEOB52hH88lcTbt/VzZpkm3EmehLU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NFR5EbiV; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NFR5EbiV" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82a15b44c3cso2059711b3a.0 for ; Mon, 16 Mar 2026 20:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773717228; x=1774322028; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gu1DU71QEoeriPLtDyr4IxAoMPD9+M+2Obobs0fac7Q=; b=NFR5EbiVru0jngFKZHrwKTZRvPbBt8dFnRsqXuYwxOh1pnK5IxdpqPezvm12o6E42a qCz+cuGfGze6zMdBdHjVO6AEIdVkejngk5tGksWQZQYHr3Bx/yOTtf6x1Xd6mNITHYUS wEGnX5mbmcp9tU2Q+5Iql+NwVlZ6KdMcEYqC0529GWOPb1FVTMpk13SpMljDRCF/hLhw EkcxsIS8QBuJqHgDgVJQny1UeFxjQy/lei2WrvjapMW8iNSOztOpmDO5c2YBg0f3ptai 6Z96gyXO30Ss1/lHsZnLl+tBv4MZuu7hNkAq3oevE1tKQbqi9IYMcurf73aAbXJjF5hA uGgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773717228; x=1774322028; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gu1DU71QEoeriPLtDyr4IxAoMPD9+M+2Obobs0fac7Q=; b=Oy45L5k/+FAsaT79kJSmHgWj/FjEn4NHmL3LM/Ex3jJZK2dAAgdes/s51EDar+Plrn uyggXFFkkGvo/gburZ7DD5nZ6sam1fhslgX4wvEmxAY2VOnwAMk5zJxpuLc2tXp2jXIR oeZYawNIrn9eYKvdZlt904pe/3UktdvswNzRRAkD+sAtdQZ/nm8luakWT32AcbLCQTUO JwvdnVSfiArp47egmgKe+OyVINofeYwjKo8K8Y0MdiUwQAuLE83zXbOksg60Lkxu3UiH BNS+/H7tlzr0xyuwFYkc1FimP3cc01/G44NAnOOGI3cMFdygkXwckI3EndM9bCCEeOsa cxXw== X-Forwarded-Encrypted: i=1; AJvYcCVS6tdGCSFIpOSLFgO4YnBPdrhN30T4j+4AV+daCxfSvHbKw60rK8cWyOW5Gb1hLOvUXjxYkCgXow3Y3bQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0HTZ3Ebg8m3oMD1aBy5122vry74DeAtf/yl5AS8Ac8tQe/+l2 ceazepaiTLFt3YQSWQt7e9iJyyLOfjSTCJRDivaiFUqd9E5bmgb5fcvAsxfN66VZ X-Gm-Gg: ATEYQzxvwR49LKGVoJEpoPRJFG75BXp3t0G3KwjkCit+yYYDWTrRRUy3Dk6m3ocVpkT Udrkl9SsDrmPn5oW7TkBdHGR2Ry9U7IhgknaoVXXd/5tmNj48lJ1e7wBbeSdF0crPRijzIoj1k1 rvgT+qPxD1rYmMUYNxzEhPrewhKVhJk0syCo0E0NQDVsN1TOIz/PemhzTA9zxyKjfzUc0wLCnMq LRiHf6tjUG8F4G/2Nvss1hlQvTsK+JLH1pBO2ycUAyAM3pvk6yZA7PyDSHZ5qNcURb/pHuc9JBf f4bsZZi/q4sHOR+KT8ucQxpwC3GxVHuqd9rG52YlGuzNIUVReaM10uFJ4yHEiGUsda+awzjXS8B LzSHGS2+LEm34yM15Ye1Xn2H8eglVIdoTTf/sfXyeNmRhvnLT/yvIMMtsXtk/+sanP/RTlZQ737 DL2Kz+DOrdBxe+/+PlovsGuxfIgTxsW7VkPpqSg3Ehdg== X-Received: by 2002:aa7:888f:0:b0:829:73f4:6ff with SMTP id d2e1a72fcca58-82a198cd33cmr11879984b3a.37.1773717228314; Mon, 16 Mar 2026 20:13:48 -0700 (PDT) Received: from toolbx.alistair23.me ([2403:581e:fdf9:0:6209:4521:6813:45b7]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a07341ed1sm14337206b3a.33.2026.03.16.20.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 20:13:47 -0700 (PDT) From: alistair23@gmail.com X-Google-Original-From: alistair.francis@wdc.com To: hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Cc: alistair23@gmail.com, Alistair Francis Subject: [PATCH] nvme-auth: Include SC_C in RVAL controller hash Date: Tue, 17 Mar 2026 13:13:30 +1000 Message-ID: <20260317031330.2794078-1-alistair.francis@wdc.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Alistair Francis Section 8.3.4.5.5 of the NVMe Base Specification 2.1 describes what is included in the Response Value (RVAL) hash and SC_C should be included. Currently we are hardcoding 0 instead of using the correct SC_C value. Update the host and target code to use the SC_C when calculating the RVAL instead of using 0. Fixes: f50fff73d620 ("nvme: implement In-Band authentication") Signed-off-by: Alistair Francis --- drivers/nvme/host/auth.c | 2 +- drivers/nvme/target/auth.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/auth.c b/drivers/nvme/host/auth.c index 4e8e4ddd6c8d..4ea1a46bad94 100644 --- a/drivers/nvme/host/auth.c +++ b/drivers/nvme/host/auth.c @@ -581,7 +581,7 @@ static int nvme_auth_dhchap_setup_ctrl_response(struct = nvme_ctrl *ctrl, ret =3D crypto_shash_update(shash, buf, 2); if (ret) goto out; - memset(buf, 0, 4); + *buf =3D chap->sc_c; ret =3D crypto_shash_update(shash, buf, 1); if (ret) goto out; diff --git a/drivers/nvme/target/auth.c b/drivers/nvme/target/auth.c index 839239fe877a..965690afd1bf 100644 --- a/drivers/nvme/target/auth.c +++ b/drivers/nvme/target/auth.c @@ -477,7 +477,7 @@ int nvmet_auth_ctrl_hash(struct nvmet_req *req, u8 *res= ponse, ret =3D crypto_shash_update(shash, buf, 2); if (ret) goto out; - memset(buf, 0, 4); + *buf =3D req->sq->sc_c; ret =3D crypto_shash_update(shash, buf, 1); if (ret) goto out; --=20 2.53.0