From nobody Mon Apr 6 23:36:58 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 089F72FFDCC for ; Tue, 17 Mar 2026 16:10:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763850; cv=none; b=uo2fO8jZFaub+fqe85IdciR1lIzj4SzxB9PwXmmAIlnwqlmiOEDl3/HoMV+K74TTeN88EFvarnNl9uLwBDXEtDOuYv60EJGW6dk6ugkgpgoKUfUNA2OpCd2H5MQzWCOoo+XdFaL1Qt1DWpTnMCRjL4eecCBo09janVCAlkApjig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763850; c=relaxed/simple; bh=Ad7z3HJ2if1PIQldhqb2c7q3YI4ATsbh//vY1VYZr6E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BQHUTJhTQTOWqTcShn5DTz3BIHqXrBfteFDs5ix8j2quOsb02bc+a/0t523TeyWua/Z/Egw1qyR45NPzo9WQ+cHqWDgUmsk1jksmWHPKuADMo4lit3cOMliNLkIjoyqr+QZljsI9YzUG8AbvmBX5XsxKyvo3EQe3OnkDjpUve6k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=AyfhwnMl; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="AyfhwnMl" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=YH8fD1IzZL6h5rUNAaqwcILRggoUDJ1blzSAWoAiJKc=; b=AyfhwnMlngogFN7ZBxoSi+p1+p jcwv86yjzqEgr/MDo7mPDIkuJJIB4YRA5eW/sl9OmaKQOVUyGb+wOTW4yzklJG4AuIr0mg8tuNNC7 u2TgIceZefQuWAd8omA48b3E7tSvHk94nkIeTcEXz2+bfEeDjCSZ6b/wIhdl5mdihR4SUjKAIraj+ gd3lJE4omGXVyQHiTpic34kKuqK30kRG3lyjNHj7H/7tlKLaWJX6S69mX9TA/hJyZ7op5oaDBtAzG T5hZurA64ozrijDZjPcu4IgbYdzZTRByiXOm4fmjI9J2IWRokaeiosDXrDL96cz63qeCNU1g/2uTY 9NC+Yg8g==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w2X0H-0030D2-5o; Tue, 17 Mar 2026 16:10:44 +0000 From: Breno Leitao Date: Tue, 17 Mar 2026 08:33:58 -0700 Subject: [PATCH v7 3/4] mm: huge_memory: refactor enabled_store() with set_global_enabled_mode() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-thp_logs-v7-3-31eb98fa5a8b@debian.org> References: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> In-Reply-To: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" , Wei Yang , Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=3635; i=leitao@debian.org; h=from:subject:message-id; bh=Ad7z3HJ2if1PIQldhqb2c7q3YI4ATsbh//vY1VYZr6E=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpuXzrh2HFlAWxcSLtzduwx9EkBuYGgsrwmns4q oXbojSC7mOJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabl86wAKCRA1o5Of/Hh3 bSsUD/9c8yfvdymyg6ulRdEROv/oa21LpucvoYvy6O/YIDoLmj+qopNzDSOp02FmGd6tqnefQBu 7gvW8EUsTvl8mmbPVVksYhzTBpgoPCVTWEM9vDI4BO/WvacFguHItfQwHIzC10UnTZC94nCDN7Y iC0xLG9TX87kUuTvmVynlzH2txCAwd3n0747aJRq+aRcE/A7SoCeY6vnB7J3JlWwUQ23V7zDQ6f HnqRhKyj+7+bxfXOtve7WoPRkiBsUCaT4s0xdxHpbbFqiyt8Ac9D7uMGKXmVAd8L0dy2E8jqt7B 8aE+5aPBG9TMHwz7pMq0yxVhjZ166QOvH/v9YCedMQ6F74mTr69uwwjd1E+V4bICpP6MWpCe791 GAbQcH8hd8qSnpw07lT2P0kjJmVI1KXP9vbeL5cDLtV91BNnxXceAI0ou/gVu2JN4ktJBGBBHXJ 7htObsRpRhXTjoO0cU18QBpa7qYdZ4kdPl75mSSSKHPUFMNHlaV66waCMHOKN2KSMSEXfOwrz8J cige+elKvcFgHiI2JoEBx7RxAREnhp0wjeTKGkLJGAVSiv9blZXMlYBBKfQVVuSfqr9e7mJwm+m 2SqUwhoaZq32V4KTXt/ejQnhB5GDMRUJ+m6q3ct47Cc4+VZn7JBoGyPl/GYDi/8u17rOodLulvT DzUygzJ+iwNIZqA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Refactor enabled_store() to use a new set_global_enabled_mode() helper. Introduce a separate enum global_enabled_mode and global_enabled_mode_strings[], mirroring the anon_enabled_mode pattern from the previous commit. A separate enum is necessary because the global THP setting does not support "inherit", only "always", "madvise", and "never". Reusing anon_enabled_mode would leave a NULL gap in the string array, causing sysfs_match_string() to stop early and fail to match entries after the gap. The helper uses the same loop pattern as set_anon_enabled_mode(), iterating over an array of flag bit positions and using test_and_set_bit()/test_and_clear_bit() to track whether the state actually changed. Reviewed-by: Lorenzo Stoakes (Oracle) Reviewed-by: Zi Yan Reviewed-by: Baolin Wang Reviewed-by: Wei Yang Signed-off-by: Breno Leitao Acked-by: David Hildenbrand (Arm) --- mm/huge_memory.c | 63 ++++++++++++++++++++++++++++++++++++++++++----------= ---- 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index f6af90e6cf05d..b95fde5843399 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -330,30 +330,63 @@ static const char * const anon_enabled_mode_strings[]= =3D { [ANON_ENABLED_NEVER] =3D "never", }; =20 +enum global_enabled_mode { + GLOBAL_ENABLED_ALWAYS =3D 0, + GLOBAL_ENABLED_MADVISE =3D 1, + GLOBAL_ENABLED_NEVER =3D 2, +}; + +static const char * const global_enabled_mode_strings[] =3D { + [GLOBAL_ENABLED_ALWAYS] =3D "always", + [GLOBAL_ENABLED_MADVISE] =3D "madvise", + [GLOBAL_ENABLED_NEVER] =3D "never", +}; + +static bool set_global_enabled_mode(enum global_enabled_mode mode) +{ + static const unsigned long thp_flags[] =3D { + TRANSPARENT_HUGEPAGE_FLAG, + TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, + }; + enum global_enabled_mode m; + bool changed =3D false; + + for (m =3D 0; m < ARRAY_SIZE(thp_flags); m++) { + if (m =3D=3D mode) + changed |=3D !test_and_set_bit(thp_flags[m], + &transparent_hugepage_flags); + else + changed |=3D test_and_clear_bit(thp_flags[m], + &transparent_hugepage_flags); + } + + return changed; +} + static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { - ssize_t ret =3D count; + int mode; =20 - if (sysfs_streq(buf, "always")) { - clear_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flag= s); - set_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - } else if (sysfs_streq(buf, "madvise")) { - clear_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - set_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flags); - } else if (sysfs_streq(buf, "never")) { - clear_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - clear_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flag= s); - } else - ret =3D -EINVAL; + mode =3D sysfs_match_string(global_enabled_mode_strings, buf); + if (mode < 0) + return -EINVAL; =20 - if (ret > 0) { + if (set_global_enabled_mode(mode)) { int err =3D start_stop_khugepaged(); + if (err) - ret =3D err; + return err; + } else { + /* + * Recalculate watermarks even when the mode didn't + * change, as the previous code always called + * start_stop_khugepaged() which does this internally. + */ + set_recommended_min_free_kbytes(); } - return ret; + return count; } =20 static struct kobj_attribute enabled_attr =3D __ATTR_RW(enabled); --=20 2.52.0