From nobody Mon Apr 6 22:03:57 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E48592F83A2 for ; Tue, 17 Mar 2026 16:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763841; cv=none; b=hDOfKGyW44Qei5PSnRg0mrQMK1hghQKjonDlf8qJnGfMoQuDwA2bAprDSzLfpF8oZPsgaN4mA2Zm+sCzfiKVi0FXtu8sTvxYAUGDtjJ3H1TfbOCZjG/nsWx+RkyikItJ2BAzQQrzZxDPJGl0kGFnw/Ha+Cgu7vBxItQMz/VMkxA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763841; c=relaxed/simple; bh=lZahW99RTlxb5nSjc6Dzfk6SVjr8wXe8geyfqZrys/g=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E/rXG0ieU9BPPt50vIyVu4t0MDpHWyKGZFknFe1xtl+HwKLmLx41CjvPKxJzkHFt3ohOxT+AAKLxPUdq46lehxKCZn21kyLMOBSAZGTWP1lEugWPANXiyuRyGuegtBASFUxNCeDrCe/6WGRSjSfL4qu/JcvywmDEV/zYU9MrIEE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=ETKtABop; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="ETKtABop" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=iXIH1tXdZIJ5fkYaX4jFP9QBJPuyNx5b18M8eLitWko=; b=ETKtABop8RMB1N1hwh9qdAsbfQ muP3R5voa2dogweh/AO6SVg93WDAQDr6d79b5H/PerHFv0YstYa4X1z9b/Tymv5Dx19Rou5a+Gtpu HPESMY/67fZYvlvgDjc9aW2TIKE+BhfERySa+V/WEwA4KnJ8G1CUZQXL6dzM7ssngsh5e4aoOKX5R 97ivItPtiPAikXLh50PTY2BdRhrW/5uLEI8SOqpO5OycL2+zMeboou6gkid3cJl2aJqp7i971BlGH IRS3n3M3EWkJOh+8QA0UD+aGsVD5nQ1uvaLxp0J/kV//tz8JIUsAK2zKy6ZqjGGXP/Dm1WAsatJtG Ut06+pDQ==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w2X05-0030Cj-M7; Tue, 17 Mar 2026 16:10:32 +0000 From: Breno Leitao Date: Tue, 17 Mar 2026 08:33:56 -0700 Subject: [PATCH v7 1/4] mm: khugepaged: export set_recommended_min_free_kbytes() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-thp_logs-v7-1-31eb98fa5a8b@debian.org> References: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> In-Reply-To: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" , Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=1398; i=leitao@debian.org; h=from:subject:message-id; bh=lZahW99RTlxb5nSjc6Dzfk6SVjr8wXe8geyfqZrys/g=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpuXzqij5aGVzOFfRM+umycL/9gIY0a7yS9b4bl 68lokWPD6GJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabl86gAKCRA1o5Of/Hh3 bbIsD/4m/znNJe40MQE5ofwG6vFNP3YWTVf/fm49nE+Q9zY6ku9griom1UxaprpDVRjKv949eF9 6l9Hw9IXB6ATAXX+LNcn8u5dlAYH+2Nj0KCb0xokAz6itx5ryfuRlCrGZCvLPJgRQpx7Fz9PTKQ 4B77AQ6bIAp3m/Wyq22IkPXBmwKtsq0YxCOtm3lEvN4GJrr+1Ey0j0Z0dkutk6HuWgO+dawk5J3 Ovyn7PAPHj62pG6TfvlT//tIeiyl6b6EIiy6ithYqdRZhNlIjUTBijbsZzhoGPaH21mv6tPvvJa wEcDmaro/jDdDOnGZBDZsiBrDRxNLzWfCioymLq48KdU8r2eLZ3psELlJZeWTUu2Xc+hndl3XXG 8mpt73PiDlIeDyxQIa0i1GaN1+/vaPqmqxZSv7uf/SdEniTDF4ODuc8or8RKYdIltEi3al3uzM5 l5+MdxWRqy9ktECgUdW65J1FhwZ2zrUwGUqMrj7Uw5hrg9rRZBeKO9L4u7na0Is5op2Wdai4GZC 4ityfFPvziO1KCtvDrp3frSQ8vcYAaafCS5470PhxnVxFxlJIagma56Xe/Nror/7ylzJga7Wfzy iD/tUZ0IzW0y2EiMELepylKwjVsCe2W8daNE3zkltIZTSjGyxC1yApaIjE6q9pq5AwG4J/R/5BB Ivwct7PqCI0G41g== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Make set_recommended_min_free_kbytes() callable from outside khugepaged.c by removing the static qualifier and adding a declaration in mm/internal.h. This allows callers that change THP settings to recalculate watermarks without going through start_stop_khugepaged(). Suggested-by: Lorenzo Stoakes (Oracle) Reviewed-by: Lorenzo Stoakes (Oracle) Acked-by: David Hildenbrand (Arm) Reviewed-by: Zi Yan Signed-off-by: Breno Leitao --- mm/internal.h | 5 +++++ mm/khugepaged.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/internal.h b/mm/internal.h index cb0af847d7d99..7bd768e367793 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -623,6 +623,11 @@ int user_proactive_reclaim(char *buf, */ pmd_t *mm_find_pmd(struct mm_struct *mm, unsigned long address); =20 +/* + * in mm/khugepaged.c + */ +void set_recommended_min_free_kbytes(void); + /* * in mm/page_alloc.c */ diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 1dd3cfca610db..56a41c21b44c9 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2630,7 +2630,7 @@ static int khugepaged(void *none) return 0; } =20 -static void set_recommended_min_free_kbytes(void) +void set_recommended_min_free_kbytes(void) { struct zone *zone; int nr_zones =3D 0; --=20 2.52.0 From nobody Mon Apr 6 22:03:57 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57D533054EC for ; Tue, 17 Mar 2026 16:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763844; cv=none; b=eWncKWTW9NGFBswNvVyM/1o6dLlU+NCCb5b5xl8ukuNzuDoV73DsCJz+MJhIYWRF5nxkrBoZW/uccbYKN2gT/A0GIzPi5sucWHQdtzpLVqu8Kv/d/BYk8N/aE/uZkQkU/ZWy/X4StsjFIzFj2SAnO8LjHWF8fHiLKXNWIMCBwic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763844; c=relaxed/simple; bh=uVMygvKt3H9/z7XcvkSzsG4Gn2PVtGxvuzCVVJiXtVM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UcvuxUiaE3ESsRfow86wuc0N0Sv12pVQyAkkHbeIiKL3XHKJMiDPmn8DTl6wApmwL05zfE+lNB0hqG9+gjt+ypOj7Y1VK46Lqr0UyXvWI+MrJwqVs+t53XiuTxhz0FhBi69MgtyWACOeoxqbdEAD8KRZdVSCb8xuzscGbPWLQsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=CtSe43tP; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="CtSe43tP" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=0FFhVCvaiK4sCPHtuUiD0P0I+e7xIUEsukRzL1BWPx8=; b=CtSe43tPytaRWUYVmPZ3ImM0bd jctNcyYVgObxGlyQdHxG/Jk1Afsl8kk9gTvJnGMq3vHRYQRHICN1DMF/bFBRnomPhAwpeZmKl0FQI fL6qPvGnwVtBvwPtGNpcjzenlDNwzCVX7R4Gk5lxcEfhP1/fkjtzZgDQf6HUFYlOnTAvPJuEwbbh5 KeTbQzTPtQpZMUaLljjvh6HFyiuQpkP92uduNo/TJ0CtFR81alBmOAJkMa29ddkD4BX9cZQyNrGw4 P0sz/jszwNtpaQ7P2WFfLY6WyQVsG6RXqjouO5YpRFm54x6TH3ock6KjXxw4b1ZzC6PTOvYAPWkGZ TYcTyzHg==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w2X0B-0030Co-9e; Tue, 17 Mar 2026 16:10:38 +0000 From: Breno Leitao Date: Tue, 17 Mar 2026 08:33:57 -0700 Subject: [PATCH v7 2/4] mm: huge_memory: refactor anon_enabled_store() with set_anon_enabled_mode() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-thp_logs-v7-2-31eb98fa5a8b@debian.org> References: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> In-Reply-To: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, Breno Leitao , "Lorenzo Stoakes (Oracle)" X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=4477; i=leitao@debian.org; h=from:subject:message-id; bh=uVMygvKt3H9/z7XcvkSzsG4Gn2PVtGxvuzCVVJiXtVM=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpuXzqHmsvblOOL0RHrdyBTRoL1xrQNiU5cacMj qU3CerKM3CJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabl86gAKCRA1o5Of/Hh3 bfHHD/418gZu10Ilig+OwpDl3ktYXmF0E6sx4ody6Jz+y5mfGOLHu9xplhIyoBrx7N+KdRcBBZ/ f4fOyBpf6eKsapIiR4wI39KiOpZ3MMU8Val+gr1Oepj03YGGgld77RaZNhs7jddK3OfiN3mXn7q uOOpOsN4BWxRaCpXWtAufAA9FvUDLNJPHfswzqDLKoj9G8EggkyMp3cLPVh28u1gXwYkGFAOU/V JRoccNZ0IPhbygTmx9aeKSpbXMPfLLkwsuwezNHCJ7dcaUFysMKQsYjMvtdxWkGJvYT7sD+O9DS k8cHbV67LLSTLqXF54KuH9yzdRseb9WwuNB89a3FAqX0Y3BkYZ2kgcK+p08ZJ952Tm7XRo9WGnx UwjqY0bZhvP1qJ/elndvioRaDwFAbhgKbacL5VGjiDRog5miAB2qhrTPTJwUVWYs21+NH0MoV6P ahv1/phBBTWlfK3MnJT7xD69IYKRbuQSFtrAfcJJZ+C0sXrSWd9vOKaN8hx5ozQbt3AGLoqMoJA AAus2c7H6D7LrMKQmt1iZ8VCO36BNJ/O+Uh+6wV4jfU0pog6Jd/UUd9HUuzwjtiuK+d1NNn3V+k SKaHEaPkSPgUnTybPtWZTCtAI1qlqbvHwqv4cl3/achR7oGN74p2NMJzpA2+2CPnH2cfwJU3agC PFT3JdJeocGfiPw== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Consolidate the repeated spin_lock/set_bit/clear_bit pattern in anon_enabled_store() into a new set_anon_enabled_mode() helper that loops over an orders[] array, setting the bit for the selected mode and clearing the others. Introduce enum anon_enabled_mode and anon_enabled_mode_strings[] for the per-order anon THP setting. Use sysfs_match_string() with the anon_enabled_mode_strings[] table to replace the if/else chain of sysfs_streq() calls. The helper uses __test_and_set_bit()/__test_and_clear_bit() to track whether the state actually changed, so start_stop_khugepaged() is only called when needed. When the mode is unchanged, set_recommended_min_free_kbytes() is called directly to preserve the watermark recalculation behavior of the original code. Signed-off-by: Breno Leitao Reviewed-by: Lorenzo Stoakes (Oracle) Acked-by: David Hildenbrand (Arm) --- mm/huge_memory.c | 84 +++++++++++++++++++++++++++++++++++-----------------= ---- 1 file changed, 52 insertions(+), 32 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 8e2746ea74adf..f6af90e6cf05d 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -316,6 +316,20 @@ static ssize_t enabled_show(struct kobject *kobj, return sysfs_emit(buf, "%s\n", output); } =20 +enum anon_enabled_mode { + ANON_ENABLED_ALWAYS =3D 0, + ANON_ENABLED_INHERIT =3D 1, + ANON_ENABLED_MADVISE =3D 2, + ANON_ENABLED_NEVER =3D 3, +}; + +static const char * const anon_enabled_mode_strings[] =3D { + [ANON_ENABLED_ALWAYS] =3D "always", + [ANON_ENABLED_INHERIT] =3D "inherit", + [ANON_ENABLED_MADVISE] =3D "madvise", + [ANON_ENABLED_NEVER] =3D "never", +}; + static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) @@ -515,48 +529,54 @@ static ssize_t anon_enabled_show(struct kobject *kobj, return sysfs_emit(buf, "%s\n", output); } =20 +static bool set_anon_enabled_mode(int order, enum anon_enabled_mode mode) +{ + static unsigned long *enabled_orders[] =3D { + &huge_anon_orders_always, + &huge_anon_orders_inherit, + &huge_anon_orders_madvise, + }; + enum anon_enabled_mode m; + bool changed =3D false; + + spin_lock(&huge_anon_orders_lock); + for (m =3D 0; m < ARRAY_SIZE(enabled_orders); m++) { + if (m =3D=3D mode) + changed |=3D !__test_and_set_bit(order, enabled_orders[m]); + else + changed |=3D __test_and_clear_bit(order, enabled_orders[m]); + } + spin_unlock(&huge_anon_orders_lock); + + return changed; +} + static ssize_t anon_enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { int order =3D to_thpsize(kobj)->order; - ssize_t ret =3D count; + int mode; =20 - if (sysfs_streq(buf, "always")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_inherit); - clear_bit(order, &huge_anon_orders_madvise); - set_bit(order, &huge_anon_orders_always); - spin_unlock(&huge_anon_orders_lock); - } else if (sysfs_streq(buf, "inherit")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_always); - clear_bit(order, &huge_anon_orders_madvise); - set_bit(order, &huge_anon_orders_inherit); - spin_unlock(&huge_anon_orders_lock); - } else if (sysfs_streq(buf, "madvise")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_always); - clear_bit(order, &huge_anon_orders_inherit); - set_bit(order, &huge_anon_orders_madvise); - spin_unlock(&huge_anon_orders_lock); - } else if (sysfs_streq(buf, "never")) { - spin_lock(&huge_anon_orders_lock); - clear_bit(order, &huge_anon_orders_always); - clear_bit(order, &huge_anon_orders_inherit); - clear_bit(order, &huge_anon_orders_madvise); - spin_unlock(&huge_anon_orders_lock); - } else - ret =3D -EINVAL; + mode =3D sysfs_match_string(anon_enabled_mode_strings, buf); + if (mode < 0) + return -EINVAL; =20 - if (ret > 0) { - int err; + if (set_anon_enabled_mode(order, mode)) { + int err =3D start_stop_khugepaged(); =20 - err =3D start_stop_khugepaged(); if (err) - ret =3D err; + return err; + } else { + /* + * Recalculate watermarks even when the mode didn't + * change, as the previous code always called + * start_stop_khugepaged() which does this internally. + */ + set_recommended_min_free_kbytes(); } - return ret; + + return count; } =20 static struct kobj_attribute anon_enabled_attr =3D --=20 2.52.0 From nobody Mon Apr 6 22:03:57 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 089F72FFDCC for ; Tue, 17 Mar 2026 16:10:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763850; cv=none; b=uo2fO8jZFaub+fqe85IdciR1lIzj4SzxB9PwXmmAIlnwqlmiOEDl3/HoMV+K74TTeN88EFvarnNl9uLwBDXEtDOuYv60EJGW6dk6ugkgpgoKUfUNA2OpCd2H5MQzWCOoo+XdFaL1Qt1DWpTnMCRjL4eecCBo09janVCAlkApjig= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763850; c=relaxed/simple; bh=Ad7z3HJ2if1PIQldhqb2c7q3YI4ATsbh//vY1VYZr6E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BQHUTJhTQTOWqTcShn5DTz3BIHqXrBfteFDs5ix8j2quOsb02bc+a/0t523TeyWua/Z/Egw1qyR45NPzo9WQ+cHqWDgUmsk1jksmWHPKuADMo4lit3cOMliNLkIjoyqr+QZljsI9YzUG8AbvmBX5XsxKyvo3EQe3OnkDjpUve6k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=AyfhwnMl; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="AyfhwnMl" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=YH8fD1IzZL6h5rUNAaqwcILRggoUDJ1blzSAWoAiJKc=; b=AyfhwnMlngogFN7ZBxoSi+p1+p jcwv86yjzqEgr/MDo7mPDIkuJJIB4YRA5eW/sl9OmaKQOVUyGb+wOTW4yzklJG4AuIr0mg8tuNNC7 u2TgIceZefQuWAd8omA48b3E7tSvHk94nkIeTcEXz2+bfEeDjCSZ6b/wIhdl5mdihR4SUjKAIraj+ gd3lJE4omGXVyQHiTpic34kKuqK30kRG3lyjNHj7H/7tlKLaWJX6S69mX9TA/hJyZ7op5oaDBtAzG T5hZurA64ozrijDZjPcu4IgbYdzZTRByiXOm4fmjI9J2IWRokaeiosDXrDL96cz63qeCNU1g/2uTY 9NC+Yg8g==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w2X0H-0030D2-5o; Tue, 17 Mar 2026 16:10:44 +0000 From: Breno Leitao Date: Tue, 17 Mar 2026 08:33:58 -0700 Subject: [PATCH v7 3/4] mm: huge_memory: refactor enabled_store() with set_global_enabled_mode() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-thp_logs-v7-3-31eb98fa5a8b@debian.org> References: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> In-Reply-To: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" , Wei Yang , Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=3635; i=leitao@debian.org; h=from:subject:message-id; bh=Ad7z3HJ2if1PIQldhqb2c7q3YI4ATsbh//vY1VYZr6E=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpuXzrh2HFlAWxcSLtzduwx9EkBuYGgsrwmns4q oXbojSC7mOJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabl86wAKCRA1o5Of/Hh3 bSsUD/9c8yfvdymyg6ulRdEROv/oa21LpucvoYvy6O/YIDoLmj+qopNzDSOp02FmGd6tqnefQBu 7gvW8EUsTvl8mmbPVVksYhzTBpgoPCVTWEM9vDI4BO/WvacFguHItfQwHIzC10UnTZC94nCDN7Y iC0xLG9TX87kUuTvmVynlzH2txCAwd3n0747aJRq+aRcE/A7SoCeY6vnB7J3JlWwUQ23V7zDQ6f HnqRhKyj+7+bxfXOtve7WoPRkiBsUCaT4s0xdxHpbbFqiyt8Ac9D7uMGKXmVAd8L0dy2E8jqt7B 8aE+5aPBG9TMHwz7pMq0yxVhjZ166QOvH/v9YCedMQ6F74mTr69uwwjd1E+V4bICpP6MWpCe791 GAbQcH8hd8qSnpw07lT2P0kjJmVI1KXP9vbeL5cDLtV91BNnxXceAI0ou/gVu2JN4ktJBGBBHXJ 7htObsRpRhXTjoO0cU18QBpa7qYdZ4kdPl75mSSSKHPUFMNHlaV66waCMHOKN2KSMSEXfOwrz8J cige+elKvcFgHiI2JoEBx7RxAREnhp0wjeTKGkLJGAVSiv9blZXMlYBBKfQVVuSfqr9e7mJwm+m 2SqUwhoaZq32V4KTXt/ejQnhB5GDMRUJ+m6q3ct47Cc4+VZn7JBoGyPl/GYDi/8u17rOodLulvT DzUygzJ+iwNIZqA== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao Refactor enabled_store() to use a new set_global_enabled_mode() helper. Introduce a separate enum global_enabled_mode and global_enabled_mode_strings[], mirroring the anon_enabled_mode pattern from the previous commit. A separate enum is necessary because the global THP setting does not support "inherit", only "always", "madvise", and "never". Reusing anon_enabled_mode would leave a NULL gap in the string array, causing sysfs_match_string() to stop early and fail to match entries after the gap. The helper uses the same loop pattern as set_anon_enabled_mode(), iterating over an array of flag bit positions and using test_and_set_bit()/test_and_clear_bit() to track whether the state actually changed. Reviewed-by: Lorenzo Stoakes (Oracle) Reviewed-by: Zi Yan Reviewed-by: Baolin Wang Reviewed-by: Wei Yang Signed-off-by: Breno Leitao Acked-by: David Hildenbrand (Arm) --- mm/huge_memory.c | 63 ++++++++++++++++++++++++++++++++++++++++++----------= ---- 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index f6af90e6cf05d..b95fde5843399 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -330,30 +330,63 @@ static const char * const anon_enabled_mode_strings[]= =3D { [ANON_ENABLED_NEVER] =3D "never", }; =20 +enum global_enabled_mode { + GLOBAL_ENABLED_ALWAYS =3D 0, + GLOBAL_ENABLED_MADVISE =3D 1, + GLOBAL_ENABLED_NEVER =3D 2, +}; + +static const char * const global_enabled_mode_strings[] =3D { + [GLOBAL_ENABLED_ALWAYS] =3D "always", + [GLOBAL_ENABLED_MADVISE] =3D "madvise", + [GLOBAL_ENABLED_NEVER] =3D "never", +}; + +static bool set_global_enabled_mode(enum global_enabled_mode mode) +{ + static const unsigned long thp_flags[] =3D { + TRANSPARENT_HUGEPAGE_FLAG, + TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, + }; + enum global_enabled_mode m; + bool changed =3D false; + + for (m =3D 0; m < ARRAY_SIZE(thp_flags); m++) { + if (m =3D=3D mode) + changed |=3D !test_and_set_bit(thp_flags[m], + &transparent_hugepage_flags); + else + changed |=3D test_and_clear_bit(thp_flags[m], + &transparent_hugepage_flags); + } + + return changed; +} + static ssize_t enabled_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { - ssize_t ret =3D count; + int mode; =20 - if (sysfs_streq(buf, "always")) { - clear_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flag= s); - set_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - } else if (sysfs_streq(buf, "madvise")) { - clear_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - set_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flags); - } else if (sysfs_streq(buf, "never")) { - clear_bit(TRANSPARENT_HUGEPAGE_FLAG, &transparent_hugepage_flags); - clear_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, &transparent_hugepage_flag= s); - } else - ret =3D -EINVAL; + mode =3D sysfs_match_string(global_enabled_mode_strings, buf); + if (mode < 0) + return -EINVAL; =20 - if (ret > 0) { + if (set_global_enabled_mode(mode)) { int err =3D start_stop_khugepaged(); + if (err) - ret =3D err; + return err; + } else { + /* + * Recalculate watermarks even when the mode didn't + * change, as the previous code always called + * start_stop_khugepaged() which does this internally. + */ + set_recommended_min_free_kbytes(); } - return ret; + return count; } =20 static struct kobj_attribute enabled_attr =3D __ATTR_RW(enabled); --=20 2.52.0 From nobody Mon Apr 6 22:03:57 2026 Received: from stravinsky.debian.org (stravinsky.debian.org [82.195.75.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 421CD2FFDCC for ; Tue, 17 Mar 2026 16:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=82.195.75.108 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763855; cv=none; b=d7tPxma9mDxi78a+tgxL0V87az34GsfpyhJLokBJoQLQVWD9eFKUJaLkM+2sZhCfpWueh+M57hbfK/uaQuA2kWFD10hZ86HuBQ/zZJ0rV7mbPRxngGUhi/LdvDmiU27axVm/af8Q/Y6N+nquDGJNZrcAXhDKHki8UineSGjod38= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773763855; c=relaxed/simple; bh=ve+lNwoqDQSYspSHS5OWSYYUOfQw+Gl9hm3vxR11Gs4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HUi+ovHe1Jy2ln06kWy7+Aur2/npgetjEYzaRf+dxZ2/tOoc0L3rmIILo40gZ+STiRleRFVj1AOcM1/o3qFhWGnYoTeFZPcsXUv57+MB1CU/FpPFZGcozXzHQrSzmQwnyY/8CE9SbpAvBAlZzkybcrmcX5Ds+OHsx3ze/JxM/0A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org; spf=none smtp.mailfrom=debian.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b=b5eay61N; arc=none smtp.client-ip=82.195.75.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=debian.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=debian.org header.i=@debian.org header.b="b5eay61N" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.stravinsky; h=X-Debian-User:Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description; bh=Nzuz22HJlpi5hM3GMMNGDuF/FPshFhM/ibIt8PNUdHM=; b=b5eay61NUmMmAob36DsZbL+iTZ 1yKb/qHzVdFH4UP8cL02l++bSWo35OlEvu4H26fErlyaH6lrNIVdK7ypxj4rNCPgAA2WL0TqPXWsk QJxtwgId2C8tDRmn6CgQibs4FsggS+yo6VJ1tHZqy4Dub73T4wy7rlbhnKHaOAU8iqD7IxPD5IIx9 wTSSf8ZDoFOzkLn3zlU9+YwrdwBBvCA+zarShmQ8YWxuPj2lxlnzWz3W3a7HRTrC8GWK6JkQyUybB hJkxMvsLJT79+2WND/bvgvgU2cHwlCKceiCGiJcPZM9PiwkJFQbIU/cxW2lUHNzpSrEmcmTPo+/V2 PIcTzANw==; Received: from authenticated user by stravinsky.debian.org with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1w2X0M-0030DI-MU; Tue, 17 Mar 2026 16:10:49 +0000 From: Breno Leitao Date: Tue, 17 Mar 2026 08:33:59 -0700 Subject: [PATCH v7 4/4] mm: ratelimit min_free_kbytes adjustment messages Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-thp_logs-v7-4-31eb98fa5a8b@debian.org> References: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> In-Reply-To: <20260317-thp_logs-v7-0-31eb98fa5a8b@debian.org> To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Mike Rapoport Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, usamaarif642@gmail.com, kas@kernel.org, kernel-team@meta.com, "Lorenzo Stoakes (Oracle)" , Breno Leitao X-Mailer: b4 0.15-dev-363b9 X-Developer-Signature: v=1; a=openpgp-sha256; l=2046; i=leitao@debian.org; h=from:subject:message-id; bh=ve+lNwoqDQSYspSHS5OWSYYUOfQw+Gl9hm3vxR11Gs4=; b=owEBbQKS/ZANAwAIATWjk5/8eHdtAcsmYgBpuXzroH5aB8XBfzM5dWLCNGjcXcgYnmHfGDSMH 3PTPikV4bqJAjMEAAEIAB0WIQSshTmm6PRnAspKQ5s1o5Of/Hh3bQUCabl86wAKCRA1o5Of/Hh3 bQ7ZD/9ZwqiZ3XSJ7Pw+NydgDOfCXjfOGMORk3H+U3xVFmlgowPcozGIvatUbinks9si7c8WJWd +Ucth2ssTs+9xbhK0mR8ybsc5Cy6309+JNiqm74LBDfFIfGZ0lipVIAkR2Gajs2tswPyvBPx3YJ SMMVHwqVLki6JZgomnsspKgCBQY5sOYwZ1BdAy3Dw8XLKM1cmlexbenH2SdieiWw7WDzfJrUTrI kRA5AySY9vKUoM8uCDaiRIIInwKQiP3y4cI/+1UXkQ4IUPaZ7IrkfZoxBXfn/uEwarpdEN2mRbE 9CahN7R3+gcQNIEbK5ln0njHGVK1AYqTsTvae7DJTktWX3VI6asrUOzsZXt455bsQvCc671tIZV 23OFigoFASibsguFSG0JJHDPnYuuBbKKr/j6XskJd4hr0yo4UzzLHPq/zNmLQ7j8mXifLt0zR1k vej9TWsFiEtCvBMFAwOYZgDaejpckfZEpw/hpeg6EItdNOLol1sIdAz/5GZG7yfKeROiKonmec6 qC9GTp4zKPgcLYKTFO0JI8eG7BAuKih7eSGMOpubX2KZ59+WGSmRVI1CZgC/veHdbwi54D5lnT5 aPhd/YUVvMcwkM47s6POfyWO5k0SrsALvDtOXb0d9z3D4c9zq7SRDRYI2CWq84K52rAZGMB7Bt+ Jy1k4o/zDV3pEzg== X-Developer-Key: i=leitao@debian.org; a=openpgp; fpr=AC8539A6E8F46702CA4A439B35A3939FFC78776D X-Debian-User: leitao The "raising min_free_kbytes" pr_info message in set_recommended_min_free_kbytes() and the "min_free_kbytes is not updated to" pr_warn in calculate_min_free_kbytes() can spam the kernel log when called repeatedly. Switch the pr_info in set_recommended_min_free_kbytes() and the pr_warn in calculate_min_free_kbytes() to their _ratelimited variants to prevent the log spam for this message. Reviewed-by: Lorenzo Stoakes (Oracle) Acked-by: David Hildenbrand (Arm) Reviewed-by: Baolin Wang Acked-by: Zi Yan Signed-off-by: Breno Leitao --- mm/khugepaged.c | 4 ++-- mm/page_alloc.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/khugepaged.c b/mm/khugepaged.c index 56a41c21b44c9..d44d463ccfd3e 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2671,8 +2671,8 @@ void set_recommended_min_free_kbytes(void) =20 if (recommended_min > min_free_kbytes) { if (user_min_free_kbytes >=3D 0) - pr_info("raising min_free_kbytes from %d to %lu to help transparent hug= epage allocations\n", - min_free_kbytes, recommended_min); + pr_info_ratelimited("raising min_free_kbytes from %d to %lu to help tra= nsparent hugepage allocations\n", + min_free_kbytes, recommended_min); =20 min_free_kbytes =3D recommended_min; } diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 2d4b6f1a554ed..c840c886807bf 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6553,8 +6553,8 @@ void calculate_min_free_kbytes(void) if (new_min_free_kbytes > user_min_free_kbytes) min_free_kbytes =3D clamp(new_min_free_kbytes, 128, 262144); else - pr_warn("min_free_kbytes is not updated to %d because user defined value= %d is preferred\n", - new_min_free_kbytes, user_min_free_kbytes); + pr_warn_ratelimited("min_free_kbytes is not updated to %d because user d= efined value %d is preferred\n", + new_min_free_kbytes, user_min_free_kbytes); =20 } =20 --=20 2.52.0