From nobody Tue Apr 7 00:08:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01B3F33CEAA for ; Tue, 17 Mar 2026 09:21:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739286; cv=none; b=ORFb+PBE4ldNaJwG4NxhRN/jJMOftBeCCNyZhDNzIhh5RE4bhTpzlrC3nvH7jZ8+nj09Ue3Gh56z4+0g9Gt5OzRVCSMjy3+fviOgf95BMOYu9AqlIidV2ulgow1o7wT8MXo1MbEywMwjU99MD6S1V1V4nF14nkKigpKU6HNOkGE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739286; c=relaxed/simple; bh=ZoTYC4gGpP+T/L/xPYhrBgESTmeIr5ilNZ2zTsHOxS8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QT3e9ICCyy4IoA04Ii0p2tOrcdugw/d3pUfyGK7bSDTIvGlSqX2dH+yBv3GX+30DWPRRQM0irsfdTr9+RabMIrULu/zd8eonmBdG2j2WPKXqSes2zYNbMM1c4JNHSoOnC4Dvh3YzOUyzi4P65D1KR18J1yUPVKuUN0dn0GyoNyk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kJXE11x8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=U4QIdo2Q; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kJXE11x8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="U4QIdo2Q" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H7PT8p3295277 for ; Tue, 17 Mar 2026 09:21:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= K+r4d0K1NIBE1np9DcmCa86bjp9Sk+dZVE7N8ud5Txg=; b=kJXE11x8HS21ZnSq GcJt9Ycvh7QcZKkVOqdI5xeIXEjAok+SOBPIXw1iTkH2uiKYVkYMQQBm8bCW7n9o XRxYoktdYHGERXH3COcayc5U+XNd/asjNG0xP6pr7IqyJZ/xckPZLZeePrtc9CHP ZZnykm5WBSsazsEwv7GIoemyhk54viDPK7eUeNN7lmRK8osicGXA97HI59JHpDoj 0r58RH2HqHyoSPXnsdG6sbeUNBk9dRvY9bAVOpcp/onUsi+oJkr2dVL8IGGJcQ2O AGFoDXaNjcIfedAe+QkGWTUVA4T/YVDz7M+244k7tknZxQc1GU7DY9xYShLznlWX Z33Y1A== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxkuy3bm8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:21:23 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35b93be1227so2692768a91.0 for ; Tue, 17 Mar 2026 02:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739283; x=1774344083; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=K+r4d0K1NIBE1np9DcmCa86bjp9Sk+dZVE7N8ud5Txg=; b=U4QIdo2Q3IxR5q49FWRiDIFLRDfKH0OL2OL9kxgR+9BkuclLo3KJW+2EI4qEnAxq93 Sb7xNnd/FPo9wT3uqBDam96yPNlPtLfTAxa8G1LcpNB7n+I+qdA/JIxZFjE5d11etKCG qRNetBO+amPa+YZoi7W9TE+1n0Wf7UazewHrLsaE1/zlRZ1htrI2IkPTifOdY3mgRjQo QCRWXFZTHUQfhLjy6D5M2oD2ubBBGzvMIWl2flyBKiBEJBxljLrWI4Gdz6xeXGl/hO4s tAOk80zgmDU5XTr8pzzpCPymQ2kd/uV3Qjui1QakxfLQSFSWyJsFVARBJUZZ89Injbyu XcXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739283; x=1774344083; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=K+r4d0K1NIBE1np9DcmCa86bjp9Sk+dZVE7N8ud5Txg=; b=m1h73xbRovkbsrOjvrMoYyRJb4Uz6kL0S/z52yx8ztt/V7AfydlmpxXO4V+/gTqfMc wLFC28Ob1dmqIoyApNlfIuHp7Js9hGRjY6l3a7XiIPKrQ9cxDkb4zuosqFTdLxbEs0w6 84Qu4a8lmM7fPxEPNlclqRt/6O9gFSiseooPBDYZ1ml0G2nAWk4cHpVv+gNnN8kLqUME tqPCyn95VkmLs3qjr0q9cKyFKZQPXO0yoo7BPYay6K9pd0mFMryPylas67alo8beBenD URmph7dp1JyRR8Y4tZmhPzlaf66N/kMOx07HQ1hPskBPmhnKzS3qH7jLVo9fr5KSP8BB 2bkg== X-Forwarded-Encrypted: i=1; AJvYcCWHNTVkgoP8kalxzwwF5mjf4gzVrnj8aQoHw3/df4ZX2qBuOvzTWPuGWzPDowcb0IBlEGZAISVCUjPwhcE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8uaV5OTd6hPTdmWqXWPAJBykdJWDGhhlqw6qwa8UsnPbvU6Is J7x25OQ1YrqCSGOji95G2kiDas7stmKZ96q+ybButfsguUSOkrQwLOh2A5eXhepB6nQFQtpc8uu ZhmUCQmfLMpyheGt+aDBW6QGiuKrqAhRUjjvhm2pdPjUtW8DNf/ZKiKgBVp/n4Iq6VsQ= X-Gm-Gg: ATEYQzxKNVHKnvPcSFxpo6XaLKHSoi2OSG/oQ10JnsYk7yiTCjAo3vaX6nECXToaOc/ 31J9gyn/bn54ydirTOL1MaO6cJ807Xk2+/kT/0Iz5A5k4lNHOf13GaOvdqw37NuZ3B8DSiSRw/F SXhVYHWDJ4D9CTeBTf6pu3c2Zy3XdVTAV5O4qwoyeRo2mrQYmbwgnE9LXN64exxS/PKjxJCf7qv pgcr0g7vRETUyu/sTRyeVbIkj7rcP/lTEpDkr5ArjQVPaPjrgG8bUOUsDaOhNHSPJ++mAf9Vr0g lHvhofJmbbp5EPdbyGPP8008zt9qR+m3JuT0fLGdW6rNMzQayjywygE34fqN8ib8c4D2pfu+sxK DeNuI097/5fQDvP5+Pj2DpKPgwEvO1qbf+5gs3eL3IMWTtzM= X-Received: by 2002:a17:90b:1e45:b0:359:f2e1:5906 with SMTP id 98e67ed59e1d1-35a21e3958emr13589226a91.4.1773739282727; Tue, 17 Mar 2026 02:21:22 -0700 (PDT) X-Received: by 2002:a17:90b:1e45:b0:359:f2e1:5906 with SMTP id 98e67ed59e1d1-35a21e3958emr13589177a91.4.1773739282112; Tue, 17 Mar 2026 02:21:22 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.21.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:21:21 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:40 +0530 Subject: [PATCH v3 01/12] dt-bindings: crypto: qcom,ice: Allow power-domain and iface clk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-1-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=2159; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=ZoTYC4gGpP+T/L/xPYhrBgESTmeIr5ilNZ2zTsHOxS8=; b=xdpCR4Jhrp26F+SmeMPtKGA42JLxPzSPWxmOzvipMHoX/IOupgWCUogAki83Kb1VVPRYaF4vL Y7H79xL/1wDADi6Vc/bFD3hABg7ETbG+F9YoksoPWeh22EMjoBKLzrJ X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=br1BxUai c=1 sm=1 tr=0 ts=69b91d13 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=FLtWHdY9P_O1C5dx__cA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX3+EczygHcRNn BCv0gXHJlIizjjbqru30mYK2gwy/CDxvgddACvLY6b9EwceaCQFLuOW47eDVwIKXmCt55OfQYbA HQqQqgVtah/y6KMxv6QBSuuDskIKImRqS1w9V8gK89maTt6LD5Fo50kJ3cgPKeanDC9s6KI4aXz eK9vcO2PblZcyv5b5u5RTCu3PSDkX03AfBIgGlda9Wn6wEvJuLa9nTmisV+jBXx5JqiWynIcCHv GHOot021VLKA5siWzWZ5J6gjLAXqgQc/TIYR/jm+8BOT2ChfAs+R/n00Sarw0ru3Pu8mCiSdeRY L1+E38IBlMvbRrb8+ilcZVsRiHtI3sm5f78+VAK0eBIQb/E2oC2foI2L1QLnSZQHi3X6VSKHlAZ oljFdfIvURQIKRbVTbFHpYPv/cQxDmJWcfjgJegmnoLCDUhG5YX9J2oYoqySR+4D0owzX/9aT0K yZ3qm7zklq+3pK1VjpQ== X-Proofpoint-ORIG-GUID: zcV2EYSo4AcE6ChO1DaiY__FywnNxU34 X-Proofpoint-GUID: zcV2EYSo4AcE6ChO1DaiY__FywnNxU34 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Update the inline-crypto engine DT binding in a backward compatible manner to allow specifying up to two clocks along with their names and associated power-domain. When the 'clk_ignore_unused' flag is not passed on the kernel command line occasional unclocked ICE hardware register access are observed when the kernel disables the unused 'iface' clock before ICE can probe. On the other hand, when the 'pd_ignore_unused' flag is not passed on the command line, clock 'stuck' issues are observed if the power-domain required by ICE hardware is unused and thus disabled before ICE probe could happen. To avoid these scenarios, the 'iface' clock and the associated power-domain should be specified in the ICE device tree node and enabled by ICE. Fixes: f6ff91a47ac57 ("dt-bindings: crypto: Add Qualcomm Inline Crypto Engi= ne") Signed-off-by: Harshal Dev --- .../bindings/crypto/qcom,inline-crypto-engine.yaml | 16 ++++++++++++= +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-en= gine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-eng= ine.yaml index 876bf90ed96e..99c541e7fa8c 100644 --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml @@ -30,6 +30,16 @@ properties: maxItems: 1 =20 clocks: + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + items: + - const: core + - const: iface + + power-domains: maxItems: 1 =20 operating-points-v2: true @@ -52,7 +62,11 @@ examples: compatible =3D "qcom,sm8550-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x01d88000 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; =20 operating-points-v2 =3D <&ice_opp_table>; =20 --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B3E53033E7 for ; Tue, 17 Mar 2026 09:21:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739293; cv=none; b=tb4bBtROlqghg2PHIHCqCZrtUHeFKSEBSKu4o9SaGsefdyhfZAty538TRHjRCVaMQMIZ4p9D0WXkXJq0aDonqhsIgKD36YZOTO7nFnXzyiY8fD9uC/brfRXyL3lzvFV/MlqI69mO9Q27Z6uP7RjAD8W8UnQngGCcXYTRJEN6VTc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739293; c=relaxed/simple; bh=mn3vp2GeE4VYgG9OnPMhnQiQ0TVYi4qOkzgc8W0I0jE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WzCpiRIqExzXE0hxQWwV45+71HwJ/4Vt14jyDcS4+TJnwCK0ZXe15LpByzPVGlns+27WOI3PsNRycUCKFxzThKvdw7OHcm0aG9XeO7Ppur8f5tUmppwY/1OroOcHJC8Rmis/0utYa7IqaVvjn8MkQyqvmt7/StiHiniBxQ22kmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IBjqnnLi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kbnf9CC+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IBjqnnLi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kbnf9CC+" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H8n3DK3103092 for ; Tue, 17 Mar 2026 09:21:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KflmNQXpDp+B1vYqVCrRq7N42vfr2cm4gnAe7kporG4=; b=IBjqnnLiCVC1yIxa K/Op6QbHBC2NFkL1SExe/+AWlMgF+peKj+o19zXqn4xukhywjos3o4WKY2VD9H4N Pg3bXMY73g3arozcnWK+otNzV06RLTqlCgXE5q1wrbx6y/Veaw2o8p8rBYPy6U3Z 1YeN8Iaeu4kS/F8wCLGn8B2Pwgz8/On99gcEv0AJfcfpZULu2bvLlSuwwFiZCaAw dpaLJondhl166hCLOu2Q3XYb8eC9JuqH+Aj0pqMbNfUJqpMEyn53s1uJZn+PXCqK NtgvCYwKfN6emoN5Je3a9XaHQRF7aibho4cq5WbxegeA3LGK3oHZJNH92aEEElmZ s3JcZg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxnb7b4f1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:21:31 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35b8da51b3eso3185471a91.1 for ; Tue, 17 Mar 2026 02:21:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739291; x=1774344091; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KflmNQXpDp+B1vYqVCrRq7N42vfr2cm4gnAe7kporG4=; b=kbnf9CC+KIgiyAXc6EhLkHXOoYoEdQ+6lZQ866ugRBoJoesgNB6J7i81crE/ni+Qp6 D0XWWb+VjeEZ9i7dxs3/UVAsoDIHn2Q5Oe1HSaOwRwvSZdwndATRquH7ZW3fWHeu6K+x y6cTdBIJEM5dwxNKjMgTQqFh6tMJlL1fdEsLGfzExEKsEM1TvEqpbUJ+mLP/deoy7k71 O/RGZ31o9tfNXfrpz6BJGDY2PnlXsA4NxSakGsD6fsiWZ/CgLeUyvHOtns3gxHn1NF0h l9bmIPJ8erV42L2htFgaYusmVI20Z5bfS41Lxocu7f4IoABL3ZQmRxTJZrWZO5pQWkgr VNCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739291; x=1774344091; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=KflmNQXpDp+B1vYqVCrRq7N42vfr2cm4gnAe7kporG4=; b=LyJ+sv/vECy7SxummKNlFxo4ZZZrCZx3HisjKXWNcc9o0WwO/NFImzNB5aaJaEgbJH kS0TAr+hk4gksjqi51US+nReJAsCyR3elfY8HVelOQqpMbQc0p+4GGL7UjDb1uqNj1Pb 6eBRXBkIerexFLkfgah1ujJqz0PrBAco2x8QRhTm5aHTBecqV1Nu5P4qU0Y1yFOGmv9X rrikkGCLAWLS3U1Ee7ysAXwWl86qyqgw6KAYq4VieZ4MvUBUoWOqzeu8/gZqr1Ndiv76 pJbv3umR9hfcV6waecWXxSSaLFGQhME8felqzP7xg5eMeiwadJ5Sl29acgxNZAZs+kz1 F8HQ== X-Forwarded-Encrypted: i=1; AJvYcCXFBDp68TPiXijfTbNVdGlLuqL2FXvioZ2JpC+kw67Q0aV4amhml7NsEB1d7f4990LZmT55pwwtBffICGc=@vger.kernel.org X-Gm-Message-State: AOJu0YwZy1ZqYYATBsPUyNN5ZpMiAIDkxnOP/4ZfiyncreOlOtXG+lPs ol04uALRFqzflz3qvzEEgQn1mNxZWsPAYcA3FOpxEmqxSxSiJCmpEhEf1DoJ3HNTDKFPxnj+px3 NlCPkSP4iwdsEGGl1KS1YV9DA3nbKuVtNwRI+kRL9T55P86mWV5gEdhqw+oyVf5svcfg= X-Gm-Gg: ATEYQzz2b13asR7+jSyn8yW83dB6rQ6TV341fPUDOQQvTnzRqKrhEkRXRTeraQ5hGpi aWy3DZF8zGVyAiV1esiPTTdgJXmgeIdtLvcMb6ofdaw/NFQcLU4bMkPpz3wYeLYhkK1Z/adTDen sVdgYS9j/e4wEtslNXUoMtMNQV1M26o+SRcKJISJBjsORwi/TnkOrF3H/OuBvkn6MCNh/MVuUqi 3bcCH8thpuzY84FNBe+M9fq0AC+fc7x9k5asDYbuc4XmUDTVOUtNT7TexkTAsUOzUODtCU1R9Zw bH/4tWKZDVrmBQJu+xvPjPJExqaoP0lNvO0REZiQETZCzNxdU2HEjS41CRwX3VQZ//TxJ7RXegf RAmQfbPosx23wv0odLglMKx53Z6bXr/80JT7alPV12sFOxjw= X-Received: by 2002:a17:90b:2686:b0:35b:9ab6:1d4e with SMTP id 98e67ed59e1d1-35b9ab61f12mr7133818a91.28.1773739291189; Tue, 17 Mar 2026 02:21:31 -0700 (PDT) X-Received: by 2002:a17:90b:2686:b0:35b:9ab6:1d4e with SMTP id 98e67ed59e1d1-35b9ab61f12mr7133804a91.28.1773739290700; Tue, 17 Mar 2026 02:21:30 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.21.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:21:30 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:41 +0530 Subject: [PATCH v3 02/12] dt-bindings: crypto: qcom,ice: Require power-domain and iface clk Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-2-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=2093; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=mn3vp2GeE4VYgG9OnPMhnQiQ0TVYi4qOkzgc8W0I0jE=; b=FeE5ZqbJvz3uxUXrsgHJcJZp18l0b/x5yjyqCFcT50hfVZuKnCshbOihBpNkExh/YoQMBrYlb WsBpyvY38HFB2x/gWsnl9E7ibcAUtsg4kS8iWnU40UnzmBtdboUYaMt X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfXwq1dBWVNsLDP 93Y5wWFmkdAsYH58y3CZKS4q1KOC+EtspINU7myz0dGySV3LmP201xQjUHDlMd4lIUED6vVH3Ff NxlWLLG3sw/qk0x22zrsbkxba9BvpzDZaOJ1siw58lnjxsUBztJBEVUgKloZp4jXw0d2DGFQO0a EIlzgZDMgW5M3ARJGkQ0SL+ZaI7nPzVQ9U04dC6lVQukiCrjCvQffLn419/v8KFXnqU1cHPCMnA DQs6SnpvZgO9YoF4eXFUNCc3j11Z9K9v5zrMGpqyrKSfkPCI95tjB8W/mMabw/XwpIpDDCtQWf2 FeAuoLtq+/Ge/zQoxV3tmqUOSXMTolT+DccOkbLWLhKWr4fRCzfBPAutCpTbVnj61r3142BY3H6 AyBibFp+EV5Ae/d0aRhQCdJh41h+Ipktu4HqibHYkHnk/7vi0LE62P+egE+qDo4mzkl/xfLXOsL 5s/X0PcwxCNQb+eiycw== X-Authority-Analysis: v=2.4 cv=D7pK6/Rj c=1 sm=1 tr=0 ts=69b91d1b cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=_NrYQG9o62cfQ7DVPTwA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: oii4fFuzVP-yeojyGqK-RmevjdZ5Z9wf X-Proofpoint-GUID: oii4fFuzVP-yeojyGqK-RmevjdZ5Z9wf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Update the DT bindings for inline-crypto engine to require the power-domain and iface clock for Eliza and Milos. If the 'clk_ignore_unused' flag is not passed on the kernel command line, the unused 'iface' clock could be disabled by the kernel before ICE can probe. This leads to unclocked ICE hardware register accces being observed during ICE driver probe. On the other hand, If the 'pd_ignore_unused' flag is not passed on the kernel command line, the unused UFS_PHY_GDSC power domain could be disabled by the kernel before ICE probes. This results in a 'stuck' clock issue being observed when ICE attempts to enable the 'core' clock. Therefore, both the 'iface' clock and the UFS_PHY_GDSC power domain are mandatory resources for ICE which must be specified in the device tree node. Fixes: 618195a7ac3df ("dt-bindings: crypto: qcom,inline-crypto-engine: Docu= ment the Eliza ICE") Fixes: 85faec1e85555 ("dt-bindings: crypto: qcom,inline-crypto-engine: docu= ment the Milos ICE") Signed-off-by: Harshal Dev --- .../bindings/crypto/qcom,inline-crypto-engine.yaml | 19 +++++++++++++++= ++++ 1 file changed, 19 insertions(+) diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-en= gine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-eng= ine.yaml index 99c541e7fa8c..ccb6b8dd8e11 100644 --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.ya= ml @@ -54,6 +54,25 @@ required: =20 additionalProperties: false =20 +allOf: + - if: + properties: + compatible: + contains: + enum: + - qcom,eliza-inline-crypto-engine + - qcom,milos-inline-crypto-engine + + then: + required: + - power-domains + - clock-names + properties: + clocks: + minItems: 2 + clock-names: + minItems: 2 + examples: - | #include --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 206D63033E7 for ; Tue, 17 Mar 2026 09:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739302; cv=none; b=I7W1xYmGQrAXp8kSMSmfyllA40Dr0tz5EMsq/1b5NAiuoujxsMdZb3ADPqNOFSoLWLKpFnCTkhCkqGA1mbuWizstB1BbaSCk1Y3AzM72dkTdl7uY36fAVtx+YKlYnVihvQrBQcJMx5nHeE/XxcMFVZr6fJ6pwJG7Ka7ElFcYrKw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739302; c=relaxed/simple; bh=h4RpmgObOzRNkVSgccxhU+fMFg+bHom6DsbHl34Ky1E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EdVc4gaItHKHA9Slcyy6wDisCSx7rNYEPyr3ZcCVgg+BwQRCsnkealPTzuVvbRJdfE5RFwXStH1euo97BW0I/6nLFrJkuMutbiPC735gldr3W2mCyRnMwXfNBTL9hLQdKAgl1PssoMZY0LuGWxZTMJYQUbStr9LorjEIT9GPTOo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WCpp14aP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QkHXRT8p; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WCpp14aP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QkHXRT8p" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H5E6qj1428842 for ; Tue, 17 Mar 2026 09:21:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fOrKK9iw7hnO0EM5jUF4TlMhkVqT4sv/sqyiQLLaVeA=; b=WCpp14aPex3IvYtw aYSI/WlBmex7QIORRUHQsERmLspX2uDSDaS/7ylOK/uWXw0ftl24cR91z01HKXq3 AXorl/TNgTV9dwVEAGsa/qaWAFPokX8BCIe38ImgwMNsU3qqWbBAsYGSXcXFkEfb 9+EwpDNOiovjXraHXCCaClSJDKJsfF5q/4ehBgfg4+JZBHuLHGnYkZN5dFkHT++3 AnCkNVlCgEVmReOCvsQw1chDQeN2wKZIa4WlHHoZfYJW6oBgy+7MUmXj2Zglu/LP ySqe8gpQ8LckZOHPuuOt34qCZAtgFZwh+N83ZqBlpJkM7Lcup72prl/DZnjxXOTX QJkcew== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxh99c45e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:21:40 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35a0998a441so34992281a91.2 for ; Tue, 17 Mar 2026 02:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739300; x=1774344100; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fOrKK9iw7hnO0EM5jUF4TlMhkVqT4sv/sqyiQLLaVeA=; b=QkHXRT8p22nAJ0HleiZlcYBa9pPqVAXc/VXVgDLjSeCcfa1pOT+IEYx3q3qzOuTwnF BYW9loaLvcdkcYYBMPYHTdRlxFH+bVnUQdtPt/bucs8YjEd2l+OI7+gD0oklUNw6XEsa sPKgkPfdFglpMgfhkFDKlnsqke31AHSnqjawKrBoxn7QMD/IJWb1AiuThUOntXQyf7Wu wAObeC8ddPHTBYfjP4bS5NKKR9AJAitzw8Jbpt/WR4wKLtskdpftVIzzXEghxlqOLxDo dbUMmBG94x3k9JL4jSX326GlopyUy9qXA3OdQwOpCzZ/KChvHmBu647Y0dnzV9E68sna Dg0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739300; x=1774344100; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=fOrKK9iw7hnO0EM5jUF4TlMhkVqT4sv/sqyiQLLaVeA=; b=NMubShIgU1CRsyFGd16HCY1NAb6sGbDSEbdVp+45DzHtGJYKkC1nZAucyy1SKI/KG4 brW4qa0VqOhlJHRqFrj5pWEktWjOUCa7V/q++vgNSP26p3nfv/w962gWtfuFTyMGmuJb tmzwYTdHSFVUHaKzcjdYs/Lk+BJvafjwEvrj9sysyUFx83SBaOVMqS43rSIorFcrwD0S wScrHdjGnhhh7Yv5KlWP6mJYQAVL0wBA326wa4QOKH47I21WwsoyGm1VHLw4DvFnEzIB XOCWtV0Hcevhd7ygb3Z9ftwiI5HyqGJHCFA1n+lEnsoVOCF6BKY11awcOxwQPBSaz+fe Yfpw== X-Forwarded-Encrypted: i=1; AJvYcCW7eFsPyp0/OfIp74OrOVly3w0g9UAg1EBpDYtm+nPGxZJ9ayT4YGm6d8r6Icya/EA/plvzBNUm9DHpu+E=@vger.kernel.org X-Gm-Message-State: AOJu0YxGJNFS+iVgqyU+qUrCHiTGCwAvUiTzeVG689/OG7UG38/pTRNS xwC3VkgzxR9SLgsGcgnJlMoHYjxi+X+0DbeGCYhqwxDZjUo1hWDG3vzCRMGVonrhN+8Wp488mcN 8axwyK8wnDBXf7PFwwxfQZQ2yKqNrvmyYoDGk9kDCaxJwE8ZQeWgT9bWF/rQDYb44g8Y= X-Gm-Gg: ATEYQzzuSFpcGqlq1SIaBjux7HmH7n22r3cv51Pazoglqx3Zd+h085t+pLRqM4rrfgH u3SszTYTrgPbacceYqXTtAus9VZ018ntMT76VoKJrlYN2EVKFsjGv6v28p696TgUgkaXqmG9P0a EdxwtcqIoffRKmAuaRvTRKs3y6/iz/pVEjJlCenCas81M4t4o8Iz/QyTdsyzX2RSYJh70AP75mO 0bUYEJJhiLgz0q3JeYoHBu5KXj6lOfngCjam4f51rW2L6tpA0NeD1D5j0W//FayMTVLEVZPS7ZX 9GpoCiShx2zVtzJDK4pGMvocLajUPI0UyFX6r6m4DH0e62HhUirUPMNO8/IXFA/7oYqnTGtlHNM 04+lrfJaa4TOk5R6PuwhovHE0kAtO4ltd6Kp52hMQ5ESu3BY= X-Received: by 2002:a17:90a:d883:b0:356:1db4:8fe5 with SMTP id 98e67ed59e1d1-35a22081da2mr14820471a91.29.1773739299814; Tue, 17 Mar 2026 02:21:39 -0700 (PDT) X-Received: by 2002:a17:90a:d883:b0:356:1db4:8fe5 with SMTP id 98e67ed59e1d1-35a22081da2mr14820446a91.29.1773739299228; Tue, 17 Mar 2026 02:21:39 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.21.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:21:38 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:42 +0530 Subject: [PATCH v3 03/12] arm64: dts: qcom: kaanapali: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-3-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=1406; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=h4RpmgObOzRNkVSgccxhU+fMFg+bHom6DsbHl34Ky1E=; b=dtCs/OirE2kPvaV+8TmLiJczC0sVB5u789ja7Dp9pUVBiJTkcFAv3iUdaSbJCWBPdm2ielOlH Zp4PTiH6XPVBdftzBOPsDRT9uUnR7uRqfxlmNehVMJ8RPncljf2uf0Z X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=RJ++3oi+ c=1 sm=1 tr=0 ts=69b91d24 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX22NEm9ggLghQ KAx+GNsg4Un3/uoOaYnlabqkIoaf6EnymL8c69uhgOfDQXGQMsZyvdY9mrmVFTtNEAZXmOOtTlP gkQkb0kZJ09A0B5fYVrfskw56pOkmjiCTxbXMfrBEk0sQf+SMWC/sLNKjEY5O2wDNJXnr7bNoMb nE7/h6NY8JmPYNXseE87LkRA0lJvPmD81LC9qUJJ7GGRXVLq0wklkI179GezJ2lhTv+t/XOalXU q30ynm2HPrpHdFmcRS+MkhcvGccok2P8a/ckaxnlx//Ft80L6vloyEL4FYOwYBHgrNs+jr4SnJ+ DNZ8cHL03e6566d3NrTCv4rAK+Cl4CUTaiWRVBrRNn27xn8EfMDuzc/OTX/YTSWR3D1eC+keyFa Nm6JAN9Y5oDbhLxRPiwodHfMl2JbSJMh2n4Fgmu0/s+ts7zFvP8OwPoUu+qJTbmtgf27KDFYjOu ntAw5Mvzp0wjtdYse9A== X-Proofpoint-ORIG-GUID: cn5Apob6Vtrb8dNp9Z0hAJXtvdZX7iIG X-Proofpoint-GUID: cn5Apob6Vtrb8dNp9Z0hAJXtvdZX7iIG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 clxscore=1015 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 suspectscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for kaanapali. Fixes: 2eeb5767d53f4 ("arm64: dts: qcom: Introduce Kaanapali SoC") Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/kaanapali.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kaanapali.dtsi b/arch/arm64/boot/dts/= qcom/kaanapali.dtsi index 9ef57ad0ca71..52af56e09168 100644 --- a/arch/arm64/boot/dts/qcom/kaanapali.dtsi +++ b/arch/arm64/boot/dts/qcom/kaanapali.dtsi @@ -868,7 +868,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A21C7355026 for ; Tue, 17 Mar 2026 09:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739310; cv=none; b=Wikp7VpqiceATo9W5zlcvG/7rrL+dDa9HjRqwyyBAe+mSyVyRS2iupfB64j/TyjxZecHSFc9mCuY7uA3Q89ro8OQPD0vmzWtOYYGYMXc5gHtnOuDwO7rCfS1RkZFq0JxA02DwfYClkbl6qo8E0NItnWZpVPwzUWMenPWjWXkvPk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739310; c=relaxed/simple; bh=W0ePF7DSyLM6ErnudVAGXiEpWPL8oXrFoEf3HGluwoQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ggzw9r1DU3kBj0NNOyyMSitWQ464di11WmgZ4NO7pWwwz9ZvcnYheI1Q/vMkSjV7dFEAgLRfMcXcDxhRNJCJsL/Gk2V7F9vMC59ehEsATVJ0xPzsxx+73KhfVEDKMU/774g4k+Ri0kZEo9pZXmBCflEqbff7h4AsulmJHsWs91s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pPgtEMjV; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EULmuLAy; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pPgtEMjV"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EULmuLAy" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H7CAj21639186 for ; Tue, 17 Mar 2026 09:21:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iPmd0rGBaUjGHe4gcz3hRnnXTBejiTovEjj6NmcJC8o=; b=pPgtEMjV96R2QJF+ Mp2JnoKy3zbxErqIsGV1hlz/ZbZpQ/leKgeab/i+pQXoK0u2a7rTfV5d+24R7Qb+ menIRNxLyiJvRllHbcQbPLfitUi/QbhUePoHqgRXtypHu2RtOh05FbPNCjYXuQMY gPD1FPfERvXYWW/tV7vLLPGMAK6T9O8KMReQ9z/vXmqJWUVbLk8nwgMoK7RIN2t5 z6UvaJrXseWsUUL55LHiM1uGls29mu4fdi0ToX4DRAiapPeTJ/QElhYA+Pnxp3bK s+FPr1jr5R9kfVmOTWZ3U3KHlST2vILlVJM9R6Rat9PA0RKlK4bO9K6BuNGg/Knl JQUTkw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxke0bjx5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:21:49 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35a1e725a8fso30875346a91.3 for ; Tue, 17 Mar 2026 02:21:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739308; x=1774344108; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iPmd0rGBaUjGHe4gcz3hRnnXTBejiTovEjj6NmcJC8o=; b=EULmuLAyIfwptrNqPJ4fctLl0pzV386Gg+kW9Jl+fvpcZvJpmqD4+i2HX87fUx+vxS kKGnJlW/WaPyizDA6WI7ddA3QxjwXd0RK8WffsZkSXrzI2ZGA7NTP0s0WGlQxjFD2oDm d4vYPkGqKcrxi8plQvui5oIzELSpY5pkXNuSNsJQP1TCSRiMbqAUkkZbwbzJLBN8sLhR 4TTrIfY0taw/kbOdxmQ5CdiHcJT6XWyH7LziTOPPN22MFxxnVIuFm+TbAaU+zLSsG1bX uUgrlllEZD9Bzr2RvXCkFKUffvfL/r71a232CxodzvG8hulF1TsfiFvkVJ/B85B5cRZT KdQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739308; x=1774344108; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iPmd0rGBaUjGHe4gcz3hRnnXTBejiTovEjj6NmcJC8o=; b=QWe2BPnV1KC4tvIRwHMCoipC1ClMXUBLmHSyEK95q9xlc1jm0NDEHELu2xDfLM4kku PavDSzfiUVymlRW6sRfh/UHa6jr7MYQxQWbSNKXkBH5yyYRhho5MFxx9SNzg9XvySITE OUm+nnFHY0YEk7i+8VhW9gficbe/CebdIVpDvJnQfJW7MhWU+pYwwruyi47lZDGHlZiI VE5++npb9O4Na30Z5Y7SjjUnEKVegDlmllVpPmu3flaT+1J4bjC+2Q5u5mFbjQoPkGce 4AYUUNyKgukdIxPnCm53R4M3fMaJg4zAdsAONaZasOEO7l4J0k2ATOYiOWV1oJQwAJEM YEcQ== X-Forwarded-Encrypted: i=1; AJvYcCXCc6D3C3yutQyUPfMG8s/LUbk8WRjVtpO8cDAUTb+iUj4fzZ7k8unMmyCTXgT7jyfLh9L/nzR+PBVhRPs=@vger.kernel.org X-Gm-Message-State: AOJu0Yxtq6xOOF4Xsq33iW5gXLrF4zYkjyqZf+aOU0JY3/pGPeanbZV+ XwOwcWt5+6POcVTJnrmjvlj4VAuSC3uHDnbGkvDafFQdnweiRdoyIj5JHDL4NFTIItFHJU7I14+ lGNVzlyRYSLxBt1vClUJ6Sp+wTu9GQW/b0LZwG+lt1QpQu+50wJohKQWj6BRNr2nJ3uw= X-Gm-Gg: ATEYQzwPnDiwcwFK/R7lCgKEs4tSkZXCRGSdySibjNbkKcwQ1OWwxn1xM5pFgAa8Wdy 6meR8Ld72djkMQul1y7wlQjkyxhrGNW6r1rfSzMGd+LzQ7sfHPeFDr2v0SguCkwOmoGmg7u/1Cu JSYeRKyM9YjxqCShgCiU1refuxesSc6FFmWQUcHKt+pZTOhnfzJFBsr1+dKEr26xdlnVYzrgOTR I0sGJQXp5SHqdDpexn/FIULO4FwcRvHbF0++xrTLpcNdVgqeM2tNgh5KzQ85cwfauwkRWJmUN4M OWUjVcqb/saxwBt+Nv78Rp3IRO5JHsCzoqlq1dueivptTnyM8Rxb4c6yQWh2qikthXbiQw4SY0X cGxhr1SnPnsqpmufvaWaQDc9023QaB2pUpSDLe/PO9SZLblg= X-Received: by 2002:a17:90b:384f:b0:35b:a44f:b82 with SMTP id 98e67ed59e1d1-35ba44f0e61mr5134689a91.11.1773739308350; Tue, 17 Mar 2026 02:21:48 -0700 (PDT) X-Received: by 2002:a17:90b:384f:b0:35b:a44f:b82 with SMTP id 98e67ed59e1d1-35ba44f0e61mr5134632a91.11.1773739307784; Tue, 17 Mar 2026 02:21:47 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.21.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:21:47 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:43 +0530 Subject: [PATCH v3 04/12] arm64: dts: qcom: lemans: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-4-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=1453; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=W0ePF7DSyLM6ErnudVAGXiEpWPL8oXrFoEf3HGluwoQ=; b=Ke72qXA5huMugw/wMSL3AKWhmc0biYEYdBMY3hvTw6Ds863BWT1nbEIa5Pr2+oc132VZ7/FmF J4BBE7XQ23VB15DpKfAziVH/e0fJs5XRPXdKraQet59QxS0JRKMFy+G X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-ORIG-GUID: 1m4MgzHg157-sYJPyYRA1zd2QGcIsYgm X-Authority-Analysis: v=2.4 cv=aue/yCZV c=1 sm=1 tr=0 ts=69b91d2d cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX7AyU6gP+Cdim paA03z2OlK77hudzASKz+qhqsudeL7WWsctRx4rzl/MKc2gYPWdWv5kE9qeuUUF8H7vEzAmSemf LpGbXjyCANrdYEva9rqHc5V8m82luAyIJieGqEjz3wZrqgqs4oeraJqqRbsmT84IZRHw4pM8GXD 83tgU/F71uvDvS+wY0+iegpZhdDr+g4kuMNV4wuTuh25EU6YTWVZTjfhEFyz5xyd1KS1NI0/oaa nNPpEk2gE2kHPj5ZZ2BbuUpy/45TqMjIcR8jE8Sq74vicrsEhSMKyYJjeETIQvxdLxudi+3IvWa 9swJ/pdCUW6SR6JH6s39X/X/qr3mEw546TrVIKxWvD2fb9UKOTen0OQicVPcJWjFEI1ioVzDJAh KvZqgNH6SqMYc+rO0c3j+poImGW3JSXFU8GNtwE7FH8q+A59EBAljbiICVw2mHe/iWQckYkNNgi I+h+wn6oQJcd6gIrYVg== X-Proofpoint-GUID: 1m4MgzHg157-sYJPyYRA1zd2QGcIsYgm X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for lemans. Fixes: 96272ba7103d4 ("arm64: dts: qcom: sa8775p: enable the inline crypto = engine") Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/lemans.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/lemans.dtsi b/arch/arm64/boot/dts/qco= m/lemans.dtsi index 67b2c7e819ad..cdfa42293022 100644 --- a/arch/arm64/boot/dts/qcom/lemans.dtsi +++ b/arch/arm64/boot/dts/qcom/lemans.dtsi @@ -2758,7 +2758,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sa8775p-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5397D374183 for ; Tue, 17 Mar 2026 09:21:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739319; cv=none; b=TpsQuew4qwg8HQT4UdX6dPLNAr4UD4mkN6BUEWwV33B4wg2/8WdDejVWHC6LaWN29I6yABvkWPVdfIlmbNJgspqVYWLEunZKcCYcMXZVnfV3ceojtJ+vv+HpjcNbw9UBFcBeeO+eCF0HQ+y43YaY5jRIatr62uldEvyGQZxmgwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739319; c=relaxed/simple; bh=8uK0totW+fO1QJ0dJXJXu3+dAqyfgP6uqq9AtSWKjgs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=p3sZze35Ey3I0HpOGaSNncoSbBiU/Img1wGhhML0GptzRrDrsTppDYfqzj+Aljg6aLaFHhURb6k3fB0URxm6g6iNcuBS/9c68RakoU8peXUMvRblkPuZZlDX4ELwelmdxrEF38lYUAKolM63Fr0hKdS6+Vo8LvSbq8xf9FwJDj0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TwuGoUqG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Lc1tyqWt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TwuGoUqG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Lc1tyqWt" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H90BKf3125150 for ; Tue, 17 Mar 2026 09:21:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HKkeB02/3Y+p8cra5GYHxicECKL4T4itHN6GbMdtRQ4=; b=TwuGoUqGQjR0qjhw FJ1CcFKaLKP2rAoe5JYhwdvs6xFT5LYKcBzx+fslhxkTn0Il4cOF6z4ToBiQiC6U 2MeScNE+t7Z+7K2MTmwQdZhkKlhUCgwd8qGjHvWLy9+ss5Pe2IeCdIjwvp749h88 xIdY4eg7MXNaaT7TGVFvFQt9p0FVeBv9n56sa95Qvr7RmLhUXFnUKKQifFBpkq4q YeKcTHN12d56l/zbZR+6UBV8X4c26H5xHV+YJoBj3WlQRAmGFou0MlCouIfs8DkI fAlkQ+cxUZvlFR3WSbE7aF/eRUrMuGofEoE+2tM235oTS9lSPb/12qZzpH9wi2Qu Wx6ZaA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxfsmmfbp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:21:57 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35a0337930eso4514799a91.3 for ; Tue, 17 Mar 2026 02:21:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739317; x=1774344117; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HKkeB02/3Y+p8cra5GYHxicECKL4T4itHN6GbMdtRQ4=; b=Lc1tyqWt91QIbAOlS79TtXEHtsgHMhlT/Af1SOROIV9r1ehn1Pom+Rzi+4ls9okBk6 e34+TNZpB2bWVAXKsml2w5U3ptZs3i7y2EJgJjiBKQxlA5PvLdNZeDMQR5ZeX9uT6InK h0WpMYgrI1ClNVPfd+sOEgEdQfozRBYfIPFMWZGVlKeq0YAWneocIPXbnz+pJYWQSUhK ovXV5X0IgpihAVIxsVubJptJ17PNTHTNzCkKTXKWdQEyr250ZwVOp7+t8rPEOpOV2Ekf dmXdFms0YDjDmLQb4XKwjHMYI27jczH6VsJ16n5CORDHHxqZLZdZDEL1ekFUO0ifJ1P3 KoXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739317; x=1774344117; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HKkeB02/3Y+p8cra5GYHxicECKL4T4itHN6GbMdtRQ4=; b=cQqeYqXa6hz1Jl4VQvXffjEMX9+uXGBhzQjJ3HkCtDVRyxEv8wF6zbvj/vqZpTswKr jrncJDX/gzmPJIvXI4lAaU0r8LDyjFmzpc1enR9c3/T18z0Lz1HGWE29U/ZgcSZcr6Hd 9wsbBl11biHUd6TX4erRdRLaRHgRCmGsqpkkhMCfnYJSfqapZ/mmtPPyozizQRkOU9+l GiFjruCDbpFaME+DzEkLEARWBvPSt3Tda5BTiz3v+MxgICBMQb58sE2Zbjp6KmxhNRBq /CYZHUn2Dxbh0SWZrWKQLbygFxvdfgk2pLJ6Mq4WakJkgAR3EJAh/5MpVRfCc6puJZn+ MW6g== X-Forwarded-Encrypted: i=1; AJvYcCVl7H9Gk9PbfeIdXXr3oKOTuCDdMNkFwsvOvd6OVR7CJKvq61sRlgGj6my+ghBHRW4JmYW8/KnbuEkVilg=@vger.kernel.org X-Gm-Message-State: AOJu0YyIKybk7uS/IVKDq0GAXTAlGqj0Mk1HDwmZvwC35mWmbyx82rAU HhRtRHwfeTTaUiqgyawQimRh+XzlwfoJWZ8e8EK7Yv6tesCsPCljdJmSf5kgEBD+ujHw8sgE3oh zXWUBIiNG4OXHrp4UAikU5cBZtMXGXVBa58KtuJNs50ipasgVS5rqKN/2y2hYEcOVY70= X-Gm-Gg: ATEYQzyXjm3HHytRfM4wkvuz9D0+hmkBoffzfFRu+Egjid6IJ2QfhiXfPZrbLqIb4tU jVhIplDh28Mw10gr4//9Ie9Zwh2AQcDFxFVj36XrNql5S15/T+IbbKGIBqxWQa7a+L+YATRYe92 dXU4CSsJVEvwx7Sy4SLKpdSf5gwxbFBsFWuU2lwTM0ZmuJtRMPURPeiNmhRFPNqjscFjgkQVab3 y5WSPlGeLGq/xQs5cDUksXPxhiU+JT5Z+s/a4iwBnsZbhOoR48tnB3fnaPa8JLomEgp168qL4+Y lhmYElrF1vfZW/7orU0kSRkRdUjAki8J7Yh0C8VgFSiFBKe/jHWtahxfJf4FWOB81lYctq38QR1 ENQpHhleBqNPPRuzsWgeyZG98+QvfnNojv9fxiO38nKMYoko= X-Received: by 2002:a17:90b:3fcb:b0:35b:982a:28d9 with SMTP id 98e67ed59e1d1-35b982a2addmr7808765a91.4.1773739316901; Tue, 17 Mar 2026 02:21:56 -0700 (PDT) X-Received: by 2002:a17:90b:3fcb:b0:35b:982a:28d9 with SMTP id 98e67ed59e1d1-35b982a2addmr7808720a91.4.1773739316397; Tue, 17 Mar 2026 02:21:56 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:21:55 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:44 +0530 Subject: [PATCH v3 05/12] arm64: dts: qcom: monaco: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-5-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=1455; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=8uK0totW+fO1QJ0dJXJXu3+dAqyfgP6uqq9AtSWKjgs=; b=ZaRitGJW72HEgnAkut96vqOlwGqBggoYgPpFP6b9sVn60d+sYtiUj5qMS6kNCdSVyFO4WNn5A dFs5Fk4bpbSAE0+mM46TLdTK0YP+QwAbz2oIhXPLgJnnpnxXZbKS7H2 X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX8X7kHXR7b7Ve ASjC8BpxJJbBa+DPmb3AeF9jRHYuz2bi5fbgoJrHdGm1yHkb+pMawHbmhPmWCYkI9sH6WIjMIYA 6I15Ve+kikGT+ZlDYWcb8PiaZ7skdXu0Wg6ZAdLRKXdt3qPZ2/hldnxEPn4OUtz8e/fBvcjIUsB OLD1X2Qlz/5FdJ+IBiyAbp5KxcCYEqMTKQH3k7SH6KaKio9LnS3FywSdxkIGh9GbFGkIf5QFYgK yhBivo11lXmLB04lORN5VZL4DFK+rKiQqhh6E0B/Q50LkxDh+dTUlNKpqndBmSn6Fx1SPLtd1bb 3Yp7F4MDrxlxtas+u7Fu1szZk1l4HVE2v8w8uD5LLe+wuR9rpYV0S69JleCkgPSKyd3RqpgCzIG FIgMqXEtEzGj3iLaJkdf0RirlvkmDOwJBANZLJDryunQTBK3YTgRdK9r3xONzFdxgrBul6pHL0k Vlgvr7QUqIw3SdngfZw== X-Proofpoint-GUID: mshb4o8cB6iFPipGahSKVZTydc2ZFxzR X-Authority-Analysis: v=2.4 cv=V/hwEOni c=1 sm=1 tr=0 ts=69b91d35 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: mshb4o8cB6iFPipGahSKVZTydc2ZFxzR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for monaco. Fixes: cc9d29aad876d ("arm64: dts: qcom: qcs8300: enable the inline crypto = engine") Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/monaco.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qco= m/monaco.dtsi index f92fdb1cefa0..e408f102a8b3 100644 --- a/arch/arm64/boot/dts/qcom/monaco.dtsi +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi @@ -2725,7 +2725,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,qcs8300-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 crypto: crypto@1dfa000 { --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBBAB35F181 for ; Tue, 17 Mar 2026 09:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739327; cv=none; b=lzgv7N7LZyWrpNSVDsJ9TKv6Mt26LmnQBaKDhc/FuqcSuUqsg4EfqmYsaDNh620L6VhqgHSV1GbKjFYAnq1+1n7x4jId9+fRAttCJUBPpkZ+o//S8d/ouaJUITQcaRLp2wr9K9rCAdbid8Xa+w+eHThDlrVtwXKTT0O1jQvo0FI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739327; c=relaxed/simple; bh=gNKhNyU8Oyr/Xdzey4+OBtMdjcQJNeOG7d2xyewrd14=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=thPRVbCEjZfBqlH8C9xybZTuoNEVF2zqyIiFClXTVin2U3Aly3A+BEHyMC408YnIJUxufTzJIqE5iK1XcZ66WBAl7woDztPm/HH4niOXmdJsEfqbe27rSOooZiHvO7WjIa6vBzrjyMiqRriyVcYE7V/klRncn1vEqAbyeAzlPNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fgXSH+vy; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=K5dw+4uL; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fgXSH+vy"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="K5dw+4uL" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H8iai93124528 for ; Tue, 17 Mar 2026 09:22:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= arFztdI06DpQzbYjhOlyWZCRNNwQAGFQwZvfaHEejqM=; b=fgXSH+vyiLZ7lxbr avUOoTh4zVC+6whj3zVISxIIQ61H8ZxrP/0CU6pmelZwgIycMNwhhneqNbulVPCY 3I6uZ9VtDP4Lxja7Zd73gzLZl+KYhWJk4R8qxdd9HgNtHWGRXP6GgpqzE3RFNYFJ Z5Dmm1NmvdR/KQE0j/JddrN+dFy1xJwMWfC10DiHe8mIku4VohikFUCCraEhiUwg sh5vmbmkI+T6Bv6ct179N19gOLdRZoTCQwjemUNWY3O07ayJw3wGNKEwwiL3TzbJ fXNbhoJ28Wjn9oeZkTCpXupCZ8+tYxDKJBhNclTy4YtWJs7YnBm6JLW1zN9DAPKG 3TS3Vw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxfsmmfcf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:22:06 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35b93be1227so2693312a91.0 for ; Tue, 17 Mar 2026 02:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739325; x=1774344125; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=arFztdI06DpQzbYjhOlyWZCRNNwQAGFQwZvfaHEejqM=; b=K5dw+4uL9n+36xZJeR0FIbi28ERBJVcic/0ddCTJ1mptfbNFV0FmDwdl/MIx3I+afI y/P+471bME9CN0KkDj2gdRuGNzKMC8wmYHLj/kx57QOqn+4YdrtgBXn85p2hmivjerT/ GCQFVDwMsWlSR4u1rQfSAeGGabStYyt56kMfYWdvGcJ1T5qrKLTVA7O1ynpHtcXLlc47 ZUmvT6T7WMIJ1R6B55kHQqSN8v3rRgmGolcUx8CTm8/nc4QVZ1GykC8VQdF3mH4Nv/i+ 1/ZGvt2dTKmu1ORGyFys1VDGKoD9jN8wAXvZgN6tMTsowNzVVTPYnrBCieyh6dizHTwu JRfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739325; x=1774344125; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=arFztdI06DpQzbYjhOlyWZCRNNwQAGFQwZvfaHEejqM=; b=APwjhGvsylKC0UlTZDhMRfvqOiuj1o7M0tG9ZizuTfT8MCPVtLSavTnxeVZO0FIsdn Nyew69yChK3xrqv5eORzx+1EjRLmIdOj3A24+9nCMOxluSDk3W9iqIFqofkFc+x9eGhE TXdClcVC6ipf/5hU02o7Z0ZXFKMNtkfu8eANtJAgmpKUqxV8VWJWPEEQ8nQ6+nc16PAE PhUc9+Wo0IpPEPlhwNgxrOm2yUNvS35E3/JcLz54LgzJRcgz+YP9tNCpDjVspAue6D9N mSHgwqegadIQYLHtyXt+iqXvQLzSjfhO09Ya9au3nHV6r0vhC+69uWMQqF/nAM6AaFH0 o4PA== X-Forwarded-Encrypted: i=1; AJvYcCXviZFSPHJSir53Fq1pMHuXCuHTBL4+sdN00JEDWBt1WhPjc3PmJ3qvgk2FleNA5iLOeoIre+4djldWGbU=@vger.kernel.org X-Gm-Message-State: AOJu0YzH7lkAwbXSIOONO1L0NdeYRwtnlG+YLHi3RSdKSfAssb9wAALe Op0REMFO+tCAQeuRRTyg4GNSCOlLgc56Tz/glXAqXtv3QwbStD+YJTr21LGfbtIvA5l6UHpuppD 4evvGc46WKNfk9ct8d2+wkhu5cJDgtkgn1a6c8Bl3sCgMujcVMgC/pdhsnX6mjReWEXI= X-Gm-Gg: ATEYQzxUPcDIAq5VqlmEvvc5zo8Rnp7XKPdEPTKTFkSUsUsTaD2iXvq5xXddiP1nbne CHu37oOeXwNlhFkUhelj0Div8StPjWY1HMbr3yxlnCmGzSwx38w7lXZsgGTLDJA2goseS4c3Icj 9/t9JWQI5hMx1ZAybr4DRqD5lAn7QZkQAT9DDvXG7DZvYVup3HPRq47u6FmW6qnNOBER8OydG4T IgKmRZn0291sf+rINnYPHoaouFgPxI3/aGMF41mXkebQiVAaHmuG0xNbtdR9sE8MYOqpQ/3zVBB 3fBT7N/8d/X1rPywbOy+686YvVgBrRCyk8Qr9Hop0sT2LmKorztbBObQ5eLvzd4fBJlP2Lou41b 4N5gCZYlHHlYg9ecJXmaSKZN8t2NI/JKgkUZLYQeRm57SsGI= X-Received: by 2002:a17:90b:388c:b0:35b:96bb:47b9 with SMTP id 98e67ed59e1d1-35b96bb49c1mr6229861a91.19.1773739325312; Tue, 17 Mar 2026 02:22:05 -0700 (PDT) X-Received: by 2002:a17:90b:388c:b0:35b:96bb:47b9 with SMTP id 98e67ed59e1d1-35b96bb49c1mr6229815a91.19.1773739324787; Tue, 17 Mar 2026 02:22:04 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.21.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:22:04 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:45 +0530 Subject: [PATCH v3 06/12] arm64: dts: qcom: sc7180: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-6-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=1411; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=gNKhNyU8Oyr/Xdzey4+OBtMdjcQJNeOG7d2xyewrd14=; b=9pKIgvcm//lW2L9A12Tw6qrcqejMTVkaU8/oO5Vfj+itPFa/MdFnXkxkFwzMU1HNV6GK2hYRw O29OtC/iUwPBCBQV44esx8o60bTwk9BGdGNxCPN2gIakMx4AboMBR4d X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfXymla/QXjbxM5 T3gEfEKk9XrhW1OuLoTFXsCxGIHYfqelazzz8i3VLSy4JOG1uImKwVccZorvRxyJArv1tsHrIF1 FGBQ3UQ1eDIP7EA3iRL7NYkjFF7nxSLwJxUIkQ/Thd1l85pDsefkXmr8wnS+I8JCr7w5lHAJr4j n3DhNcFEmhgbMvTmwaiJvY4UzJ/p2Titkag7uAgvH/JZXJiszkCaCKiORdCQLeBQmk3GdDR+A4P NfP5EjgsM5DbjsjQASPYMKtBa8w4ERgWgl/jcbcMaMlVbM0ElmGDLeIPetHYwBqeOtVNeyd8EJP GeUg3zWWEN3W0wjOJWRhIRCqRO1h/ibatXs3ZT7ZZzi6hfRH/y2lhCQGHBbAKYMb+CWVF9mAE62 gI7X4tgI06jjErNEGhqqFZ36JroygZXfCMWqFc08/seeAQqz6vFRD6hodJ4Yc5CUdZDZ0MHyhtL S9XKU3VZvRCOV0GkMzQ== X-Proofpoint-GUID: mIBOqXi2QItlYknHRR0nsT8xKcwZaeKM X-Authority-Analysis: v=2.4 cv=V/hwEOni c=1 sm=1 tr=0 ts=69b91d3e cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-ORIG-GUID: mIBOqXi2QItlYknHRR0nsT8xKcwZaeKM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sc7180. Fixes: 858536d9dc946 ("arm64: dts: qcom: sc7180: Add UFS nodes") Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qco= m/sc7180.dtsi index 8d69225a4271..9eaee5dc824c 100644 --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi @@ -1605,7 +1605,11 @@ ice: crypto@1d90000 { compatible =3D "qcom,sc7180-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d90000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 ipa: ipa@1e40000 { --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 175D337F8B5 for ; Tue, 17 Mar 2026 09:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739337; cv=none; b=tG5GaTmqVAT6IXyMKxv6CDt3VqH2gJQVEbzJdhMQFYdhcBwEIDPHBky+n4bXTYsg+n2I92z4Ceb43KpNQNFkSqHEXBeu170iMOjKThbpZ8zKtcPuwSibInoHtVBOIVgppALip1HMrYRWZxstrVK2lawdbxRMo7nadoP8rMJHETI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739337; c=relaxed/simple; bh=zUfKGirFr7TG0U6cUb0RW8kjlwT7PUFFAQGpnGGIbZg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OGzsdCvEfKMQwdKbOo7uApXHj8f8y+MODA6yxOYbt1Q9sR7XhGWVmTCewv9YQuw6IJtklqTPwbVHICCNp+zmidtVzJ0ili7WDyssDpg2gFVz/wrYaFSrz4vd9BvaWj9DM8S4KBf0j9oY+WyGmwLALzJFwXGlRNbHS1As9jGeSBA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U63Og3Gl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EjQDyWQl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U63Og3Gl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EjQDyWQl" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H9IRsj3101961 for ; Tue, 17 Mar 2026 09:22:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /6lBKgDxYlBHzWej2pbhNBWHqhnNs9qiOdlqR4udlsM=; b=U63Og3Gl0khFP3dr /U6PVywHZet3B4xhgI1Ao1G3qDME3QfMlO2d2CwukPR/CP1AOh2ySdNT0DObpBpp FG1C0w8QBFGRX56Nc3yY6+yt+nDJu0b4Mo5LFj7RCVvF0x03IDsbHgz1jhsPr7f5 t0kAGMxsppGUQmfKDc7lGkVGIg9KbLtS3sga0Hw2DVSvsi8DACMzDFvs2p4v5HaD sT2CVaxn/D/cdkoEvsAdOOO3dre3WZPIoS4S6HHuEH/jeoUMoB+cKofILnG5ly1T JuSvkI5WNa8XRGx+DT/Da6rr31DjEebdnqSurvLuC923TVw6ZCYkwP7mQbZPfMlK CzT+ug== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxnb7b4j4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:22:14 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-35a032cdd78so26785490a91.1 for ; Tue, 17 Mar 2026 02:22:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739334; x=1774344134; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=/6lBKgDxYlBHzWej2pbhNBWHqhnNs9qiOdlqR4udlsM=; b=EjQDyWQl7ISxME+dS46slOhY3McPNNXx9Azd7N2ZsxSk4c/+jVOX/CmCuI7vpiwxKU 2pHyz2kCEbIRMQU9EjdYGkt7jM78TZDO3rkxDSLDJEPfwlS5kk/PTk+aiwfpfUS/bgxY HLNV/fo5jnlPmCXsJgPxImpntWpmwNCrtuuAOsO4FJcyWfDpJPw/8vtsI8eTdbfpAfKT uxQVP58uamCcXi6UW76lIKj5lbTx7mLOKaonvKYbJqDAcDelyj3ivqhfaokJjzRuU/el dyOI+gKyXFd1bXYChPKBNL0U8d/tWPAWHVWV/ahCmHZPcUVrHmQMIfZ7DuQ0nhscd6Ip m4kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739334; x=1774344134; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=/6lBKgDxYlBHzWej2pbhNBWHqhnNs9qiOdlqR4udlsM=; b=rnWtQBbaRXoZvikjJO6jNlb824/ag1qY2+1wEeZCMBYzzsdhi8QnIlOj1gCgoKopmD 6OHvlH6HbR6qyYOqRiVBzYyv4BBVoMOzIHMA/484mAl2lHYZjqzfMDfLeuO0c+p54AMz fElzZROU4s/HBey3kpof1mX/WzwfK3W1uJKKHZyJtSlmUpKPAHg1KH1o3HoHzkH5KQNJ NDOzZ+DV7ZI9mE7+veI7e1cZpye9I8rjbKaDJlOowP5mWYQq9o7wf/+SXT+M/wIxCSSC 4J2At3eKxgr3AwtDxVG6Ji3cgmwZwERztLFOWavGAQVq2v3AfUJ0gU7JxJTKYmMII9/E DZFQ== X-Forwarded-Encrypted: i=1; AJvYcCVqpfjkPMqcw+hW61fI/feUBK8J9qTqPczCdleNShRdjMTi8I2nqCUwd2OnnkyIJZFvojauZMAMzwBM9oQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yxg9/uggcK2nU5Zyw084D/WOs3nakfYShciR1BWQ9D/1FIo4p5k 16Z9XmTsAL+51/gcap9iVp2GNKxcktLVVIc0qmNla7q+AyklNX4LqjzbP5gCE0dJSJ/LioW82dh W+yCkmlP8c713eJY15rqQAuwuI9ZoVapAsLPFykF8wvM9BgO4QuJ0rz25Zcf429MYL6E= X-Gm-Gg: ATEYQzw1a15RU/dC9xA+xDylUk9Jy05VjlfFgsJRRCjJ9e37HGEolqwSuPx4BYUbME6 tvRAuRJnCNoH0HkPzSrrKtO1kPJkOphBO5wRstl/6WqEq/rI/vzGf/aK8DaTQ0tRXVZwz9S1vE6 X4LU5Ykf8F6up+OQRvjhNaE4pvc+Gv8EDghx/DesdK2g5KCgXoSnC083yhOSKYWKw+254KyUt9o mAcr1qTV5kBrsfLNCaCQz3qnW8f38KA39pou15qMa5SyH91Iy0pI7tePjgUpblnT/PESE4W70wr yiZNw48TKMTZlELODa17wULDR/J531D06ks8fN5MaZMXxdZqfXB0og/uYw5vfwFoNewAvtY9Zt9 FYccuzfrrTgZlNwCr/eQho0hosk66uAD4eJbmPJ706nkuK2U= X-Received: by 2002:a17:90b:2885:b0:35b:9b77:d7c with SMTP id 98e67ed59e1d1-35b9b771ab8mr6839274a91.14.1773739333730; Tue, 17 Mar 2026 02:22:13 -0700 (PDT) X-Received: by 2002:a17:90b:2885:b0:35b:9b77:d7c with SMTP id 98e67ed59e1d1-35b9b771ab8mr6839236a91.14.1773739333291; Tue, 17 Mar 2026 02:22:13 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:22:12 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:46 +0530 Subject: [PATCH v3 07/12] arm64: dts: qcom: kodiak: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-7-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=1452; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=zUfKGirFr7TG0U6cUb0RW8kjlwT7PUFFAQGpnGGIbZg=; b=a4Xrxp7svox3j68gZ8iMgDE0wafE/EN/A4Y4REKcjmI9XTvfAAYBSDZavKD5clFCNbBZR2tjF UC4/2a5keA6D5ArDP6r217QHRLfk3EG14Pa2bldvz30ZyTVCDpLNL1Z X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfXz3VyR+11rT4a U8DvxmgL/RGH5PqfSGui5PBCXKGU9chR1b7FMz0rDiVGCtgASd1zGk3U4CdjbYc+Xlkg6cp3fSk 2phjT+A3+RDSzlmHHOaU/EZ3CSeP5tD1W8IcQAnhM6xDpylJRgkEWWUfSKo5blrPXhXUv1LBAWE LI/eoJA97LCWFn1Dv5Ie/4Z1je9QkpVX7h4Vylq2fh7I4/6DoCleS733Pm8fFsik02Ph3xXTZEe LpjU3r1WX+fi5uV9W+hYzSsNzhL9D1pn9cyZRYWrVbKQw1YM6hU1w5FxouzpzkZur8V0OAKMKHg t5c5Xh9c0U+OJlpvll5jQCBAcv7+orGFwMgrJ3DcWnGWTDcEckJpu97DmaWk/f5iit4ytoXOwuD FfX7Zhaggii7eqk9LDxIRsFMm+vryEZrqITdg8Wj7RQFbudpX871nAnkUgMnaLYc1QZK9B+EQFY rXNT3DJFxzlIUzZsCDw== X-Authority-Analysis: v=2.4 cv=D7pK6/Rj c=1 sm=1 tr=0 ts=69b91d46 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-ORIG-GUID: -uZyKdQy1OA0sDYyGoUwyTFIi_0yzVch X-Proofpoint-GUID: -uZyKdQy1OA0sDYyGoUwyTFIi_0yzVch X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for kodiak. Fixes: dfd5ee7b34bb7 ("arm64: dts: qcom: sc7280: Add inline crypto engine") Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/kodiak.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qco= m/kodiak.dtsi index 149954a3eb7c..9765bf361db4 100644 --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi @@ -2579,7 +2579,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sc7280-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36FF937F740 for ; Tue, 17 Mar 2026 09:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739345; cv=none; b=RIlnn+plpKznqvKkaqwLpP+SPZ4e7E6epqn2aSyp14o7GZ5dwT9F+pudEQKPvKq/k5/siUpENesUntcvV5lMUO7U4zlyUDJuUHKi+f7PsYP+sbhEK1TLpxPs2+B4N8XhHtKclUm1l0svi9fmCacxOEyV7UnDC4FrVJcqhkEwJD4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739345; c=relaxed/simple; bh=EyymIO+0SX1tNJOGZcOd6xpMbabopuFyvEaUeA6tyUA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KllQjunV7kXOD+RjpLQcNauacXL0YEbQYpjwq0I/gmMPqwgWdx/EXhveIRzzU3k1SZEDklisEO/sQ1hB3lPBNaUx0b5taaORKzevUIK8e/CsdtK+MctH3ESBhMx4zlPmbXvVhu1WmMFR8zF7niHRs3U8jIiTXDoJznw7iwiDQwU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=K69OfnBa; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AhKYxgbX; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="K69OfnBa"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AhKYxgbX" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H7JINK3124255 for ; Tue, 17 Mar 2026 09:22:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= iGgwjLrocEcbshjjlymfN5Fda9m7X1bHIMMmGcLOwZw=; b=K69OfnBa0rqrDogn Xt/v/gk/JV/+uYKbMBPRaOTGWKklIBn4hC5fK6GwBlS8AdSD89XtZ7pLZITy+kQn FRAUuHsFx5DvCkWO5eqXqevIwFnuOwwuj/JaVf2du0528d5OOdW1XUvTLrt2NiW8 4caA7TGBSXDqyqwRA2ioK4m+emRmlcFufI1R9dKBU1NRIeY5KOkYUkxjIg2F0ENH wXVYh/pFJ3A6Lkcz/zT3ebCY7PXE6e8LZVjZaXlukSe0ECo4j7CmFB9i7LSWwMJF EpjPg59HhepEjRfQKkVNRRwIPk5lZw64iDM0JP35Fc8oAWPVcDNcP5lVraRWjy/u wJs4zQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy2fbrfa1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:22:23 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35845fcf0f5so992477a91.0 for ; Tue, 17 Mar 2026 02:22:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739342; x=1774344142; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iGgwjLrocEcbshjjlymfN5Fda9m7X1bHIMMmGcLOwZw=; b=AhKYxgbXcXWGr7enEvX8VqfxqmZWycc4OLDn6FaQ/tWR27cPMwxD3XprcCcnYinbBF Plmcyntb6hbWMM1j592EpOF1mNWr1FX+24PNpDbtZvY/eEPOFt0VWLnOm1sLRejz2Tlc +Y3T/dRtjOSs2CJjWzYb3hGUXmqkiHawMCnApmfToek9uNkSkPaefaIokDKHIBafe5Cl v4RVTkw4gwtlsLwMh3Hr+5Kc1IOmWfq+BVmtZBOmJ4vVP4cTYJabtFm2G9d16FjHLulk kjN1hAW2zXKPlDb1HHUUYTE7DgOYhpQeAjiTJb+r3/InqIMcA5nSu6vcYIUmN35QjRhH mJ/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739342; x=1774344142; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iGgwjLrocEcbshjjlymfN5Fda9m7X1bHIMMmGcLOwZw=; b=LRWK3j3nnXl0Nb9gFAVy9CmuWMAX52STQHOAsj33T06VeBHbTezTDOi08YI7/jC6TN 7DMy1qg+EULororZF/Bt30Cd7HrtuEZoqBIsOfs2HoVUEM+ABfLN7DRi6lXOLti04dtH gYHB6yKQ//cfU8AeWz54QSZfdZARg6/i51IPY2sdwODH5at1cWokFR8dlxhnqC7faDVN mch3kTg1PrsD25DNYt18QA9sYwdWq+b/BmD5yhN+2LzGdbH6i/n47DzQGnuSyL5sUDNa B+fQfshs9LWMEVOFyONccfBCp5MA/TSC4T+lLyMAMZRqDDnahzRMon9KrIcfTUzefTFH tYfQ== X-Forwarded-Encrypted: i=1; AJvYcCXTF3BcszKROFh9i0CDubiGuh3Zl6Es+QapTcLIUbfAqb5SrxFqZ11ARcNqYUPOXZ7EW848jE+HYSDqQoo=@vger.kernel.org X-Gm-Message-State: AOJu0YxW3U3R/puTh/CPdIkCZkvAYqqLG/LPo5ire5x5F5YYqG4uvacL usI/OPgTSr0nCWpSwWRbb9lYRXvkiq3m64PzEgenY6NW4ZeS37bESAO6p/XKF/k+mDzCSxvZq/g W/EyMUVkzvvqd9DbVI9yd5xT/DFhr9PRWkZtNz42GEvxeOyJIZsCfEeQPykwG3FC3uJc= X-Gm-Gg: ATEYQzxdoccStxjXtpXE8IugL0pzmFY0NOgPdSgxumf1DIvq/xUNuGwZaNRFdRhOZdp RIf1mvwFdPzp2aKYlFjFHv3pmBDbijPN0ExkXbwAqfqQAzgVnHzclcZ+ujjvUsBrBoUcT3IM5sm ZELaiPmNYpvzVyLUYw5rROeGCNotZ2u/mxFqkiFc7n3KySPC0+w8j11rGGldgwYf7DBvUEsum0r Xibl7YgpzTf0xn9P0DehkvxROXLmghdooPzFqyIwJXvHsogi9/GcJiDGn8a6WBQ7nTGjto7SXJm v2Juk+buA0mNniEIzcNDjTFJ2HZl3B3gmHMGX4Wv3+Uf1yKMZInTkQV9TksECACceo6ykRyiO8v x/vc+rZBe9EkbhsZuZXfl60eoq7WTq390IV5hc4GJvOu1I5s= X-Received: by 2002:a17:90b:2781:b0:35b:9ab6:1d59 with SMTP id 98e67ed59e1d1-35badb4ba88mr2157277a91.13.1773739342091; Tue, 17 Mar 2026 02:22:22 -0700 (PDT) X-Received: by 2002:a17:90b:2781:b0:35b:9ab6:1d59 with SMTP id 98e67ed59e1d1-35badb4ba88mr2157229a91.13.1773739341566; Tue, 17 Mar 2026 02:22:21 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:22:21 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:47 +0530 Subject: [PATCH v3 08/12] arm64: dts: qcom: sm8450: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-8-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=1446; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=EyymIO+0SX1tNJOGZcOd6xpMbabopuFyvEaUeA6tyUA=; b=lQAGtlUNfquAf2gQkMUAACvFjA0vALVpEjVrGUGXWiO6Pisl+B1wLZtCpF4Zkqymj34vfw1+P xE/KWbwJfa3AzLJZpWI0aUb24irCQBa6lDVcRnR7OarF3i7alGJVEiM X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-ORIG-GUID: g-3TpfHy7Zevv3Y8SxwSAvK80_o4gRyz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX7zzVQCmTjHs3 iPj2PJMGNYngYnT0ETvX+QQbrj6pcEnobNGIvFXzz5LbZSKCVqz7ewY6/O/pOk0FwHhi00sfP/F iTc3N7QBcFhJ8O3cu5lSu45/7kFDE31Lh18CLFJSXx+CcdBfI8DAlYfxhiDT2tjlMy1+M43IVBP 3w2FGsmhU4p37BIRUc8D36w6bbRgwUi3n+WyCCfaJB3DZWQQ5GqPS6AYHvob8vxnV2xWrvg4MGM iCcoGYdKEZ921LBXJLmcawXo7XqAHbPf/ztYHJJDk3qa3prYN0g74kI6NRfW25jNzRNpyh6uJkb f4i1gP+OtxkgE1sMFMQQyVhGZwkEMFi/Yar6e5ChC6qw+Bqj9a4vGQp7ZzraP2nVghgjJ3u/SP7 A7+b0GuTeyWfZqzfbkuC4lEQQ5Jzf0u0DGoz7QldR+7rDtojnMaKwYjnkeOdhscXA/fxANRYhyP 8VO8lnSfQzxO93m7VfQ== X-Authority-Analysis: v=2.4 cv=fa6gCkQF c=1 sm=1 tr=0 ts=69b91d4f cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: g-3TpfHy7Zevv3Y8SxwSAvK80_o4gRyz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8450. Fixes: 86b0aef435851 ("arm64: dts: qcom: sm8450: Use standalone ICE node fo= r UFS") Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qco= m/sm8450.dtsi index fd2d5648b92a..0dba282d644d 100644 --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi @@ -5374,7 +5374,11 @@ ice: crypto@1d88000 { compatible =3D "qcom,sm8450-inline-crypto-engine", "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x8000>; - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6FAE36C9C0 for ; Tue, 17 Mar 2026 09:22:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739353; cv=none; b=q1/Nf3fDlt8UDyqtV1AOQp2gi75XQ8wU97tnChCamBKs8KYPGo/9YPe9VNaWO8dgyGRx21YVGVThxU6eT6oSnFPbEtkIlnvAdEV0tRz0OZA/QLBLmuiWkr3Rm5ZBTPN3pcTvSzPogGi+ioT4CTJxH/gJEtHdrK6YE/n3G9n6T10= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739353; c=relaxed/simple; bh=jNnS6vGH+4xi0XIVQONh6OWH1bIBeXmAWadZ36T98CA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Q0hO72ZcB4dSkfQClK22SBeGHlOWQrSTg9B9kvzwM6eYWmHFITmFmACySkQNnjR0ePIG5HWxJS0VnuIpSnso59UPzGifSIP0VhHNTMffJpaKd7ziDDG/6J+TNrZJJeVqxDMg/0YzqurFpiixRibH2dRWZ19FN5EUhxJx/gTeHO0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fwJ1WhY2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bMgAF7aT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fwJ1WhY2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bMgAF7aT" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H9C9Fi3101993 for ; Tue, 17 Mar 2026 09:22:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UQ+QjOHQmyJW0MDla5KzS+DLHnL+9knlYFjtShy+6P4=; b=fwJ1WhY2wbwJ1LzF gZ6k//13FDlX2U8X7N2L8n2YpGdyLybKfXvZTD7GXvFHCZXwrZuNR8R8yn2v3P6J u3eOYEwn5dLzMjGbgWt3VlFR2Nkopdo0V/9DqC2KESNEMgk1RxMLmmJ7cSKvClWp ijb6YYMVuTJ0iGaK8SHxlsUz/aWDD/0biAga9iykW9cAh1DG8Kf7R/nRHrQADrqi FfxYsTeG13u8lBXLyz4jCufA+8LGGUM0PCrYUu2IapuGmTietOyCrlCdmK/Ga5uY B8xSxu5Sy+I3OP9bJyVf+6voPn6vkHMP8iveJ7bn9TOkFsQq+jCri7uCOrWbdciJ SpQAuQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxnb7b4kq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:22:31 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35b9333cbfbso12274348a91.2 for ; Tue, 17 Mar 2026 02:22:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739350; x=1774344150; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=UQ+QjOHQmyJW0MDla5KzS+DLHnL+9knlYFjtShy+6P4=; b=bMgAF7aTj84tPbsnucbrFzimt0MGJru7+hcqhw5UztP2XGLcI2IQkNAzjxRQP/uZlm NvTBroXG3MIi8KYUAOelUPPWNl3wsVUZyaEN1qh0qoNBkd/FFbtxouBgmAUbipjWhbiN Y5ZU0vL8oj3c5a1lCfwcGf3H9F95yNWhTRKJ7Sra6YELUB+m7JV+t6qcTlJvKK5RSv3S nNjQal9WEvTl4r5x7Kx1uNK5ZfwE/eP/b5KOqnIwxADG5lhG+FmReNxku2oE0IYQ6Sps Pxqr8Nt+aeTBfN3fQiBpwM/Jp+5d51UDw/8RGqnu/ilFTMdltG5QFY/trGoBlwoeOpe+ v0WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739350; x=1774344150; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=UQ+QjOHQmyJW0MDla5KzS+DLHnL+9knlYFjtShy+6P4=; b=JInZRYVSb5iUS34g274LOiJrMvKUw6v+NbPfNrqmapzi3oxpdtSdQU+nwG/372JHIB gtpVu/xWIP9Sgua2mfRCXEVJNfBw+Xs8kYkvBXd1+wb2z1SgIqqZtmKDBiasYvRcJiSA nrUwgOrgUvHnRo8MMhVf3DeSlpBg2BXazC9vKLffccnuHGg2rv0pDUxe/skphdvqoabz 2yeQgZqRJf1YJIoqeLOlvntRSOYGJ3NccNZ+1DzCGnnJeIm4nuEt3rklb3J/Aya7j5Bb xHIA1vlc0BvOPDPMrFVb4WYCI3weiZ2B+tfojySDQIib1792a/ygaxYCeHA2iH+tayGV /FPg== X-Forwarded-Encrypted: i=1; AJvYcCW4e2jeGECeYtrjeaMtRaVOySDz3LqocbX2WJ2ONeJ2Ez4LEfYuv93RdYI6GqLosNUfQJYRPmzK8iZS7Do=@vger.kernel.org X-Gm-Message-State: AOJu0YzVqivcl5Jq8nMHJYQgXsu3ycQ9HD0XhSv2Peq4ctZ4TbN2Cq9U BIiS5V0+U0yXXdv09G3Rda4ZJBOA6Q0Yx+LXrVAAiKH7NxEttzaRICOht4kNWp3wu3nG7JzuqKE R1kk5Kn0UQ4U2KfYIHBd+2rjND1aIwZDfk3nU5hOKkJByhOVpr5F6L1A8V0R0Xw4OzUs= X-Gm-Gg: ATEYQzx/WnxFY2RinpMLUy4RuA38LNmr36ScM7KnKAtlkPsuSxcl0J2enVkexZDlIJh 9bi2nyA2cMdebp62SGa6/OobfZkYt3DpQSOU9YFKoef0eHeKgaIDy/bAcK8wJs6hg+8do++k6IF LdCg4g+Fz9tDv2Tc0xEN49yYD9+I643mxqEwp8rozclkeyATy2IhFn3dfKwOPBu8tKiDerHxtgC foTZPMJaNkiiIktsJZZsCL3NiPSQN+GGLa764RDt5kbwSiOFRdSTIIF/KyXhTiMC1sjiMmnyT7h C1EyLSso0Nxc/p0ib36W06FQZbI7AWr1USiZsywOEFBlAebEdcbq7xQ+An6psIwd5ve++0CZ8uV 5/CrStgXqckecZ6lRjRjWZTesbOySVqZLlVXPcFdGqxqC9Co= X-Received: by 2002:a17:90b:5292:b0:34c:fe57:2793 with SMTP id 98e67ed59e1d1-35a21fdd40cmr13749996a91.20.1773739350509; Tue, 17 Mar 2026 02:22:30 -0700 (PDT) X-Received: by 2002:a17:90b:5292:b0:34c:fe57:2793 with SMTP id 98e67ed59e1d1-35a21fdd40cmr13749969a91.20.1773739350086; Tue, 17 Mar 2026 02:22:30 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.22.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:22:29 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:48 +0530 Subject: [PATCH v3 09/12] arm64: dts: qcom: sm8550: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-9-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=1391; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=jNnS6vGH+4xi0XIVQONh6OWH1bIBeXmAWadZ36T98CA=; b=vbNo5npV05uEkkrqWTggqoxF8bz7B5m5CsrowYg9qOdDLAE560Z/12CZZAz8+WrSotUThYCbR 9yQrRYwteMuB+oVbxVzk0Z9CRwWO3hSPjP/Ux83tT3zpUYU3A77bDyE X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX9eMWBsAdHAGo z8RJWSS/XzhTRCBTI1IYTZcl24YFyLaCJ3Bpszs+0iuNiAKjLL3hybWs0RnRFR6pbfQdK9tMnE3 kzY60NQvEaj9o5x//ChSaBW2zjjPyhdZMvy8DHhpiGJZP9ZXuZF8Dwz5JeIxkqfugePhkgmqoR0 g22ma28dPQcHfCfYF12VYi4xbKX5tIbXOT1VOgMULf/cwZ58fUUiNTjw0A24xzarSdveNJD0yc4 KstNquGWNEzV2xPldTpQ8jU5sRL/FyvkmTFnuY6nDeJhXLe/dTaKmn4XafoOcyTUXpHyLAULNp2 cfsZ7sV7aDMuI9MiCckvOS0W0mR+eTA8fVQYYze5sxOvyQZwvWB2NA98GztWIt5QxyG/0VRhXfj eYosB+kSj0u+LIVcFk94gw/mfdbkDvu+JHBFMctZIUCPcf5lNV/jI4DlHGBoHvud9ccHRxdiQ1w tmJ+F2YoSkQL8ajtsUQ== X-Authority-Analysis: v=2.4 cv=D7pK6/Rj c=1 sm=1 tr=0 ts=69b91d57 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: 0qV9N2ld4-OO4pKGniJYaGu4pTyaA9Ye X-Proofpoint-GUID: 0qV9N2ld4-OO4pKGniJYaGu4pTyaA9Ye X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8550. Fixes: b8630c48b43fc ("arm64: dts: qcom: sm8550: Add the Inline Crypto Engi= ne node") Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sm8550.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qco= m/sm8550.dtsi index e3f93f4f412d..473fb4748036 100644 --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi @@ -2449,7 +2449,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 tcsr_mutex: hwlock@1f40000 { --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AA9135C195 for ; Tue, 17 Mar 2026 09:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739361; cv=none; b=U3P4nmJnpYO+o2gdsfuJvlTNDc/7BCEIHBKMgR1Bm7gCB1wsq5LgFGxIrAtEwnC8o8J4gp21F6lVLOodD8BRNjwIbPiurENXKzAS61CD9kwVifniJsXuINDQ01VodrqT5O5gTdmfrg9kHzqgdcnIP8O//H0dr3qMkVvOu+wYkGg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739361; c=relaxed/simple; bh=vXjE20g2L0ZJQyzxZj8qyvW/3Cs1H+TeODfjjpRRFrg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qNcx7MeJE7QBr4kGQ3Jek4uj3k1+/lWIefkFzffSNzBPYsJIr3QPqAqKRYpalUUYHj5dPKRzvQ0QT6FhS2AIEa4lXhhcKh/bKf7v2yv1qpTV3hDBYmds5j1G4bnQBOTfuhAoQ/gFodyg935OJwp5WJBDfmNaao+Y8/h7hoMSu68= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RHCG+Odg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PDlf0H3y; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RHCG+Odg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PDlf0H3y" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H7RDJj2905945 for ; Tue, 17 Mar 2026 09:22:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sYytFxuD86mKrnrbni0xkdSR0IRHqvzld2dCJ36Tg+I=; b=RHCG+Odg97U9OZ2+ 9OvlCF+J1KrgAGWBp2ISSrqEtLSjgaQUocrVMyXHPgjdeh+wYmhLK289DtWTiIOn olrdQPK/d7tjRbbmDO+nI1NiM3lPU+W+tcQXjfy9KoK4rZ/1qySHkuph8BjG01IM ZoVDn1wK3jxO90gCzf7ueo6EZ8wSeORe9BcIhZ4h2hUbummDOylA6fqsI1uAkk7p Wz59dSSoOpz7turO1qh7Q8CZYao2zdu353OHunCaMxJE1Q5KPKu2TW0JsRljMlI9 ey6QYvoJvDbUPW4dBC8F34ZRB08bJDpklwlBzsA3wCVYSh+c3RmSLD6av1lkCl0K ibWAJQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy2jxged6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:22:39 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-358df8fbd1cso6438573a91.0 for ; Tue, 17 Mar 2026 02:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739359; x=1774344159; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=sYytFxuD86mKrnrbni0xkdSR0IRHqvzld2dCJ36Tg+I=; b=PDlf0H3yay62D3yesj3nUnK5fQhhv6Ao1qO5v4gCTcDXPpzf+44gutNN9H0rMBIQRh tVmK+0PVGz1AjwnBuek/0fwuaSxPfY1AMs/LMyyKYhs3FesWGlNUKdOS5fvrZkLsS/+P /ATFPMoJSkQaJyT1a//I9OGIaGqJhnOTwBXcpN4luwgNYx8Us9+hAVXrYIRx8Stejt4I ZtVO8ZmC7ZLvJTT5NfvHUVHXfqIAnkcxdb3iGomUykFWwoM/XwBGizvxJf8XE90gqjw5 Qb6Ft98h5TX8YzaFAeJWB2u/xfIEAfVR5HCqFiD/TC1y5VdjXFmaxMDVKGMRJt5uiNZb e+oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739359; x=1774344159; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sYytFxuD86mKrnrbni0xkdSR0IRHqvzld2dCJ36Tg+I=; b=AeFZAGoJm9AsBTcczWabTTjZJe/yKd9yW5TqmmPNrUC5g4vl0YXA8dnkABdGPAlv9H yPhG41z5WyOF6WkhGIGw41nO1Wv64iAfhKda+7VQwPEaZ60aY6H+SAcSjXzMRu04gM4l o/hQ7NwJUCCiHf0emXf2auNUnPaw++P/trXd1FvHYJ5Fv/QzVbFg7SPx0UsSHb71GO7y 2pQtw518HDEfHQrEDNvtgco8Q9Wfrd+vUcWAYXxZnDrF/00nQjng/FpD80NR/4Lo9JYY cw8J/pR55xrDbY+QuZKQCxAkRtzNFtucFGRA7yv042+Jvobhw+xaXo6bHcZNwinfpkg+ PMCQ== X-Forwarded-Encrypted: i=1; AJvYcCWVzxvRTXwfJyFBSnzJ8WnUZHEnThcfAtOqY46DYVRl/lhO2GR03gZoid2XBitdjEgjDhsTeg4gCgPeZJ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9thUUb9763Xch0VtZulZKYSlFJLgp5k9+DN/+L5/DkAzkrdfy 9Hh7es7Skk9Kifh0kT4NQFw+2zvsma7tPeTqEYuNYfOAyCWvywa/O7rE+Jy68chxDXuQ4P/JbbC K7+5YpG+6kae476IunMfwlBvNXKeMS7LCL44aK+zNzG6SSwhtSwfdkeic98KG4yhTDfA= X-Gm-Gg: ATEYQzw3ph/EHdkdggABmqYRwDArr9LL8ICtthA3GNO3GqH/9Bx4SC1/X8DJUeRBuYx QrOxUnz3gvPXYPqQW45v05HSVXukKmajTC9OBCqHUZO/MoYI/33Sy+EbIPNCajOfgCrHA3+9XvF Ki0k6L+CHSAkGXILzB6PODZLoqaAFHuTCQxsjKMUW1AZRpqXANvN181gMcrCg5+E/kOfWNJ9edJ sRgY7uzKv5lcrIdfTxNJem2l+DEFUm2L7pg1s7T5pniNGHv1ZzC1OWyic4Mu9QUP87DsRtvtCso bQfd8zHw6Zq470NSw6WX+lrG8mX5F8meJK604K83Xy+0uXqxrbhzANuX00Z8DMEI319jCErvkXy e8VSzBCb91ZEEkGOckpx/jaPZjqbZ3caPIdoTsoPwraFsuIE= X-Received: by 2002:a17:90b:3fcb:b0:35b:982a:28d9 with SMTP id 98e67ed59e1d1-35b982a2addmr7810958a91.4.1773739358985; Tue, 17 Mar 2026 02:22:38 -0700 (PDT) X-Received: by 2002:a17:90b:3fcb:b0:35b:982a:28d9 with SMTP id 98e67ed59e1d1-35b982a2addmr7810921a91.4.1773739358504; Tue, 17 Mar 2026 02:22:38 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.22.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:22:38 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:49 +0530 Subject: [PATCH v3 10/12] arm64: dts: qcom: sm8650: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-10-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=1404; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=vXjE20g2L0ZJQyzxZj8qyvW/3Cs1H+TeODfjjpRRFrg=; b=1vG0VQdenz/MfPd/Mx+daP0cUk/cs2FwW+9Kfgk0RGQx22WSSBVux5ZrABbBvP8E/bUCNxJDP esdkSYWTFsnAttv+c+2/voZzjJx+emnZOlKjs/F1iuC77rjCEdVDzbQ X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: fimQ2WAmJ88z1tGdC21E4Co0A_RPZI_R X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX6KWmv2ZGQEBS p7bL44003pTb590/43libwLGjTFbtH8tLvOw0xutKan0ru+WPSwd/tgpS460M7zCooOetv/cSIQ jLEeFK5fSpAc42ha7OYuNbM4E3b0FzENM84LnIdPIaZ1XNy22Z/texCljfrOj82NZGmNNy+8al0 WJXuZqXNIumPoYwptIdfM26ZoGQSOgy1+DNU+TurDqNduhOEPZYZsaK8sJr+3+MolmeqlqyU2vV dxLyHhbZta2IZxCBkVb5qUYYniLAn3O6RcaGiMdIzYVUdAyDJ53O0lQE1hpqEqfdUxrDdPP7VBz hEYAn3/BmTtIVF56nXMRHFvd+HgWkvX1zEHtLI9kbesLTyHbk9kyPxlWcxi1hXl4viO4NtdIn2t gqlhvWWpdBKNg6esNhXdlaUsNk+qBVSOoosvo3Fzo3PUpKqipCGUD/9igUxOkIKc+qCmsbjpKMf rYUTMAyVfcFz9T8+08Q== X-Authority-Analysis: v=2.4 cv=c4imgB9l c=1 sm=1 tr=0 ts=69b91d5f cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: fimQ2WAmJ88z1tGdC21E4Co0A_RPZI_R X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the UFS_PHY_GDSC power domain is enabled. Specify both the UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8650. Fixes: 10e0246712951 ("arm64: dts: qcom: sm8650: add interconnect dependent= device nodes") Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qco= m/sm8650.dtsi index 357e43b90740..d211bd94fb41 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -4081,7 +4081,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0 0x01d88000 0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B21AE356A12 for ; Tue, 17 Mar 2026 09:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739369; cv=none; b=nHY3ykFkJz45iRG5hMZgsjt+wP4yW5lkvyOdI92SL95GqVhsCLjI4V4BJRkbegioB7XO6feFjj0KXeoRB3tqCidjt0YPY1oY7dfRRNmW46nYoipRlJIYJi2+ZAj7h6B4Hlzq+1VBB4FGrUADrutbBs0ATEc6aGLspHJn6eyDLGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739369; c=relaxed/simple; bh=pGdwSBuA+w0A/TFeoG9/2wpNf6UWc6RSkzFexzGtbzo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c/daURfm6Z9x3XbN7BdEDQ7YLO40Q5xwqn6/qRQXuWVVBmZweHCE6FXhXxXlKhcgZzis9RYx5c5l8ry+oWHa2qVY5gAR6UYvwc1den8/+1REKAnCK3FRXKJHIJphntgp/ElbfFoIezFgAn1fGz5SqgaR5ZUfHn7oxBfL8To/0dM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CeOee/sG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=J6L+jZO9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CeOee/sG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="J6L+jZO9" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H7RDQF2905953 for ; Tue, 17 Mar 2026 09:22:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vSM2tzOh8gKHXyh3ES9OOyv9+idtbwW9v6rQcAEw4FA=; b=CeOee/sGVDSskamv AqYEv676TnDTUxiASINvrlbaVyAE496ir4jHqqtaAAvun4leKlKV6UHyclGipxCm 3+OsQjnz07PtEyd0hinyJTYRuvhpW3pnb10bojy4eGJ+H2/5Gs+Ow58asy1rRclq 8M5j3z/Wq1m7UjqTLM1Ui+Np3HvXQR+Z1vlwFVBxmEhA0IyuwCwEvmrx5Ep13U00 iaAhmofep3O5V/FDP9Uw+Alzzdiqy7tFOmyCH/RrsshmIsRZYVt5aM0fcX6lTcZH IXzeiBqWESZcf2qYBk2FgsQZt87dVLUSiYot+hseCZW6NMy39EL6ql7bnte1uFWB A2uIEQ== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy2jxgedu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:22:48 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35a0b5cf34dso5896440a91.1 for ; Tue, 17 Mar 2026 02:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739367; x=1774344167; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=vSM2tzOh8gKHXyh3ES9OOyv9+idtbwW9v6rQcAEw4FA=; b=J6L+jZO9fbiUPwRHyiXLtmutJ5jSLmgGvBlKJFtWq2GlELL9vvrmnJmPV475QpBj+v XHyV589z8/u2Q6Mic8MjdVrwg8RMK5PN1Yktst7Qkd2hWkEHPEh6ZVlqhyLQk4KbRvxC W9gkn38tdfoL6BgBkfnTMkOZOQ7JFJuBUWOrgBrxrWZrWjjVTnh3NvplXv7yKJ3soK+Q /M7T1vksZpPLCXaCd55cwo8Et7dkzoCxMKCHd7Q8+lIEirPIfHoK/cBroZXV4fWJchNT joq6aCD609mYImxhUPxXH2NILn0YSs//1rAmoICCb1/rAkSYiUZkyLICgpDsMnJ9C4lU 5y+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739367; x=1774344167; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=vSM2tzOh8gKHXyh3ES9OOyv9+idtbwW9v6rQcAEw4FA=; b=haG0yZ/trSE3chjk2pGLiRi8063XqAk4xsPraXImIgX0ondb7imzipRqMpOJwUV/Ci BDll/2SWwVIrmQiS5BtVN3gzZxGmyJ6EWVspV6K/udKYtUE37hwfMDz5xNN2euTSc4G5 tTjbNn6v1CkvyZofSdC4lKQVTp9t0q9d7hW1erun+wFgy7kgIZD4dGv+YSTVnnqlIpr0 1RZYBLgXLgZ36ClowL8ayQ6qO1/aV+wyJkAl1siwRD/PIgEtx9WTSk0nyl975+r4dhBd fPKQjY9Mw3ygDbX4cuKC1GDVvVLcpYDZ9zb5bHc/BWlCWCMoIczqtsfjBlYY3L//8loq 09eQ== X-Forwarded-Encrypted: i=1; AJvYcCW07LBK/OVveQB9gmnzw1XyrPAkzZxFoVX1W+d1LNuJYbZ4aibge9Sxwk2YNDMXnYGtlNANcZdHAcN4qx0=@vger.kernel.org X-Gm-Message-State: AOJu0YyM4jZxOsO7pI8IfEW7xBHfVZZnEGRkpZ8uUZ6WGy1VfQ87NrRs kdrsl4V/KQNNbWOB85kqdItSd2CVZQEus8NI+LxsrTOmiLfQKtxhIylloaIKE20ZkrPiwosqsDu UzruynwxgTaERSAfv1iDGPU5lV8Hg2FiHfU7r8/COptQJK9bMy6dEc7nfzJPX/I8SSsI= X-Gm-Gg: ATEYQzyoJL2S6FUz7Kyv2speenllXznBlpUTPO93RaK7psIakIYlTSXG3BK2nJRjX7Z mBcpyrNEKsNGKB8UcMYgy5c7lzqIUpfnUb22TwDoI2to5DQXJHDyJu6q/M+7WS8Sb4Ecdek8/1m thV8207+oSC+/HTkmu5bGwk4pnIMoHt/tE2f8E7/Mvr6NP8v5XBk34IBHZBs9E0Fw3W9C0xSfHd UuWjrcGXyDVhhQuMIBjnXvh4rO/j1XaOahZkIrm31xRUItBYucSNt5giuHf546snIqSOeXsuUmc I9YyDAK1XySpMlTQUaeBG2NQVEc0mUnswRTrBzJAyxRww+V72qsJZu3lJc6i1iVTn4UayTMDeoo a/fbobsM96+vIoFs9ma1EGR9ZNP8SFXQ3qTpdO8iN8L6Yy3c= X-Received: by 2002:a17:90b:4b82:b0:353:356c:6821 with SMTP id 98e67ed59e1d1-35a21e460f4mr14293820a91.8.1773739367459; Tue, 17 Mar 2026 02:22:47 -0700 (PDT) X-Received: by 2002:a17:90b:4b82:b0:353:356c:6821 with SMTP id 98e67ed59e1d1-35a21e460f4mr14293788a91.8.1773739366935; Tue, 17 Mar 2026 02:22:46 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.22.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:22:46 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:50 +0530 Subject: [PATCH v3 11/12] arm64: dts: qcom: sm8750: Add power-domain and iface clk for ice node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-11-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=1395; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=pGdwSBuA+w0A/TFeoG9/2wpNf6UWc6RSkzFexzGtbzo=; b=RED4vcGcO2pv+Q9c7AL54C0M577HAoEvyt9ZJFBJIYiKCKuqER5RXRwC5ZtpRqMgJfJz+g/mS jvn8c1ytF9iCxgTMgIWlnI7f9Rhw+0wbJowJnF/B71b0LCny6F16rPF X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-GUID: hA_nj96aOEbWSFAe1ZnCJ2tsEWwMTrSI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX4O8q5HwxXW7t W79yyz6IJ1jfQkXjx2m8qPVnZQaY/c0BRePbHNWXMgvkZsZZLzib09R3zo9BDl/rDYdDSmi9Cmc mJMWIn8v69RBGHB70JsDT+0F7hhEX7tL5o//E8MWdODO72knMUdwA3jlMEr1lm1Nb4UtTuNFnwa kw5DLZfis5QdM2CaypVv3OuMD+bHhRNlXMCIAPSVSblc0INGzmGDBM5DUfP9S+oQB+v2GrJ+DFP zvioUjrrkkU0K+fLRyQG94O61vqwQze2hnyd9jjIwTIACVPPwaqK46ZO09NX7MNq/4HxDE7kNau DbqrxzOZHP2NNOgWuGns6ymeDxVEzZ8I13VXD2PLsZbbcdnCXJU3K3wAMz6NZaKOnareGZgTH1U sTz+2++ynG6CVPXBArKi57NzIZw7Pb+g80rnOB0n1dB+7NJHbvZa22c7yz7lksEr88ndG19NayG XBG3ENicd3jHxTFpwfA== X-Authority-Analysis: v=2.4 cv=c4imgB9l c=1 sm=1 tr=0 ts=69b91d68 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=IPGZAGG64n0kybUxs1kA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: hA_nj96aOEbWSFAe1ZnCJ2tsEWwMTrSI X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 impostorscore=0 phishscore=0 priorityscore=1501 bulkscore=0 spamscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Qualcomm in-line crypto engine (ICE) platform driver specifies and votes for its own resources. Before accessing ICE hardware during probe, to avoid potential unclocked register access issues (when clk_ignore_unused is not passed on the kernel command line), in addition to the 'core' clock the 'iface' clock should also be turned on by the driver. This can only be done if the GCC_UFS_PHY_GDSC power domain is enabled. Specify both the GCC_UFS_PHY_GDSC power domain and the 'iface' clock in the ICE node for sm8750. Fixes: b1dac789c650a ("arm64: dts: qcom: sm8750: Add ICE nodes") Signed-off-by: Harshal Dev --- arch/arm64/boot/dts/qcom/sm8750.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qco= m/sm8750.dtsi index f56b1f889b85..8c33bc3620ef 100644 --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi @@ -2083,7 +2083,11 @@ ice: crypto@1d88000 { "qcom,inline-crypto-engine"; reg =3D <0x0 0x01d88000 0x0 0x18000>; =20 - clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; + clocks =3D <&gcc GCC_UFS_PHY_ICE_CORE_CLK>, + <&gcc GCC_UFS_PHY_AHB_CLK>; + clock-names =3D "core", + "iface"; + power-domains =3D <&gcc GCC_UFS_PHY_GDSC>; }; =20 cryptobam: dma-controller@1dc4000 { --=20 2.34.1 From nobody Tue Apr 7 00:08:31 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F233839151E for ; Tue, 17 Mar 2026 09:22:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739379; cv=none; b=uvacCb25YnrbHypY3sbv51UX0amJNRf/8Gw+Q7Nsj7QDnQywqEfKidhlmMvsHkLUDq7lExYWNL8mj43SRlXz7lnnfcEJGzik0PRrzgLXEr4ksa95LbBsKzjPBNJpRbsGXQc4WognPPSkhQCqYxNITPjaJw0FS7Ndd5s8nTjG0og= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773739379; c=relaxed/simple; bh=GRasFOQDQnuoi6LdOvdCuvHUGo8tuUdcLZv2gGWTa7I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ShSSV/FVyOFfMdTn8A3U+upmV4YDn8zPqDLV8V6VFtn8Anh8Zra3tItip9VEpssqJBEdFap9CKKfhYiN6cmRXhrvM7Ag4DqIcAiL5IygJ+tK6RWxSydUX74wEi++bSKLeTzw2Ap+Uf/+acR7XdYjbXDdVdhY38HH34X/nlJ6sk4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RCW2JEum; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZXZrlg/X; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RCW2JEum"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZXZrlg/X" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62H8Snmn1534048 for ; Tue, 17 Mar 2026 09:22:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= K38ecOXWBMhUStpTWn+W7TDtJFk9bdxlpPeuhwPlVTc=; b=RCW2JEumTDgqfoZc h6J5QYGwLFJCRzNTGS8QA6cY2Pa0um3aSQmDaA+H/tzB0O+NUG4Ifjfn5psRtT1a BHfmtiVIvtmoBujayF+6OOyDXU5NPn8y60G14qjH/BcTGvKACI180g2EEI+j5FKm d7z+6Ei2su9wFFlmtLXV2yQ2IWs7698l26nieZJ46/x+T0VU6kJmqbwbcKUjrmnr AfX3jCiRG+0y/irlef+LTLUC2HhHUoSDKXVvzClJzaM89EvKHlhwOsK1AMImbUaz kk440VHILJenuS+tgLIyge99dqH4p3zzpWhMtOxt8Rjo1CXdDBzpr3Un3MDGs60D ZRryWw== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxm5k3cps-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 17 Mar 2026 09:22:57 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-3595485abbbso6868555a91.2 for ; Tue, 17 Mar 2026 02:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773739376; x=1774344176; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=K38ecOXWBMhUStpTWn+W7TDtJFk9bdxlpPeuhwPlVTc=; b=ZXZrlg/XVTSDL27z0anP2RFz4JVT+vRygYLJ9nJXVfx/oFOy5VCFBe2+e5NQwgS1kU ooapcT8SlukhP+wttpl3Js70a0oFWVZuts+8VUCZyir+oPSXmektdhw86kPppNtpWGgw uCWr7GLpjDZ6ucZgW1RdqHdtmnHlS1mZzxaieL38dFCUJMCKxaeZpDxyHp8wsX07HQIE blUY2OARK0YEYxi9b3nvZr55OZa5jwGPXuIfHWsTANncGf2g1rX+3fMrz2MKus6AB5cm rDssMF6lZ3+TNJ8Bi5IZ06yc/uhSkJUC5S4f/SMIZIzxuLvKPa7pwlCss9FVTmzMXj0b 0k/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773739376; x=1774344176; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=K38ecOXWBMhUStpTWn+W7TDtJFk9bdxlpPeuhwPlVTc=; b=Qx3rGIWOzHFmJEgjIIVRiKzVwlWyURNKCkk/Gu+KS5hChGDKFZA340/cG/ARncYh6c //aIU8ig6QGF1YkZWKsjCEa1Kb0sJZB3gmUNsz35fSLj9kZn4MZyQbsYcaFTId/lb1Tl RFBjJ5jC/8VceGX4K9MHIWbrlZowJpNps/mYtytEoY3RfucQ1fLkBRw0xQpVwAjahGqC Xt0F8pTumvA+ZJP7HSQQNuBZrjxxL2q8OURDyXhi5YXh7894793pjZdmv2wFyeosX0Yf dHwwt1jHjf5pvkHAsNbqqrjzXlapsZb9oidK9GOFzEG0Hz77hUSzH3bFJ/NXdIptwT5M cfEw== X-Forwarded-Encrypted: i=1; AJvYcCVtLxMpnLPb89zXpFZ4UQePg/kY0TwZJG9RodR+cM3yFRDf5O59IfF//4D4WfSXVDpmgUdw82/eKQcofxs=@vger.kernel.org X-Gm-Message-State: AOJu0Yzct6K5Dg9ytcCMYd6Ws3ZVPS3K+vY/HEYHHpAHiJ38DPy3WsAf s5nzjBClOzFvBBHVW76AN2HIQCPEBwoX7ghg3wHPMtasQ3asFbj9IFvTCg36GZ3uwmLeDBE6yuX suIa+SLp6kc3XNVv9kVWckSpK90v8UBtNGJ9SobUS9QYwXdmPSo5fXIMe1wuN6o/4E3I= X-Gm-Gg: ATEYQzyW7MV6tfzxLpYeVrkhg3PQY1eqNwk5RFqgqrB0FIj5CR0CV//+QzN6c3GF7nw obwWuiqOzPQUH21W8LMTH4bu2cHj0W2T/SPpu7GbcjFWqwOlk12fGiqvR561AJ4mYkiz9zXzyU6 NybSmnjMAytwqYbaAJJU/6Y5BsZrYVqpV54KA1HkWV0wNLAeFAyiGALRYgzykFW9zXCHGBqNAO1 7k/isanzNSjaGhryszWQCz5Q+duLY2INHLOZignE4Ze8NNpEFNldBF4bSeY0O0+xINLEo0TOtXR Zxhj+1qJFZXEPVmsKu+nOEvkXfZ/PDf1qX2obtQpqzOSPLabQFoZnIYKXV4/aIFVrK90JaPwXlj ohBiCfE4CT5Sx/oZvsCHKCgnTBz+msxGPX6Q9mR7lEWPGX8A= X-Received: by 2002:a17:90b:1648:b0:35b:9ab6:1d4a with SMTP id 98e67ed59e1d1-35b9ab61ef4mr6008223a91.18.1773739375987; Tue, 17 Mar 2026 02:22:55 -0700 (PDT) X-Received: by 2002:a17:90b:1648:b0:35b:9ab6:1d4a with SMTP id 98e67ed59e1d1-35b9ab61ef4mr6008185a91.18.1773739375465; Tue, 17 Mar 2026 02:22:55 -0700 (PDT) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badbcdaa6sm2331968a91.15.2026.03.17.02.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 02:22:55 -0700 (PDT) From: Harshal Dev Date: Tue, 17 Mar 2026 14:50:51 +0530 Subject: [PATCH v3 12/12] soc: qcom: ice: Allow explicit votes on 'iface' clock for ICE Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-qcom_ice_power_and_clk_vote-v3-12-53371dbabd6a@oss.qualcomm.com> References: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> In-Reply-To: <20260317-qcom_ice_power_and_clk_vote-v3-0-53371dbabd6a@oss.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , Manivannan Sadhasivam , cros-qcom-dts-watchers@chromium.org, Eric Biggers , Dmitry Baryshkov , Jingyi Wang , Tengfei Fan , Bartosz Golaszewski , David Wronek , Luca Weiss , Neil Armstrong , Melody Olvera , Alexander Koskovich Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Konrad Dybcio , Kuldeep Singh , Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773739265; l=2504; i=harshal.dev@oss.qualcomm.com; s=20251124; h=from:subject:message-id; bh=GRasFOQDQnuoi6LdOvdCuvHUGo8tuUdcLZv2gGWTa7I=; b=a4n3IxWFcsTR5Gbl0Rca2o6ovz6cpNADv2ocVDC7UUJtQvbi+2qJEobHHXL8L+yvjwzB892io BrQuwGTC+WCCgJGFyq1XVTOKaBQCPihkhHfoNHlB3CPl9hv0iCXY4Nk X-Developer-Key: i=harshal.dev@oss.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Authority-Analysis: v=2.4 cv=fJ00HJae c=1 sm=1 tr=0 ts=69b91d71 cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=DGDWbsvPyNGGEFbMfx4A:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE3MDA4MiBTYWx0ZWRfX0PcX4xRdf5MT VwZNyNgTbpeR+BUVmHq9ZrxKTbfnqEGX7CBx/eBtioVYLPVdLQ6L7Z6FTL502DkjeeR8jNovwR0 S3q7oYtBLsK/ktKN4Z6oYuqgYjUeunYF/6QuOrURBYnRIbq1Vn/IKBcvEQhQcCrl4rT1iiNQFHw GFph8R0o8FtdGsG3ME+7d0WBfLtwbGPRAYQ5Pw7WFFoLmsDKug1RaELdoJR+J+JIwl+wTV5Cti9 WDmAk76ugTVakAFgIrRhUmoJdgH1tRGSb+fwQahGRYlIw2Ktxjjcw5Q+eNY19GvchC/waKyihTK 77CGeZ6kotT0N08EqZqn8xmHyW6svYq/d//vwJK2NqW2dPo8bGv5pdnpW7tuCNhhijcQpNjPKir tXOC69XhQ9wOorh5va8Nn1ggA9VTZA2PS2bm3aZx+cjHMp0lmrW1ET9MmVo/2tBAfRwkNrwBXsO 1IgV4Bj9UKl5F05ulLg== X-Proofpoint-GUID: XcPVsFbKtr4PUKP8GLEKC0aic77v8VuE X-Proofpoint-ORIG-GUID: XcPVsFbKtr4PUKP8GLEKC0aic77v8VuE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_01,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1015 malwarescore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603170082 Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver de-coupled from the QCOM UFS driver, it explicitly votes for its required clocks during probe. For scenarios where the 'clk_ignore_unused' flag is not passed on the kernel command line, to avoid potential unclocked ICE hardware register access during probe the ICE driver should additionally vote on the 'iface' clock. Also update the suspend and resume callbacks to handle un-voting and voting on the 'iface' clock. Fixes: 2afbf43a4aec6 ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicate= d driver") Signed-off-by: Harshal Dev --- drivers/soc/qcom/ice.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c index b203bc685cad..bf4ab2d9e5c0 100644 --- a/drivers/soc/qcom/ice.c +++ b/drivers/soc/qcom/ice.c @@ -108,6 +108,7 @@ struct qcom_ice { void __iomem *base; =20 struct clk *core_clk; + struct clk *iface_clk; bool use_hwkm; bool hwkm_init_complete; u8 hwkm_version; @@ -312,8 +313,13 @@ int qcom_ice_resume(struct qcom_ice *ice) =20 err =3D clk_prepare_enable(ice->core_clk); if (err) { - dev_err(dev, "failed to enable core clock (%d)\n", - err); + dev_err(dev, "Failed to enable core clock: %d\n", err); + return err; + } + + err =3D clk_prepare_enable(ice->iface_clk); + if (err) { + dev_err(dev, "Failed to enable iface clock: %d\n", err); return err; } qcom_ice_hwkm_init(ice); @@ -323,6 +329,7 @@ EXPORT_SYMBOL_GPL(qcom_ice_resume); =20 int qcom_ice_suspend(struct qcom_ice *ice) { + clk_disable_unprepare(ice->iface_clk); clk_disable_unprepare(ice->core_clk); ice->hwkm_init_complete =3D false; =20 @@ -579,11 +586,17 @@ static struct qcom_ice *qcom_ice_create(struct device= *dev, engine->core_clk =3D devm_clk_get_optional_enabled(dev, "ice_core_clk"); if (!engine->core_clk) engine->core_clk =3D devm_clk_get_optional_enabled(dev, "ice"); + if (!engine->core_clk) + engine->core_clk =3D devm_clk_get_optional_enabled(dev, "core"); if (!engine->core_clk) engine->core_clk =3D devm_clk_get_enabled(dev, NULL); if (IS_ERR(engine->core_clk)) return ERR_CAST(engine->core_clk); =20 + engine->iface_clk =3D devm_clk_get_optional_enabled(dev, "iface"); + if (IS_ERR(engine->iface_clk)) + return ERR_CAST(engine->iface_clk); + if (!qcom_ice_check_supported(engine)) return ERR_PTR(-EOPNOTSUPP); =20 --=20 2.34.1