From nobody Mon Apr 6 23:08:48 2026 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF7273F6617 for ; Tue, 17 Mar 2026 18:08:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773770904; cv=none; b=QCHLciVVkP5TB1rs1IXnr+KDpzd6AchnGqkQKPOWs7GvIrmInMRwpwfk11WuNSnV17aVWNooF5AHOqbpCZZhNJY/buuV1QTtxe4Nj9Tlvzv8KZZPXfmMAfbdvGEll8pTXYuRASPjPZDmGO1slyWq+kGmINH38hLka1yxUvEVNXw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773770904; c=relaxed/simple; bh=adUNrc5DmhRHUleLGmdaxH9/D4sLCU6UUObKtpN1GPU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EhlEVa09KD7aK9ktLEMiqIMsLSG7UKN5++0KpNaRSTb+crU84u/OHN8SMA1L1lrggmTuGgjveQ/r43BkeqgG7subeso9vFi5VeU5DvMnf8EWIb4HQubb6jPqhdJlJ0QJD5PZ7Qq5bRAOfXaZ7ipBHxemDzolEo9niN9OP1moxSM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net; spf=pass smtp.mailfrom=flipper.net; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b=ns0e12ay; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=flipper.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flipper.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=flipper.net header.i=@flipper.net header.b="ns0e12ay" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-439b9b1900bso4029757f8f.1 for ; Tue, 17 Mar 2026 11:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=flipper.net; s=google; t=1773770901; x=1774375701; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zZzaejzhKh2/pl8uBJakl190/CtTYCUrflLlLKsisxI=; b=ns0e12aylGGu33RxMy5d7BDj7PNJ5Gfdb2pS4XmfURX+xhwZI9TVEi8VvIWVSguRGg gtN0kNT6nEBivxkow31CQOnkzm4N4JixjO0XsPkKVNQsvrzY6+j1UDeaccjKuzzgH6bg GQfKs+hxhXdg1pUYCv8migj9FPg9Pt21yKE39RbCBbCLqPUIU2BTBhsg1FEahIe3BRwr 4VnwDD5klgS7jGQzxr+O9Dj2+QqdHQ6mzsaZL3SGS7jmw4fSF1EAb1LyRIOthOuioK4+ tF9dUDOVvJHjSTf2R5hHe7dlDHPDQg4DmqzDAx4jDqzbgqzcHfze1aGWgqYBR+KZi87t C0rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773770901; x=1774375701; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=zZzaejzhKh2/pl8uBJakl190/CtTYCUrflLlLKsisxI=; b=H39wDpUyAeqFV5wkFWsu1xG3Pih7+mXHlKzBfAaITHhprAq6/xIcI3tUpZQBZYrwWS 8YzTvC0+b/lEFCDLdumTwZhFOEFyGNaqeuJlpObyrIB0lHMq/1l+oHuFo6QxGGLNEtI1 lrBi/XfAd+2BSVkYbQro4L3pPA7Bb/CWWgDSPIvg7snxZW3vi3POGnvd4VG7Qrte0vDB tviXFHo6mSRSE8w1diYpJ0NCl5NCrzU3IHnuydNMdzWo+zAKkNzY/bGf7nCFtwgOoFGn 86hqqkc8QzyAAhW3773fAoV8dz1w1dynF8E+vUFyumnZDVQL+AvedKurYX5F3XYhqd/Z 2GbA== X-Forwarded-Encrypted: i=1; AJvYcCU9oFiCkzAF3/+Y1nUPP0EUg4JRU4m8ZBNNmnLRg9xHwtmjBwRaRRZCdk3pOfsDyuJTYkqHVyXRTAQ2q4E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7mT0mIDhFPn4oxtivsoMlQ+lKdIkDi6WvWhgvfF0jjpM8pt03 FvhgTnujkMgS+jzCrG+NrKMfppClkjgfpox6LDNz0+m6vVBzd2zXQ4ReFEAKydxXxRs= X-Gm-Gg: ATEYQzzWqQGQLh49yLVxBqWlnZC77zOX8FmKPrUAeKkjgNgRZzuWumaZOu/QEiN7FhT FKVf66gGMD3aoC5DlsO//YSnewaNabGr/f/y23FUt8sOmQGyULxSpBPcRimOFoa+ZPfggXbMTOB 9kllkQosbNqRFO/LuGI4ueGnGWafrcchog9fyqwYAp2PsfT0sNHgdbXV6OPmNyyOwndfzIpL2JK bIIC8tiynwCI94pXgjGoq1xmKAf+7lFxz6QHlm6bxZD/AjQAEeDoABJnW/TCsTLrKvRiur9NSpX QxBvjaHKr5Oyd5gIC74nw3UUuQ/TwanmuiwT8h5EK9XGQqP227tBnlSqA8mmlF2TAeFWSQR7/5y rOeRH7zxm3AouWCgePMvzoHZ8tQ2Gfl5gI2f8ZlG99j/AV9eXgpaW9A3k/BThDmhO+uc+5E7dwD pVDWLln8okHnFAgwSYa2INWQYOy4R0+kP4JLFsTaA56lw+KWevAvqwsQlhWHteKw6jTRXPOdEMc y511hoQ7DF0zoW/ X-Received: by 2002:a5d:5d13:0:b0:43b:45d1:f448 with SMTP id ffacd0b85a97d-43b527aa5bbmr374980f8f.14.1773770900811; Tue, 17 Mar 2026 11:08:20 -0700 (PDT) Received: from alchark-surface.localdomain (bba-86-98-192-109.alshamil.net.ae. [86.98.192.109]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b5184b8b9sm1436536f8f.1.2026.03.17.11.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2026 11:08:20 -0700 (PDT) From: Alexey Charkov Date: Tue, 17 Mar 2026 22:08:01 +0400 Subject: [PATCH v2 4/5] usb: typec: tcpci_rt1711h: Drop unnecessary VID/PID/DID checks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-husb311-v2-4-03c17c986abe@flipper.net> References: <20260317-husb311-v2-0-03c17c986abe@flipper.net> In-Reply-To: <20260317-husb311-v2-0-03c17c986abe@flipper.net> To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Gene Chen , Heiko Stuebner , Yuanshen Cao Cc: Sebastian Reichel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Krzysztof Kozlowski , Alexey Charkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3767; i=alchark@flipper.net; h=from:subject:message-id; bh=adUNrc5DmhRHUleLGmdaxH9/D4sLCU6UUObKtpN1GPU=; b=owGbwMvMwCW2adGNfoHIK0sZT6slMWTunNEm7lq/wyh58vysd8teFvqaSX7aqZlhekVIp2SHw hzjoNeiHRNZGMS4GCzFFFnmfltiO9WIb9YuD4+vMHNYmUCGSIs0MAABCwNfbmJeqZGOkZ6ptqGe oaGOsY4RAxenAEz1VmuGfxYZ97tT9/Pu1tP4ff9FTPE84X1lm3ofM82yYv76Y4acTR4jw5pHJ93 58wTaY1/eUZrd5S50eEub3t7nTuf2MzMeNDBdxw8A X-Developer-Key: i=alchark@flipper.net; a=openpgp; fpr=9DF6A43D95320E9ABA4848F5B2A2D88F1059D4A5 Existing checks for VID/PID/DID in the driver are redundant since the driver is already matched to the device via I2C device ID and OF compatible strings, and they preclude the use of fallback compatibles. Remove them to make the driver slimmer and adding new clones easier. Signed-off-by: Alexey Charkov --- drivers/usb/typec/tcpm/tcpci_rt1711h.c | 59 ++----------------------------= ---- 1 file changed, 2 insertions(+), 57 deletions(-) diff --git a/drivers/usb/typec/tcpm/tcpci_rt1711h.c b/drivers/usb/typec/tcp= m/tcpci_rt1711h.c index 37cf55ad74f8..4b3e4e22a82e 100644 --- a/drivers/usb/typec/tcpm/tcpci_rt1711h.c +++ b/drivers/usb/typec/tcpm/tcpci_rt1711h.c @@ -18,13 +18,6 @@ #include #include =20 -#define RT1711H_VID 0x29CF -#define ET7304_VID 0x6DCF -#define RT1711H_PID 0x1711 -#define RT1711H_DID 0x2171 -#define RT1715_DID 0x2173 -#define ET7304_DID 0x2173 - #define RT1711H_PHYCTRL1 0x80 #define RT1711H_PHYCTRL2 0x81 =20 @@ -57,8 +50,6 @@ =20 struct rt1711h_chip_info { u32 rxdz_sel; - u16 vid; - u16 did; bool enable_pd30_extended_message; }; =20 @@ -304,35 +295,6 @@ static int rt1711h_sw_reset(struct rt1711h_chip *chip) return 0; } =20 -static int rt1711h_check_revision(struct i2c_client *i2c, struct rt1711h_c= hip *chip) -{ - int ret; - - ret =3D i2c_smbus_read_word_data(i2c, TCPC_VENDOR_ID); - if (ret < 0) - return ret; - if (ret !=3D chip->info->vid) { - dev_err(&i2c->dev, "vid is not correct, 0x%04x\n", ret); - return -ENODEV; - } - ret =3D i2c_smbus_read_word_data(i2c, TCPC_PRODUCT_ID); - if (ret < 0) - return ret; - if (ret !=3D RT1711H_PID) { - dev_err(&i2c->dev, "pid is not correct, 0x%04x\n", ret); - return -ENODEV; - } - ret =3D i2c_smbus_read_word_data(i2c, TCPC_BCD_DEV); - if (ret < 0) - return ret; - if (ret !=3D chip->info->did) { - dev_err(&i2c->dev, "did is not correct, 0x%04x\n", ret); - return -ENODEV; - } - dev_dbg(&i2c->dev, "did is 0x%04x\n", ret); - return ret; -} - static int rt1711h_probe(struct i2c_client *client) { int ret; @@ -349,12 +311,6 @@ static int rt1711h_probe(struct i2c_client *client) =20 chip->info =3D i2c_get_match_data(client); =20 - ret =3D rt1711h_check_revision(client, chip); - if (ret < 0) { - dev_err(&client->dev, "check vid/pid fail\n"); - return ret; - } - chip->data.regmap =3D devm_regmap_init_i2c(client, &rt1711h_regmap_config); if (IS_ERR(chip->data.regmap)) @@ -408,27 +364,16 @@ static void rt1711h_remove(struct i2c_client *client) tcpci_unregister_port(chip->tcpci); } =20 -static const struct rt1711h_chip_info et7304 =3D { - .rxdz_sel =3D RT1711H_BMCIO_RXDZSEL, - .vid =3D ET7304_VID, - .did =3D ET7304_DID, - .enable_pd30_extended_message =3D true, -}; - static const struct rt1711h_chip_info rt1711h =3D { - .vid =3D RT1711H_VID, - .did =3D RT1711H_DID, }; =20 static const struct rt1711h_chip_info rt1715 =3D { .rxdz_sel =3D RT1711H_BMCIO_RXDZSEL, - .vid =3D RT1711H_VID, - .did =3D RT1715_DID, .enable_pd30_extended_message =3D true, }; =20 static const struct i2c_device_id rt1711h_id[] =3D { - { "et7304", (kernel_ulong_t)&et7304 }, + { "et7304", (kernel_ulong_t)&rt1715 }, { "rt1711h", (kernel_ulong_t)&rt1711h }, { "rt1715", (kernel_ulong_t)&rt1715 }, {} @@ -436,7 +381,7 @@ static const struct i2c_device_id rt1711h_id[] =3D { MODULE_DEVICE_TABLE(i2c, rt1711h_id); =20 static const struct of_device_id rt1711h_of_match[] =3D { - { .compatible =3D "etekmicro,et7304", .data =3D &et7304 }, + { .compatible =3D "etekmicro,et7304", .data =3D &rt1715 }, { .compatible =3D "richtek,rt1711h", .data =3D &rt1711h }, { .compatible =3D "richtek,rt1715", .data =3D &rt1715 }, {} --=20 2.52.0