From nobody Tue Apr 7 00:44:53 2026 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9C133BBA19; Tue, 17 Mar 2026 12:09:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773749401; cv=none; b=XbPGy7q0aVroM0AlD9pJ0uewvgAcmzupEAVGDKVaRpQYvYxCel53whTdxw9ky30e4exLYD2IiY06krPVCLusDLpXHNOiKfi+L14OA4MvFh9oYnL0n3qch84vdkSYnOGkv3QuXuMPkmnW1HACC0k9CxWXZETfA0bKT695VAFK4Uw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773749401; c=relaxed/simple; bh=8sN9QwGz77K3Y0zsOpXU7uArFmzQe2gheap8pVeEnU4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WuQuycTzFSPNe+2z9nYkUhDPmgy2vQ06sYCXOebAGtRzjI9VcVNojji1toTCSaWN/bBOQfpuR5wAJMWT0QBoi0sMR7utMdjW/XypXUZcToDG+npoydpRNuRTuuaYOgO8XuYjYpfh2Y9OoXMwXr87OyUxMhZFY0Po/aft6lAoelQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=g7l47nzh; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="g7l47nzh" Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 83D80BD2; Tue, 17 Mar 2026 13:08:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1773749323; bh=8sN9QwGz77K3Y0zsOpXU7uArFmzQe2gheap8pVeEnU4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=g7l47nzhKxdxq0WnQ9WKbaubyK9DDy/rOWBN/K18yMks+nVSzEVcsQjUKhCOm7bMJ kYz8/ms/pzWqgPby5FljU566KXNs+zCRORK9IwREeCnFjIuc+onUgNE7/YZAOJA7B1 ILv4tJstWSyNEi8D/Vr9Q6fukVP95k1+INiKQf0g= From: Tomi Valkeinen Date: Tue, 17 Mar 2026 14:09:41 +0200 Subject: [PATCH v2 2/3] media: subdev: Minor v4l2_subdev_get_frame_desc_passthrough() cleanups Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-frame-desc-passthrough-impro-v2-2-0c93b437d85d@ideasonboard.com> References: <20260317-frame-desc-passthrough-impro-v2-0-0c93b437d85d@ideasonboard.com> In-Reply-To: <20260317-frame-desc-passthrough-impro-v2-0-0c93b437d85d@ideasonboard.com> To: Mauro Carvalho Chehab , Sakari Ailus , Laurent Pinchart Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jai Luthra , Tomi Valkeinen X-Mailer: b4 0.15-dev-c25d1 X-Developer-Signature: v=1; a=openpgp-sha256; l=2335; i=tomi.valkeinen+renesas@ideasonboard.com; h=from:subject:message-id; bh=8sN9QwGz77K3Y0zsOpXU7uArFmzQe2gheap8pVeEnU4=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBpuUSRKhvAcYzmyNIFQ6TSJVZmeNPhmDyM7ko2w YES1+yKwouJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCablEkQAKCRD6PaqMvJYe 9QtEEACvn/pii3+0cC9wZ4C5VneHwojHz6kj48DtcJLnQ6W+HpNhDElBC7mtlvTUi+sYfAJZjXJ xd+BQNXiAGms1noS9X1F3Tq2qqBNdcCcFVoEFQl/TSGsgqU2Vwq5378IPkJAxfsg8b4f5isUzWn S7bfe03OkWbSsgEXjrBCsDLUfE2skhchjdMBAkOWRTaK7sVvPRWe12RMGOAbO0c4B3z94LGjImR F4SHU9EFD7LQXj1mV54R8GU3qEwxbF06VfmPWFhKWqQ9T+KxRzsFIvuC/fqiBslV8M5FM/RCEM9 nZdmVIz3I2MwZaFbIaqhfsewponVrHRudghRk0HDmRecwR24uIkwWNRhv+qFtcRqfMTbvDF916y tP/xGd8i59aNnkXr8GKiC5RKT73NpR9rf0PIXKL7jP4sJf4ZQjl9XUfeth/LXuzzLqA3s+UBQng ac+guOiWkRLasQbAnWKlFtyc2GEKW5LMcOCj9s+ZeT/sudUV99fuGsE08IgzCjgODqsAikAazgN 20APwYsR5W4wVe89zLZTLgQgx4m7iEKUrUonZZe9Sy1PCCLSf0/V2y5GNhsISof2BQY4cmhVWPb dz89lSwCOaQGyTAXcfdCBfAOwX/E7YE5kfktCZqqcTbtvoqlcGA2WU3jl16iWDGJ9OL9qM1jF5y netQnegA5VsyfRw== X-Developer-Key: i=tomi.valkeinen+renesas@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 Minor code cleanups, no functional change. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/media/v4l2-core/v4l2-subdev.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-cor= e/v4l2-subdev.c index 9efd14d4026f..2757378c628a 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -2549,14 +2549,13 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v= 4l2_subdev *sd, unsigned int pad, struct v4l2_mbus_frame_desc *fd) { - const struct media_pad *pads =3D sd->entity.pads; struct media_pad *local_sink_pad; struct v4l2_subdev_route *route; struct v4l2_subdev_state *state; struct device *dev =3D sd->dev; int ret =3D 0; =20 - if (WARN_ON(!(pads[pad].flags & MEDIA_PAD_FL_SOURCE))) + if (WARN_ON(!(sd->entity.pads[pad].flags & MEDIA_PAD_FL_SOURCE))) return -EINVAL; =20 state =3D v4l2_subdev_lock_and_get_active_state(sd); @@ -2577,7 +2576,6 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v4l= 2_subdev *sd, struct v4l2_mbus_frame_desc_entry *source_entry =3D NULL; struct media_pad *remote_source_pad; struct v4l2_subdev *remote_sd; - unsigned int i; =20 if (route->source_pad !=3D pad || route->sink_pad !=3D local_sink_pad->index) @@ -2622,7 +2620,7 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v4l= 2_subdev *sd, } } =20 - for (i =3D 0; i < source_fd.num_entries; i++) { + for (unsigned int i =3D 0; i < source_fd.num_entries; i++) { if (source_fd.entry[i].stream =3D=3D route->sink_stream) { source_entry =3D &source_fd.entry[i]; break; @@ -2630,7 +2628,7 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v4l= 2_subdev *sd, } =20 if (!source_entry) { - dev_dbg(sd->dev, + dev_dbg(dev, "Failed to find stream %u from source frame desc\n", route->sink_stream); ret =3D -EPIPE; @@ -2638,7 +2636,7 @@ int v4l2_subdev_get_frame_desc_passthrough(struct v4l= 2_subdev *sd, } =20 if (fd->num_entries >=3D V4L2_FRAME_DESC_ENTRY_MAX) { - dev_dbg(sd->dev, "Frame desc entry limit reached\n"); + dev_dbg(dev, "Frame desc entry limit reached\n"); ret =3D -ENOSPC; goto out_unlock; } --=20 2.43.0