From nobody Tue Apr 7 02:34:18 2026 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BA8A19ABC6 for ; Mon, 16 Mar 2026 17:48:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773683301; cv=none; b=Bjw3FlzsSUTh/hsdnLARloP9SGNM9zkbjb7f4FsEZXAREx0colsnZtirXE1XwTsCzxYJa0oInJhwnouUqhKzcTEQ9R+1qBP/w7B6fjjkDQT/sOxCSgiH3CKcCprzzHsDizLLXgwabPYTdFyjne7DpJYOTqdJoAxUqln8vOxiTA8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773683301; c=relaxed/simple; bh=9pPeX9Og9XKvw52be7oukqVQdGpyIJ+ESHORa/A+tiE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=mBOwkATlYmqYgWvxz35m97GpXHdYi0KYf3Z5t8oLX33uMusuRUXrVQ99U9Aj215UplQNJKKisnq58Pj2Ke59OuYOEvy6fWLUImYMvkt+A2ygU2l1bAIaRe+xVnFmM7KHJ9q1Dz+r4IIIMnYoI3Bw7zzMqPCVuDfAiej/4RBgkE4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aDWyNGYY; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aDWyNGYY" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2aecc6b0861so19757825ad.2 for ; Mon, 16 Mar 2026 10:48:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773683300; x=1774288100; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=V4r4EPN0k4/5QJ3xUXUMd727+oQtnnk0aBexwlfPH3c=; b=aDWyNGYYyvfMzJYzR/qL5tEWJCK84+mxWfOKUHOdI9e518rPQLV1T+IyRTSQq7OnGX 7cwfQLByzx5jb2I9iXnK+LGCwQ7NKn7ZEE5woutHaVRDmpZkQwaqt69zaaLnS4+E1Gn6 8QuP52Fw1IYIAWO5CDa756OaehBNH3Uj3ukC4tDs7iypz0GBDE0dMkOD6hwQY6bxj0bh cNt4+09VdiLTxE8qrgZqCV2JlIIKrI497cDe41GQ9r2Zz0cRInyeZEfkixguAS5Ftz0u flGMC6TqaKJYDISMIUHpNUX9j8X7TZNykiv9M5RZhHQWQkXIu2ivhU6/D34epoNBly0A UjGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773683300; x=1774288100; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V4r4EPN0k4/5QJ3xUXUMd727+oQtnnk0aBexwlfPH3c=; b=fEGHYAWYW56TxsUrYevRdyE+EbSgXisv72LuftpvAriWBdGEodUM2Rr25fHhZVuBHF RRM0T2UzsYbcSAG2uv7zoa1Y8MbueEP11tW/DWPaQG2jB8RSVXQwbzgRF4lRBt/V+Vde tNlhwWDqUWXkI2K5hwUJbknh7TuHmNSIvLoaFZ0Te3xiyx+TyY/jo48LRjq0XELs7oWO eHozl6A9+QUbD6iHH0M9nyOlz0D1JApk3sNwoaxVkekkYnRg5GIMN9vL3hCt/Q64qJzm Jy0kcWosAHwOjAOU8BFtsWC2Yc3/zt9oJKVjyGfAuomJnZt7ghsGLkChPRN4++pTSsRQ a8uw== X-Forwarded-Encrypted: i=1; AJvYcCWKjFqX/w9FQe3OfQPFtPS56kC7Oh3GsxQfCTF7vKPUXlkk8u5LV9+/pG+avuYOlxv08R93AsvvWtu1XnQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw76lrRmBuPSe9rQTP6f+D+oEBQCpkn3scf4L/z3N4jbBjuDor8 a2fZLRAxoAS5aVPN9MNk3J10QYZZL2Kj6nhvYvXhZwHASzPTHF29P7Ry X-Gm-Gg: ATEYQzxM5UcATWf6iwCfKQ8JWSQ6RT1urm4GRG2b73ig+Xe9eVc3wswwNF2fv7xFFzS flP0KNg+yNW60rgmhTy3ms9NR+mojPaXhY8Jh7w8aqE1yUUjvUYX1lrMmqSOQZN3PJmwvLwIeBK 3rb3qmtGLk57t1A3tqnUBa8OR0aoTV0mxvHtUscGTqIhr41idGYDCswj1vRnt+4B8Nx+EDYA5f3 xzRlaGB3PO/W+nVRx7AYOvNecyoG3z9L+fd/VN7KHrC98hczln5gEavlyqV9dlG2zFkieE3g7sM kmr22yotC1DCv6Z/9qP4RxSBDdjdfx0/sAe7MgFI8cEJzC9jTeJcY40hLnVv3JzIX9khLkNwjZp eBmQ5o9Gp2YenRt8cxYH+XfuKyWXX4EAjQOt10NraNIcJFhtIeqXyZuE7FFxDJm9zvFgN6Wp9pP 9Q7LrnzyOL3FsGwaLHVD0AtQHnim2n8FsGEMu6 X-Received: by 2002:a17:903:41c6:b0:2ae:5345:89ee with SMTP id d9443c01a7336-2aeca9589a2mr125945015ad.1.1773683299538; Mon, 16 Mar 2026 10:48:19 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece7ed6cfsm146391765ad.59.2026.03.16.10.48.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 10:48:19 -0700 (PDT) From: Felix Gu Date: Tue, 17 Mar 2026 01:48:14 +0800 Subject: [PATCH v2] i3c: master: dw-i3c: Fix missing reset assertion in remove() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260317-dw-i3c-v2-1-fa57e6394b1d@gmail.com> X-B4-Tracking: v=1; b=H4sIAF1CuGkC/2XMyw6CMBCF4Vchs3ZML6SAK9/DsChlgEmEmtZUD em7W9m6/E9Ovh0iBaYIl2qHQIkj+62EOlXgFrvNhDyWBiWUEVoaHF/I2iE1VpvBdcK0Csr5EWj i9wHd+tILx6cPn8NN8rf+EUmiRDvUshP15JpWXOfV8v3s/Ap9zvkLsIt59pwAAAA= X-Change-ID: 20260316-dw-i3c-e7a36bc90682 To: Alexandre Belloni , Frank Li , Philipp Zabel , Aniket Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773683296; l=2173; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=9pPeX9Og9XKvw52be7oukqVQdGpyIJ+ESHORa/A+tiE=; b=0Tc3dLmA/m1BZHxHoc1k1QWs8lf+DLHIWaHK9TqAhUxBqTcvrMK+uroa5ZKf/zu57mNLGyu7p b1m2OFB6nOLDe/dhIhfk8AyxnoWeITcGHfRrdjld9j64eGwzCj4q+/6 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The reset line acquired during probe is currently left deasserted when the driver is unbound. Switch to devm_reset_control_get_optional_exclusive_deasserted() to ensure the reset is automatically re-asserted by the devres core when the driver is removed. Fixes: 62fe9d06f570 ("i3c: dw: Add power management support") Signed-off-by: Felix Gu Reviewed-by: Philipp Zabel --- Changes in v2: - Switch to devm_reset_control_get_optional_exclusive_deasserted()=20 suggested by Philipp Zabel. - Link to v1: https://lore.kernel.org/r/20260316-dw-i3c-v1-1-ab41904fc780@g= mail.com --- drivers/i3c/master/dw-i3c-master.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index d87bde3f7700..f3dabd8d1225 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1606,13 +1606,11 @@ int dw_i3c_common_probe(struct dw_i3c_master *maste= r, if (IS_ERR(master->pclk)) return PTR_ERR(master->pclk); =20 - master->core_rst =3D devm_reset_control_get_optional_exclusive(&pdev->dev, - "core_rst"); + master->core_rst =3D devm_reset_control_get_optional_exclusive_deasserted( + &pdev->dev, "core_rst"); if (IS_ERR(master->core_rst)) return PTR_ERR(master->core_rst); =20 - reset_control_deassert(master->core_rst); - spin_lock_init(&master->xferqueue.lock); INIT_LIST_HEAD(&master->xferqueue.list); =20 @@ -1624,7 +1622,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, dw_i3c_master_irq_handler, 0, dev_name(&pdev->dev), master); if (ret) - goto err_assert_rst; + return ret; =20 platform_set_drvdata(pdev, master); =20 @@ -1671,9 +1669,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, pm_runtime_set_suspended(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); =20 -err_assert_rst: - reset_control_assert(master->core_rst); - return ret; } EXPORT_SYMBOL_GPL(dw_i3c_common_probe); --- base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900 change-id: 20260316-dw-i3c-e7a36bc90682 Best regards, --=20 Felix Gu