From nobody Tue Apr 7 01:16:57 2026 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8720371878 for ; Mon, 16 Mar 2026 22:19:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773699581; cv=none; b=dQsoSnuPuS3SuiZ25nlwu22cr20eQRuzQ6oKZ4rPvAjCiOgc16QN2LZkoumLmHoyRdnDJ2vMkPgOw35gRWMjcSranxDVvPIOAV4cRQvinBd9Pug7UhbgulrR6gxOK4tPVPOyWv6+QQ+JyqJuzjGk2ZYPI1i8QNo50V5kAxmiqs0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773699581; c=relaxed/simple; bh=uM8xgUxffcfZ4kAgfdU9p+zDofvgv7fXsInaDAtiB6Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=N/lInByMqH5ZEG8ooDNH1QH6pU4JhakNleOe1B1QWXHpSqOse1L7DEDnY3hbDNzVgP3FMGasNAumXnt8FhN0NDzSPFYrZzW52D7HD+6FyLLJf0WE6irwzDAPeDuwOL8Ek5rqvCpC/O1hzBRb8fwp00q/I7NC50xZekWTIvCA4/0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JCtbm+/1; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JCtbm+/1" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2bd9a485bd6so3761879eec.1 for ; Mon, 16 Mar 2026 15:19:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773699580; x=1774304380; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IvlaMzjqwAVznwWNgyNx6/MBIRXqUaZTnYJ6kz1dy5o=; b=JCtbm+/1WEyXebRnyW6N3VHjhuJ0lgCLo74keo4+FZmq5wpQNoOoOEkpOc66u+1Bg1 NcyrWyTw6/iGOpQmIX68VebVjNlqAFkJU45HeI4yDEboLWyUGZVfaquwSGXhd5Kkb0Wx 2yVShCC7mJcnSsWAgwevGDDPLp+DQJwPzORGg12WI8L4CV25yfcG3oOyW07KuvrD2nv4 TbTklv5mcbXn3e8K/IwmUZJUzHCq37xn9Wr0f/tCyto7zi5RaAF4vPRzhiNRfOrV+IMg 8YC1eaKSvliQJjqqRHYaXK+P3b9Nct+zam2IIVoT/nm2vqXGdxhHoUhlM9yf6t+Etis3 kfzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773699580; x=1774304380; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IvlaMzjqwAVznwWNgyNx6/MBIRXqUaZTnYJ6kz1dy5o=; b=pdB1QHBdVMBGWQfVZuYZ5CKpJlNhtt7Th+EKRsMgnyHEhz7WHgXGPZunIIKKvZ0vos zpQaDzodyBvjvt5U9xjxJqJcMbs8rhwEb/Deb3IT6Vgm74Flhxg8D9A9PX6uBJcceV9n FfdHK2BSEtlLV+3S4XVt7Ha4ajHzlCsY+gwhhxx2vcIw84mIY6clGUauNSerYsjbIXES md1ggzPNZq6vrXPhYJK3Jj9MsSiUpuvgJ8L5pzCV9Wb5BLFSUCpFvmjSNfHMRUZDwYo6 GCQsb81ERcBb7pQxe5J1TWj0jo8oo2YVfrER/vFW8TNp0EsrQBIBRnEgsClbb+z0ITSl De+Q== X-Forwarded-Encrypted: i=1; AJvYcCVxlOUauuJK0t6E5hi/ZJjnJ6UIyUOrzuCX8pQ+fd2wWAB93fS4qtTT9qLOZopvYM9U49NKPGHu2p2fsRw=@vger.kernel.org X-Gm-Message-State: AOJu0YwSRV4ZG31zHLWC7O7lPtxq4kl50nTHo5bWYO8vNiesFopTboOj /kjuIIiINRqbTf3wdZDE4xm2cvO9nOya9JhqiiLFYh5O68u8H4rdwe/e X-Gm-Gg: ATEYQzydDF0T9u6XbfmhDB85Yi8fmNckgWC38EcCFni39kzMVXaneYQ3exX5YaYP4y8 afc0VzXkmP8izJ4gq+Duv+7RRdoYEBo3Op6UFytGBB+NdhhpIxUhMyqEbxlMzG5+eItKt6NlOxL 6fAy2MmyJ6zWdkfGd6E36W8jqXBOWScphlUOlWRiR64GxyX3PavMmc/S4YQ2Ilb+nkmL64ChMW9 aQL18nLo9YCgVxFM+BSs7l/lH7oFNsLqHuHgo3rgXATVClTbXT3LuhZVB082sBH81AVhhH666U7 /E3i6EXHGnSMIbe3BX4fmwQcWTH8ptsbq/c173umHkOuE5XQqC3l45b9wT6WgMI+rF8pcUSB0vG si95UZc9xGoptt5BJgB1iS3vj4GMbpj7Ao9m7a/koKKiDLwamWFq+0S3Ti0vOsxshOMM9gv4ArZ 6075TwOM0Qn5w9lQtnr6j3NWx/4eOLJ8mBavtjBjqIUXS0vpM= X-Received: by 2002:a05:7300:bc8a:b0:2b7:32a6:82d1 with SMTP id 5a478bee46e88-2bea54818a7mr5535943eec.13.1773699579873; Mon, 16 Mar 2026 15:19:39 -0700 (PDT) Received: from mjmachine.localdomain ([131.255.96.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2beab526d61sm19548389eec.17.2026.03.16.15.19.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 15:19:39 -0700 (PDT) From: Marcos Andrade To: Greg Kroah-Hartman Cc: Ethan Tidmore , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marcos Andrade Subject: [PATCH v5 1/2] staging: rtl8723bs: Replace network magic numbers with EtherType macros Date: Mon, 16 Mar 2026 19:19:23 -0300 Message-ID: <20260316221924.4904-2-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260316221924.4904-1-marcosandrade95963@gmail.com> References: <20260316221924.4904-1-marcosandrade95963@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace hardcoded magic numbers for network protocols (e.g., 0x0806 for ARP, 0x888e for EAPOL) with their standard EtherType macro equivalents (ETH_P_ARP, ETH_P_PAE) defined in . This change improves code readability and aligns the driver with standard Linux networking definitions. Signed-off-by: Marcos Andrade Reviewed-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 7b18be891..4062fe0c1 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ #include +#include =20 static u8 P802_1H_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0xf8 }; static u8 RFC1042_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0x00 }; @@ -2026,8 +2027,8 @@ inline bool xmitframe_hiq_filter(struct xmit_frame *x= mitframe) if (registry->hiq_filter =3D=3D RTW_HIQ_FILTER_ALLOW_SPECIAL) { struct pkt_attrib *attrib =3D &xmitframe->attrib; =20 - if (attrib->ether_type =3D=3D 0x0806 || - attrib->ether_type =3D=3D 0x888e || + if (attrib->ether_type =3D=3D ETH_P_ARP || + attrib->ether_type =3D=3D ETH_P_PAE || attrib->dhcp_pkt ) allow =3D true; --=20 2.53.0 From nobody Tue Apr 7 01:16:57 2026 Received: from mail-dy1-f177.google.com (mail-dy1-f177.google.com [74.125.82.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C33C036D9EA for ; Mon, 16 Mar 2026 22:19:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773699585; cv=none; b=gYwi7+4bJc6lkrJ+T2S1tC56JuBdpl9ateszZXxyluu+Wi0XKH53QC3XiR+CoxkTj+ZyQC1mytujng2TNrYEVb8uhQN2MA4mkdzZ8a/xU5IkYNnyZJBunSMFAbjsoVsMa3pXcPp8g36KsLe/BHBws/xJmAAjI1RCiAVf8kRW/yY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773699585; c=relaxed/simple; bh=CM/X8S0vcpdZ3crm2UrFKGdMJv12g+UEOk4qsMehcw0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FRwo2GC3UoiDj6N3nU3xGSSxEfO/jTxC3kvgA1Z5cNze5idwWN8vxnATWISWwEIQGXifPhG86sqOZLv+GAfOeQqWTZUp9/Hns0rn4o4o4jpUxEGk/K6ZuLbSvfMoo/MOUge9Rn6gyD8nGeN/R9+5ZC2TvxF/+X3Muujmcq0JVaQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=drk1Rc0y; arc=none smtp.client-ip=74.125.82.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="drk1Rc0y" Received: by mail-dy1-f177.google.com with SMTP id 5a478bee46e88-2bdd40d3c61so4485015eec.1 for ; Mon, 16 Mar 2026 15:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773699584; x=1774304384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JDEKwxQMYWzrzuldYy7udy2QmtY/Hmc7D8YU2PTvK+0=; b=drk1Rc0yVY4vePPZbAwuizWfN9pM3ALjkgh3qPFWeCmvXtp91RHSi0Yyg+SZ1qi7+b 2w/4q0v+Pg2aCeR4QkdeOUZDicDqeEaGZ1k5ULxrpEiLZKwT9eLjgVtzGvqloQ6JhXYc PRZmkAKWjUEJYEqEE/f8GKCpIpup6SYUD+Uh/8jxJMrDz0HRTQAjbWlK2iD8cMc6QU2e 75ifKDWBOjPT7mmQ+fpK/AdypB1QGjclkpJ/7QcwPYp5BjIcRBsAsmt1H0Cf1VAmAH+k 3RWDKPeOGVmD8msiKhpvQKh2MBEOJP1w/oVUqy7P1g1Tgn1T2JQebFuMYqjGr/+0T1eE URTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773699584; x=1774304384; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JDEKwxQMYWzrzuldYy7udy2QmtY/Hmc7D8YU2PTvK+0=; b=ElxJDvAhvil65FLKMNurd3lD94F27yzdV2HJ2f0y96p8wmZN6Q2UAAZz+2Ywgo1E2R 6Elbh77vBSbo13USpau5dSxuOpQ8K+Q6WSrbxf2GvexlpHgin0zk5P4JjsUPJZ+Rj9NT Xg7tQd93qRMWLB5JJ1zPIPk0aVAq3j5Z/gmS2mZDCuJmZ0SPZI+dQz24SYsz2E+9guYn XXtVBoWS4MHerb8jEHQvAhHu6Qw27Jd1Hj7LS+8GigfC8/KSpo61K6uiy0BKLT5KYkzC S1tPPeK/f4tUmeuRt96TRjd9pJm3utigTU9e+Pnsz8+yX4mMKr2pA2HjrUHIYZRUp3kg pyVg== X-Forwarded-Encrypted: i=1; AJvYcCVPUkSDBMkYXphseCPI3ZMDhcJrqQjSQZy7evCAuEefIPnKpdRKF70Ks6QyaPXjc8G5lolbGWXWbm5qtps=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9jC/aAXXQm3LQyFh8MBaNmP2ImliCOLVywZn5iHinMm53NUqg OBpg4u/a+lT7dDQ6Ena6nFzLaVRrXfEXokkrRCn79GNlPKx9GCyoqb0t5Q/rBw== X-Gm-Gg: ATEYQzxOPOM8UauKsz+hGtgBUc4zkOn/Hpk5oEAImrPMVM3EBQS+KT5OdhaWqfM2vha yr69BStPI5w1upuK3N6U6oUAdctuJBf4IS6XOKf31refXgwNckgYfGktvJNq7OCIu9m1uLj7lkq FEZ7PfF6wk+TuC443bgb+VCqsHnKF/591MPoGq3sJWb2hxXMz04Tu37RSY0msKOhKBnZyorU7xk StgMIpaZAg6u19cSnvUctNReV2OOdszez+vja+03hJQv+2AKfEOlWcF3aRWsoXej/qSwznY4EJL 6LlpCzNegw+660GHctw5Ex0fwd7jW0n/JpBYBzqMOmc4ifkGkP0olAPW2DaZylylmg2LAfXnL4c 4exkKsy3i/lbmClDSy1dEEBs4OcRWuFO26b0iRWJ4Jprbf8hnMCIRy5e7yFSxCdie1hWU67FFHY fpautdSvp5Hl1xYQq6QIEbKkJkvEGyqNLzEBkCRY5f5OSDVLk= X-Received: by 2002:a05:7301:d19:b0:2b6:af85:dd2d with SMTP id 5a478bee46e88-2bea5523ab7mr5892838eec.32.1773699583971; Mon, 16 Mar 2026 15:19:43 -0700 (PDT) Received: from mjmachine.localdomain ([131.255.96.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2beab526d61sm19548389eec.17.2026.03.16.15.19.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 15:19:43 -0700 (PDT) From: Marcos Andrade To: Greg Kroah-Hartman Cc: Ethan Tidmore , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marcos Andrade Subject: [PATCH v5 2/2] staging: rtl8723bs: Replace msleep() with fsleep() Date: Mon, 16 Mar 2026 19:19:24 -0300 Message-ID: <20260316221924.4904-3-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260316221924.4904-1-marcosandrade95963@gmail.com> References: <20260316221924.4904-1-marcosandrade95963@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace msleep(10) with fsleep(10 * USEC_PER_MSEC) in _rtw_init_xmit_priv(). fsleep() is the new standard API for delays, as it automatically chooses the best sleep method based on the duration. Suggested-by: Ethan Tidmore Signed-off-by: Marcos Andrade Reviewed-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rt= l8723bs/core/rtw_xmit.c index 4062fe0c1..dab16851f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -5,6 +5,7 @@ * *************************************************************************= *****/ #include +#include #include =20 static u8 P802_1H_OUI[P80211_OUI_LEN] =3D { 0x00, 0x00, 0xf8 }; @@ -129,7 +130,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, st= ruct adapter *padapter) /* Tx buf allocation may fail sometimes, so sleep and retry. */ res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ += XMITBUF_ALIGN_SZ), true); if (res =3D=3D _FAIL) { - msleep(10); + fsleep(10 * USEC_PER_MSEC); res =3D rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ = + XMITBUF_ALIGN_SZ), true); if (res =3D=3D _FAIL) goto exit; --=20 2.53.0