From nobody Tue Apr 7 02:34:18 2026 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3765735A392 for ; Mon, 16 Mar 2026 22:04:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773698697; cv=none; b=ru0lJ+I9Uvyi9bppMjsWkjxTfnqShZBjwhNkvauGvgfYw+1DJtL8aWaGW9t+NMn8AIxMuvBG83RgBylfNnLWG+BSiVgERz1MObUhoPNrUXD5uyUEw4LLATF0TQuQQD1S4AxSHOHaE49G4UBzkXjPmsFaUks733+4D/TOTxhIafM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773698697; c=relaxed/simple; bh=YDf0vZr4bnJMoapPE03NGmxzvh6KF5ka7pzfxFBWHgg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=T6SiUQpQkhSeNN43B7B0NSwzLA00muq1khKqMnCPk5lrDQLWbn2sksW9qutXj4/Mt5KgVbOgvl6OY7sa4XkpkOKwAsVc77vmwEJeptQyzMRXzIvRgteQBKImV/DSnFx6wpih4kgigvjocjMbJu9s+WIKGGPsmXNtEmyDdLe3NnE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RLCtxvkk; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RLCtxvkk" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2bea8220c38so1953439eec.1 for ; Mon, 16 Mar 2026 15:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773698695; x=1774303495; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KC9m9ym2S0i/PiPwmxbORLStDxWF9dLkktnO2ZE6V2c=; b=RLCtxvkkDpI9vbqFLe9Kmo1wy76QacJAVgtf66dfg5+7Xy/DIVXfob4dfUczF3Tok2 hETIR4+dNtLS7qUQ4ofNsoIEuK400F5S/xGLCDay78uaH/m9A4wNb2P9OLH+JvaXjqRq Bf1yTivqv8lSGJySHB7cinOstZIgFobfIJqV/Td4QWZN+KVU44ZVSgQ6/KPJh/b1chQk nSslSlav2Mx5eS4ZZ/r910fABH02N2KW5I/ou5l2ONb0C8OUE4YLONalkzXMxQp1LkOc SRK46CYSOTD3ZBXvErMB9sdxrATUkoE+moa9H+Dw4TCxO36bxEl+0xvjHyxAgo9bQ8m7 +yug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773698695; x=1774303495; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KC9m9ym2S0i/PiPwmxbORLStDxWF9dLkktnO2ZE6V2c=; b=XNfM3PPhhjOuGzqUXvKbTYyIe2kcLSNXn1D69+m536eMdEVbwfzAYQ04jQyLKVd0vB FobYTZ2rDmbumM2Orz6unajdfOf71tJHYH7lDPq6570lCy4WslTcB9iSoIYsronT91Hk JhhP18x42kc5tKYZXXpWlRajGY4ng+hCMZpsVgIxOz8EF7mbzcJCF8Ix489hhoRpI8y1 1fuxBShL4ZhnUhbXsdOWK7pmft6DTcfuUb6SW6eyEQ1mAzFABs7ApNXvYBUGKH5vyqvH swMpOUaIOuZZhtWNjM714K0MzZ1knToBo7GHdhV42SYh8J2rQ0mzXCGbzpUl3Xskiyn1 TMWg== X-Forwarded-Encrypted: i=1; AJvYcCVVW1BZxFRn0f42ZR0b6Gin1uk/0pjcmIdHNNnj7FbduoNwL9EIuf4pMYgzADk3TJRZw7lu0Lx1c3JwIac=@vger.kernel.org X-Gm-Message-State: AOJu0YzF0jwzYNVZnZCmchapTJiB0dcb1NbX4y6LRWplEKirX4tq5Z6d VangNut0hQMV23ECCt/geJmOL90Wiyh3TJLwDFUdxCC4mBZxCjE8e7Pq X-Gm-Gg: ATEYQzy8+h/taN++T33XGNzy7eCn50OHE8qz/4mUT2ZKPj6ZfHuutnKkA+5lxJy659r z01wSO/ZopfbyuWyBOF8NnJ/E0ybmEE3PsqD0/ffxBMJj3A2bAZZWlG5zZZ7kw1z7dxbLGTLcS5 x4sb64rqjlooX1KiEAJsABFbUCeAIiiDBq6mQemDUnRUZEH1i4/Gic1jhpKPjW4INtjVPyTuWA6 AxLs8IW/gOJk4V0KMlHtyM3A9Dr+4VuTbV0TlbJ+B3L9CWagFt5mzOP2BlKxFBUviqKp7y8KtSO 9slhjOm1bzM/6ARwB68FBT8y+zSGbEkJ8EDXOPgpZCjb5l2wUsJucDY52XJKa293G9V0EnWRGEL 7J0b78FZH+gdIhWGOgZUTAEVCotn5mTXyCypQLgpBM0rI4ET5l/eJTzcfzKzEYmC6R1BSKQR/PZ v45GSP0X6pEvnTwv2IXkLJWocZDjY5D/gE8EoYqwPCQDdvKGE= X-Received: by 2002:a05:7300:fb86:b0:2ba:931e:7021 with SMTP id 5a478bee46e88-2bea5720289mr6586401eec.34.1773698695168; Mon, 16 Mar 2026 15:04:55 -0700 (PDT) Received: from mjmachine.localdomain ([131.255.96.168]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2beab3a0b3fsm17238753eec.5.2026.03.16.15.04.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 15:04:54 -0700 (PDT) From: Marcos Andrade To: Greg Kroah-Hartman Cc: Ethan Tidmore , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marcos Andrade Subject: [PATCH v2] staging: rtl8723bs: remove unused global efuse variables Date: Mon, 16 Mar 2026 19:04:35 -0300 Message-ID: <20260316220435.2249-1-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove several global efuse variables from rtw_efuse.c and their corresponding extern declarations in rtw_efuse.h. These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely unused legacy code. The driver currently maintains the efuse state properly within the 'efuse_hal' structure, which is encapsulated inside 'hal_com_data'. The removal of this dead code cleans up the global namespace and resolves multiple checkpatch.pl warnings regarding CamelCase naming conventions. Verified by compilation that no functional code references these variables. Signed-off-by: Marcos Andrade Reviewed-by: Ethan Tidmore --- Changes in v2: - Collected Reviewed-by tag from Ethan Tidmore. drivers/staging/rtl8723bs/core/rtw_efuse.c | 18 ------------------ drivers/staging/rtl8723bs/include/rtw_efuse.h | 19 ------------------- 2 files changed, 37 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 98b15ca10..0e550c631 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -8,24 +8,6 @@ #include #include =20 - -/* Define global variables */ -u8 fakeEfuseBank; -u32 fakeEfuseUsedBytes; -u8 fakeEfuseContent[EFUSE_MAX_HW_SIZE] =3D {0}; -u8 fakeEfuseInitMap[EFUSE_MAX_MAP_LEN] =3D {0}; -u8 fakeEfuseModifiedMap[EFUSE_MAX_MAP_LEN] =3D {0}; - -u32 BTEfuseUsedBytes; -u8 BTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE]; -u8 BTEfuseInitMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; -u8 BTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; - -u32 fakeBTEfuseUsedBytes; -u8 fakeBTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE]; -u8 fakeBTEfuseInitMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; -u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; - /* 11/16/2008 MH Add description. Get current efuse area enabled word!!. = */ u8 Efuse_CalculateWordCnts(u8 word_en) diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/stagin= g/rtl8723bs/include/rtw_efuse.h index 936b204b8..191ffdf59 100644 --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h @@ -68,25 +68,6 @@ struct efuse_hal { u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN]; }; =20 - -/*------------------------Export global variable--------------------------= --*/ -extern u8 fakeEfuseBank; -extern u32 fakeEfuseUsedBytes; -extern u8 fakeEfuseContent[]; -extern u8 fakeEfuseInitMap[]; -extern u8 fakeEfuseModifiedMap[]; - -extern u32 BTEfuseUsedBytes; -extern u8 BTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE]; -extern u8 BTEfuseInitMap[]; -extern u8 BTEfuseModifiedMap[]; - -extern u32 fakeBTEfuseUsedBytes; -extern u8 fakeBTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE]; -extern u8 fakeBTEfuseInitMap[]; -extern u8 fakeBTEfuseModifiedMap[]; -/*------------------------Export global variable--------------------------= --*/ - u8 Efuse_CalculateWordCnts(u8 word_en); u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data); =20 --=20 2.53.0