From nobody Tue Apr 7 02:35:49 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC8C2363C4F for ; Mon, 16 Mar 2026 21:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773695576; cv=none; b=J/RAIv/uhuZOToowo+KUXmzlOe715lr+1PU6pjVO3Ivd1jNzyXfOpCKevuTqGt3xpAKEO4OYDdeQWMVYVrXoQL2l06fRfHiNYekRQuRSTSY5x96BsEDEsQ5UiXFlsNvPTklBOVV560zuEebmqRYggAl7L7gDKUlRXGyaIBLMgiE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773695576; c=relaxed/simple; bh=zPnFkQZjQ0RG3q4nEVHKTYmsaNoCW91HThqa/P4wQnc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UAoghud3fodK63LyGITOqmzes/A6mahwUL30CRPoYgJWKRz4cJrHG5VhNDgOPoFuEMd9fZU4RVQbAqbqdxEL1Thp4FKzoLLBd+fNhulocxUWwaQ+H1OpRF/seEPKzLyznASoJ6Wwfh/89BfsTdR+LMKGWSFwwSo2jrpTBGLIY2M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hqG2chDe; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hqG2chDe" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-35b98def50bso1216479a91.0 for ; Mon, 16 Mar 2026 14:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773695575; x=1774300375; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ah6ADGtUrKQ4BhiZqAnHVlA7ObzF04FCaRZ9gATsGa4=; b=hqG2chDeF7XYv5Ygc6zwokAjqi4NqZD16Oy503MzpCohbWSPtP6xpRj+QctN7EzfML 7o0crsh1hYPAjr9A3hTtLArUE5lGsppSgFyj+oq2zHhJWkwQ1l0lF8QZrD87Mjxi/Dfx 9cCEIBGkCsJmavDIL2iBT/SUaJnWbMXwLHfRnHZc398dXHQ5jlaF2BN0I3X4MpYZdP6i sw+S5YZN2hDzaP/76o/MIVJuGPRFQZ4P/9bSDS9+FSyNpl5FP0P8jYkjTEh//ObZrr+w LidsNnvlmFjcW0ATwWsS/aQ/5bH6/BtjTgGES+eBIIWilA9EJEuYwfVERQ1xtfGOZYB1 ofYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773695575; x=1774300375; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ah6ADGtUrKQ4BhiZqAnHVlA7ObzF04FCaRZ9gATsGa4=; b=FrW6uJzwE0pyjSmPVFEF91eBhs5egkpteYPyqy1CxoXZgeoZR0D1rzuU3+gqaMIMa6 qRZSUlXemTvr74ubBPSIaR9wVQErk0j8wv6RUKspmU9oKy39kw7O5Tbuheyy4KMwLRfT 0BSuD9d8jSu4640rqb8HAbJoLj+uFoFwshmnjmQ2bSBxLMx2Ifd2M4KocfRNETBBiO7O 8TxKqAdDYoIE++ejNF4YTR2Efyiz90Dgsunj3FQT1D4/FlWk1tv8LZw+iB16/N46ZHOA H1N46GyTDaLBTOrjyT7bCdg/8VmgLRxyP1+Nk3fZvRH4l/teDZQM/+kKFIbQLHwk5Sxv HuNw== X-Forwarded-Encrypted: i=1; AJvYcCU/izevIsURsOV+EMLlHvB4Wgld47qMolKxVjbpdOOlUTUYJfTTTvKHJ1NebIFffipqIiwQ5Raa4lqznck=@vger.kernel.org X-Gm-Message-State: AOJu0YyFNb/ij7nnJcp9xx2VxfbJjfPZo1TYBeemv7JnNUGgjRRuZnNR v6Y3LClJFiKtaNcKnYzv9sXjOjZ97C1RCy7UDgjHuCCRn5HfQAQuT3VHTWwt2J7r X-Gm-Gg: ATEYQzzEThT0qR2PP7PzsaGygbz8kbr7+ytaH4P7tD85oBFN2PKkgEUsdsbT6ly6VlA MqRB2E2n6VH1D+KypLTwAK2RsJZmZjQrBu5AQJDoR7y9/cutXPaXwFnsWL8YHXRy6HVaK2GnyTg 9Dwp+SPfexR3a793KfbPhZy9jdlzX/Slo99Sq/L/NhSczTDK/8wVP5gTcEkwIz/00m/fAndZS2j 183AsLQR/NmupzZDobEMl4Qd41LFNG04Q0M3eh7YK7cUDlK6tLOkm3Oq0/mo4W1dV+9rvCgK2Ni /Ull6+67dklahAPbFM1rnOGKMiwPizWLgTfUYY5QnZgiXYSwJ1uStAfg8bdEi+k5bNfjJhLDk+w uaE5n/J0qmL4XNSchGXoTyiuEo8wFLlTpqaiYC7Tylz+VkutN3Reav5ea3I7tiJIdpTQ+itcPTr kqLxYn6yfeqnSDPuU4HE2ShL9mbsKKWZKKJwOZuRhsOHk5mycaglOSVszFHnfYecfLiPlOvJppA kKvlhIS/xVxHCUZ X-Received: by 2002:a17:90b:1d03:b0:35b:9a4b:24e7 with SMTP id 98e67ed59e1d1-35b9a4b261emr5101571a91.14.1773695574146; Mon, 16 Mar 2026 14:12:54 -0700 (PDT) Received: from localhost.localdomain ([110.44.115.173]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b93d07292sm2676546a91.0.2026.03.16.14.12.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 16 Mar 2026 14:12:53 -0700 (PDT) From: Shuvam Pandey To: Andrew Morton Cc: Andy Shevchenko , linux-kernel@vger.kernel.org Subject: [PATCH] lib/tests: extend cmdline next_arg() coverage with mixed tokens Date: Tue, 17 Mar 2026 02:57:49 +0545 Message-ID: <20260316211249.88601-1-shuvampandey1@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260316101227.15807-1-shuvampandey1@gmail.com> References: <20260316101227.15807-1-shuvampandey1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The cmdline KUnit suite now covers quoted values and the bare quote regression path in next_arg(), but it still does not exercise a mixed sequence containing an empty value, a bare token, and a quoted value with '=3D'. Andy Shevchenko suggested covering a sequence such as "bbb=3D jjj kkk=3D\"a=3Db\"". Add that case so the suite checks all three forms in one parse stream. Validated with the arm64 cmdline KUnit suite and a W=3D1 rebuild of lib/tests/cmdline_kunit.o. Suggested-by: Andy Shevchenko Signed-off-by: Shuvam Pandey Reviewed-by: Andy Shevchenko --- lib/tests/cmdline_kunit.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/lib/tests/cmdline_kunit.c b/lib/tests/cmdline_kunit.c index b5c7aba65f43..af44ae9e92c3 100644 --- a/lib/tests/cmdline_kunit.c +++ b/lib/tests/cmdline_kunit.c @@ -175,6 +175,29 @@ static void cmdline_test_next_arg_bare_quote_regressio= n(struct kunit *test) KUNIT_EXPECT_STREQ(test, next, ""); } =20 +static void cmdline_test_next_arg_mixed_tokens(struct kunit *test) +{ + char in[] =3D "bbb=3D jjj kkk=3D\"a=3Db\""; + char *next, *param, *val; + + next =3D next_arg(in, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "bbb"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, ""); + KUNIT_EXPECT_STREQ(test, next, "jjj kkk=3D\"a=3Db\""); + + next =3D next_arg(next, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "jjj"); + KUNIT_EXPECT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, next, "kkk=3D\"a=3Db\""); + + next =3D next_arg(next, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "kkk"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, "a=3Db"); + KUNIT_EXPECT_STREQ(test, next, ""); +} + static struct kunit_case cmdline_test_cases[] =3D { KUNIT_CASE(cmdline_test_noint), KUNIT_CASE(cmdline_test_lead_int), @@ -182,6 +205,7 @@ static struct kunit_case cmdline_test_cases[] =3D { KUNIT_CASE(cmdline_test_range), KUNIT_CASE(cmdline_test_next_arg_quoted_value), KUNIT_CASE(cmdline_test_next_arg_bare_quote_regression), + KUNIT_CASE(cmdline_test_next_arg_mixed_tokens), {} }; =20 --=20 2.50.1 (Apple Git-155)