From nobody Tue Apr 7 02:34:27 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BAEE3DB62A for ; Mon, 16 Mar 2026 18:44:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773686689; cv=none; b=N7/hemca/yu4chDDOkPgYLjobWucxlH3gPugmLuwKyq+zzOyQS+NlN+sj+18J+McqirEoRW2d5gn6J3cgFC3u9W5RwHpUrV4LWMeHzHyWHicxxL1EfBSQqBX8iwm9CoJ9AmCyvPL85Pu4GqIb2XWS4lPUIfaeagKoZBeJhLyqDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773686689; c=relaxed/simple; bh=jE4D1swpL8Um6LGyMEDXGN3uSXFJdqxsXdNj0I5lHtg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MDLXvVLB/n1yXRTd4RCQpumTHuaqMGAQj404Fu4ND1fS5GkOytzJ/y+K6aVLFU4dqd7Nxq7EMt2T3nGzTgk5CL+P6OyKwLTQxOz1ygGK3daJpITWKbdepq5BQNS8vUxfYE+eKW0TyRbM5J2eixS9/n4cVSDJPK/DQ0Eu9sTsN1o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WgNVbvl9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SypG+PZO; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WgNVbvl9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SypG+PZO" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GECMuU1639209 for ; Mon, 16 Mar 2026 18:44:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=0ttFQZOfTjABcr/CRg+BE/xbEpdFtWOpPO3 5ThpdIfs=; b=WgNVbvl9R/3IIJBd77oCtMTQp/ywFS2m0nIkqHvpJ4tuJ/lDwun Vfl2RqWP6pkpyhgW7bX2AekxSUJ0rtmUBbdt7hYHmvP7x+5muph49RvgUvqbYHyi DKf87yM/M6cMfCWxiFgkNU9S46jdeyTOWc7YYx/0JCiR5I8BzHvKk70zLi12zZn9 uNeJM7Qmul4zw7C5mmJsbEP0C8BMhehTSKB/f3XDYO1TbALh03ydke2ijqCYAUUc /WBYMtq2mALi9o9QTxqvC7QxoHi9oWcLTkkVKbaHvdb8v/nlEzBjzCEwudCTiegz tbtPu8F/yCMQFTSsj2ta/7kNkXvjdnwYdSA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxke092d3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 18:44:47 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c7387c70046so2721115a12.0 for ; Mon, 16 Mar 2026 11:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773686687; x=1774291487; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0ttFQZOfTjABcr/CRg+BE/xbEpdFtWOpPO35ThpdIfs=; b=SypG+PZOWsiT0KxTaYHdRI4mmiAyxH+5vC8STPi5at+Az1+Ufs/ZYb/+rfx5K3Glbg dKwrLNQHsE11QoV1VkN5dni4FWDPQlfvoulUi1CAaIwmduynraCE+Iqg7YqKKo2EhsiA 9L7MLHbmZsiVqvvfl9YHk8N4mvI5beJ0DChxpzc112hq99yZC2SlXZ3sHN9gP5DEmhOS drRlnhlU+VANnLeyQuODRdgSMBtwFEW0Kp3NYJOkAwuoX36ZYUezoYjGCumHP51cLbdP eyMLYmY9iE5yg2IOyAxKt1RIEdsTbAHv1pa+XsQkjYkXnfIpwzja90lSHp1biykL5FNg 5Ztg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773686687; x=1774291487; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0ttFQZOfTjABcr/CRg+BE/xbEpdFtWOpPO35ThpdIfs=; b=TrTrjiQ1DkjOjeK97nVQt20rgozgCwI0aGI/NFf+x8Se0OpxlLKf3rXjpxn2Th2FX1 rUWCXtMHNej0+v1BfYQhmU45V0Ing/iKwcQ+Z36/IClT7PQYjfG2+oszvSSLI4SVhYf1 IOIRMFevWCWrHXdYuh0Wsntb3tuiMgpW90+meCbflP0HRXcKV91t7G6h/WaLe4ynpfcv vrZgFtPiVS4creW8/PYjLKVV3+whqrHHVBos9uw3r7U/Lvc3SdPAANrBNMAL/5NZWhBX 7Rd9XQb8eFt2FHJnZZvx9duemhQlUDnxTSzqU5BKiWEFdLDnU7IeO60UoGv4csTqFwl0 Q8WQ== X-Forwarded-Encrypted: i=1; AJvYcCXw15wHp0FYfQdp/652FHvv8OxTPsdtzZsdgdKEe7+leMhjaRmc9cFeOXSK6atNgBJaB3CL+qM6GAHYWpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwMalmFueSWnebrzm1vka/IoL85LXGz1uMDzr9rYZVkrfVJTWeW ZlP5pyzjtJ5LC1T5zt0/Up7gnZGnyMEO/eBzEsUG01xsmAx49bXeqXA9waEYOIhU2EmZHykDA7v P0boNZ2l+9WpxbvkYIEbZNcKJSe5NA3nHvuettJ/ItoQfK/yvoRL20bxgJE4c5pc/zFo= X-Gm-Gg: ATEYQzwyQV9iLickNb00+P/vmKSwX8aWi5Nr4xkS4m6kMfV6Hmlq95IM83qcWs9Ks5P x8ot6LDH6+OC05hBQbR/vBDtxsonT2Yw/UGa/WVGmZ5UN25zkq5RBWyKNR1oDKnskzk5aNo8WHc nzG4VBzAE9fGYG4YAs2F0USO4EpWOllrOoXQ5H4eyKwAV3JBEcV7T4w4uvPXWjWfbOVrK/IXajl iK78J45RRfn2+WfEA7fdOoeYpiEtel4PVSLTPnOhjnP2CuSMpoafuQhkAgSWPEHiYvOvLi2nF56 B/jkcJA0dUW5QQTydo9QandqALX/fVe9J2AvXkiz752wliD91nrqnVOumx+N7hwYAyXZ6RTE8Fc C950lUGpM6s+W71ntzOH3nW6CiyJ7UHOX X-Received: by 2002:a05:6a21:2c11:b0:398:80dd:5705 with SMTP id adf61e73a8af0-398eccf385amr12697703637.46.1773686687026; Mon, 16 Mar 2026 11:44:47 -0700 (PDT) X-Received: by 2002:a05:6a21:2c11:b0:398:80dd:5705 with SMTP id adf61e73a8af0-398eccf385amr12697675637.46.1773686686581; Mon, 16 Mar 2026 11:44:46 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73fc935ad4sm5615135a12.2.2026.03.16.11.44.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 11:44:46 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Rob Clark , Akhil P Oommen , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] drm/msm/vma: Avoid lock in VM_BIND fence signaling path Date: Mon, 16 Mar 2026 11:44:42 -0700 Message-ID: <20260316184442.673558-1-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: T7xL-2yV4aTqTqgBYcScPPR_9fcMNSeV X-Authority-Analysis: v=2.4 cv=aue/yCZV c=1 sm=1 tr=0 ts=69b84f9f cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=BjPo030qj9DsFgYBbnAA:9 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDE0OCBTYWx0ZWRfX2r07HG7Qj195 QZjQsSptMCwR8a9HnPaQ/jglwkVeERUfT2RmzrtSIrsJD04tCvGWTZGZNu+G2yh3p5vG/pPjH0A dVtObeehq+oF4S4/EsFPIZV4OFzzKL6CrMp3gSQIGpBexvsx7WaXDDYE7lfbDmgStHQbxj78caS DO6o/PE+ZEsyGmbWYrcPU9tbep7njsjC00lSvdppi6iP26zgtPy843fCabDPeyBcETuK3E1VgFp A7ixnei2YTvYnm78T/SA2WLrBSwAHySOH1ahEtnvc1Tp/VOQ0Gbj+2SHA1/j1nGdUFoAXNHdnsW HplajGkWVNomafHbKzChpNHU2HmCoSn4pz94tnjerAQbdqh61XAAIoEdIxgDjzLoYC42Ku1Eo0D WraaI88LWHk0hsA7di7dK1KObLf7ny5Q3H28+I+wkccpKW8CIYhZR5ExQeT4Tn36yToZOjY9LHB YS5VaM05zNTV1YtfDXA== X-Proofpoint-GUID: T7xL-2yV4aTqTqgBYcScPPR_9fcMNSeV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_05,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1015 phishscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160148 Content-Type: text/plain; charset="utf-8" Use msm_gem_unpin_active(), similar to what is used in the GEM_SUBMIT path. This avoids needing to hold the obj lock, and the end result is the same. (As with GEM_SUBMIT, we know the fence isn't signaled yet.) Reported-by: Akhil P Oommen Fixes: 2e6a8a1fe2b2 ("drm/msm: Add VM_BIND ioctl") Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 3 +++ drivers/gpu/drm/msm/msm_gem_vma.c | 9 ++++++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index da74f1413f94..74636646d80e 100644 --- a/drivers/gpu/drm/msm/msm_gem.c +++ b/drivers/gpu/drm/msm/msm_gem.c @@ -507,8 +507,11 @@ void msm_gem_unpin_locked(struct drm_gem_object *obj) */ void msm_gem_unpin_active(struct drm_gem_object *obj) { + struct msm_drm_private *priv =3D obj->dev->dev_private; struct msm_gem_object *msm_obj =3D to_msm_bo(obj); =20 + GEM_WARN_ON(!mutex_is_locked(&priv->lru.lock)); + msm_obj->pin_count--; GEM_WARN_ON(msm_obj->pin_count < 0); update_lru_active(obj); diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_ge= m_vma.c index 3a6c435d5105..1c6b0920c0d8 100644 --- a/drivers/gpu/drm/msm/msm_gem_vma.c +++ b/drivers/gpu/drm/msm/msm_gem_vma.c @@ -696,6 +696,7 @@ static struct dma_fence * msm_vma_job_run(struct drm_sched_job *_job) { struct msm_vm_bind_job *job =3D to_msm_vm_bind_job(_job); + struct msm_drm_private *priv =3D job->vm->drm->dev_private; struct msm_gem_vm *vm =3D to_msm_vm(job->vm); struct drm_gem_object *obj; int ret =3D vm->unusable ? -EINVAL : 0; @@ -738,12 +739,14 @@ msm_vma_job_run(struct drm_sched_job *_job) if (ret) msm_gem_vm_unusable(job->vm); =20 + mutex_lock(&priv->lru.lock); + job_foreach_bo (obj, job) { - msm_gem_lock(obj); - msm_gem_unpin_locked(obj); - msm_gem_unlock(obj); + msm_gem_unpin_active(obj); } =20 + mutex_unlock(&priv->lru.lock); + /* VM_BIND ops are synchronous, so no fence to wait on: */ return NULL; } --=20 2.53.0