From nobody Tue Apr 7 04:14:07 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CF4F3E023E for ; Mon, 16 Mar 2026 18:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773686452; cv=none; b=Jm8KzfCYOGSxHtQxomdR+addP03LSjjn3VtPNF0jzrkR4CoXlAvZsKlxjQIgY8FwICaml/DOFz2aZCe2EJjQq/86Hr7Nib39qjmqKcKOPvY8eEI70LRPx0XpN97TFXbXvbK3VTZefFSKRPHqVZQDKRz2i8qVpNT6g6VLetlHpn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773686452; c=relaxed/simple; bh=bKW4WMs3JH5EpHet7R5WXoshw8T6K7Q2rEq+33ehq0Y=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=FlkLNafr+s+tHJ/TjwcJGwh1g8f3UC/++LvCVBWdpQYBKn6J7B+zZftjilOQdKLMKP3V7+bw3HqCUPmhWxgMiHV+cmyEodZFzKBzSC9fHM8TGgyAXoVAqAB2U1Jk5SHyT2jKORlQHjzB9TT+4WU0anUIdeJ40BpbLjyg5/ngag8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=j3+WwTjz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="j3+WwTjz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4350AC2BC9E; Mon, 16 Mar 2026 18:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773686452; bh=bKW4WMs3JH5EpHet7R5WXoshw8T6K7Q2rEq+33ehq0Y=; h=Date:From:To:Cc:Subject:References:From; b=j3+WwTjzG3OlPgAT+GfO3+qoZb7KCJDG3Gvemxc5/9TaipVZXVNZWQqOYOJlHE/SN gfyMqB2OmUNUEnx8fegpfftnC8o9BtohjBaK4ikFXSBiwWYO/EbM0rsc/Kn3PaFxY+ 9Nkq5/ql7dMKiyuUPLoxV2L/02wrZsh8cZLifpc9DFbpVJn8zBssZvRt0OcU8DAR+c uDXzMGUyrWvpvFvTBDPQlK9WE76NIt1sloqYS6kaFDHos5lC1ViSyh+OiOWGkolmpQ JI7cr5sSL6r9pTC83dQX8lFO+/gSPpb0FG7eupjulnTDNBeZhrmjpQ7xCkaa6qSU0E YtCVoyfLyHf4g== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1w2CsO-0000000853v-2FLT; Mon, 16 Mar 2026 14:41:16 -0400 Message-ID: <20260316184116.391842142@kernel.org> User-Agent: quilt/0.69 Date: Mon, 16 Mar 2026 14:40:38 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: "John Warthog9 Hawley" , =?UTF-8?q?Ricardo=20B.=20Marli=C3=A8re?= , John Hawley , Andrea Righi , Marcos Paulo de Souza , Matthieu Baerts , Fernando Fernandez Mancera , Pedro Falcato Subject: [for-next][PATCH 5/9] ktest: Run commands through list-form shell open References: <20260316184033.927944169@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: =3D?UTF-8?q?Ricardo=3D20B=3D2E=3D20Marli=3DC3=3DA8re?=3D run_command() currently uses string-form open(): open(CMD, "$command 2>&1 |") That delegates parsing to the shell but also mixes the stderr redirection into the command string. Switch to list-form open() with an explicit sh -c wrapper so shell syntax errors are captured in the same output stream as command output. Otherwise, important errors can not be retrieved from the ktest LOG_FILE. Cc: John Hawley Cc: Andrea Righi Cc: Marcos Paulo de Souza Cc: Matthieu Baerts Cc: Fernando Fernandez Mancera Cc: Pedro Falcato Link: https://patch.msgid.link/20260307-ktest-fixes-v1-5-565d412f4925@suse.= com Signed-off-by: Ricardo B. Marli=C3=A8re Signed-off-by: Steven Rostedt --- tools/testing/ktest/ktest.pl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 42bc505e14cb..9d6f50045dbd 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -1921,7 +1921,10 @@ sub run_command { doprint("$command ... "); $start_time =3D time; =20 - $pid =3D open(CMD, "$command 2>&1 |") or + $pid =3D open(CMD, "-|", + "sh", "-c", + 'command=3D$1; shift; exec 2>&1; eval "$command"', + "sh", $command) or (fail "unable to exec $command" and return 0); =20 if (defined($opt{"LOG_FILE"})) { --=20 2.51.0