From nobody Tue Apr 7 04:14:08 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F2033E0233 for ; Mon, 16 Mar 2026 18:40:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773686452; cv=none; b=gzlran5Ju0GdngbReDQ9uFugr1QHT+PCV7UMwz7TygFk1EEygzvG3BluZ+qQ7E7SYvVKQ1PtKkqGc0DGFNdE30CDsImWO3+1wf5yAgxT7tfSkQ9X6NiC1XbHlCpNr8z4dGObDDL8hKxSPdXYCGJE4z1eFden6IfteC25k1H7ZRs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773686452; c=relaxed/simple; bh=185RqqWcCOnKuq5ZXnAXkFRu6tv+tRMLZcuB2gTRoWE=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=pvEYpwJ+nupYaSQbcWwsGmb0ds0liJsMr6geUEeCvTOWU717g4CAaswBpkygXa1hQAqXC4HvtEZfxdIcur/puSqf3WVJg+rpVQq/i8GT7FzmE98n0qAfeH5KNRDKdr9fJILP8dGJBRDWZHRJJs/i5+2wIPZbhsKY/chb54Ed7H8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kvp1AYgr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kvp1AYgr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9C9CC2BCAF; Mon, 16 Mar 2026 18:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1773686451; bh=185RqqWcCOnKuq5ZXnAXkFRu6tv+tRMLZcuB2gTRoWE=; h=Date:From:To:Cc:Subject:References:From; b=Kvp1AYgryLe52qCi6a2dueUVgWbWil7kuGet10LTEEWR7Ak7iYeb+7MqtjJfkQsb2 AEaEnYbWJZGbRiO0a64C45rincnazPDXArbLwyNQVpugCEdTNAsJEbKWLCN+cU5NE7 CfZ6KbOo/kzDaY/Y+ThGIerAQDA99Aol0A9ECBh1aKSM9gxCt2lchqOaJhArzOhyP4 oqrOAHizR4+xeTrjhmtAPGU55RQ4QTs/INbDSaqlXeUmRANQ5VMAhbFzCVQbTeJ+th tbyk5B7t7/aLoWX1VOMWNKJP4hxO179sLKYMnMGzLpsfbJxqDDox0xoqeZjRfJg8At mzkz+0FdtXkIA== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1w2CsN-0000000851y-3iAx; Mon, 16 Mar 2026 14:41:15 -0400 Message-ID: <20260316184115.741900299@kernel.org> User-Agent: quilt/0.69 Date: Mon, 16 Mar 2026 14:40:34 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: "John Warthog9 Hawley" , =?UTF-8?q?Ricardo=20B.=20Marli=C3=A8re?= , John Hawley , Andrea Righi , Marcos Paulo de Souza , Matthieu Baerts , Fernando Fernandez Mancera , Pedro Falcato Subject: [for-next][PATCH 1/9] ktest: Avoid undef warning when WARNINGS_FILE is unset References: <20260316184033.927944169@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: =3D?UTF-8?q?Ricardo=3D20B=3D2E=3D20Marli=3DC3=3DA8re?=3D check_buildlog() probes $warnings_file with -f even when WARNINGS_FILE is not configured. Perl warns about the uninitialized value and adds noise to the test log, which can hide the output we actually care about. Check that WARNINGS_FILE is defined before testing whether the file exists. Cc: John Hawley Cc: Andrea Righi Cc: Marcos Paulo de Souza Cc: Matthieu Baerts Cc: Fernando Fernandez Mancera Cc: Pedro Falcato Link: https://patch.msgid.link/20260307-ktest-fixes-v1-1-565d412f4925@suse.= com Fixes: 4283b169abfb ("ktest: Add make_warnings_file and process full warnin= gs") Signed-off-by: Ricardo B. Marli=C3=A8re Signed-off-by: Steven Rostedt --- tools/testing/ktest/ktest.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 001c4df9f7df..f48ee64c69da 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -2508,7 +2508,7 @@ sub check_buildlog { my $save_no_reboot =3D $no_reboot; $no_reboot =3D 1; =20 - if (-f $warnings_file) { + if (defined($warnings_file) && -f $warnings_file) { open(IN, $warnings_file) or dodie "Error opening $warnings_file"; =20 --=20 2.51.0