From nobody Thu Apr 2 06:14:16 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6D283A1A3D for ; Mon, 16 Mar 2026 15:34:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675273; cv=none; b=K75RObX76+ervNbWZi9G4XWedXuHHenQ2/nXPz5PTVzPIG+OoaFjdPaTwDvYNse0UsfXYQgxD8Cgt18Pdx9GZ0Peb4YOklTXbhQhJLm3Jb/5FjrJVkzhoKXYtiduyJJ/oyscy5NDbiqIL0YvmGBGvBktdNIRI/LQpwjK8AVf8Cc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675273; c=relaxed/simple; bh=0jF/Skpappl8e6rE9BFwQF2Uw2riMyYj60IKPk3xg88=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K2X0Cw26KS8YyvruhWtyHzFCwTU18HuvecByBBNE33SXSYSJrDVNdf1TIZCpTzUvBNQ6vSDkpdigy2+ymtWKRc3rlYce2u/E67/FRmGq6g5ovaPXL7fsZy7CIfsgbyV8cQQVdXP/KST/vRryjI6n7/HNKevgntM+vKrbcklf9TI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mw+LfReC; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mw+LfReC" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-35ba2ae4df3so663000a91.2 for ; Mon, 16 Mar 2026 08:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773675272; x=1774280072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D3HNVJWbjalr4X65+4J0/1uR1SNrklyVdLh0q57Y2MA=; b=mw+LfReCM1NkM1ZStYqvyX6Cju5EHMOnR3HZqoLOrxmRcvimxpy/0oRtOgaZZxxgNM EnFJDex88yUACc5vKaxgl+FD5pcNjuOW6R/3/ubiAaIIl9z29uaeKA4yO0YjH/psU26a nB1HTjzjDgUxa/TpoJ9hBiA72rJ+Owh0jZlITtPOFLYq/tOcoEIvkCuqFI3pSrzd4oTd 31JdgmHV+F/kQGa7RWOFOy8iHBHLIj9emvsG+FS5xeOqQUk7g1cWl2khnLuF6p/uynuY Tgxwt6i7pYo8WtIjHOIsVOqXlB1I63/mgDCPTQx7YF+tDciQ7L3KNKXajFiM181j8OJf Ct3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773675272; x=1774280072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=D3HNVJWbjalr4X65+4J0/1uR1SNrklyVdLh0q57Y2MA=; b=P5NZu01FhuxpmNI/4t/KV3b8G/sQA6B9VheOoLOvKq0AIw/sqzRNX4oTlufxy4a6sY LxD+T18PTx09h/AJa/+bmYMQADDU8GifQZFsT1lOCUwzdZtEFsjzPKp9z+9VadjAjepG 7KU24x590i4AeY+KkwmghYq4VzOpThyoc9xyIiAxHhvUhXy41lOxWExZsZlbn2uKpe4W OaA+OA+3/5rnMXk52MeDLrURUnnk8bL1Fq637rO5mSukoVbjvEnLRB+lMbepqzcUzH8g 3Ut2nrV/mScDdcQ5a9uSz0LTkL0NSOubviS4MSk9OkiYZ+YeDkZm6UrrEpMYrjNQKGp2 W6cQ== X-Forwarded-Encrypted: i=1; AJvYcCXoK1onmGl3x9HbgCB8mOEUpuK8qLTS1YBRBiR5nydLkO8PmPS0g601t19dFGmkG1HfYi2e5qBl0YHAo4I=@vger.kernel.org X-Gm-Message-State: AOJu0YzJYNO2xzejTuhYcbHuVrkosq8cGyoNqpWEwwa3C4TkItH44TYL WenIzrOb08bSgPNQZb33tGch7XrlQfzIHwN1Hc80M6idQfTcSAQ8gBg= X-Gm-Gg: ATEYQzxAT48O4TL5XOHqSsT7k5v4hcPca1McUUgZKrzfpypSIcpcbQSXwQKsVJ1rjCr Jc410n/CnxM94eExVtHm9nVDodUHvhwIDaaxCKCGCW5qsoYOALPMHB3Y06j0y4U/zIYbsGFJOEU f3x5Np3qlxT9nI2Alq8vGh7ziQ7qmcRVdvnLHFCQFaOmRWx4fSg1Jgv22Nc6zJGgX+cdBqAufU3 3+3KoPphQbipjVXK0kY3nnWD+CYqyXnDIw7HNyuIY8Ypb8nah7PfbtgLRMBE57y+TvQDrMcyxOy qNOUIYym44lXuJVEUQxiDc/K8EjKy/7hkHischN6zpcOii/5rII+92JjgdlqWCy90Tmd+WkaKSw BSisNO32os8E3NGLbCgat/aW5tczJhAFpdYAG6PEq+AK6YZI0Bv4ygaszMZV/UEv8preK5c9dC+ /9CZ1zCOkNCSjnpHFyLlfQhkehn7s2WUAsa7YOmMnKB9hkmJGJTFHDszzpJwuNFG8= X-Received: by 2002:a17:90b:1d88:b0:35b:9c13:30cc with SMTP id 98e67ed59e1d1-35b9c133309mr4190158a91.23.1773675271990; Mon, 16 Mar 2026 08:34:31 -0700 (PDT) Received: from at-Standard-PC-Q35-ICH9-2009.. ([171.61.163.197]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35badb906c6sm2685a91.9.2026.03.16.08.34.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 08:34:31 -0700 (PDT) From: Atharva Tiwari To: Cc: Atharva Tiwari , Ard Biesheuvel , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v4 2/2] platform/apple-gmux: use apple_brightness to save brightness to EFI Date: Mon, 16 Mar 2026 21:03:47 +0530 Message-ID: <20260316153407.1781-3-atharvatiwarilinuxdev@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260316153407.1781-1-atharvatiwarilinuxdev@gmail.com> References: <20260316153407.1781-1-atharvatiwarilinuxdev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" use apple_brightness to save brightness to EFI. (tested on iMac20,1) Signed-off-by: Atharva Tiwari --- drivers/platform/x86/apple-gmux.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple= -gmux.c index 1417e230edbd..cab3122c1a86 100644 --- a/drivers/platform/x86/apple-gmux.c +++ b/drivers/platform/x86/apple-gmux.c @@ -22,6 +22,7 @@ #include #include #include +#include #include #include =20 @@ -78,6 +79,8 @@ struct apple_gmux_data { /* debugfs data */ u8 selected_port; struct dentry *debug_dentry; + + bool save_efi; }; =20 static struct apple_gmux_data *apple_gmux_data; @@ -960,6 +963,13 @@ static int gmux_probe(struct pnp_dev *pnp, const struc= t pnp_device_id *id) } =20 gmux_init_debugfs(gmux_data); + if (IS_ENABLED(CONFIG_APPLE_BRIGHTNESS)) { + ret =3D apple_brightness_probe(gmux_data->bdev, &gmux_get_brightness); + if (ret) + pr_warn("Unable to Enable EFI brightness save: %d\n", ret); + else + gmux_data->save_efi =3D true; + } return 0; =20 err_register_handler: @@ -1012,6 +1022,16 @@ static void gmux_remove(struct pnp_dev *pnp) kfree(gmux_data); } =20 +static void gmux_shutdown(struct pnp_dev *pnp) +{ + struct apple_gmux_data *gmux_data =3D pnp_get_drvdata(pnp); + + if (IS_ENABLED(CONFIG_APPLE_BRIGHTNESS) && gmux_data->save_efi) + apple_brightness_shutdown(); + + gmux_remove(pnp); +} + static const struct pnp_device_id gmux_device_ids[] =3D { {GMUX_ACPI_HID, 0}, {"", 0} @@ -1026,6 +1046,7 @@ static struct pnp_driver gmux_pnp_driver =3D { .name =3D "apple-gmux", .probe =3D gmux_probe, .remove =3D gmux_remove, + .shutdown =3D gmux_shutdown, .id_table =3D gmux_device_ids, .driver =3D { .pm =3D &gmux_dev_pm_ops, --=20 2.43.0