From nobody Tue Apr 7 02:59:02 2026 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 296583A1A35; Mon, 16 Mar 2026 15:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675236; cv=none; b=ogj6t527w2L89R8jesdmYbsRvlQxZBZ1XZAGqmEDrVBqLKgFPu3enU4QupdeH1fIXYG2kd7Ag5ALbFO8DSWrGU7aGVvkljJyFQWnioMIE3cf+Fhmts+aQmWyoNbDTzjDlhojRRYol+sGIxXbgXtwtgRHXxByccF6foC3/E1Oonc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675236; c=relaxed/simple; bh=hE5rYVjiRfPJCIf9eXzZQUhfWKiMeU8KcbO5MPNuZzA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KlQYzadQ8J6NGmgluIL0nU3cZr6yA4eLU2ZVmV4d4WfnVxJTj/J8hhFELGQwJgXUJiuY1O8WNE3QkOe0kWgx4nVeJ0R4Fmv2Ze3rifVqvSAxjIYqcZh09LTbrEx1n6n/HFdhmRRP/iywMsOVM0baP2aG7IWUYtaarLxqv0YNduw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=QMqg48G6; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="QMqg48G6" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GFPlsf717620; Mon, 16 Mar 2026 15:33:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=g+qcf0dnOOiVBF8qp pxKPaTTpNVkuDcREhm8Gt9XanM=; b=QMqg48G6SOtRxkjdaX4Bf1ciFNFoLXszY HR4HqaiAc8RUTeWKOjDxX3EPwK8gLdlKWohnbRZdzPn+AcDQ/32zWEtN1+YTJhAm enPZthZ2gbO1QdkyXSie9nil2oR9egLINVLGA3GYdpts9Bhh8lvaUu8Kndw9EIwj IKV78FoNZcO04e8XwiymJKL7tkIW3swzh+0dHHH/uqRQpcJejt6z8HinxnzrgUXb Q+EiuqibHY5/5ECqLS0xuWKxcdDOJyKWvwNtuh5MieB5rUJgUHamRgAp7Pj19Fnl mKZ1OvFBOhiPwJMaWmn6Pyj+HgzeUaVuB4KSX6qIlgJvgNf/8m1HQ== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4cvx3cr8ba-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2026 15:33:46 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62GEP3C1005380; Mon, 16 Mar 2026 15:33:46 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4cwj0s5f9g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2026 15:33:46 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62GFXgqJ35717500 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Mar 2026 15:33:42 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 427D62004D; Mon, 16 Mar 2026 15:33:42 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 17EC020049; Mon, 16 Mar 2026 15:33:42 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav06.fra02v.mail.ibm.com (Postfix) with SMTP; Mon, 16 Mar 2026 15:33:42 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 56370) id F365FE0198; Mon, 16 Mar 2026 16:33:41 +0100 (CET) From: Joshua Daley To: linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, jdaley@linux.ibm.com, mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, eperezma@redhat.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, mjrosato@linux.ibm.com, farman@linux.ibm.com, frankja@linux.ibm.com Subject: [PATCH v3 1/3] scsi: virtio_scsi: kick event_list unconditionally Date: Mon, 16 Mar 2026 16:33:39 +0100 Message-ID: <20260316153341.2062278-2-jdaley@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260316153341.2062278-1-jdaley@linux.ibm.com> References: <20260316153341.2062278-1-jdaley@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=arO/yCZV c=1 sm=1 tr=0 ts=69b822db cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=20KFwNOVAAAA:8 a=VnNF1IyMAAAA:8 a=fOgkfDuy17jzwl4HYOQA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDExNCBTYWx0ZWRfX7cL9mfKl2YwR oqTPHsFUkSq9kyMdxpuw/V9+3fco/eR48T7sIjHgiJFDSyRfntzWLFDn2MLl0mFRWq2FZ5rCxW+ nQlHLIFCG84eqImRkypGc1P0D4Hk1+f5Yx586xiqVIzOeZ1WsV3MM1GNIS29oPBwqPnHFtM1Asn lTANeueNvGQGYWp+C1mB/GD1vqU9JrDEFxbXJEJUsp2UcMTUV73Q2D58Ajuhua5o0WNmyVdIuxN BnXAIa5Iat/z8bPNuilrSEIaKX/JXswcvOU0L9ZMNS046dCQSUEuD2rDhiB106JFHuJRzwMLgaE gTEVO2dtkX/M0keL2gJSL+AOupI/zmdqTxqZThGgj6rdNv3JDFNSMcXqzhyaJppHJmw7bqcik3s nVz2LVKVfELkBzPJZawhhMTg3A5hGnPD54KUFA4m3mY6kLiSBAFOlFyvp5MgNOHR2A609UahB3Y 7HCVxqcaIihAfxaOS8Q== X-Proofpoint-GUID: 1ohHNN3-C4YkdJ6CiNOzHQ-9AxSD1eNy X-Proofpoint-ORIG-GUID: 1ohHNN3-C4YkdJ6CiNOzHQ-9AxSD1eNy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 clxscore=1015 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160114 Content-Type: text/plain; charset="utf-8" The event_list processes non-hotplug events (such as LUN capacity changes), so remove the conditions that guard the initial kicks in _probe() and _restore(), as well as the work cancellation in _remove(). Suggested-by: Stefan Hajnoczi Reviewed-by: Stefan Hajnoczi Reviewed-by: Matthew Rosato Signed-off-by: Joshua Daley --- drivers/scsi/virtio_scsi.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 0ed8558dad72..982f49bc6c69 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -983,9 +983,7 @@ static int virtscsi_probe(struct virtio_device *vdev) goto scsi_add_host_failed; =20 virtio_device_ready(vdev); - - if (virtio_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) - virtscsi_kick_event_all(vscsi); + virtscsi_kick_event_all(vscsi); =20 scsi_scan_host(shost); return 0; @@ -1002,8 +1000,7 @@ static void virtscsi_remove(struct virtio_device *vde= v) struct Scsi_Host *shost =3D virtio_scsi_host(vdev); struct virtio_scsi *vscsi =3D shost_priv(shost); =20 - if (virtio_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) - virtscsi_cancel_event_work(vscsi); + virtscsi_cancel_event_work(vscsi); =20 scsi_remove_host(shost); virtscsi_remove_vqs(vdev); @@ -1028,9 +1025,7 @@ static int virtscsi_restore(struct virtio_device *vde= v) return err; =20 virtio_device_ready(vdev); - - if (virtio_has_feature(vdev, VIRTIO_SCSI_F_HOTPLUG)) - virtscsi_kick_event_all(vscsi); + virtscsi_kick_event_all(vscsi); =20 return err; } --=20 2.34.1 From nobody Tue Apr 7 02:59:02 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE49D3A0EB1; Mon, 16 Mar 2026 15:33:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675238; cv=none; b=FB1iHFMXuCu4WdvvqIzmHZkaVxoHcr+Mnmq1HGqIvZMdyewPAXCbkxDazC5KKDv0cP54XsiV33iUB7fpDymosG1x9GjPjJ+aJjvkYUj9JIL7sfmjWrqNSWtxU8cCChLwlWQ8MV7syDhVRLTMST3HOdSj3fdkPAwu4o4UXEaw6AI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675238; c=relaxed/simple; bh=DL2ac9OnJv3Fq/xVqfXOb/t5ETJ66jc57gLPp1PZJZM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T3Ou/PXLzjgLDEUsS8VA9tA6ReH5lKmcvB2AUVrsjFWWcsF3QOyiUoGOe44yEdpKrHaHHqE/f8TR/5+WPoJzMOQqPnxf37dF2V9gYJ92roUXhkvL9aJwSv8wUfNG0+ntAPflCoLhP5d3tCNboaIZmVmOvZB+YugHK5iD9bBRfO8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=SC8d6P08; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="SC8d6P08" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62G14kq61189532; Mon, 16 Mar 2026 15:33:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=QFkhCorH22uyFoF9L HbviC9UCB0m/J8xRtt6YSZnI+I=; b=SC8d6P08JegjvWmQgkBmDwL5nm+oHgLJQ 2j58Q//HtSbG2b3nQMYEdYT+VruRY/MxymCAAmXtQuQMZ4M31ecOXN92uOQRv+zA v0c0MC4PJBL48Yr4/Jqn3cHZyzi8qQ5GhSevc+jEytwkAdgkpH3AbMqFjb6/saH6 qaa9zmFdo7ALQxRixZ5PN6fUfsqsYwhwh2jRqkgIHo+UbpFY8NTCbQk/RP1c7cVh Iav7n6uRHht4kD5QCnMSc4YS+a2Rqpqz/yjmcxDNoRf0fmTnH6bWCH4AHodmlCx/ NA0fHcC+t7+dVxkxfOTvJaYVav6/omtFSGjBOoMlB7yYri6ilPhnQ== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4cx7vfau3k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2026 15:33:47 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62GAkfvF029194; Mon, 16 Mar 2026 15:33:46 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4cwkgk5a10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2026 15:33:46 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62GFXgOw29360524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Mar 2026 15:33:42 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4DB6920043; Mon, 16 Mar 2026 15:33:42 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B7D020040; Mon, 16 Mar 2026 15:33:42 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav03.fra02v.mail.ibm.com (Postfix) with SMTP; Mon, 16 Mar 2026 15:33:42 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 56370) id 0269EE03D4; Mon, 16 Mar 2026 16:33:42 +0100 (CET) From: Joshua Daley To: linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, jdaley@linux.ibm.com, mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, eperezma@redhat.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, mjrosato@linux.ibm.com, farman@linux.ibm.com, frankja@linux.ibm.com Subject: [PATCH v3 2/3] scsi: virtio_scsi: move INIT_WORK calls to virtscsi_init Date: Mon, 16 Mar 2026 16:33:40 +0100 Message-ID: <20260316153341.2062278-3-jdaley@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260316153341.2062278-1-jdaley@linux.ibm.com> References: <20260316153341.2062278-1-jdaley@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: yNUPtiGdc0RtYb1-tu-JoIAgrnoxHKHW X-Authority-Analysis: v=2.4 cv=KajfcAYD c=1 sm=1 tr=0 ts=69b822db cx=c_pps a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=20KFwNOVAAAA:8 a=VnNF1IyMAAAA:8 a=v7jRQeFWwknd2TLyXd4A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDExNCBTYWx0ZWRfX9pCntnbcG3xP GpVOxL+Pqzy1oxJdxAAy6g4m3LYvJa89xmC8MOJKVUxsOq2O5nv3w3O3A+SZ97I282cDyp1Lslt 59lFJz+8AoWC153003C8yZk3nGxqD1z5FZkGOZxkRw35YSh2NuWuBkNOPkaR9yCAzDypxrMNRfk F9nJnfx2Drp/AVLBvyZssWJqfFcXoeaDi0l82ADbWXKY6MSQYfvA6Gad6ZLK1mN7ntJew9OqDLo hRJuh6TnV1T1bUp8UK09PoDdlO6ZANogEt2mUjsWo6EBKHttgYH6wLgwXKLvCgEszHuNEx4jgT7 SqGRvzYP8/vxgKK7nwgcxV0w2P/5699iX6YYatiRnrvtHG+OxtOnE4ti/cC2dUOw2djMsR44pKh HkSTDdFtrUroWexLMrGsysTe1bHa8MffghJw626WAprCQLdNeP7V3kn9epvOATlzEqcq+Dihi+5 CmJF7mkUJUCKUumOBzA== X-Proofpoint-GUID: yNUPtiGdc0RtYb1-tu-JoIAgrnoxHKHW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 clxscore=1015 impostorscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160114 Content-Type: text/plain; charset="utf-8" The last step of virtscsi_handle_event is to call virtscsi_kick_event, which calls INIT_WORK on it's own work item. INIT_WORK resets the work item's data bits to 0. If this occurs while the work item is being flushed by cancel_work_sync, then kernel/workqueue.c/work_offqd_enable triggers a kernel warning, as it expects the "disable" bit to be 1: [ 21.450115] workqueue: work disable count underflowed [ 21.450117] WARNING: CPU: 1 PID: 56 at kernel/workqueue.c:4328 enable_wo= rk+0x10a/0x120 ... [ 21.450171] Call Trace: [ 21.450173] [<000003db2e5bdc3e>] enable_work+0x10e/0x120 [ 21.450176] ([<000003db2e5bdc3a>] enable_work+0x10a/0x120) [ 21.450178] [<000003db2e5bdd86>] cancel_work_sync+0x86/0xa0 [ 21.450181] [<000003daae97d9e4>] virtscsi_remove+0xb4/0xd0 [virtio_scsi] [ 21.450184] [<000003db2ef3b5ca>] virtio_dev_remove+0x6a/0xd0 [ 21.450186] [<000003db2ef9106c>] device_release_driver_internal+0x1ac/0= x260 [ 21.450190] [<000003db2ef8edc8>] bus_remove_device+0xf8/0x190 [ 21.450192] [<000003db2ef88d72>] device_del+0x142/0x340 [ 21.450194] [<000003db2ef88fa0>] device_unregister+0x30/0xa0 [ 21.450196] [<000003db2ef3b2fa>] unregister_virtio_device+0x2a/0x40 This warning may occur if a controller is detached immediately following a disk detach. Move the INIT_WORK call to prevent this. Don't re-init event list work items in virtscsi_kick_event, init them only once in virtscsi_init instead. Reviewed-by: Stefan Hajnoczi Reviewed-by: Matthew Rosato Signed-off-by: Joshua Daley --- drivers/scsi/virtio_scsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 982f49bc6c69..15ca2a2d7aa4 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -242,7 +242,6 @@ static int virtscsi_kick_event(struct virtio_scsi *vscs= i, struct scatterlist sg; unsigned long flags; =20 - INIT_WORK(&event_node->work, virtscsi_handle_event); sg_init_one(&sg, event_node->event, sizeof(struct virtio_scsi_event)); =20 spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags); @@ -898,6 +897,9 @@ static int virtscsi_init(struct virtio_device *vdev, virtscsi_config_set(vdev, cdb_size, VIRTIO_SCSI_CDB_SIZE); virtscsi_config_set(vdev, sense_size, VIRTIO_SCSI_SENSE_SIZE); =20 + for (i =3D 0; i < VIRTIO_SCSI_EVENT_LEN; i++) + INIT_WORK(&vscsi->event_list[i].work, virtscsi_handle_event); + err =3D 0; =20 out: --=20 2.34.1 From nobody Tue Apr 7 02:59:02 2026 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11E0C3A1A48; Mon, 16 Mar 2026 15:33:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675240; cv=none; b=Q9DfILiqBeNkSqfK4q8zg2peg/aG+jLM1nMYUt0Is0KACM4gQ+Tmuwlj7ThCXam3cFAMQ9pq5k9AzsuXdi5Jom2jhf3h1d12rGBKUF7kWm0Ef6tlajOGs6Fb0H0LEQvOiaD6SqsHBU1wfvMQGOzXkhfQYTX/VZntkQiELOLZOI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675240; c=relaxed/simple; bh=wsI/lAbInzKemMINd8sp2hdbpa7iJ0AjRHMIuHIBZy4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fwHYw6sz8vIEzZ6M4mlHEFw4oozI/OkgzFG0t7+xZmTA98HUkyp2nI/2IPWIJXzcXnmw2Y2SjmLp9ZTHBEbM8c7X7v8mNdqtylvoLWelW6RPL2NYA6r5WTDYo0I1QvLCisPRRys718yj8TypGX2YxTXKmzTU7e9vtARHfcL4SL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=Ni9iqodh; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="Ni9iqodh" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GEsEYv1106118; Mon, 16 Mar 2026 15:33:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=loamRpzwOR7CpZ1Qb KcxzvWTLgiAxBJrtR3Ay8n4uHE=; b=Ni9iqodhRPnLTC8OKqhviadAVt2uwOUQg XgURPxl+Zcj5LxqZEOSE1XbvjYt49+2rYI1+QqSoTPJEGFtyB1ETKfzz6bzOtGRD OB6BpQKHzFIASlK8Z/rvJp4YxWzTrKEJc4FF1KWPPRYDU8mOSI8SAAy+948GcUFU MjfDlVpQcc8r7olVl7Yb0qGyBB9A5V/Q45CNWV77wW1ovX0SNoyLcn6I5GtjuYwZ X70ie3kx++Lje0eo6t7vTi9Y+9AKykwZ/Z8efcZrdeQxH/mp41oGdYdXlX4uzWxX VJy+PqPiaT9vRrZDpp1EjJ9ja52uiL/V5DgOc+nd7SnHsKzn9Fp6A== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4cvy64gm0w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2026 15:33:47 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 62GBIJdh028459; Mon, 16 Mar 2026 15:33:46 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4cwmq154a3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Mar 2026 15:33:46 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 62GFXg3A47382924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Mar 2026 15:33:42 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 45E652004E; Mon, 16 Mar 2026 15:33:42 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1B48A2004B; Mon, 16 Mar 2026 15:33:42 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.87.85.9]) by smtpav06.fra02v.mail.ibm.com (Postfix) with SMTP; Mon, 16 Mar 2026 15:33:42 +0000 (GMT) Received: by tuxmaker.boeblingen.de.ibm.com (Postfix, from userid 56370) id 05168E03D5; Mon, 16 Mar 2026 16:33:42 +0100 (CET) From: Joshua Daley To: linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, jdaley@linux.ibm.com, mst@redhat.com, jasowang@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, eperezma@redhat.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com, mjrosato@linux.ibm.com, farman@linux.ibm.com, frankja@linux.ibm.com Subject: [PATCH v3 3/3] scsi: virtio_scsi: remove unnecessary fn declaration Date: Mon, 16 Mar 2026 16:33:41 +0100 Message-ID: <20260316153341.2062278-4-jdaley@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260316153341.2062278-1-jdaley@linux.ibm.com> References: <20260316153341.2062278-1-jdaley@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: DcsjZgl0eYmGCwXJ1ikRdX4bxe7nlL4w X-Proofpoint-GUID: DcsjZgl0eYmGCwXJ1ikRdX4bxe7nlL4w X-Authority-Analysis: v=2.4 cv=KYnfcAYD c=1 sm=1 tr=0 ts=69b822db cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=Yq5XynenixoA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=20KFwNOVAAAA:8 a=23WZjCL68Duz3tq5-14A:9 a=NqO74GWdXPXpGKcKHaDJD/ajO6k=:19 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDExNCBTYWx0ZWRfX0TgtOtMPOzns 2M/Abw39OoniWTCFzwllcxPLHMnUvxEO00F2NGZc26P5/q0qYfmPDYD13S6RAPgs/vCF14GORGc bqdrLednme0GSYnjx0YuHf12LAGIoPnUb855Rx/0Gr3DQZl/qbQTN+aX7q1TvYrhmhoxBz6j5ad vA0DEIGLIADuIx4lCRWbBjlMawgLbKdzU4P+4PqXDWkSjqF0zDiHOtrr0H7AOuRRd0yDNs0sitt InZ3KkC9y8OLHhrhhXTPh+U/x/etp6g+WM9x6Tn+PMtZbCNDUihk3zJTh6dsjQQq0LRulr3gkdu K9G0JRh16PFgMF/l1xnZezMkw6s+uCDAyWjaiSgKiAhZnmyG+4E8+FHudmEfgQS58Hvi2SVzM7r ct5292/LUdA/L8IA1wCEAhqWHcgvnLNJwKTrVdgPc/KpTrWW5rhND6aIKJ59XJn0efLyg65vEWr ufi0JMkKbSutqv5gPaA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 priorityscore=1501 suspectscore=0 bulkscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160114 Content-Type: text/plain; charset="utf-8" virtscsi_handle_event() is not used before its definition, so remove a prior declaration. Suggested-by: Eric Farman Reviewed-by: Stefan Hajnoczi Reviewed-by: Matthew Rosato Signed-off-by: Joshua Daley --- drivers/scsi/virtio_scsi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 15ca2a2d7aa4..fe1bf37f1317 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -233,8 +233,6 @@ static void virtscsi_ctrl_done(struct virtqueue *vq) virtscsi_vq_done(vscsi, &vscsi->ctrl_vq, virtscsi_complete_free); }; =20 -static void virtscsi_handle_event(struct work_struct *work); - static int virtscsi_kick_event(struct virtio_scsi *vscsi, struct virtio_scsi_event_node *event_node) { --=20 2.34.1