From nobody Tue Apr 7 04:36:49 2026 Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 964E0398915 for ; Mon, 16 Mar 2026 13:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773668012; cv=none; b=HeIddvyCfapnQq9eDu1EPR37BqeeFxzW6Hh2fKJ/x+VCTaylz5OWEMRgD6rkfBj2tsnBiSH1O9Hr5kOJKzG9lbRNDqVGxz9FWfygNZ0vvDUWq6oyFkHy0+Q7oOkvH2psdHVAfg29/na1dEqty3JxYatyvR6hgQgjKnoPhSkzSws= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773668012; c=relaxed/simple; bh=L5geDWiGcTUN9x6Qm56Swndmi1WWAZi7fHSFPyS6Udo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MzH7zLXU2XOogCldM3vg1Xypc6Tu1EAhmBVG7pG1G2FAWrs7HEy3fFEmBJEQMpAQ7bLM12QJ4IF/0sxHYH3IjHMkP4nEBdDdeDbQPHnfTSUwCAfLGxnxVDRlVvuN/kTHdYLiLQMch2cyN6DphAt/vM36/0HGMNDx+HxpouEbMW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=AJf9WrcH; arc=none smtp.client-ip=209.85.208.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="AJf9WrcH" Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-38a76ba6a78so31249091fa.0 for ; Mon, 16 Mar 2026 06:33:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1773668010; x=1774272810; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BTJLUcXBzmJ7olAbj0A01gWZuReFxSOM42B5au/jsgg=; b=AJf9WrcHHqJPmgZ5lxataPmnW9maV1A9NaWktxO4k9qkG6Rzp7/UQUgox9xie17R7h WymPYrqw7Z9f5Zv4rKTzSP56twifDGfsvN6hoqY1M2FFYHwlYniBElqTivTb7HtomsQF N4C35tydnyIt92EhzR39JKtznuEXJXD1B3sWZnVSzuLDxCfIaIWAuxjLbXdmNNYIiRFi KN3w2HzrjM8vyAK3U+iucbv4Dh1VZgVsa6hKkVeQs1TRmPGw9yrh/S+hdFsYlEfLbtpW 5CY+wzxXm/EDFDGRGgrX4aQqMqHa4STWMZSxXob0/0C/zicsiV7E4FxDBxFCp9O9z0oG DKGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773668010; x=1774272810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BTJLUcXBzmJ7olAbj0A01gWZuReFxSOM42B5au/jsgg=; b=BK+8M2S3SJHAxLU5BkSJkVDkmDJFlDmmiSuoM36U8f38n+905nAOedWz4dFZ4adEwG wBnjxB1qX8LVxv+SVkWTN6I1QlWKCNhD2R2aX3ZFIOFM9MYCPR/XDJv0J24BjOw+9AfM WQR6eLh+6jyz4PhcmVYfh8Z92Y00Z4iSa6PU/5Nb6080fswmj9VJJ4vM5oxIXnXWFHcl 0dVtmFKy06Z14EuLnMl8Wt7Dz6HXeW0cMrWgsQHlMIwAKCRqiKxiwoJXw0bXexbSWdcV OO9eJL72hdJbGLUAW80ACPvaV+LGoxjkt4xmrLjIi6opathmb9ORucp0sWiKo8g1O4ID lGhA== X-Forwarded-Encrypted: i=1; AJvYcCXCNMKBdQ29W82Ev4rCxYnsk/0JePN2RWhEv2Kzrvm3/3FIlJYtecZK372YthkWhaSdLu49mz1MALhckLM=@vger.kernel.org X-Gm-Message-State: AOJu0YzXhz58joQD4kqq3UdDLQdtmCx7HPUZcdU7PLycsX5Ew0zLCcGZ wI4CjuDfTBvgT1KzGq+drbF8UGpowR/TVHrtD+5omN1v2TXo+DJv3++WVKRr+hGmyz+fIZgjBhI 15cno X-Gm-Gg: ATEYQzzURuw30M1Qqm59LiQbQM3wnsjJwnMRBBzoZyttLW/Ksph2UbWkcp5CQ4ZLTFd 93D5tXqPu6Dnu2GAgQrEs6nEd8u/oiNbq3ctuzePStJkF74htOJ2Z6tC7x/fBFFzIEttWfsWGOM uve4okOHfwBP4TPStaAEzQHiJDWR4rKFZKIXf558jUwrL+5XI99RHpyv4V41SQ9BDaswmbkMCRq 90mDlvz9lvziMMyjfAyz+RxVwHWr83QdyrDlJ7GIdR+9G382QhYQKIXVUkdP25+e+mk5/qCAK+f dSjLVM+Q8fVqLW/ypiuA48jil+cgoQkWUC3cWet2zzyUNuLs+/FOqSRsx87BGaBpQJe8ot9p+NL JXaZAkwlvBgL+FF7CIkvwTkGInmPP9U+cu+kpSBFBrF+4mwVKeqkT0Q7Sh8fnXLRvNJQ+SYV2e6 dlL93Z/wOqN/OYwMuouwUkoSfBP+ZUlfNOW1EXRFUsww5g/GNZs3wvLpS+MJO6QWE8Yk2dDf35k dNZN6I= X-Received: by 2002:a5d:5f83:0:b0:439:b1be:819f with SMTP id ffacd0b85a97d-43a04d86767mr24243679f8f.2.1773667990801; Mon, 16 Mar 2026 06:33:10 -0700 (PDT) Received: from claudiu-TUXEDO-InfinityBook-Pro-AMD-Gen9.. ([2a02:2f04:6208:0:c5e3:3624:ad1c:6b4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b419270efsm11629888f8f.16.2026.03.16.06.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 06:33:10 -0700 (PDT) From: Claudiu Beznea X-Google-Original-From: Claudiu Beznea To: vkoul@kernel.org, Frank.Li@kernel.org, geert+renesas@glider.be, biju.das.jz@bp.renesas.com, john.madieu.xa@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea , Frank Li Subject: [PATCH v10 5/8] dmaengine: sh: rz-dmac: Drop unnecessary local_irq_save() call Date: Mon, 16 Mar 2026 15:32:49 +0200 Message-ID: <20260316133252.240348-6-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260316133252.240348-1-claudiu.beznea.uj@bp.renesas.com> References: <20260316133252.240348-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rz_dmac_enable_hw() calls local_irq_save()/local_irq_restore(), but this is not needed because the callers of rz_dmac_enable_hw() already protect the critical section using spin_lock_irqsave()/spin_lock_irqrestore(). Remove the local_irq_save()/local_irq_restore() calls. Reviewed-by: Frank Li Signed-off-by: Claudiu Beznea --- Changes in v10: - none Changes in v9: - collected tags Changes in v8: - none Changes in v7: - none Changes in v6: - none Changes in v5: - none, this patch is new drivers/dma/sh/rz-dmac.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index 6c9bfe39a11e..eca62d9e9772 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -272,15 +272,12 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *ch= annel) { struct dma_chan *chan =3D &channel->vc.chan; struct rz_dmac *dmac =3D to_rz_dmac(chan->device); - unsigned long flags; u32 nxla; u32 chctrl; u32 chstat; =20 dev_dbg(dmac->dev, "%s channel %d\n", __func__, channel->index); =20 - local_irq_save(flags); - rz_dmac_lmdesc_recycle(channel); =20 nxla =3D channel->lmdesc.base_dma + @@ -295,8 +292,6 @@ static void rz_dmac_enable_hw(struct rz_dmac_chan *chan= nel) rz_dmac_ch_writel(channel, CHCTRL_SWRST, CHCTRL, 1); rz_dmac_ch_writel(channel, chctrl, CHCTRL, 1); } - - local_irq_restore(flags); } =20 static void rz_dmac_disable_hw(struct rz_dmac_chan *channel) --=20 2.43.0