From nobody Tue Apr 7 04:36:26 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF717399357 for ; Mon, 16 Mar 2026 13:33:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773667987; cv=none; b=rdzlf1oFnzg23e88BU9XZTjqb6mlhgOuF/+2CuD6MNFLvLMP67qwejCeZBuM88Xozjpy7DMU2tOUonBhbbaMqdWwrPdKFWtHVZ2flDJYrhlN9lK4/bnH6qCjpOePfIg+k/Nm5ZZlrXozCJMkeiXPLTNt+DnUM2AV2ZypJ2C4Q2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773667987; c=relaxed/simple; bh=5vNGiQOV9z2LuY7BexBTaM4+b8WdnI5Dm+Qs8Ojt3x4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RUM5uS2GOjckBTOuGl2zTaP4RbtKoaCOAGGrt4mczTnFWNqTKVxBAvwHOXzgb3SzhNFR+IhG8zIggzJzH3m2mvXs0dJQtTPiWnDBwzCNegWG117xhZS0evY1CveI4A9noce2fHlUHJEMQsn4FRLESL+Pvu0hvIMgiMjsAnCVto0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Y3cleuAq; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Y3cleuAq" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-6653b589a78so1817750a12.3 for ; Mon, 16 Mar 2026 06:33:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1773667984; x=1774272784; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3+W56HzNycC2wMkiULlWF3cNiCiN6FevvWbhSc6vRfM=; b=Y3cleuAqHMD2a1ulTa1eWT8AYviCDnSgUM1AjUDk3vEQfxmWIN1okEtY2l/sUvGgLl hoYhqQGkCZH1YOQAmJ/Q+hRM5TsSbvmrbD0u4XVRbar9sKzQO4E3H0FKVpBwwaaNf1RB OQVVM15AxdJ/KwTYgCxt1jdcdfl4wMj3a9L70LDq0SKSLhQh/ToEDQnrV0wGzrzF6egR 3mM+Niqtg7eKyq3Ai36fl5QliY9C0gEt1NyZAdAVWhPkuLFlpdT1rmXurk6Lpc0sqQFB Pdjzj5d8YQ+LlqlLTbgv8LAjIzwjKFgyBdtZS6DCREyQWR8JTAmfaQsgWH2uPZov9axC xx2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773667984; x=1774272784; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3+W56HzNycC2wMkiULlWF3cNiCiN6FevvWbhSc6vRfM=; b=JBXAXDo7PcoILOSJssdsizLk+QmLYbrm5SiMTFx8au5Yhk/WcEH0GtTHdhgDevLc9J dgC2G2gWzHZ45aCZEwaS1ODzQNLKGJBDQK7fNePAbvmfjGpUJNgZDCXv6Ei9P70tyAjs H25ID179+JAT5hZElvm9jUT1dAh9cC3HRjBCtJYZfCUvj3RLYsoqiNzBFxQVWZDHfGdh UsHofTLQbYNSZFaq7kUzseRdhncNFd+R6P1HtDdPz7zbeRzTCRwT9DrkCcDLz0vZDH57 KpBI0SvO3hyjaFEWdp2yyHykJpaIcAiiyBMYl3in/ottkqYqcY620r+xIM8onjz8gNS0 GA5g== X-Forwarded-Encrypted: i=1; AJvYcCXibO3Omp7DZfGCOgIk8iAbfLvNO+geLGA0KZopXxiCgQh8voAs4NjwoWHXXwYjtWu9OH+8FxWYAsYH8ak=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+xzdqdLQAqK67rk2tol0V1j6bhboeSTQg/04GHHWemLXnAqid zqoRE2xU4l30YvQGzarI8bEMzngaB88C3no1YUNMEbby68OCf46skMG1RADd8tJPJdA= X-Gm-Gg: ATEYQzzXRskwd8voGMK5UqhVvTrGBQNnS/LrPF2UIXDFURkGua5AWgAtZ5ZhQZBx7Dm fUdZ4AFctdTvvPkk3uuJa/1E5iyD4OnXp8BhhmmA9w9rk4hb3p++cbxHh0u/opRKwjCZ9/G4B9I OdzvW4e8M6Cv+0lq62O/UBDAvuv7dDL7VR80ross1soN3DRqs9jMRePodaSf7dh643IviWKOgWn yNT2PDOG+lQDgkD9v0ZGSFOej6GRVh8c33rWOa0m/NvYbI1wcL1gvsqVNO7VMx1RPb/7/byRmnL qe76x4eBtT/OQ15dNzAJd1cfaUJ1wDDJGENNIz2eKISd2cS6OVxiEpWlvMLycPjyLPs3TANzptu QIRTVr2e6Y9BuHBrWjnbknY/U1ooQRuKL1cO5g/3PzfsZB448xHtSlw6En7m7HiSlgmDYQR7hcK fjJIuBK2isl00akG5QCgUGw59jpRtuELWNVfxRi9v6Sl39ie6jE5fqnt3i5yJpWkaybZg2hN9GW GlJABg= X-Received: by 2002:a17:907:2982:b0:b93:5405:9260 with SMTP id a640c23a62f3a-b976519a1e1mr613963966b.30.1773667983963; Mon, 16 Mar 2026 06:33:03 -0700 (PDT) Received: from claudiu-TUXEDO-InfinityBook-Pro-AMD-Gen9.. ([2a02:2f04:6208:0:c5e3:3624:ad1c:6b4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b419270efsm11629888f8f.16.2026.03.16.06.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 06:33:03 -0700 (PDT) From: Claudiu Beznea X-Google-Original-From: Claudiu Beznea To: vkoul@kernel.org, Frank.Li@kernel.org, geert+renesas@glider.be, biju.das.jz@bp.renesas.com, john.madieu.xa@bp.renesas.com, prabhakar.mahadev-lad.rj@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea , stable@vger.kernel.org, Frank Li Subject: [PATCH v10 1/8] dmaengine: sh: rz-dmac: Protect the driver specific lists Date: Mon, 16 Mar 2026 15:32:45 +0200 Message-ID: <20260316133252.240348-2-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260316133252.240348-1-claudiu.beznea.uj@bp.renesas.com> References: <20260316133252.240348-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver lists (ld_free, ld_queue) are used in rz_dmac_free_chan_resources(), rz_dmac_terminate_all(), rz_dmac_issue_pending(), and rz_dmac_irq_handler_thread(), all under the virtual channel lock. Take the same lock in rz_dmac_prep_slave_sg() and rz_dmac_prep_dma_memcpy() as well to avoid concurrency issues, since these functions also check whether the lists are empty and update or remove list entries. Fixes: 5000d37042a6 ("dmaengine: sh: Add DMAC driver for RZ/G2L SoC") Cc: stable@vger.kernel.org Reviewed-by: Frank Li Signed-off-by: Claudiu Beznea --- Changes in v10: - none Changes in v9: - collected tags Changes in v8: - none Changes in v7: - none Changes in v6: - none Changes in v5: - none, this patch is new drivers/dma/sh/rz-dmac.c | 57 ++++++++++++++++++++++------------------ 1 file changed, 32 insertions(+), 25 deletions(-) diff --git a/drivers/dma/sh/rz-dmac.c b/drivers/dma/sh/rz-dmac.c index c75e9202e239..ec1b6b00af76 100644 --- a/drivers/dma/sh/rz-dmac.c +++ b/drivers/dma/sh/rz-dmac.c @@ -10,6 +10,7 @@ */ =20 #include +#include #include #include #include @@ -452,6 +453,7 @@ static int rz_dmac_alloc_chan_resources(struct dma_chan= *chan) if (!desc) break; =20 + /* No need to lock. This is called only for the 1st client. */ list_add_tail(&desc->node, &channel->ld_free); channel->descs_allocated++; } @@ -507,18 +509,21 @@ rz_dmac_prep_dma_memcpy(struct dma_chan *chan, dma_ad= dr_t dest, dma_addr_t src, dev_dbg(dmac->dev, "%s channel: %d src=3D0x%pad dst=3D0x%pad len=3D%zu\n", __func__, channel->index, &src, &dest, len); =20 - if (list_empty(&channel->ld_free)) - return NULL; + scoped_guard(spinlock_irqsave, &channel->vc.lock) { + if (list_empty(&channel->ld_free)) + return NULL; + + desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); =20 - desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); + desc->type =3D RZ_DMAC_DESC_MEMCPY; + desc->src =3D src; + desc->dest =3D dest; + desc->len =3D len; + desc->direction =3D DMA_MEM_TO_MEM; =20 - desc->type =3D RZ_DMAC_DESC_MEMCPY; - desc->src =3D src; - desc->dest =3D dest; - desc->len =3D len; - desc->direction =3D DMA_MEM_TO_MEM; + list_move_tail(channel->ld_free.next, &channel->ld_queue); + } =20 - list_move_tail(channel->ld_free.next, &channel->ld_queue); return vchan_tx_prep(&channel->vc, &desc->vd, flags); } =20 @@ -534,27 +539,29 @@ rz_dmac_prep_slave_sg(struct dma_chan *chan, struct s= catterlist *sgl, int dma_length =3D 0; int i =3D 0; =20 - if (list_empty(&channel->ld_free)) - return NULL; + scoped_guard(spinlock_irqsave, &channel->vc.lock) { + if (list_empty(&channel->ld_free)) + return NULL; =20 - desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); + desc =3D list_first_entry(&channel->ld_free, struct rz_dmac_desc, node); =20 - for_each_sg(sgl, sg, sg_len, i) { - dma_length +=3D sg_dma_len(sg); - } + for_each_sg(sgl, sg, sg_len, i) + dma_length +=3D sg_dma_len(sg); =20 - desc->type =3D RZ_DMAC_DESC_SLAVE_SG; - desc->sg =3D sgl; - desc->sgcount =3D sg_len; - desc->len =3D dma_length; - desc->direction =3D direction; + desc->type =3D RZ_DMAC_DESC_SLAVE_SG; + desc->sg =3D sgl; + desc->sgcount =3D sg_len; + desc->len =3D dma_length; + desc->direction =3D direction; =20 - if (direction =3D=3D DMA_DEV_TO_MEM) - desc->src =3D channel->src_per_address; - else - desc->dest =3D channel->dst_per_address; + if (direction =3D=3D DMA_DEV_TO_MEM) + desc->src =3D channel->src_per_address; + else + desc->dest =3D channel->dst_per_address; + + list_move_tail(channel->ld_free.next, &channel->ld_queue); + } =20 - list_move_tail(channel->ld_free.next, &channel->ld_queue); return vchan_tx_prep(&channel->vc, &desc->vd, flags); } =20 --=20 2.43.0