From nobody Tue Apr 7 02:54:15 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0332938D6B0 for ; Mon, 16 Mar 2026 13:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773667569; cv=none; b=Y05RdGDN3eQifghb1xb0ach57+sqOAOMDZq60SSK85xaTn0Gi4/nlYYdzPnZJDlDxNzFTf+k4AQlnUNa/jT0i3w2zSbuJGynpkr1NhCaRu6hEroPYp+subWnaSBAv76MYOpepAZJTIytzmyma53t8C+OXsWfCvrdboT1IxvHcxs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773667569; c=relaxed/simple; bh=EF7ThkIDWGZ71T6IecTms8KOZntoVVYPN0bKX3Nt7x4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qSYQc2XV/CpHrpGYC0OkC+5QpDmok2VPhLW6J2zh3ggjl1ko7bixib3NBv2UkBtmRyzv+xVqwoGumHi2He3sH/xLFTgmWAPjmAPFgvs4gPdXnd7K3lSCz0HFB1bbTF+Ep8Wi3fBX6Dgy1NJhxVE9CXPCJgcObrGuiYuiMn2Eb8Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fCnLRfjK; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fCnLRfjK" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c739e680bebso1466696a12.1 for ; Mon, 16 Mar 2026 06:26:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773667567; x=1774272367; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oP3lPjxS6zYX+flCgYkDZV1k9Jb2LZBcKTV9VF2r+hA=; b=fCnLRfjKOcknIW/B2OxCvv7orDx43Ie80kG6u9IE6CRdVXhPee0zdSJnallf4xs/lT yc1b4r4YWnb8UWHGRJTdbBRtDxeNC8Bf5Pdz5tC7trpiweULDlLM1hfg0/Ru4QSGJCUY iBwkY52M2XYM4iQY8HbNSfes8zRhBqX6mCGA8HIDkoaPYD84qjbe3mwlKaJt6HI4W1rW fXPVq2R50f8zlF5NbBXadh7QlftErhrHQKjS8UWb0PBzmmCNVepasbFj756+T5Ds2Ttr nnRXD57K+8oz4+OlufwHS5Um3IxfEaZNyd0L0DRIiVSqCTWTS4UNk7hbfzBNsljVZrfF QWQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773667567; x=1774272367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oP3lPjxS6zYX+flCgYkDZV1k9Jb2LZBcKTV9VF2r+hA=; b=tEGLXl7mZtc6Kz1smhk6p764p6xgG7aiVEqcfINAPdDV5DmQPwkc6bqcFJpwAk9WAl kIfwD6Mcy7TMc4KlT87qXYMElYH6sqBO6HVqqsMAa8/c3YWUesK93gq3gMMlCSRyrUa+ 9HRnCpVnDNAG8fjmPx3uPZlcMrILKQy4zn4Zt9up6eCKrNHkIP6GrftnwmzrU9bct3a3 4q3Ic1yhjZR8Oy00xrlDhHKPdv3JPHEIDknyrzEnrJTXafQKbIOT3j8nLYfNvPV9tExN 310ygQiuUb35Fs/ytY+jR59Wc8bFQOElrw1PjGJ6lOZqzUIEyZk59Xo/eX22LS1Ut+py n7rw== X-Forwarded-Encrypted: i=1; AJvYcCXP2NQnPmeatAiT7I8rcKA43E3JFiWxQCTYU8cF8M1B9qd+x48nAaNFgPc01lGHia9vRllANOPPaS3R78s=@vger.kernel.org X-Gm-Message-State: AOJu0YzDMfpD4kCPt3n0rIVwTNe7WAPMjp/WKJAxARiLeOWIuxl610kb IYDEJEr0WcbY/y70D0ebNi+DL6Z6ZCBeScF3kkeLI7ZqwSltS+XN1Wqu X-Gm-Gg: ATEYQzzt7u8fR6VECVV2m8tOIQ39iGbVPtabvg54ub5fVw2i2aaSpTCJnCbAe97egbj +HCFFMjh8cgKT1wzLxvwq/MtRjbxY+VTp4dTHwLSQqsiV6UHXB2lh3x0vxgvL89NBAzN4fFttmI JciweStDaDZcJHIIAYcpbizq4jKS1G0HYaomEnmTD3Z85ymtOtz822i5PiamtJ1shg1Lw5CYSy0 kL4u7aTCcuOkvgLbNpg3hdvmXXR43NP+CEGoa/g22XrdRLcH1jqWMSQhocvPN3AssYrlecX0mzF QR00QdCKByTGckOZHciOLk4/VfFPTZm9GE55OPTDuOVsYh4SjQTDx2t6gYFMFge//HnrWw15rGJ FbYXCbZQOKv5ZEz86Q4Je3VehzwWEBvbehIhtOOKArUTVKQhJd64J/djQtCOpeEJouUHVSiwNuN FnelWUNnJkE71j3uQb4m7LaeMK X-Received: by 2002:a17:902:f708:b0:2ae:cd8c:bd04 with SMTP id d9443c01a7336-2aecd8cc00emr101838685ad.10.1773667567266; Mon, 16 Mar 2026 06:26:07 -0700 (PDT) Received: from ubuntu.. ([152.58.131.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece60e6f6sm111100865ad.28.2026.03.16.06.26.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 06:26:06 -0700 (PDT) From: Anas Iqbal To: jonas.gorski@gmail.com Cc: florian.fainelli@broadcom.com, andrew@lunn.ch, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Anas Iqbal Subject: [PATCH] net: dsa: bcm_sf2: fix missing clk_disable_unprepare() in error paths Date: Mon, 16 Mar 2026 13:25:47 +0000 Message-ID: <20260316132547.1274-1-mohd.abd.6602@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Smatch reports: drivers/net/dsa/bcm_sf2.c:997 bcm_sf2_sw_resume() warn: 'priv->clk' from clk_prepare_enable() not released on lines: 983,990. The clock enabled by clk_prepare_enable() in bcm_sf2_sw_resume() is not released if bcm_sf2_sw_rst() or bcm_sf2_cfp_resume() fails. Add the missing clk_disable_unprepare() calls in the error paths to properly release the clock resource. Fixes: e9ec5c3bd238 ("net: dsa: bcm_sf2: request and handle clocks") Reviewed-by: Jonas Gorski Signed-off-by: Anas Iqbal v2: - Add Fixes tag as suggested by Jonas Gorski Reviewed-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index 960685596093..de3efa3ce9a7 100644 --- a/drivers/net/dsa/bcm_sf2.c +++ b/drivers/net/dsa/bcm_sf2.c @@ -980,15 +980,19 @@ static int bcm_sf2_sw_resume(struct dsa_switch *ds) ret =3D bcm_sf2_sw_rst(priv); if (ret) { pr_err("%s: failed to software reset switch\n", __func__); + if (!priv->wol_ports_mask) + clk_disable_unprepare(priv->clk); return ret; } =20 bcm_sf2_crossbar_setup(priv); =20 ret =3D bcm_sf2_cfp_resume(ds); - if (ret) + if (ret) { + if (!priv->wol_ports_mask) + clk_disable_unprepare(priv->clk); return ret; - + } if (priv->hw_params.num_gphy =3D=3D 1) bcm_sf2_gphy_enable_set(ds, true); =20 --=20 2.43.0