From nobody Tue Apr 7 05:42:50 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E521374738 for ; Mon, 16 Mar 2026 11:29:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773660551; cv=none; b=CafOt6iF9rIe0dpxL6gRaAs7Lj2VP9euEa8yIRD2GekxEjSVRTpfCz+ouUNPF/Br5XM9RYLJQNqzCi435GW4uP+UA+RzCPIx86mYzt7sv7AWFraCQA9FVvK8CsE9Sh3qhSzH74V8qowQVigznoJBiVjAANkl4kiOOlzeMr3eoYY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773660551; c=relaxed/simple; bh=UjK10OBfDG4cifl9Mz4i7HLK/ZoPL07F/KNEv3xPjSA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OUoBwE4S+jCoLRFzydNZMQUNcjdDq3cPUvc4oFEeHi62adbjHafNjBTrmyD9H3HYh1NNDATowidQ9un2b0FBjdp0IoTlVQ6CW3lqHBjRFP0sFOgQxD6DnClA9xwMqbREsKmfchmIDMp7NwupFk7VNOkenhLcdojPV+iGHpRRv/c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YTIRw/ct; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YTIRw/ct" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82984c077b2so2210246b3a.1 for ; Mon, 16 Mar 2026 04:29:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773660550; x=1774265350; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HpPRbYYnTe0Bs7rJxn1jlZ275hZTs9fjUlBButpAMuA=; b=YTIRw/ctKVt+YLqTE4cSt64k3AZn3q9DpzeRgQ4uzBbtOm05XInj7EAuJorrxbWpo1 /iyU0ob19rJfbHve6oJcNrN5GpQj2GyrEhCXS9nV9OoIaDeTjYIzT4M7Bl6Hx9NMMKWb +vTiUEH2kGaQUfk1sWHR/FTy/VaxTqR9uuHCO8NqVF35gjuFWVhwn7B149eq6+9n/ash 883Fhwzb5EA3lYb0MMdw0lra1Bxk8MSADXHvsepaYHSWtRm0jEvgoldKB+Ba5PP+DsaN ASl56O377Wa1ZgGRjxWXSUxzFjdTPHHWz8QJwYniZCvuJWEYOtq0gQurzFqOse+SiroQ cMkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773660550; x=1774265350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HpPRbYYnTe0Bs7rJxn1jlZ275hZTs9fjUlBButpAMuA=; b=FH+JJh4wSbzAKt+VMJTuKtcBqs0KzqpPwphOARrfQlwKe+JZy94wji1hzMuTXlO4hq W4kzSgxQkiG/J+pEVx8OkBek+dX9WFVFH7qU1QLnoaIZrnat3/m6mjzhsGn74TGpl/A+ bPIYOsiWUBGQJvhJREif++DhCmks8qnpNQc1sSqaqrTNt9K6EBkcNK4R2nnPwuC4R3v8 t4iSf4TPsF0uba9CyKf75riK/NZ/7KRM87JDpa9OuYVlkpS7WqQwiQEBv19PrJV6UDun QaV/c23/QAQrWelNt/WStBXS/LD26l9sl2+wf/yj+KWI2j6lmU9oQJJDKXWmVECNKCv4 PiNA== X-Forwarded-Encrypted: i=1; AJvYcCUfC6B2w91j9gJ4NzJ34S0+l6k44KNVufy5B3YrSNhn59akM74ZNxphH3/IOzmmlYaCIi12bbRNawAQ3VA=@vger.kernel.org X-Gm-Message-State: AOJu0YyjAf4aKAA+u/kFlrBsEv7TUzXcklwzPFHghN05QManVYhH34XG JBfLg2RzfbBStq5Kpflui8oPM1qN2tX0X4YTkgjPx8ReSsvl5un91XD+ X-Gm-Gg: ATEYQzwY6RYDVyCJJwOj2x8wt4n2hQApwHmMYCOw11CifTG4gsJHy8uo8+E+eA/gBI9 JGUuI7gq4mvfMT+4IrmNItXLadLnyXVCv6rFN6f2tLl9aomlou+F5moop7Xoj7+5HouGTgLL/n3 8ylAo3Dr1h4gnhxfTxuVEKHkTUB9eujyhMK9XJsCjJ/g40goa5a9acYuG6QYPO9CopKfaHloLRa 3viUBa75MMr0lCo5Yvqav78thPhVCoRrD+yOR5JyCxCA5I0trOxDupwZEd5izaruLi91h8WKniO DZ6V9b6I2blohUwm0RCLwkGdrbDKgcUP1nn68K/wJr+Ci1+i2eXcOxi1Ifls8I75RpxN+bbQKPX Lls9NWJYnZ69avYtxwNEenGHpGYilBScsUrfAJRLI//ZUtmFLx8LOrCWuR9wL3PRkx7KG5pgMmk 6xOoAGuOXEAHfTMYlJmQLNhrdvtzvFwHKY0HdXy6gC808fyLhAQp03FLtQWaT6iAumCw== X-Received: by 2002:a05:6a21:4d8c:b0:38e:54b8:60a1 with SMTP id adf61e73a8af0-398eca2fc4amr11781405637.4.1773660549984; Mon, 16 Mar 2026 04:29:09 -0700 (PDT) Received: from localhost.localdomain ([116.128.244.171]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7401588ecesm4684940a12.32.2026.03.16.04.29.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 16 Mar 2026 04:29:09 -0700 (PDT) From: Chengkaitao To: martin.lau@linux.dev, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me, haoluo@google.com, jolsa@kernel.org, shuah@kernel.org, chengkaitao@kylinos.cn, linux-kselftest@vger.kernel.org Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH bpf-next v8 2/8] bpf: refactor __bpf_list_del to take list node pointer Date: Mon, 16 Mar 2026 19:28:37 +0800 Message-ID: <20260316112843.78657-3-pilgrimtao@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260316112843.78657-1-pilgrimtao@gmail.com> References: <20260316112843.78657-1-pilgrimtao@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Kaitao Cheng Refactor __bpf_list_del to accept (head, struct list_head *n) instead of (head, bool tail). The caller now passes the specific node to remove: bpf_list_pop_front passes h->next, bpf_list_pop_back passes h->prev. Prepares for introducing bpf_list_del(head, node) kfunc to remove an arbitrary node when the user holds ownership. Signed-off-by: Kaitao Cheng --- kernel/bpf/helpers.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index cb6d242bd093..e87b263c5fe6 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -2426,9 +2426,10 @@ __bpf_kfunc int bpf_list_push_back_impl(struct bpf_l= ist_head *head, return __bpf_list_add(n, head, true, meta ? meta->record : NULL, off); } =20 -static struct bpf_list_node *__bpf_list_del(struct bpf_list_head *head, bo= ol tail) +static struct bpf_list_node *__bpf_list_del(struct bpf_list_head *head, + struct list_head *n) { - struct list_head *n, *h =3D (void *)head; + struct list_head *h =3D (void *)head; struct bpf_list_node_kern *node; =20 /* If list_head was 0-initialized by map, bpf_obj_init_field wasn't @@ -2439,7 +2440,6 @@ static struct bpf_list_node *__bpf_list_del(struct bp= f_list_head *head, bool tai if (list_empty(h)) return NULL; =20 - n =3D tail ? h->prev : h->next; node =3D container_of(n, struct bpf_list_node_kern, list_head); if (WARN_ON_ONCE(READ_ONCE(node->owner) !=3D head)) return NULL; @@ -2451,12 +2451,16 @@ static struct bpf_list_node *__bpf_list_del(struct = bpf_list_head *head, bool tai =20 __bpf_kfunc struct bpf_list_node *bpf_list_pop_front(struct bpf_list_head = *head) { - return __bpf_list_del(head, false); + struct list_head *h =3D (void *)head; + + return __bpf_list_del(head, h->next); } =20 __bpf_kfunc struct bpf_list_node *bpf_list_pop_back(struct bpf_list_head *= head) { - return __bpf_list_del(head, true); + struct list_head *h =3D (void *)head; + + return __bpf_list_del(head, h->prev); } =20 __bpf_kfunc struct bpf_list_node *bpf_list_front(struct bpf_list_head *hea= d) --=20 2.50.1 (Apple Git-155)