From nobody Tue Apr 7 05:43:35 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CAE537C916 for ; Mon, 16 Mar 2026 10:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773655984; cv=none; b=uZbzRHYMAnqX+Im3RG8YodswnCbdOH2jSoJSJV3Lih1h4Jgjiw2httJ8GEf5HPIPujB+fINAUs081kDDnhjhIz1sNBsC6VR6Yam/STfgB9wdG0M3Ox7yD9PoZ+VcZgcwxl8C5ygnOyTRQ1oOxGSDEdMvNSj9GqKwRBrQAhapoUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773655984; c=relaxed/simple; bh=lZX6HQjF/0E2nERVFKcTjN0vufIiznLworrRjgpiKxQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Xq3VqV14xGY4qJIo0dJRS8/teX4H8goHFeE+wH+fW9EcgVJiKfpC97fGTkaDMu0m/FVs4UJs2I8j2synuEk92xkX0GMx1VTwDeh1SYh1M9q7UBpc9WilnyPN19AxBfiRRCcUOdPMx5gfrd9xZH2PLh7jlKsoScY14w85gJXj5RY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hd7mOCEg; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hd7mOCEg" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c73aabd620bso2913317a12.1 for ; Mon, 16 Mar 2026 03:13:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773655982; x=1774260782; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BxyW5H4JDwZZVKFI+6XMRZ4X/ja44pFqAKNOBXdDChE=; b=hd7mOCEgpcR2wWVQGXQW2u58kMTlzRT6e2133PKywAJE5LEkiu8EGYw2mpGNAEo+y6 UiZ9+clhY/K0zfn4FfityKhdusi/tMqzsVtE9Me/weBDfMh4dWqkhTWZMtQelIIiqAzw BZRnv9RCevY2fx+M9gX2jEG747Pn2lMSRhu8aR9S87zQ/75XgWR8tBC4kRPP7YSWXG4A i8qyhncr0zVRxgMk8kowTUdRdoLTFRbxNyUVwjiGh+Ks7b8bfIH72SN2xJ+u8uEhal7s 5FT5QiVE1YHTDZk3sgVyzagOcRdXyCJyT4gKP83iN/SGQeNjNXrXuJUScmjpQ1ny/kBY OFUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773655982; x=1774260782; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BxyW5H4JDwZZVKFI+6XMRZ4X/ja44pFqAKNOBXdDChE=; b=WR4s8gkimqC4pFtU/5DjLuHHDfLGKnAN3XTia5B9KEwI0TilG8C+HFo09jnuiKbZ0b P54d8jToi17/mRD+XgaCWOMc8E0+tR9wQAJdSFbTjV/L8BKKcUX1DJihabhWgFrfpcRc Qz9/gyQCceqKQLYYRITDyM1hnZbAUu07+PgGOIM6k7m64JSGDhqYmfOyoN+rickb0oYE APLJdX5Ll5RdoEVQJ25G9QrhrLkQ97XTn2/DCREGDzM7lfdAqvBAYNC2jlE6Lln6Kd/X QTZ3HeexolVP11ISnfwi+qVURXKC3aKM/GxjjSz/o5X9D8MMVI9cHFcnjXx4MbW3knlD v5tQ== X-Gm-Message-State: AOJu0YzA9XPIOfSv02LxQVMj9erZ2ZviJ6dvtZaf38bLHswRpz7ytGWr 4ie/uSSHwGLe3smnorHlsYsHxGZKMt5qmoJ+gMxxuoSC0A8menZ+S20NpWm57A== X-Gm-Gg: ATEYQzxd/onOFG/T1OTPF9iySabeLMmhaA5A3kXNri1NHNl9achchLqgk+ESh4hudJq IIm7TUt6OW9DC5saqDupNR8KZLQj+wqG0O36q0oATmIAyMkq3AHIqzUOlFLxvd8TC2fev35QDbN xog6JdMpPic/WIStvEkVMDbdckruSo2ovKT5xm9mz+xJiTrPtsXjQNklJoC6xqvXAhU+vWHu4Gn VL2lAJ1LZBJuhtwWDEPrNiGJsSMu1HoEIqTHm3j6Fxcqimt5tpXTyLqcNlXn2oYpr6Ry5fStQcL ubFBxWLCqzb/84Ll3fqtoyg042gzdVFuVP9rqRzIvNqL4pXAkRRPGp2bx2ZoQPWkpiT8Ykb+RRB jipAoiMD95MY5l4YParuO+O+iUpF/i6EM5sgJ62ejjXla7WGG4cD+zYMYu1mhH7vUdFRVN1mpQb 87Ie/zJ2GP+MJkZ1SI7OYnT6/LZ9DwnHAafjkN9xyWu3q1UEAbOFzNcC7PnLsGCWwHLEvvTyrpF h7ka6nyLFlX/l0= X-Received: by 2002:a05:6a21:3212:b0:398:a6d4:dbf7 with SMTP id adf61e73a8af0-398ecd98afbmr11039122637.55.1773655982330; Mon, 16 Mar 2026 03:13:02 -0700 (PDT) Received: from localhost.localdomain ([43.245.86.102]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73ebb7f2basm8145272a12.29.2026.03.16.03.13.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 16 Mar 2026 03:13:02 -0700 (PDT) From: Shuvam Pandey To: Andrew Morton Cc: linux-kernel@vger.kernel.org Subject: [PATCH] lib/tests: extend cmdline KUnit with next_arg() tests Date: Mon, 16 Mar 2026 15:57:27 +0545 Message-ID: <20260316101227.15807-1-shuvampandey1@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The cmdline KUnit suite covers get_option() and get_options(), but it does not exercise next_arg(). Extend the suite with one test for a quoted value containing spaces and one regression test for a bare quote token after a normal parameter. The regression test covers the bare quote token path fixed by commit 9847f21225c4 ("lib/cmdline: avoid page fault in next_arg"). Signed-off-by: Shuvam Pandey --- lib/tests/cmdline_kunit.c | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/lib/tests/cmdline_kunit.c b/lib/tests/cmdline_kunit.c index c1602f797637..b5c7aba65f43 100644 --- a/lib/tests/cmdline_kunit.c +++ b/lib/tests/cmdline_kunit.c @@ -139,11 +139,49 @@ static void cmdline_test_range(struct kunit *test) } while (++i < ARRAY_SIZE(cmdline_test_range_strings)); } =20 +static void cmdline_test_next_arg_quoted_value(struct kunit *test) +{ + char in[] =3D "foo=3D\"bar baz\" qux=3D1"; + char *next, *param, *val; + + next =3D next_arg(in, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "foo"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, "bar baz"); + KUNIT_EXPECT_STREQ(test, next, "qux=3D1"); + + next =3D next_arg(next, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "qux"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, "1"); + KUNIT_EXPECT_STREQ(test, next, ""); +} + +static void cmdline_test_next_arg_bare_quote_regression(struct kunit *test) +{ + char in[] =3D "foo=3Dbar \""; + char *next, *param, *val; + + next =3D next_arg(in, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, "foo"); + KUNIT_ASSERT_NOT_NULL(test, val); + KUNIT_EXPECT_STREQ(test, val, "bar"); + KUNIT_EXPECT_STREQ(test, next, "\""); + + /* This hits the i =3D=3D 0 quoted-token case fixed by 9847f21225c4. */ + next =3D next_arg(next, ¶m, &val); + KUNIT_EXPECT_STREQ(test, param, ""); + KUNIT_EXPECT_PTR_EQ(test, val, NULL); + KUNIT_EXPECT_STREQ(test, next, ""); +} + static struct kunit_case cmdline_test_cases[] =3D { KUNIT_CASE(cmdline_test_noint), KUNIT_CASE(cmdline_test_lead_int), KUNIT_CASE(cmdline_test_tail_int), KUNIT_CASE(cmdline_test_range), + KUNIT_CASE(cmdline_test_next_arg_quoted_value), + KUNIT_CASE(cmdline_test_next_arg_bare_quote_regression), {} }; =20 --=20 2.50.1 (Apple Git-155)