From nobody Tue Apr 7 04:14:22 2026 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF04933A6F8 for ; Mon, 16 Mar 2026 09:28:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773653319; cv=none; b=fuf+0D7M6slzGgYQOrMnrv5GUXRYGfewK77SZMrKbeYkOdq1g0nUmdjw/rThoLdCo9Njv9rdYOmnGDKHPPcdiivmbK4uCf7eEAoAkuJUzI1ommIt1tNbygsj7T4bS/rSY6ZRE/EZw/JteWXH1uS8vfXzdjVCgyW3JrBP0eRcxeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773653319; c=relaxed/simple; bh=oQzzFAMCttNUJVUfDwf/erlmu1VPa/A4aDaVaPX++84=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pwN9weeMDUnqn8wO4fzQCyNTi7V3FjGgu+1Jh0H1jxHoPT4VwKJyGZUfx32cfduRDo1q/s4LLy3vk7BlKl6fdM+7hatjI2fxtACckb9+1tZ/7Dk6lhuFEx+M7za7PE+swlCBXTAHSH8CYaJCxskx7FaBTdwwmUBN0lUYieIhdlg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j3uZs2K6; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j3uZs2K6" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-663a6bb0fa1so5048194a12.3 for ; Mon, 16 Mar 2026 02:28:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773653316; x=1774258116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=C2/IwV2vEnvqLSZJL+1QuzLYnReiJ7GcK2/btvbYBlw=; b=j3uZs2K6iYR9CL11l+Dd8i/kCLUVm42UXiMxQz3moarrYB/WIXdzF8iROQf3IIlO1k b2fTC6DEQr2adHYwCc+KdsRikhrVMvIpn66YuvDXF8PelYuH59JVrvuRK09YbJyGKln4 hSCvoGZe1oyCzf8FyQCx4wxchoCIObbR2/Gzvgzo6qq/73jvPtrwufPlV7K/C/Nkhh38 wB1c5la/igKfKNSidpJIaaNErkOHgDeZeTeIXU8ETIrdeAo82mjzVZ/bhlGpQIP/adeT XD4z27G1G3UoSqfVxRYspaNrivxIJUArakpe+o8cFXlKVwcEmQqbsmapeuwx3gJiyz0i b3Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773653316; x=1774258116; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=C2/IwV2vEnvqLSZJL+1QuzLYnReiJ7GcK2/btvbYBlw=; b=pIPe30BWF+P8VIqzeDNRZWYn14IxLLvTDavg8A4A/rdFZa0V5uN5AB02mpfyswyfZ/ ynB3/R20f1ZYiLjJzHllFAsmX0AZR5X49foiOSmbxCuS9JU+WhvJXWbOIJmO/4Bqj0J0 +5u9q5dHwSm7gg/+aNcvrQEumz8oRlyJL91qPo0IaR7xBGhhn6x70EEMxKeXcKnz1XiK uclJ5+juZ9b4AP8r35o/HhzXqGWtIHHvaTEpCjxeSFDbvrYLokgnGN/Bozg2k0fPQnPY yyc1O1jK6Yy9vKEZROpLppuFDQbL9miE1dETL3/yGAomz1XAHIk7WMGCB18cCf32cOQR 2lvA== X-Forwarded-Encrypted: i=1; AJvYcCXY0W9BMBuxhlr1bWWGd8wDs6qvpf1SUslfCVNQhq2WG5KAs3OlbY5x3kMgpAQGAEtLYz1lqGLaxrTmUoY=@vger.kernel.org X-Gm-Message-State: AOJu0Yya13tDPjRI3kSR6qt4vmUEb+Ou1JeQ79KuaRCqbpRfIE6EOs58 XcbyF153q1AcKhAuA0GD7ha3IzLb8MR6i5H0o1ZCnZBrx3o3vmBIuB3m X-Gm-Gg: ATEYQzygyv3nVfiqWbj82eZqLHuhdnAHonNlX7gI5v76VG/I9OmNVI9E6yZBdU70ALF GExI8Uf05lCanpfN7qf8WnLtQqs64TDv8l6tkabcv6SqnUzXx565W5Dg7nw/Db19+ra4mx2Vdph biFnZCOrAIBEeqD1rOr8Gi/rxL018RQ9VhTZUzk7v/b3TvQ1k4GXl6eQOIMrY0udn3tyaDPm1O9 fH8Is852XZsBkpbnUsCyz395RBsiLhYnbCTQxSjgxaVZ+rKLc3k2PDhlSTpUZgwaTNTQl0iMtXN L7mXYv2nDLA7SXKIyGWMzNawwKPpnUGaTd8L9fAwaJHg5uu3leyKL5lZR08hii/Ql6EdOyNli3o ZlQB+Ti3Qwo3t4jwk5dVghNySl4dgX39rg0d5uMTXOtFGGbLAIkuqHNyxi+JS3R7QcISovuqmmA C57DuKZKIkxAcO3A== X-Received: by 2002:a05:6402:1476:b0:660:a2df:ad1 with SMTP id 4fb4d7f45d1cf-663ba0e9e6dmr7669579a12.7.1773653315826; Mon, 16 Mar 2026 02:28:35 -0700 (PDT) Received: from gmail.com ([2a09:bac5:4e24:2e3c::49b:47]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-663509919c9sm4892225a12.23.2026.03.16.02.28.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 02:28:35 -0700 (PDT) From: Qingfang Deng To: linux-ppp@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: James Chapman Subject: [PATCH net-next] ppp: require callers of ppp_dev_name() to hold RCU Date: Mon, 16 Mar 2026 17:28:23 +0800 Message-ID: <20260316092824.479149-1-dqfext@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ppp_dev_name() holds the RCU read lock internally to protect pch->ppp. However, as it returns netdev->name to the caller, the caller should also hold either RCU or RTNL lock to prevent the netdev from being freed. The only two references of the function is in the L2TP driver, both of which already hold RCU. So remove the internal RCU lock and document that callers must hold RCU. Signed-off-by: Qingfang Deng Reviewed-by: Breno Leitao --- drivers/net/ppp/ppp_generic.c | 3 +-- include/linux/ppp_channel.h | 4 +++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ppp/ppp_generic.c b/drivers/net/ppp/ppp_generic.c index 6344c5eb0f98..0918ece061eb 100644 --- a/drivers/net/ppp/ppp_generic.c +++ b/drivers/net/ppp/ppp_generic.c @@ -2995,6 +2995,7 @@ int ppp_unit_number(struct ppp_channel *chan) =20 /* * Return the PPP device interface name of a channel. + * Caller must hold RCU read lock. */ char *ppp_dev_name(struct ppp_channel *chan) { @@ -3003,11 +3004,9 @@ char *ppp_dev_name(struct ppp_channel *chan) struct ppp *ppp; =20 if (pch) { - rcu_read_lock(); ppp =3D rcu_dereference(pch->ppp); if (ppp && ppp->dev) name =3D ppp->dev->name; - rcu_read_unlock(); } return name; } diff --git a/include/linux/ppp_channel.h b/include/linux/ppp_channel.h index ca8ad03eeef0..2f63e9a6cc88 100644 --- a/include/linux/ppp_channel.h +++ b/include/linux/ppp_channel.h @@ -72,7 +72,9 @@ extern int ppp_channel_index(struct ppp_channel *); /* Get the unit number associated with a channel, or -1 if none */ extern int ppp_unit_number(struct ppp_channel *); =20 -/* Get the device name associated with a channel, or NULL if none */ +/* Get the device name associated with a channel, or NULL if none. + * Caller must hold RCU read lock. + */ extern char *ppp_dev_name(struct ppp_channel *); =20 /* --=20 2.43.0