From nobody Thu Apr 2 20:16:45 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D4101F4168 for ; Mon, 16 Mar 2026 08:31:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773649899; cv=none; b=PNq13a8f/pun3YW9KTXbN9Z0BwVfEql0MbEFVctFX/Dne4i2e3d1jFZZA6tMvALcSshoWhBy40RmcYtBIejlDX4PSHfxG5GSvynhOoUhFgS+6Z77e5SgG1SumyvsZY8m+sGRdXhpnJi9NKU0SBkP9XClddfLbVBky0swMGzTGF0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773649899; c=relaxed/simple; bh=SbzoBorLYrD7JirBAghIl6KN+QOccmx9tCu7NPjLY+g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RtUNYk5s8FBSCEExaAhmjaw3d3eklj296IrouWdyeMkMYjFwWBHSuzxe9uj6++RiF5Ae/Rclxn0ggaYvF1ammCslS9CGaT1CtU/c4nP/j53fMFu98f/KSI8zv0QTnKBNOvyie7Iqry36kwCToYEh4j1cLPSJccv5bOlPCZdHPPE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cobB987+; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cobB987+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773649898; x=1805185898; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SbzoBorLYrD7JirBAghIl6KN+QOccmx9tCu7NPjLY+g=; b=cobB987+QImTf8RfGMWhMmxQl+zmszZfy8jDpkoyGk2i5g4P/RN+om3Q XLahI8V/TR2COJMMwycHde8XtucUBvol3cAb70fobzvbZFAmTOlRJKKbe 7ofoFfYzbduHqZ9Mx9Y02dwfeIUs9fiVw1KdJ0rfJ2wCJu4SZGHyB84G0 JQPGOOHmI8zLzt1E1kJ+plkWRFvt2sFTr4QucJSoDUOc4wMHckWp+lsN4 OECVNKKEXZOi0MCeyDqFwua7yXNbwoV879LtelLohI8tQIBnltBEAXLC8 2iZ9USEAElxmluCCee3LMYnU9yDQ4HEObKo8/q8Ra0fPatoZYl0sV868/ Q==; X-CSE-ConnectionGUID: tg1vUCIpSOWkaIWVBWAFyw== X-CSE-MsgGUID: 4JbnpRDsSISORN4tkUfl4A== X-IronPort-AV: E=McAfee;i="6800,10657,11730"; a="77268388" X-IronPort-AV: E=Sophos;i="6.23,123,1770624000"; d="scan'208";a="77268388" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 01:31:38 -0700 X-CSE-ConnectionGUID: o3KNXB+cSn2qLk1J/aLJ6w== X-CSE-MsgGUID: Bv93gwZ3S7GLeNIipK00hQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,123,1770624000"; d="scan'208";a="220889111" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) by orviesa006.jf.intel.com with ESMTP; 16 Mar 2026 01:31:29 -0700 From: Suraj Kandpal To: freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-list@raspberrypi.com, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, uma.shankar@intel.com, dmitry.baryshkov@oss.qualcomm.com, arun.r.murthy@intel.com, jani.nikula@intel.com, harry.wentland@amd.com, siqueira@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch, liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, robin.clark@oss.qualcomm.com, abhinav.kumar@linux.dev, tzimmermann@suse.de, sean@poorly.ru, marijn.suijten@somainline.org, laurent.pinchart+renesas@ideasonboard.com, dave.stevenson@raspberrypi.com, tomi.valkeinen+renesas@ideasonboard.com, kieran.bingham+renesas@ideasonboard.com, Suraj Kandpal Subject: [PATCH v3 7/7] drm/connector: Modify cleanup_writeback_job helper Date: Mon, 16 Mar 2026 14:00:09 +0530 Message-Id: <20260316083008.87466-8-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260316083008.87466-1-suraj.kandpal@intel.com> References: <20260316083008.87466-1-suraj.kandpal@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Pass drm_connector to prepare_writeback_job since drm_writeback_connector now resides within drm_connector. It also makes it uniform with params passed to other drm_connector_helper_funcs. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 4 ++-- drivers/gpu/drm/drm_writeback.c | 2 +- drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 4 +--- drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 6 ++---- drivers/gpu/drm/vkms/vkms_writeback.c | 5 +---- include/drm/drm_modeset_helper_vtables.h | 2 +- 6 files changed, 8 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c b/drivers= /gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c index d02f5d20f3b1..bf1ecf5d3027 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c @@ -144,8 +144,8 @@ static int amdgpu_dm_wb_prepare_job(struct drm_connecto= r *connector, return r; } =20 -static void amdgpu_dm_wb_cleanup_job(struct drm_writeback_connector *conne= ctor, - struct drm_writeback_job *job) +static void amdgpu_dm_wb_cleanup_job(struct drm_connector *connector, + struct drm_writeback_job *job) { struct amdgpu_bo *rbo; int r; diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index d6b260478889..1134be412cde 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -447,7 +447,7 @@ void drm_writeback_cleanup_job(struct drm_writeback_job= *job) connector->helper_private; =20 if (job->prepared && funcs->cleanup_writeback_job) - funcs->cleanup_writeback_job(wb_connector, job); + funcs->cleanup_writeback_job(connector, job); =20 if (job->fb) drm_framebuffer_put(job->fb); diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c b/drivers/gpu/dr= m/msm/disp/dpu1/dpu_writeback.c index b8b299067845..8e10d71ad292 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c @@ -100,11 +100,9 @@ static int dpu_wb_conn_prepare_job(struct drm_connecto= r *connector, return 0; } =20 -static void dpu_wb_conn_cleanup_job(struct drm_writeback_connector *wb_con= nector, +static void dpu_wb_conn_cleanup_job(struct drm_connector *connector, struct drm_writeback_job *job) { - struct drm_connector *connector =3D - container_of(wb_connector, struct drm_connector, writeback); struct dpu_wb_connector *dpu_wb_conn =3D to_dpu_wb_conn(connector); =20 if (!job->fb) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/= gpu/drm/renesas/rcar-du/rcar_du_writeback.c index a0ad4c97971e..5553b7fcbd3a 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -72,12 +72,10 @@ static int rcar_du_wb_prepare_job(struct drm_connector = *connector, return 0; } =20 -static void rcar_du_wb_cleanup_job(struct drm_writeback_connector *connect= or, +static void rcar_du_wb_cleanup_job(struct drm_connector *connector, struct drm_writeback_job *job) { - struct drm_connector *conn =3D - drm_writeback_to_connector(connector); - struct rcar_du_crtc *rcrtc =3D wb_to_rcar_crtc(conn); + struct rcar_du_crtc *rcrtc =3D wb_to_rcar_crtc(connector); struct rcar_du_wb_job *rjob =3D job->priv; =20 if (!job->fb) diff --git a/drivers/gpu/drm/vkms/vkms_writeback.c b/drivers/gpu/drm/vkms/v= kms_writeback.c index ebfd243e2c1a..fffdee585e4a 100644 --- a/drivers/gpu/drm/vkms/vkms_writeback.c +++ b/drivers/gpu/drm/vkms/vkms_writeback.c @@ -103,13 +103,10 @@ static int vkms_wb_prepare_job(struct drm_connector *= connector, return ret; } =20 -static void vkms_wb_cleanup_job(struct drm_writeback_connector *wb_conn, +static void vkms_wb_cleanup_job(struct drm_connector *connector, struct drm_writeback_job *job) { struct vkms_writeback_job *vkmsjob =3D job->priv; - struct drm_connector *connector =3D container_of(wb_conn, - struct drm_connector, - writeback); struct vkms_output *vkms_output =3D container_of(connector, struct vkms_output, wb_connector); diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_mod= eset_helper_vtables.h index 9de96a04784e..4a0e7c19dd4e 100644 --- a/include/drm/drm_modeset_helper_vtables.h +++ b/include/drm/drm_modeset_helper_vtables.h @@ -1134,7 +1134,7 @@ struct drm_connector_helper_funcs { * * This callback is used by the atomic modeset helpers. */ - void (*cleanup_writeback_job)(struct drm_writeback_connector *connector, + void (*cleanup_writeback_job)(struct drm_connector *connector, struct drm_writeback_job *job); =20 /** --=20 2.34.1