From nobody Thu Apr 2 20:16:46 2026 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 685A537F730 for ; Mon, 16 Mar 2026 08:31:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773649874; cv=none; b=Zf5FH1O71k7CpQg95hafuNx4ndOsDradUGyeP/bHtpIJPzyeGT+GOmLwrAAQ5WIttDIJLyc2+xbxOGzkVzELu2UfJ8zSAJgfk1043jhl70ELxpqaZJg4verVVHJaC8dfQav5keL+e9AViv7RrpwcAFvC3PfUX2erwb1BFmnnZ6Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773649874; c=relaxed/simple; bh=k4y8iTNZZPlbPyjzE+qIn051SDnRprfm7rCbusDToDs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=pZQt7StupJMAqoRxtv678Wi6XF6zKYHd+cgXjJKzWkL689r/t9VT8yaKxSePPopeQrMCPQOCrwtvje9iw0FwcKb1v/BdGmYiZt8S55bftGpjgKFRKJJpdlqNAd5FKh1Jk5gSkB3LAxoETANUDQe08e8Es0a3bXsw4dRuDVy44Mo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=jkr0A3Gv; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="jkr0A3Gv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1773649872; x=1805185872; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=k4y8iTNZZPlbPyjzE+qIn051SDnRprfm7rCbusDToDs=; b=jkr0A3GvGTONABgqgaaR1zaAvQTiQ4UAV38GdXM1GBJmoVcqTgDDBCgJ bqFye7NqW4CdV4pqltEJ+lam74+TYRfOWX4u1wki/Xd3AwYL3UgyyX9aX sbnZrI4TMI5V7zfplXsvuEoFIcgSQfx/usptGFUb5ozILKckbYrKdGWvX aP9ppUte04tzU+ShSxiTDtOBTnT34QN0/6YJri0cCuKiUSHmjIGvEot/+ 8h53vQgskO9JCibRd5Xt75P7GPnDiYozRmimTihxYDr30jHqnRmkeao/8 U7wT7oGiwfVhnx9bZKLNtF3rzLeiqW9gB/gGVAeX1GOC+xGRbrLxQx72g A==; X-CSE-ConnectionGUID: 3xsXgvSPSSO6r70WJDIUvg== X-CSE-MsgGUID: KyKni5rZSEe3rN96qS9+ww== X-IronPort-AV: E=McAfee;i="6800,10657,11730"; a="77268304" X-IronPort-AV: E=Sophos;i="6.23,123,1770624000"; d="scan'208";a="77268304" Received: from orviesa006.jf.intel.com ([10.64.159.146]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2026 01:31:12 -0700 X-CSE-ConnectionGUID: F4OwHw9zQIyn58eECFYpiw== X-CSE-MsgGUID: OHmb2rmaSyyv5YCy+9dpVg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,123,1770624000"; d="scan'208";a="220889057" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.10]) by orviesa006.jf.intel.com with ESMTP; 16 Mar 2026 01:31:03 -0700 From: Suraj Kandpal To: freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel-list@raspberrypi.com, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: ankit.k.nautiyal@intel.com, uma.shankar@intel.com, dmitry.baryshkov@oss.qualcomm.com, arun.r.murthy@intel.com, jani.nikula@intel.com, harry.wentland@amd.com, siqueira@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, airlied@gmail.com, simona@ffwll.ch, liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, robin.clark@oss.qualcomm.com, abhinav.kumar@linux.dev, tzimmermann@suse.de, sean@poorly.ru, marijn.suijten@somainline.org, laurent.pinchart+renesas@ideasonboard.com, dave.stevenson@raspberrypi.com, tomi.valkeinen+renesas@ideasonboard.com, kieran.bingham+renesas@ideasonboard.com, Suraj Kandpal Subject: [PATCH v3 4/7] drm: writeback: Modify drm_writeback_signal_completion param Date: Mon, 16 Mar 2026 14:00:06 +0530 Message-Id: <20260316083008.87466-5-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260316083008.87466-1-suraj.kandpal@intel.com> References: <20260316083008.87466-1-suraj.kandpal@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Move to using drm_connector instead of drm_writeback_connector since it now resides within drm_connector. This will also help make sure drivers do not need to access drm_writeback_connector as much. Signed-off-by: Suraj Kandpal --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +- drivers/gpu/drm/arm/malidp_hw.c | 6 +++--- drivers/gpu/drm/drm_writeback.c | 6 ++++-- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 4 ++-- drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c | 2 +- drivers/gpu/drm/vc4/vc4_txp.c | 2 +- drivers/gpu/drm/vkms/vkms_composer.c | 2 +- include/drm/drm_writeback.h | 2 +- 9 files changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 9faf16036531..308809128ac1 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -679,7 +679,7 @@ static void dm_crtc_high_irq(void *interrupt_params) 100LL, (v_total * stream->timing.h_total)); mdelay(1000 / refresh_hz); =20 - drm_writeback_signal_completion(acrtc->wb_conn, 0); + drm_writeback_signal_completion(acrtc->connector, 0); dc_stream_fc_disable_writeback(adev->dm.dc, acrtc->dm_irq_params.stream, 0); } diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu= /drm/arm/display/komeda/komeda_crtc.c index 0d22c2e7f722..eed6ac53cc35 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c @@ -213,7 +213,7 @@ void komeda_crtc_handle_event(struct komeda_crtc *kcr= tc, struct komeda_wb_connector *wb_conn =3D kcrtc->wb_conn; =20 if (wb_conn) - drm_writeback_signal_completion(&wb_conn->base.writeback, 0); + drm_writeback_signal_completion(&wb_conn->base, 0); else drm_warn(drm, "CRTC[%d]: EOW happen but no wb_connector.\n", drm_crtc_index(&kcrtc->base)); diff --git a/drivers/gpu/drm/arm/malidp_hw.c b/drivers/gpu/drm/arm/malidp_h= w.c index 5a7bd27d3718..9b845d3f34e1 100644 --- a/drivers/gpu/drm/arm/malidp_hw.c +++ b/drivers/gpu/drm/arm/malidp_hw.c @@ -1315,15 +1315,15 @@ static irqreturn_t malidp_se_irq(int irq, void *arg) if (status & se->vsync_irq) { switch (hwdev->mw_state) { case MW_ONESHOT: - drm_writeback_signal_completion(&malidp->mw_connector.writeback, 0); + drm_writeback_signal_completion(&malidp->mw_connector, 0); break; case MW_STOP: - drm_writeback_signal_completion(&malidp->mw_connector.writeback, 0); + drm_writeback_signal_completion(&malidp->mw_connector, 0); /* disable writeback after stop */ hwdev->mw_state =3D MW_NOT_ENABLED; break; case MW_RESTART: - drm_writeback_signal_completion(&malidp->mw_connector.writeback, 0); + drm_writeback_signal_completion(&malidp->mw_connector, 0); fallthrough; /* to a new start */ case MW_START: /* writeback started, need to emulate one-shot mode */ diff --git a/drivers/gpu/drm/drm_writeback.c b/drivers/gpu/drm/drm_writebac= k.c index 1c1802d87f13..f3b4371d4201 100644 --- a/drivers/gpu/drm/drm_writeback.c +++ b/drivers/gpu/drm/drm_writeback.c @@ -477,7 +477,8 @@ static void cleanup_work(struct work_struct *work) =20 /** * drm_writeback_signal_completion - Signal the completion of a writeback = job - * @wb_connector: The writeback connector whose job is complete + * @connector: The drm connector whicha has the drm_writeback_connector wh= ose + * job is complete * @status: Status code to set in the writeback out_fence (0 for success) * * Drivers should call this to signal the completion of a previously queued @@ -492,10 +493,11 @@ static void cleanup_work(struct work_struct *work) * See also: drm_writeback_queue_job() */ void -drm_writeback_signal_completion(struct drm_writeback_connector *wb_connect= or, +drm_writeback_signal_completion(struct drm_connector *connector, int status) { unsigned long flags; + struct drm_writeback_connector *wb_connector =3D &connector->writeback; struct drm_writeback_job *job; struct dma_fence *out_fence; =20 diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c b/drivers/= gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c index 5beffb73fd50..0311aba2bc73 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c @@ -371,7 +371,7 @@ static void dpu_encoder_phys_wb_done_irq(void *arg) spin_unlock_irqrestore(phys_enc->enc_spinlock, lock_flags); =20 if (wb_enc->wb_conn) - drm_writeback_signal_completion(wb_enc->wb_conn, 0); + drm_writeback_signal_completion(drm_writeback_to_connector(wb_enc->wb_co= nn), 0); =20 /* Signal any waiting atomic commit thread */ wake_up_all(&phys_enc->pending_kickoff_wq); @@ -432,7 +432,7 @@ static void _dpu_encoder_phys_wb_handle_wbdone_timeout( phys_enc->enable_state =3D DPU_ENC_ERR_NEEDS_HW_RESET; =20 if (wb_enc->wb_conn) - drm_writeback_signal_completion(wb_enc->wb_conn, 0); + drm_writeback_signal_completion(drm_writeback_to_connector(wb_enc->wb_co= nn), 0); =20 dpu_encoder_frame_done_callback(phys_enc->parent, phys_enc, frame_event); } diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c b/drivers/= gpu/drm/renesas/rcar-du/rcar_du_writeback.c index 4921d4b9cef5..e874732f4d01 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_du_writeback.c @@ -253,5 +253,5 @@ void rcar_du_writeback_setup(struct rcar_du_crtc *rcrtc, =20 void rcar_du_writeback_complete(struct rcar_du_crtc *rcrtc) { - drm_writeback_signal_completion(&rcrtc->writeback.writeback, 0); + drm_writeback_signal_completion(&rcrtc->writeback, 0); } diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c index abd47bea60ed..23c8783f9f3c 100644 --- a/drivers/gpu/drm/vc4/vc4_txp.c +++ b/drivers/gpu/drm/vc4/vc4_txp.c @@ -505,7 +505,7 @@ static irqreturn_t vc4_txp_interrupt(int irq, void *dat= a) */ TXP_WRITE(TXP_DST_CTRL, TXP_READ(TXP_DST_CTRL) & ~TXP_EI); vc4_crtc_handle_vblank(vc4_crtc); - drm_writeback_signal_completion(&txp->connector.writeback, 0); + drm_writeback_signal_completion(&txp->connector, 0); =20 return IRQ_HANDLED; } diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vk= ms_composer.c index d15623be85fa..cd85de4ffd03 100644 --- a/drivers/gpu/drm/vkms/vkms_composer.c +++ b/drivers/gpu/drm/vkms/vkms_composer.c @@ -646,7 +646,7 @@ void vkms_composer_worker(struct work_struct *work) return; =20 if (wb_pending) { - drm_writeback_signal_completion(&out->wb_connector.writeback, 0); + drm_writeback_signal_completion(&out->wb_connector, 0); spin_lock_irq(&out->composer_lock); crtc_state->wb_pending =3D false; spin_unlock_irq(&out->composer_lock); diff --git a/include/drm/drm_writeback.h b/include/drm/drm_writeback.h index b4c11d380df0..5e8ab51c2da4 100644 --- a/include/drm/drm_writeback.h +++ b/include/drm/drm_writeback.h @@ -100,7 +100,7 @@ void drm_writeback_queue_job(struct drm_connector *wb_c= onnector, void drm_writeback_cleanup_job(struct drm_writeback_job *job); =20 void -drm_writeback_signal_completion(struct drm_writeback_connector *wb_connect= or, +drm_writeback_signal_completion(struct drm_connector *connector, int status); =20 struct dma_fence * --=20 2.34.1