From nobody Tue Apr 7 04:42:32 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6D1F351C3F; Mon, 16 Mar 2026 07:33:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773646401; cv=none; b=YAjhbZ3UWf8i+tiop2OFSaZ/tXgmkqzNdd1P4vFIBzSM+fYEHiz7YZ7uF1TW3JWCP2zGzP0FD97FsXGditgy0hqnVsSNdy0mWvfUikJ8SGcDmXc46s/HWXPdpi+XCVOub5TGgwQjSyTCWC0dvcWFx/PZk203vwYYSw23k3TGM1s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773646401; c=relaxed/simple; bh=9bDtVPCaDyihF4JYIEJMFa5CYDsBVQWCIKMUCFBW018=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=njP+DGceyVUY0lLyRVf0xhQ9ScdltDM6IHhTcUU4AO9tVKwthdu+WhFFFXIWA5beDBZgipSJ1WtctjDOI1LH5kxs6qOkLGf2hZ/S5sUjrc85J2sup91YarH/jXx2ZCiZDQwnS/lqyO3czm2asKhQNF8LMLKwJmCAGeHWM1l0WQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 60d70ed2210a11f1a21c59e7364eecb8-20260316 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.11,REQID:aaafc0ae-7847-4c01-b8d0-89afe625e327,IP:0,U RL:0,TC:0,Content:0,EDM:25,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:25 X-CID-META: VersionHash:89c9d04,CLOUDID:f7dc0c24b2947aef876f9a9d354098c2,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|850|898,TC:nil,Content:0|15|50 ,EDM:5,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OS A:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 60d70ed2210a11f1a21c59e7364eecb8-20260316 X-User: heminhong@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 1878682063; Mon, 16 Mar 2026 15:33:08 +0800 From: Minhong He To: horms@kernel.org Cc: andrea.mayer@uniroma2.it, davem@davemloft.net, david.lebrun@uclouvain.be, dsahern@kernel.org, edumazet@google.com, heminhong@kylinos.cn, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com Subject: [PATCH net v3] ipv6: add NULL checks for idev in SRv6 paths Date: Mon, 16 Mar 2026 15:33:01 +0800 Message-Id: <20260316073301.106643-1-heminhong@kylinos.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260315160159.1394504-1-horms@kernel.org> References: <20260315160159.1394504-1-horms@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" __in6_dev_get() can return NULL when the device has no IPv6 configuration (e.g. MTU < IPV6_MIN_MTU or after NETDEV_UNREGISTER). Add NULL checks for idev returned by __in6_dev_get() in both seg6_hmac_validate_skb() and ipv6_srh_rcv() to prevent potential NULL pointer dereferences. Fixes: 1ababeba4a21 ("ipv6: implement dataplane support for rthdr type 4 (S= egment Routing Header)") Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support") Signed-off-by: Minhong He Reviewed-by: Andrea Mayer --- net/ipv6/exthdrs.c | 4 ++++ net/ipv6/seg6_hmac.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c index 5e3610a926cf..95558fd6f447 100644 --- a/net/ipv6/exthdrs.c +++ b/net/ipv6/exthdrs.c @@ -379,6 +379,10 @@ static int ipv6_srh_rcv(struct sk_buff *skb) hdr =3D (struct ipv6_sr_hdr *)skb_transport_header(skb); =20 idev =3D __in6_dev_get(skb->dev); + if (!idev) { + kfree_skb(skb); + return -1; + } =20 accept_seg6 =3D min(READ_ONCE(net->ipv6.devconf_all->seg6_enabled), READ_ONCE(idev->cnf.seg6_enabled)); diff --git a/net/ipv6/seg6_hmac.c b/net/ipv6/seg6_hmac.c index ee6bac0160ac..e6964c6b0d38 100644 --- a/net/ipv6/seg6_hmac.c +++ b/net/ipv6/seg6_hmac.c @@ -184,6 +184,8 @@ bool seg6_hmac_validate_skb(struct sk_buff *skb) int require_hmac; =20 idev =3D __in6_dev_get(skb->dev); + if (!idev) + return false; =20 srh =3D (struct ipv6_sr_hdr *)skb_transport_header(skb); =20 --=20 2.25.1