From nobody Tue Apr 7 04:39:58 2026 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793D186347 for ; Mon, 16 Mar 2026 02:30:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773628253; cv=none; b=JYaFw6j5YlZoYG5kuUBFceWQOcCbGWf5zwXbUKW7YLXttbQU4Xb4ITM1zHhD2S6mLwhwtD71ONl48aGQnF3JYZJGpw/54HnyJyrOB8JFdUILL7U62kWebrRP0sJ/FFGblezIIHgAGJgQl3nCmgORHjnvvRtpe7Ea2J/pY9RU9wE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773628253; c=relaxed/simple; bh=9+EEpNIFfZVq8GbT2p5Z8jpLBPNqRD4XGeXaUyYDgY0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZexLDzezGsK2+ADajfaH2u6/F4b6tdB0DeGlGldiuEHN0l2zr0P7Fud5iMYuHCUlafYYeRVSfWmvHHqb6mCUeu2/AbC7aBAqTerTzK0qwAxma9J/74mOEP3oqSd/tyYUi1rclIQap2tLjS9ZbwrdGEERwr2Zmf2CE+Ml8U+1CeI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wf7QO04N; arc=none smtp.client-ip=209.85.221.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wf7QO04N" Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-56af30dde0cso1529790e0c.2 for ; Sun, 15 Mar 2026 19:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773628251; x=1774233051; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B80zMXXpfCeq/8Z8TlXHY887n5ywr8jOIpxYzXa8D94=; b=Wf7QO04N5torKY1GRGO7XMlpcdoQi5JhnndSj8HzkGwk5TV5nkEMFBP0jxB77mjd1h ahcxBmyLzIiqMrtzqLGwEs6I+ovyMCMrS2RrciPSQaet1JDRy937vWP2AeXS+HVqHQoU qdo1gFIcjFs+pinmrwWbZnv+r7woPW83WlFUR0ZEvZG1uxUbr01RysPeHfNBqN6yD3wJ HL8Y4hXLz8ajQar3QRbrUqg5DhP38rLUEri+8tUaNGcmteGivw5++1li/uF8+Hm7C7aP NaQx1Z6EMLj0e7r3D5errx31c+/tesuvPmDU5mDMOspFZhyikIzMbmA0P0d6thZLtLta wbVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773628251; x=1774233051; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B80zMXXpfCeq/8Z8TlXHY887n5ywr8jOIpxYzXa8D94=; b=hDhvvwdhTbTNZzrYPWLNDYYQdNsJU+JtgbCUlnJUcrgWgaFJu++OCwUbvSC1d7eW57 jH7pVlD1wjaSiizzxnmcSiwb/0GC15kREaCChEKSf8n2AXXWbWNM7CUlZQP2aszubLZG azCHSUFKWW+U3CKGRL2X3bR2aWEyWnVp7anZz8witIP0f2/uWtyBTsWj/ct1Iqt2HnfT xCjk8T8Li64LpM3oqWPctWX5R1C/rz9vDRE2RYNd/wo+8EObzNrYO9lek/VK9SKdETOy 0GjDip8v/PEpCuwb6MdYjJA4kgkDZZ6Blah1N8f/9glJzX0RpLlTyeDr9p9sdlqmIG9y fPJg== X-Forwarded-Encrypted: i=1; AJvYcCVlNXH2wbJDbZ54isUB/ng8JOpdHPVnljkB4CcVSd702CpC6p7xZPLGyI0NGvPvA7VeNnKDsm3yMNPc6+8=@vger.kernel.org X-Gm-Message-State: AOJu0YyK0hrBnE/EQSDk/vEgV4vegkqAvM7S9LkzI2abgeDXqTg/ulc5 YTyhtWXDsW3ZiXUo+/F9VHxtJhQ0CkKGaRMoKr/20rrzbuVBTNjP0KWN X-Gm-Gg: ATEYQzzUl/n0Q6tllYV6RTJ4cLpPEWuL1qvSssuGuCFyIeObAyg2BwpZlgWOejtOtVh 47I+l3MFoSxq9w8LycggmznuFW0KvJC39n4TXitCiPAKIJiQnyCsgai062jjPoZxXww8XDO0Vwd ZMvNiv2iktZMhJIEhaT325zUE5HQLIQPdGLWehJ6ScTlsXVecTsqGBMOt5bvOoW51eJoJxyVrxy 5EazJuFCV/4/eToMKZaaEeOcQPc1KBTMLv/h0Xcjr7ZlnZU2rNA3/fOhS4LpSpZS2fzXRcp9eYQ NN0r5UeDSQcf8ZdRpJDpdwOsP33npR2+n7MXKDvhEBnjevVMkVOH9bc/VjDP1O0cE8nIj8bc3i5 WmDlOHP3qKsSXFC89waCPop8NbCrp3nf9k4in7jQm4aKD8h9PGB7GWO/9ArCnnCVUTKT3LWBWlp kEON3caHcJa2zMDdqoKz1K50inC3KqtMJvc4IxpVQyfosY/UjI4KLNR4oHLw== X-Received: by 2002:a05:6122:1d45:b0:566:3c22:c131 with SMTP id 71dfb90a1353d-56b6294f25fmr4131464e0c.10.1773628251468; Sun, 15 Mar 2026 19:30:51 -0700 (PDT) Received: from mjmachine.localdomain ([131.255.96.240]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56b6f39166asm3117460e0c.9.2026.03.15.19.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 19:30:50 -0700 (PDT) From: Marcos Andrade To: Greg Kroah-Hartman , Ethan Tidmore Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marcos Andrade Subject: [PATCH] staging: rtl8723bs: remove unused global efuse variables Date: Sun, 15 Mar 2026 23:30:37 -0300 Message-ID: <20260316023037.11437-1-marcosandrade95963@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove several global efuse variables from rtw_efuse.c and their corresponding extern declarations in rtw_efuse.h. These variables (fakeEfuseBank, BTEfuseUsedBytes, etc.) are completely unused legacy code. The driver currently maintains the efuse state properly within the 'efuse_hal' structure, which is encapsulated inside 'hal_com_data'. The removal of this dead code cleans up the global namespace and resolves multiple checkpatch.pl warnings regarding CamelCase naming conventions. Verified by compilation that no functional code references these variables. Signed-off-by: Marcos Andrade Reviewed-by: Ethan Tidmore --- drivers/staging/rtl8723bs/core/rtw_efuse.c | 18 ------------------ drivers/staging/rtl8723bs/include/rtw_efuse.h | 19 ------------------- 2 files changed, 37 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/r= tl8723bs/core/rtw_efuse.c index 98b15ca10..0e550c631 100644 --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c @@ -8,24 +8,6 @@ #include #include =20 - -/* Define global variables */ -u8 fakeEfuseBank; -u32 fakeEfuseUsedBytes; -u8 fakeEfuseContent[EFUSE_MAX_HW_SIZE] =3D {0}; -u8 fakeEfuseInitMap[EFUSE_MAX_MAP_LEN] =3D {0}; -u8 fakeEfuseModifiedMap[EFUSE_MAX_MAP_LEN] =3D {0}; - -u32 BTEfuseUsedBytes; -u8 BTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE]; -u8 BTEfuseInitMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; -u8 BTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; - -u32 fakeBTEfuseUsedBytes; -u8 fakeBTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE]; -u8 fakeBTEfuseInitMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; -u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] =3D {0}; - /* 11/16/2008 MH Add description. Get current efuse area enabled word!!. = */ u8 Efuse_CalculateWordCnts(u8 word_en) diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/stagin= g/rtl8723bs/include/rtw_efuse.h index 936b204b8..191ffdf59 100644 --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h @@ -68,25 +68,6 @@ struct efuse_hal { u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN]; }; =20 - -/*------------------------Export global variable--------------------------= --*/ -extern u8 fakeEfuseBank; -extern u32 fakeEfuseUsedBytes; -extern u8 fakeEfuseContent[]; -extern u8 fakeEfuseInitMap[]; -extern u8 fakeEfuseModifiedMap[]; - -extern u32 BTEfuseUsedBytes; -extern u8 BTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE]; -extern u8 BTEfuseInitMap[]; -extern u8 BTEfuseModifiedMap[]; - -extern u32 fakeBTEfuseUsedBytes; -extern u8 fakeBTEfuseContent[EFUSE_MAX_BT_BANK][EFUSE_MAX_HW_SIZE]; -extern u8 fakeBTEfuseInitMap[]; -extern u8 fakeBTEfuseModifiedMap[]; -/*------------------------Export global variable--------------------------= --*/ - u8 Efuse_CalculateWordCnts(u8 word_en); u8 efuse_OneByteRead(struct adapter *padapter, u16 addr, u8 *data); =20 --=20 2.53.0