From nobody Tue Apr 7 04:19:57 2026 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C53C83D1CB6 for ; Mon, 16 Mar 2026 17:19:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681597; cv=none; b=lU2VNP6CIZtBmf80HrpZR6yGnn6XzxVi9MjOPd+rArztkaepF1UxqH1zzFunjB+yC1Hw9PIyQ2qH/lxAxQLBGwrKDjw/LiicLIFXiMgopUyzTsH1kjDse9V6mtBncksK8mqZlVjcxPRncOSN4ZC1JvvAJD+IBg/LGPfZLmV3l8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773681597; c=relaxed/simple; bh=fwyYVczkGGhNbbtuDw6wb0iPQK79Hav8hEBxFnyoihs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HWj1WWvzlNZWWSPBNqb1WgLaH9fMYh4sEBJ4OpNLRVYFD0aSv3L0ImKux8DR/cHCNrEMClEoOnecxti/1uOFSLmjuQxinyLBjfdzn52qvFYNaokOnbG9BDfmF1HYliS2ElPZOQKQ+xuoMgStP4do8+ZK3BxAk35fGJsFaVPeR9A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l4jO7IqV; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l4jO7IqV" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-b97a0f18a3aso258762166b.1 for ; Mon, 16 Mar 2026 10:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773681594; x=1774286394; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l5lDxPgHMLUWf4KOAgcF/BaGDb9kL4QT6S8GOy/ie+w=; b=l4jO7IqVxgcgLUJJZSXH+fqmT1n1VQSP3xwRcXDBMj0sVhNGdUL6jHWoaUjETIDdaM uGQzxXGnitAcjqy71ublk7gqpi+vbU0KEYBKxcYRD7qkhdcX6MQ1kdqHRsJQLhRLL4Nt Ulo2YYNjFnxDkEcR+BNVnEhQZrhQLpURiaDuITnb4OgDi1/8V0miq814s013JPr3NHPE xlFYb0RpcFbOWyt9lVwfnvkC5pl3lXsAQ+mMlAP9yN7jcQuPaOhxeY55dRwMLNYa1g1b 43pzma+5Wz7FwVVSITsXn2eHqb9Tx/0Vt440c2sHQ7f9AwfASz7Nh7RKLiNv/WGjgsdW IIAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773681594; x=1774286394; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=l5lDxPgHMLUWf4KOAgcF/BaGDb9kL4QT6S8GOy/ie+w=; b=OUL7Xl8z+wcwkaA12FC825LWtPezQzYdbFgUHv2kSlnmvttv3kCmlK4fOO7Tn7UCJK EKlPiJC+B0y7US8BTPTkBJxbvdv8jt20lKa8jQ5eZLAFQSemcqM6Rb//Gso1ftP5yNdi k/DmtPnBzSv3C9RqXuFHzWPF+cy0ZE4OThm1rpXhCQTOOURqmsGGrxcKWqGTOfStIG0+ gjTcrLDq0etGxt+RMlkWN43MmnqfgeSVhgXGIUiZwehI2YRQMud4O6wSOvjsj03huOxg uGvHj3ocgmb8K+TmxBGEUwlnuEx75GLOHftExrYutd9bFjOkAU9PcbEgyq409nBVtuxA wjpA== X-Forwarded-Encrypted: i=1; AJvYcCXCfLQu4ywpBVR+xIWARHvBGqibg/nuxN2R/Bj8L1fEdZcPESZXP0W0XM0vXtiDh8E3xraK02DjdLY1oN4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw09NcCXRl+t5mpJEKm0wK2jyPHkPepCJnjmO785icLH5tYnuWE 47r1oZfz8GgOpPi8iMwzMByIVVMY+8L3yqVb7/oTNNC4Rdb04oSdbee0 X-Gm-Gg: ATEYQzx4DMJN93j0LbfZ4uGc4+Q5gggA3oGEaiHbYHoAn/AGMwMABtBqkgqDsysgrJA vGxhDS733aNaoXz8jpeQQonQNdIchOIzj05puLIHwyH+6Gf937hcNJnLxhenWjacV3Q2en3fj4c XFVbW1hIMlbyq+15Gm43Nvbk51Lk6zbiMNqGO1QWMa+r/KkGh2DjC2X+l1Ea7iMlD8+DsQN8lPC IclpW2rcZaizpiJFy3N7kQrDKM0DRrGZDLoyGJbdFAXQlqwDa6suOydv0nnWV/1JS3mBiXwElJc zt1xt6b7qMA9rHEZ16uTQHy9C2Z+TRhziPfV8Q86ivPOKGDV6/idzPDeLnY1AgTz0c4OnZZy71L ZtWRndVjHxiC4flcGAymYyKVVFuQ+vXV0OmHy/hqxGtrhvpneUF5tdhdNh0+Msnxb1IcZd+1iiA w7mShKr5fT3v7a4PwfSG52KBWYsQ== X-Received: by 2002:a17:906:3396:b0:b97:464:956e with SMTP id a640c23a62f3a-b97651d0b0cmr575179866b.34.1773681594087; Mon, 16 Mar 2026 10:19:54 -0700 (PDT) Received: from [192.168.0.39] ([79.133.247.80]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97846174cfsm505940266b.22.2026.03.16.10.19.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 10:19:53 -0700 (PDT) From: Erikas Bitovtas Date: Mon, 16 Mar 2026 19:19:47 +0200 Subject: [PATCH v4 3/7] iio: light: vcnl4000: move power enablement from init to probe Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-vcnl4000-regulators-v4-3-854fc2eaf54b@gmail.com> References: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> In-Reply-To: <20260316-vcnl4000-regulators-v4-0-854fc2eaf54b@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Meerwald Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Erikas Bitovtas X-Mailer: b4 0.14.3 Given both vcnl4000_init and vcnl4200_init end with dev->chip_spec->set_power_state(), they can be called once from the probe to enable the sensors. Move the set_power_state function from init and call it after init function in probe. Reviewed-by: David Lechner Signed-off-by: Erikas Bitovtas --- drivers/iio/light/vcnl4000.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c index 939ff2d65105..287ccd89cfb2 100644 --- a/drivers/iio/light/vcnl4000.c +++ b/drivers/iio/light/vcnl4000.c @@ -280,7 +280,7 @@ static int vcnl4000_init(struct vcnl4000_data *data) data->rev =3D ret & 0xf; data->al_scale =3D 250000; =20 - return data->chip_spec->set_power_state(data, true); + return 0; }; =20 static ssize_t vcnl4000_write_als_enable(struct vcnl4000_data *data, bool = en) @@ -425,10 +425,6 @@ static int vcnl4200_init(struct vcnl4000_data *data) if (ret < 0) return ret; =20 - ret =3D data->chip_spec->set_power_state(data, true); - if (ret < 0) - return ret; - return 0; }; =20 @@ -2003,6 +1999,10 @@ static int vcnl4000_probe(struct i2c_client *client) if (ret < 0) return ret; =20 + ret =3D data->chip_spec->set_power_state(data, true); + if (ret) + return ret; + dev_dbg(&client->dev, "%s Ambient light/proximity sensor, Rev: %02x\n", data->chip_spec->prod, data->rev); =20 --=20 2.53.0