From nobody Tue Apr 7 04:21:17 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57A6385C4A for ; Mon, 16 Mar 2026 13:24:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773667460; cv=none; b=kQB2R1VTYulLPTzx2SUfJ6zD4kI+E1HVbbWntg2UqlaKNowk8RGEKIgj9zojYTvd8XJDoUaDwGoApmYVEghYfSMvgBoq/gZQyROhCneNLOtu3OtjI7Lz1rea/w/SF9l7CJFpA20wc5j4EMQEP0T006WIr3LWnk4YP800hPIPdDM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773667460; c=relaxed/simple; bh=nzqy+hSON4ND/X1vo5z3WIJHZSGtctE4GPV5DLK9Pgw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=pwHAyUc3dfq+cRhub1bhTJgqnKnzEhGlrhBkZwgqgvEsuH2f6HA0Rj9vst85zlFochUfxK5ArYHTcH7SVmQi7Q2j5sNXCESn6Yde2CfLF9rpAo8r+qDRHaYa82vcS0SsCTKOCrmqE/Y3U87gbjes8kGhMdZuTdwDJ9gmSpupmYM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=djTK11N+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GLk7JEtu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="djTK11N+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GLk7JEtu" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GA46eg3124533 for ; Mon, 16 Mar 2026 13:24:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=TykivBUS0GQn7Dlm1dBGtz uFnfmr8W6go4PhlR2QyM0=; b=djTK11N+YBMw7tqp98Wqs5otQiFVZuX+g3R6F2 VaI6Ctf0B37TclyT5uAAGEU7NPwODLhWoMxDyLuQlEVSkMo2RELHpfjVZBwCrFYv cgE9UGTM13ueYgz+j/fnjRvcWo0yyaHBHTnSs80maPOQo4G4B7JUGSKPaK8WzCj6 dIOL3garX0YglUUjOr7IoBTnWff3IVsTTlRto1KKahFRr1YNz9VLNyxuyyULRIwc q8X9ZaXgDjXQxV/c8MZy+mLdGjUmqfaut3XY2damcEltmLJyyT+bBHRCTjIg7OBF BMg3N1/lUVpbkmBXbg8g4kgY/LpmAmNgX6YmG1AhuQxvaSSw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxfsmgpmd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 13:24:18 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35678f99c6eso3567589a91.1 for ; Mon, 16 Mar 2026 06:24:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773667458; x=1774272258; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=TykivBUS0GQn7Dlm1dBGtzuFnfmr8W6go4PhlR2QyM0=; b=GLk7JEtukgU68/ysbbVoNgPACYSwI8nxe0fJTUv9g1pbyvsEujOfuvbpaFV2y5cOeq EcImSaM+KY9SHKDNN0oHZlUycdGL4Z97YWLR3EMjE28TRVOcXQjxdD57V2UthuHOiLqN 9AQBVSqyQEYx1hSo+6e1UFxe8x3i1yVmxSVwtiQxmWhVcFWFWdRfUBSIgZusfRfmgJoY BPXrD3Sl6B+OCyrETNvPny3drkYD+8dbhyHZa1Y9B6RNoowAySv0cl3YGWRwa5DOJ/1i dRXklAiJf42LO1gfOjWj/app619hNguqTuAOyHixp/0QTrS7SRdqubC9RGPf+k3iEcyZ lVMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773667458; x=1774272258; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TykivBUS0GQn7Dlm1dBGtzuFnfmr8W6go4PhlR2QyM0=; b=lEvSMLTPogR86B71XhT3BBn+k8/dFtMypGEJROkuMwX7cEu+zUGnBqHnY8mO9UGoki JSGJHE1zsIjDlB37au6aJJFXhSSyxlQ8FBpzzXDQgldR+C+U+O5YpwYc/23eSL3OvQ52 OYHAgtWV9mLDSTTPWIi0fI7LNkqqGD7+WxF9GLwCb0nvj8F4CDGKNIsPdHk49YDboQdW l3PhDw/D58JogwH8CmhmEDVZ/QdTVV3vZGsT3L2sXqZ7DV7DFK90Wh648Ve7wdNVMC+v BVCPUZ1TRYNBVOxfO5BzuY+2phO5/am7XOyLvnMyYtH8V6Xc65XuPIVL2Xm2YnlY/8fl DxBQ== X-Forwarded-Encrypted: i=1; AJvYcCUPRvswWj0E9ttW3wmg4Ofm0hFCDU2jWGdaoowDxlmPj4rG2ynsHTjHiVyvNdfd0UWYanIKxggUlRMXHGY=@vger.kernel.org X-Gm-Message-State: AOJu0YzEH4/auv0mo3Z6AcxMPiLzhtL3jImPvGAiu+//sKqGiE7a62Qf 8N9+l0wb6avtlgW/iCKDPADXwixFhL9p01YtZelZrC6c5EzS5g2ok0f7bw/MSwwXfHbaZzFyzle awv8y2FCEvM8AdPrhPNV6rbP8PLTS5uLh4yCPFpS7VQz6bIo0mfN4O8suhdTiAfC7SC4= X-Gm-Gg: ATEYQzxKOxlpV6TqWHulG4xuAg+P4ANe945n6xKhScDx+Ow7EzLwvoLhjx65zSGOEJj sAn11Pv4hj1PbxTLV8ejmC0KNILd55o+7mwFZNMOKMi6x4Q3pKuKMEs0A24uuWaDaIWHTI8t4dW jwjQ20Msu3Fw1Sv3yRURv1LAq8310Bb/MWWnoItDpEgKtCVMKYj/1B8IX67VqwyKV1E3JY5o676 IYs/jFTUOj957DHR5RuQdqUCgdhFHsQdFcdhZZBYFPjn4K6U5U27+Csu92qNOv3Buby7tD/Wki8 PMjT4GrJstx/ZQE2LwM6i/vh9RKyyXZuOH9DuTuqrbcq+84H3xdzoJdDAAzuDM5dyBq6vAQ3oKn tsply2aGzg3CkXKWplckpoIPYMkGkggLosFGNcHYt3lE= X-Received: by 2002:a17:90b:5345:b0:35b:93d8:6ab7 with SMTP id 98e67ed59e1d1-35b93d86c97mr5359859a91.28.1773667457989; Mon, 16 Mar 2026 06:24:17 -0700 (PDT) X-Received: by 2002:a17:90b:5345:b0:35b:93d8:6ab7 with SMTP id 98e67ed59e1d1-35b93d86c97mr5359817a91.28.1773667457498; Mon, 16 Mar 2026 06:24:17 -0700 (PDT) Received: from [10.213.103.163] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b929558d1sm2493497a91.4.2026.03.16.06.24.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 06:24:17 -0700 (PDT) From: Maramaina Naresh Date: Mon, 16 Mar 2026 18:53:31 +0530 Subject: [PATCH v1] spi: geni-qcom: Fix CPHA and CPOL mode change detection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-geni-cpha-cpol-fix-v1-1-4cb44c176b79@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAFIEuGkC/x2MUQqAIBAFrxL73UIqSnWV6ENyq4VQUYggvHtLP wMz8N4LlQpThbl7odDNlVMUUX0H2+njQchBHPSg3WCUw5oZD4qMWz69IF2484PjpLSjYK3RFmS cC0n+jxe4FaytfaIAwpNsAAAA X-Change-ID: 20260316-spi-geni-cpha-cpol-fix-89126ed55325 To: Mark Brown , Jonathan Marek , konrad.dybcio@oss.qualcomm.com Cc: kernel@quicinc.com, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, dmitry.baryshkov@oss.qualcomm.com, bjorande@quicinc.com, mukesh.savaliya@oss.qualcomm.com, praveen.talari@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, naresh.maramaina@oss.qualcomm.com X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773667453; l=2079; i=naresh.maramaina@oss.qualcomm.com; s=20260316; h=from:subject:message-id; bh=nzqy+hSON4ND/X1vo5z3WIJHZSGtctE4GPV5DLK9Pgw=; b=KbIDaMv5XyHWZjr46USGkKLK+8aSZrOHTD5aWp+gPDk0pGYv+SkDzPx0VBHJiKYblI5nL6Rty 4WFB3ovD672DVJ6361LFXPP11MuuvDoe9iONv9nRSMj4cKxWbQSs/jb X-Developer-Key: i=naresh.maramaina@oss.qualcomm.com; a=ed25519; pk=j7iST9yrLbsgWcWrqdlUNIOWl2WBl4wV1q35/n9SCkg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDEwMiBTYWx0ZWRfX7KbPaRFQn5ZH nElIpp6Xcdgp3cJv5DXmPUCDZ63OelJL7d0Z+806xwiCRchn5S5IHZGnJlMzSKN8QA5+GwRY4sR VTntFW9d+FDPzUXufA+C/dvTBBZeOPFnwHCZ9GtTrhxCEJUtlhtOdHBuCxT17TaiI8MnnAyLVGm Ekx2Om7B+jnlq2dfHNc52fwTYNwuuHSmvZrh63KNiB37PwWltGykYSghWpYfSgdgg24PrunqGM9 Zhfr9jgR0iSZmSPwd3OoaURZVUOT0wcwW7eTCgA+29m/L1GpHZYGpNIbE97hu18gO6kGy1qwHVw bIcl0sh8kaWrozOWkN3TXsnpbFq618gSQ9BVQ8b9k7D2e8GZutkwEeZejtZpuCRy0eWL0Sa7nYl +VFGBBhH0HxEHFxNU2x3IdsMb41vIEmfKp1u+b0lKaLMYlpVONI+ESIt04rj0Sidt/8MFd/XLdA /b1JBrcW4dg9t0qzU7Q== X-Proofpoint-GUID: 6uj7z4DV2e5rVQibkak5Zo1ZY0u1lpAn X-Authority-Analysis: v=2.4 cv=V/hwEOni c=1 sm=1 tr=0 ts=69b80482 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=D3EvElEm-D6odJYB-dYA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: 6uj7z4DV2e5rVQibkak5Zo1ZY0u1lpAn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1011 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160102 setup_fifo_params computes mode_changed from spi->mode flags but tests it against SE_SPI_CPHA and SE_SPI_CPOL, which are register offsets, not SPI mode bits. This causes CPHA and CPOL updates to be skipped on mode switches, leaving the controller with stale clock phase and polarity settings. Fix this by using SPI_CPHA and SPI_CPOL to detect mode changes before updating the corresponding registers. Fixes: 781c3e71c94c ("spi: spi-geni-qcom: rework setup_fifo_params") Signed-off-by: Maramaina Naresh Reviewed-by: Jonathan Marek Reviewed-by: Konrad Dybcio Tested-by: Val Packett --- This patch fixes SPI mode change detection in the spi-geni-qcom driver. setup_fifo_params compared spi->mode against SE_SPI_CPHA/SE_SPI_CPOL, which are register offsets instead of SPI_CPHA/SPI_CPOL mode bits. This could skip CPHA/CPOL updates on mode switches and leave stale clock configuration. This is a single-patch series. --- drivers/spi/spi-geni-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index 43ce47f2454c..772b7148ba5f 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -359,9 +359,9 @@ static int setup_fifo_params(struct spi_device *spi_slv, writel((spi_slv->mode & SPI_LOOP) ? LOOPBACK_ENABLE : 0, se->base + SE_S= PI_LOOPBACK); if (cs_changed) writel(chipselect, se->base + SE_SPI_DEMUX_SEL); - if (mode_changed & SE_SPI_CPHA) + if (mode_changed & SPI_CPHA) writel((spi_slv->mode & SPI_CPHA) ? CPHA : 0, se->base + SE_SPI_CPHA); - if (mode_changed & SE_SPI_CPOL) + if (mode_changed & SPI_CPOL) writel((spi_slv->mode & SPI_CPOL) ? CPOL : 0, se->base + SE_SPI_CPOL); if ((mode_changed & SPI_CS_HIGH) || (cs_changed && (spi_slv->mode & SPI_C= S_HIGH))) writel((spi_slv->mode & SPI_CS_HIGH) ? BIT(chipselect) : 0, se->base + S= E_SPI_DEMUX_OUTPUT_INV); --- base-commit: 7109a2155340cc7b21f27e832ece6df03592f2e8 change-id: 20260316-spi-geni-cpha-cpol-fix-89126ed55325 Best regards, --=20 Maramaina Naresh