From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBB8C381AEC for ; Mon, 16 Mar 2026 08:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; cv=none; b=C7HVxZTJ/mV4atOmaDyCQUhQBBp/KDesPH3X572kru3U4jWlzGG4GYKcewfv12+LnIE9s0jhriS4DBTnlN2uhFUON7YXgoY4YIYXcAHmGb3Ix1KrdFm2W4bYde0O3QCKsk/rxL+uMGsmcy5dbgXrYV+u/UjtS6HHLFYhOWrEk3s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; c=relaxed/simple; bh=SHz4NE4IKRYQ0CsRjkTYWjUFChKza2Kx/M8C2LxWvwk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qGeUNIMUNseIwwbtA4cUyieX/J24Th5xkYx/x3gsRKAKfTaDDOEyRCovZRnD4d2htEbnpaix8wwGSbeGfUhp9tnJyP8am/RAavSKFyHqJJIWjcEsLBYM2zqPuQgLYOHAceA+ugouPnM1mZd0XijzwBYd6ks2Vh8Ah/NDWrW+Qyo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005Rv-24; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UF-000XVE-2L; Mon, 16 Mar 2026 09:39:43 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 69B2E5049BE; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:02 +0100 Subject: [PATCH spi-next 01/11] spi: spi-fsl-lpspi: adapt to kernel coding style Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-1-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1415; i=mkl@pengutronix.de; h=from:subject:message-id; bh=SHz4NE4IKRYQ0CsRjkTYWjUFChKza2Kx/M8C2LxWvwk=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfnDvpAO3+X9F+VUoXd8RXSnHeN+mzU17z3sbh7nG+ jWv3/GJdJSyMIhxMciKKbIs/XFCUSDQobT3ZcIkmDmsTCBDGLg4BWAiGjsYGXoTPW2+vIk+dfTS r3NlThXdR/a5vT7Ln5t2dqPsfDf1ddKMDNMv2qz6xT7R5J/sG95l7WpcfdkM4SukFuyzmsubsqR LkgMA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Adapt the driver to current kernel coding style standards. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index b361c1bb3e43..989d0ffddc25 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -112,8 +112,8 @@ struct fsl_lpspi_data { =20 void *rx_buf; const void *tx_buf; - void (*tx)(struct fsl_lpspi_data *); - void (*rx)(struct fsl_lpspi_data *); + void (*tx)(struct fsl_lpspi_data *fsl_lpspi); + void (*rx)(struct fsl_lpspi_data *fsl_lpspi); =20 u32 remain; u8 watermark; @@ -271,8 +271,9 @@ static void fsl_lpspi_write_tx_fifo(struct fsl_lpspi_da= ta *fsl_lpspi) } =20 fsl_lpspi_intctrl(fsl_lpspi, IER_FCIE); - } else + } else { fsl_lpspi_intctrl(fsl_lpspi, IER_TDIE); + } } =20 static void fsl_lpspi_read_rx_fifo(struct fsl_lpspi_data *fsl_lpspi) @@ -348,11 +349,10 @@ static int fsl_lpspi_set_bitrate(struct fsl_lpspi_dat= a *fsl_lpspi) return -EINVAL; } =20 - if (config.speed_hz > perclk_rate / 2) { + if (config.speed_hz > perclk_rate / 2) div =3D 2; - } else { + else div =3D DIV_ROUND_UP(perclk_rate, config.speed_hz); - } =20 for (prescale =3D 0; prescale <=3D prescale_max; prescale++) { scldiv =3D div / (1 << prescale) - 2; --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 924723822A4 for ; Mon, 16 Mar 2026 08:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; cv=none; b=I58hx+apfoXE/eW1NGUOjVqzVMKYkP+xt+PN2rNEzK/j+8Gma6wDYCQNh7uBEhl6ahgmZp8lWwgs+uBCT2YDevW5lHJ5fFhHzU7uomHeYyU6l9p8viEvs0R3BfPMnvi4TuMkSq970T8WScmtDA3ebXN4pHuA10/O4PM0gYvODIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; c=relaxed/simple; bh=67IqHHUgq2tLs1hEake5YuaFz+dRmTGCUQrSSZoEZbM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=G6IaqsUjr02Y3bKeVAIJTwml7Vms64mSl2gW52+qNc9QlHzR/ToITCEKbjjmmbVeCE0XicjyIRoAmX6Ez2z/D8Omusi1hNGt+OxG3IDfQZEzhrkOAcVtdSFprFTwDHSzvMzm7LxuFBpp0eofV/B83vUmdIN5zvkuFag9CZrHnpo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005Rw-24; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UF-000XVF-2Z; Mon, 16 Mar 2026 09:39:43 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 71CFC5049BF; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:03 +0100 Subject: [PATCH spi-next 02/11] spi: spi-fsl-lpspi: fsl_lpspi_probe(): use FIELD_GET to decode Parameter register Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-2-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1371; i=mkl@pengutronix.de; h=from:subject:message-id; bh=67IqHHUgq2tLs1hEake5YuaFz+dRmTGCUQrSSZoEZbM=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfnCfufxBPacPU91eVu/7Irz21oPJM7J5b4hmv/9yw ChP8PPpvx2lLAxiXAyyYoosS3+cUBQIdCjtfZkwCWYOKxPIEAYuTgGYyNZWhv8xKV1G/w4xzvsZ U6FWa2EfcH4Xh6sK8+XNNZEd5Xk1XrsZGTZHChzNMQo9HbxMyiUjbus9Q4WED9MdeMLlNctnPVz mzAAA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Instead of open coding mask and shift operations and to o increase readability use FIELD_GET() to decode the Parameter register. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 989d0ffddc25..4c550f740d85 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -55,6 +55,9 @@ #define IMX7ULP_RDR 0x74 =20 /* General control register field define */ +#define PARAM_PCSNUM GENMASK(23, 16) +#define PARAM_RXFIFO GENMASK(15, 8) +#define PARAM_TXFIFO GENMASK(7, 0) #define CR_RRF BIT(9) #define CR_RTF BIT(8) #define CR_RST BIT(1) @@ -978,12 +981,12 @@ static int fsl_lpspi_probe(struct platform_device *pd= ev) } =20 temp =3D readl(fsl_lpspi->base + IMX7ULP_PARAM); - fsl_lpspi->txfifosize =3D 1 << (temp & 0x0f); - fsl_lpspi->rxfifosize =3D 1 << ((temp >> 8) & 0x0f); + fsl_lpspi->txfifosize =3D 1 << FIELD_GET(PARAM_TXFIFO, temp); + fsl_lpspi->rxfifosize =3D 1 << FIELD_GET(PARAM_RXFIFO, temp); if (of_property_read_u32((&pdev->dev)->of_node, "num-cs", &num_cs)) { if (devtype_data->query_hw_for_num_cs) - num_cs =3D ((temp >> 16) & 0xf); + num_cs =3D FIELD_GET(PARAM_PCSNUM, temp); else num_cs =3D 1; } --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99B383822AC for ; Mon, 16 Mar 2026 08:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; cv=none; b=qWeGQngFBPIVSdv8EOy9nwEZQD+IIVYHypInWh439BurCfutUCXaCXxu1rPdOqozQ7jWDzlo/vXS864Xj71m0FhAQK6D5sE2f8WoTHq6SWCTbDuR6iw8od1SgScgxILmV5a5khbMD2LUMC9pOCcmOpLpvNzWpj/KdEDNipQwevk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; c=relaxed/simple; bh=MK4eF3o6uDhZXPb+u+HVrV4eAVAALjASvbFdaQvBpE4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Bp/+CJnr2kCnVqt+CY+uUr4QuIc+5JgqytGjI9F6Z+RU8P3/m2TgLqcFvM3JOY2aVxAi9C2S6snfzY5+z0r8QOK2jUrWz1VQSr55O3Vr5TuYBY1QN+6j1pkh5TFtQbSjE9jq0dO6flsd8YppnMzNRha3w+TW5G9PjOxxLgWu5vs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005Rx-5B; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UF-000XVG-2j; Mon, 16 Mar 2026 09:39:43 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 7D7415049C0; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:04 +0100 Subject: [PATCH spi-next 03/11] spi: spi-fsl-lpspi: fsl_lpspi_set_cmd(): use FIELD_PREP to encode Transmit Command register Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-3-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1617; i=mkl@pengutronix.de; h=from:subject:message-id; bh=MK4eF3o6uDhZXPb+u+HVrV4eAVAALjASvbFdaQvBpE4=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfnD/EY2bVQ52c+988Hfm578gvKL/bNEKTZUbzmXLH d531iqt6ihlYRDjYpAVU2RZ+uOEokCgQ2nvy4RJMHNYmUCGMHBxCsBEot0Z/ooZ8J7Zw3H+8+r3 9gp/hddyMd4U86088m4Ht1hLyfnpjTwM/z3bhJzbvmTVT61gZJpVr7JQu4uh4OBa2SRHi8X5Hi8 beAA= X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Instead of open coding mask and shift operations and to increase readability use FIELD_GET() to decode the Transmit Command register. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 4c550f740d85..e75b9acaa9e5 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -82,10 +82,14 @@ #define RSR_RXEMPTY BIT(1) #define TCR_CPOL BIT(31) #define TCR_CPHA BIT(30) +#define TCR_MODE GENMASK(31, 30) +#define TCR_PRESCALE GENMASK(29, 27) +#define TCR_PCS GENMASK(25, 24) #define TCR_CONT BIT(21) #define TCR_CONTC BIT(20) #define TCR_RXMSK BIT(19) #define TCR_TXMSK BIT(18) +#define TCR_FRAMESZ GENMASK(11, 0) =20 #define SR_CLEAR_MASK GENMASK(13, 8) =20 @@ -290,11 +294,11 @@ static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *= fsl_lpspi, { u32 temp =3D 0; =20 - temp |=3D fsl_lpspi->config.bpw - 1; - temp |=3D (fsl_lpspi->config.mode & 0x3) << 30; - temp |=3D (fsl_lpspi->config.chip_select & 0x3) << 24; + temp |=3D FIELD_PREP(TCR_FRAMESZ, fsl_lpspi->config.bpw - 1); + temp |=3D FIELD_PREP(TCR_MODE, fsl_lpspi->config.mode); + temp |=3D FIELD_PREP(TCR_PCS, fsl_lpspi->config.chip_select); if (!fsl_lpspi->is_target) { - temp |=3D fsl_lpspi->config.prescale << 27; + temp |=3D FIELD_PREP(TCR_PRESCALE, fsl_lpspi->config.prescale); /* * Set TCR_CONT will keep SS asserted after current transfer. * For the first transfer, clear TCR_CONTC to assert SS. --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4ACCC38228A for ; Mon, 16 Mar 2026 08:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; cv=none; b=flSVPtQc3iXIpkq/OGIm+Y/dsZYBiM+NTYwpASacd8t9/qaL3ccR4m6L4SqRZ4RkLaE+aP/xi102d2qNQrXnBXeD2Tc7kX7XTdVOwLZnjwLk61HY6/OUKBX1x9vKXyWINqF/UrpHY2rJ9x4GgYHlBoKSUcLL81k/ih8vzusCMZ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; c=relaxed/simple; bh=VYbNxLcS6kp4nY2TuLaEWedCLs2o9gH+xxnacqzQzyc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=A1UE06PHn6SRs5ahqbTxecX2y5oenBd8e51Tjt/06hqcwuJUFi7xnjkSddKnEuWUACKnOnSLtXHRZOXato/U2jKd/JyGZJKgfNqo6hFjtN4SaBrZUx3q3W8mN5J5P16yhv63/vvDBowsaN19e562N9gTgUtGUt4Me1QmbIV+jkc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005Ry-5I; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UF-000XVJ-2x; Mon, 16 Mar 2026 09:39:43 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 866985049C1; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:05 +0100 Subject: [PATCH spi-next 04/11] spi: spi-fsl-lpspi: fsl_lpspi_set_watermark(): use FIELD_PREP() to encode FIFO Status register Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-4-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1520; i=mkl@pengutronix.de; h=from:subject:message-id; bh=VYbNxLcS6kp4nY2TuLaEWedCLs2o9gH+xxnacqzQzyc=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfvBAwd6ZOl/CX0/ZH/rT918gl8zCzX/9st6Uneb+Y 3tv93MV245SFgYxLgZZMUWWpT9OKAoEOpT2vkyYBDOHlQlkCAMXpwBMRP8Hw/+YlH/m9XLMc6+9 8zo3sdZe811WOafn4e9hAue+yX1MyJnD8L92RnHI3Zo/mZNCW39b3Tqb/O9igp6H+EXepZ+bpC/ a/GIGAA== X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Instead of open coding mask and shift operations and to increase readability use FIELD_PREP() to encode the FIFO Status register. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index e75b9acaa9e5..139d6573a013 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -78,6 +78,8 @@ #define CFGR1_PCSPOL_MASK GENMASK(11, 8) #define CFGR1_NOSTALL BIT(3) #define CFGR1_HOST BIT(0) +#define FCR_RXWATER GENMASK(18, 16) +#define FCR_TXWATER GENMASK(2, 0) #define FSR_TXCOUNT (0xFF) #define RSR_RXEMPTY BIT(1) #define TCR_CPOL BIT(31) @@ -326,17 +328,18 @@ static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *= fsl_lpspi, =20 static void fsl_lpspi_set_watermark(struct fsl_lpspi_data *fsl_lpspi) { + u8 watermark =3D fsl_lpspi->watermark >> 1; u32 temp; =20 if (!fsl_lpspi->usedma) - temp =3D fsl_lpspi->watermark >> 1 | - (fsl_lpspi->watermark >> 1) << 16; + temp =3D FIELD_PREP(FCR_TXWATER, watermark) | + FIELD_PREP(FCR_RXWATER, watermark); else - temp =3D fsl_lpspi->watermark >> 1; + temp =3D FIELD_PREP(FCR_TXWATER, watermark); =20 writel(temp, fsl_lpspi->base + IMX7ULP_FCR); =20 - dev_dbg(fsl_lpspi->dev, "FCR=3D0x%x\n", temp); + dev_dbg(fsl_lpspi->dev, "FCR=3D0x%08x\n", temp); } =20 static int fsl_lpspi_set_bitrate(struct fsl_lpspi_data *fsl_lpspi) --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FAB738229F for ; Mon, 16 Mar 2026 08:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650397; cv=none; b=WppfxcBD75YTmqEUktZzcrDLzCsasV8oQKAa5vkeULBEpbD5ywno43nqBlkCQVmvMHDxzqg3fklExJyo8oispvfMu0ox0uQ5WfUnSwbrereXQ05mAieg7Q1jrlmrgj6mu1ePlUZZSIyYBAZKHr3wzfUgRhnp4UyG9RBrWziMGic= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650397; c=relaxed/simple; bh=xfuZBuTtOxab+LBEJpXSlzw9L/LLXDkIoyaxaIUuh+E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lcxre5O5DMzf+zBU5bEQzuUogziAZ91QP/ljNTJGtniVawd+yCFrqINMxY18kCBIF40kOyWVVxxdw3GESCpX2JS36HVbOTttprTIMF0TIONq+cSYscFInz/3WZOIwBPA9XMUKADrAH7XBM6Dbl9o7vneOvoEMGELCfp6arnXwm8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005Rz-6q; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UF-000XVK-30; Mon, 16 Mar 2026 09:39:43 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 931E65049C2; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:06 +0100 Subject: [PATCH spi-next 05/11] spi: spi-fsl-lpspi: fsl_lpspi_setup_transfer(): remove useless spi_transfer NULL pointer check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-5-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1149; i=mkl@pengutronix.de; h=from:subject:message-id; bh=xfuZBuTtOxab+LBEJpXSlzw9L/LLXDkIoyaxaIUuh+E=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfvCgVvS2qe+FMmft38e2Usa33FNy580+w8K7niaz7 sV4nxf83VHKwiDGxSArpsiy9McJRYFAh9LelwmTYOawMoEMYeDiFICJ8GUwMjzI7jROXv3Ku/Gb T+a+YnMZu5jObYYvOGwXbFdTqP6VsovhD/fk1V/mzdzAncD893DJ8UJRDhXei5oHJ0mLCLe8v58 7jw8A X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org fsl_lpspi_setup_transfer() is either called via: | fsl_lpspi_prepare_message() | -> fsl_lpspi_setup_transfer() or | -> spi_transfer_one_message() | -> controller->transfer_one =3D=3D fsl_lpspi_transfer_one() | -> fsl_lpspi_setup_transfer() The first call path already has a spi_transfer NULL pointer check, the second one explicitly iterates over all spi_transfer of the spi_message. Simplify the code by removing the useless NULL pointer check. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 139d6573a013..1da2084f582d 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -476,9 +476,6 @@ static int fsl_lpspi_setup_transfer(struct spi_controll= er *controller, struct fsl_lpspi_data *fsl_lpspi =3D spi_controller_get_devdata(spi->controller); =20 - if (t =3D=3D NULL) - return -EINVAL; - fsl_lpspi->config.mode =3D spi->mode; fsl_lpspi->config.bpw =3D t->bits_per_word; fsl_lpspi->config.speed_hz =3D t->speed_hz; --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD0A2381B1A for ; Mon, 16 Mar 2026 08:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650399; cv=none; b=nRZhyMUMI9a889vIqCGD58n6ZmyfRy8cPgdrxUnsfd8SK77N6DjkrnZmwidPQTmDFclcv7L9Pzrj3CPVQzxelAKYNHzz/Hy0cYZWOt/73jOvGOqUx/rlrQtqETt7jMur63Fy6zTkb2sGh3qIbAwViQZVxg4g3QCdD/vovg7gfag= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650399; c=relaxed/simple; bh=acNJCA+szzoHf0giaQYVW0RmFvfHGMnhFrTnqnY9u5I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GIGciIFNwZXH1H5OjeO/kgKZXOrxoera8EJ2TqldsxTRV4ZVO3miQrMDos5jGPCDNfoF3tjxwyoZSTB2DEOYhV5NSb+mNaH5IkihcyUYcMOH7neBO7rELAUUwHuyb5ffJkj3Kkjv3Rd8+i8v6pcN4yozTuEWR5cSo/V2cF169kY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005S1-9S; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UF-000XVN-35; Mon, 16 Mar 2026 09:39:43 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 9E80C5049C3; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:07 +0100 Subject: [PATCH spi-next 06/11] spi: spi-fsl-lpspi: fsl_lpspi_can_dma(): directly assign return value to fsl_lpspi->usedma Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-6-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1330; i=mkl@pengutronix.de; h=from:subject:message-id; bh=acNJCA+szzoHf0giaQYVW0RmFvfHGMnhFrTnqnY9u5I=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfvDQu2/l7qGiYVf/dkc6zJ2y2OXQofuL3B54X118a 86LIxWqvzpKWRjEuBhkxRRZlv44oSgQ6FDa+zJhEswcViaQIQxcnAIwEZ0ehn8KE14wcR1ewKHg qzGh2rqk10Cza7XejfqT5+04t2XszmVk+B/yQdSFffaKWa8sor2ili4JVF/LbN2Svvf34zVfzhc bKLMCAA== X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The function fsl_lpspi_can_dma() returns a bool. Simplify the code, remove the if/else and assign the return value of fsl_lpspi_can_dma() directly to fsl_lpspi->usedma. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 1da2084f582d..76dda2c7aa85 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -524,10 +524,7 @@ static int fsl_lpspi_prepare_message(struct spi_contro= ller *controller, fsl_lpspi->usedma =3D false; ret =3D fsl_lpspi_setup_transfer(controller, spi, t); =20 - if (fsl_lpspi_can_dma(controller, spi, t)) - fsl_lpspi->usedma =3D true; - else - fsl_lpspi->usedma =3D false; + fsl_lpspi->usedma =3D fsl_lpspi_can_dma(controller, spi, t); =20 if (ret < 0) return ret; @@ -801,10 +798,7 @@ static int fsl_lpspi_transfer_one(struct spi_controlle= r *controller, spi_controller_get_devdata(controller); int ret; =20 - if (fsl_lpspi_can_dma(controller, spi, t)) - fsl_lpspi->usedma =3D true; - else - fsl_lpspi->usedma =3D false; + fsl_lpspi->usedma =3D fsl_lpspi_can_dma(controller, spi, t); =20 ret =3D fsl_lpspi_setup_transfer(controller, spi, t); if (ret < 0) --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6897936C9E8 for ; Mon, 16 Mar 2026 08:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650399; cv=none; b=EXU58/ia5oGxx3PK7MSIb+iwS2p3q8vkYxFWNcr2QatalauVnayizkSbAQFEjknRh6PP/Ts//lkP7XTJRlL3rQxSue1+UovJZpEJiUG1vngHopx+llUiagt9+o7V56AoOEn3+bLMy8JAllhQR40ND6OeqG/xAz9KW6qQZm/2+qk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650399; c=relaxed/simple; bh=5rydyZLGpSkjEvcQg7H2/5j0Nfc28QBa1MSkF9ckga4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oOhlRRpjpxJ7QkzFwEHg7gzaVLwDG9HU9/G27yUo1pfX3isjn7wnqrilI87RR5rOovGCiDAd6dHUwHhbbWPLEPdFpmzlMix5IlCFSBPqjPk19UQQ1B7qTSmXVt5hHT52GGX091ChLG/qKXrZe5yMYjCqVqmFb3hh6icwgZbZYKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005S2-DT; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UF-000XVO-3B; Mon, 16 Mar 2026 09:39:44 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id AA7B65049C4; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:08 +0100 Subject: [PATCH spi-next 07/11] spi: spi-fsl-lpspi: fsl_lpspi_reset(): convert to void Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-7-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=1018; i=mkl@pengutronix.de; h=from:subject:message-id; bh=5rydyZLGpSkjEvcQg7H2/5j0Nfc28QBa1MSkF9ckga4=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfvCw7LFA3/UPGhQ5/9c3em37nbpzq+1J2WJdRnWbX 8ZhrdkbOkpZGMS4GGTFFFmW/jihKBDoUNr7MmESzBxWJpAhDFycAjCR3fsY/uklLuGwSW9JlhJy lK+ts/Jnre8Lnvrl/LwfKmVuSSLnyxgZfm+95L/0bnW5jL3p7alfb+5hVrxX82JaxJX8/Iabdcf K2AA= X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The function fsl_lpspi_reset() cannot fail and it's return value is never checked. Simplify the code and convert it into a bool returning function. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 76dda2c7aa85..920748795314 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -578,7 +578,7 @@ static int fsl_lpspi_wait_for_completion(struct spi_con= troller *controller) return 0; } =20 -static int fsl_lpspi_reset(struct fsl_lpspi_data *fsl_lpspi) +static void fsl_lpspi_reset(struct fsl_lpspi_data *fsl_lpspi) { u32 temp; =20 @@ -593,8 +593,6 @@ static int fsl_lpspi_reset(struct fsl_lpspi_data *fsl_l= pspi) =20 /* W1C for all flags in SR */ writel(SR_CLEAR_MASK, fsl_lpspi->base + IMX7ULP_SR); - - return 0; } =20 static void fsl_lpspi_dma_rx_callback(void *cookie) --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 459B1382285 for ; Mon, 16 Mar 2026 08:39:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; cv=none; b=WxQxJYoQM+NzlOYO1pV0nq04UcsutYqlASuGzMs7AgTT7aXHyrv1+cyQ0ViQfqkzuJj4EZPtwON4RcWyKpynYTDNWpdp6YqG87SL1kuoHmZknOQu7E8mrE0EqR5XtZSmA9wmzQlWY0pZsvAImayq0pzVR6tAxaHEcYKm0iVLVT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650398; c=relaxed/simple; bh=ZrkmyysVLpLzso4QTKvAnnm8NM+EluwdOKygUeYeVXg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RhXlJarkkM8ubxSaSXBOfOKr3Ine9hA1IHtfJF5Zd1yJW/1//BVulFB8Et6TvXy7icrxl5RZFnUUDJnIf/DZrAK8aS+1i7Jmh2HPI6EBYEQ+oYyp5PBqun0MXJflrXd0VMRTVhyb2WvvPBNVWO+17cVKLAV7zB4C4bRr+gN7+hg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005S4-Gg; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UG-000XVQ-04; Mon, 16 Mar 2026 09:39:44 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id B55E95049C5; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:09 +0100 Subject: [PATCH spi-next 08/11] spi: spi-fsl-lpspi: fsl_lpspi_write_tx_fifo(): simplify while() loop check Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-8-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=837; i=mkl@pengutronix.de; h=from:subject:message-id; bh=ZrkmyysVLpLzso4QTKvAnnm8NM+EluwdOKygUeYeVXg=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfvBo5Y6d17I3z9OJlkhYs+una2m8+q4bjg8nzVIol 8z5HbZ/aUcpC4MYF4OsmCLL0h8nFAUCHUp7XyZMgpnDygQyhIGLUwAmcjGNkWG955+Wj50VEyab au17OTHY5cCHLFt2f+1f/55pPErKNchh+GfJ9G+VaN9i5b8ei7sPVF6IOf7r4OUZszUvfFm0W27 fLgUWAA== X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org To simplify the loop check. Combine both conditions of the while() and the directly following if() into the while(). Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 920748795314..ae06bc06f626 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -265,9 +265,7 @@ static void fsl_lpspi_write_tx_fifo(struct fsl_lpspi_da= ta *fsl_lpspi) =20 txfifo_cnt =3D readl(fsl_lpspi->base + IMX7ULP_FSR) & 0xff; =20 - while (txfifo_cnt < fsl_lpspi->txfifosize) { - if (!fsl_lpspi->remain) - break; + while (txfifo_cnt < fsl_lpspi->txfifosize && fsl_lpspi->remain) { fsl_lpspi->tx(fsl_lpspi); txfifo_cnt++; } --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D13B382286 for ; Mon, 16 Mar 2026 08:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650397; cv=none; b=D/q6zZhKT66dEIJWGMEtx6UXoGX07PVZAcWrp3aInHHvgbRRa3sqEe4/Sc6yCPWMM+I8btSIIs8vN9IKCpLdqZ/2f0Jfdnv0KI3iS4CjugYDaPuJMsSmVGzlFFj381aw4T5XzHEtPM2lT9UBztp+D2VSS36rTQKkZQyL/GsaC3A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650397; c=relaxed/simple; bh=lXUNGUc3oMf6fcKTpcyTQn+I/dkgp7Q2clB33fEtKlA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m9a0Gqv6u3il/gMeE4KeyhJz8zDQgDUEsL7wdnxkFibCl8oTffmG/Pe+v/d+auuTqo4hJywHv/nn57ekdaaRJF825kn3fVLNcS2DDroxPu7Hci08iSkRN4IU0zwwj2Cu5E2wY0V3YkheBn9h1qAfHW0KRb8DOUIdP662vfVBpF8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005S5-H8; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UG-000XVR-06; Mon, 16 Mar 2026 09:39:44 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id C060F5049C6; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:10 +0100 Subject: [PATCH spi-next 09/11] spi: spi-fsl-lpspi: make struct lpspi_config::mode u32 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-9-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=794; i=mkl@pengutronix.de; h=from:subject:message-id; bh=lXUNGUc3oMf6fcKTpcyTQn+I/dkgp7Q2clB33fEtKlA=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfvBY9X/VsvQyjk0aPaYpO3wj59bdnx87X/H7ogkWy yU9XI9XdJSyMIhxMciKKbIs/XFCUSDQobT3ZcIkmDmsTCBDGLg4BWAiESsZGVYtfZ11OPj19HVz Cha9E9daPJNbntXCI/a/zSZZtdYbkc8ZGVb+Ybn898Pdbvv3fCxua3guGQvN+XZnmmzSJ70V+tV dfcwA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The struct lpspi_config::mode holds a copy of the mode of struct spi_device::mode. In commit 937e6d756422 ("spi: expand mode support") the struct spi_device::mode was increased from u16 to u32. Increase the struct lpspi_config::mode to u32 avoid truncating the mode variable. Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index ae06bc06f626..9ec5554b4fc0 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -104,7 +104,7 @@ struct lpspi_config { u8 bpw; u8 chip_select; u8 prescale; - u16 mode; + u32 mode; u32 speed_hz; u32 effective_speed_hz; }; --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4977371CF9 for ; Mon, 16 Mar 2026 08:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650397; cv=none; b=TnqKUgmIlySZtF6R1WdNjBC21wuhdiQGqPkSv98iQZXkkjUfSc2iWkFHjgT1zMGFq+R6Q4ii7vd61zBC5B963YyfGp4/Av5FYC/2bdeJAvZB9jDjZgjFpRmiEkf2ZGdqGopUk5H9goQ6lGX+bcLgkWFPJhW2U/P3JKQXDRFm5gs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650397; c=relaxed/simple; bh=Xl/Vup7v7SMiBJVnSPHfx+fZf3L1th1+3qi6PfO90BE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nTuqopqmrJy8UwveXlveDer1/tq6+7rBtyBIH5GsPpNZCoIrdZBnD8xr1ir2SfnVbNl6D1GZb1ogd/3dkgIYtO32xFJPoe8FajgR6u/en4Z+OPc+j3PB7jUw0U75yq1aJJvB7y082WR7olqt9KdgN6K+0y+ZsrRW7mGGv91URNk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005SO-ML; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UG-000XVV-0R; Mon, 16 Mar 2026 09:39:44 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id C9FA75049C7; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:11 +0100 Subject: [PATCH spi-next 10/11] spi: spi-fsl-lpspi: fsl_lpspi_set_cmd(): use mode from (struct fsl_lpspi_data::config::mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-10-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde , Marek Vasut X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=2102; i=mkl@pengutronix.de; h=from:subject:message-id; bh=Xl/Vup7v7SMiBJVnSPHfx+fZf3L1th1+3qi6PfO90BE=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfvB4ZuYJnYeCaWqv+RgZrj0Urz9fEWSxK6znw+7Dl 8xZL2e/6yhlYRDjYpAVU2RZ+uOEokCgQ2nvy4RJMHNYmUCGMHBxCsBEzt9mZFgXHyPAzJCfFLXv /PV5R1J237pfcV22JudW0F3DWyeX7l7P8D8sf1V76ef0ogXF2bkMoZ3iv4rMFvbuF9i/bJp7/UL zeewA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Commit 7ae4d097b752 ("spi: spi-fsl-lpspi: Handle clock polarity and phase") enhances the driver with clock polarity and phase handling. That commit adds a 2nd argument ("struct spi_device *spi") to the fsl_lpspi_set_cmd() function. The "spi" pointer is used to access the "mode" of the current transfer. However the mode is already available via "fsl_lpspi->config.mode". To simplify the driver remove the 2nd argument and use "fsl_lpspi->config.mode" to access the mode. Cc: Marek Vasut Signed-off-by: Marc Kleine-Budde Reviewed-by: Marek Vasut --- drivers/spi/spi-fsl-lpspi.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 9ec5554b4fc0..3a0e9726fa71 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -289,8 +289,7 @@ static void fsl_lpspi_read_rx_fifo(struct fsl_lpspi_dat= a *fsl_lpspi) fsl_lpspi->rx(fsl_lpspi); } =20 -static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *fsl_lpspi, - struct spi_device *spi) +static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *fsl_lpspi) { u32 temp =3D 0; =20 @@ -313,10 +312,10 @@ static void fsl_lpspi_set_cmd(struct fsl_lpspi_data *= fsl_lpspi, } } =20 - if (spi->mode & SPI_CPOL) + if (fsl_lpspi->config.mode & SPI_CPOL) temp |=3D TCR_CPOL; =20 - if (spi->mode & SPI_CPHA) + if (fsl_lpspi->config.mode & SPI_CPHA) temp |=3D TCR_CPHA; =20 writel(temp, fsl_lpspi->base + IMX7ULP_TCR); @@ -527,7 +526,7 @@ static int fsl_lpspi_prepare_message(struct spi_control= ler *controller, if (ret < 0) return ret; =20 - fsl_lpspi_set_cmd(fsl_lpspi, spi); + fsl_lpspi_set_cmd(fsl_lpspi); =20 /* No IRQs */ writel(0, fsl_lpspi->base + IMX7ULP_IER); @@ -802,7 +801,7 @@ static int fsl_lpspi_transfer_one(struct spi_controller= *controller, =20 t->effective_speed_hz =3D fsl_lpspi->config.effective_speed_hz; =20 - fsl_lpspi_set_cmd(fsl_lpspi, spi); + fsl_lpspi_set_cmd(fsl_lpspi); fsl_lpspi->is_first_byte =3D false; =20 if (fsl_lpspi->usedma) --=20 2.51.0 From nobody Tue Apr 7 04:25:22 2026 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 299C4320A0E for ; Mon, 16 Mar 2026 08:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650399; cv=none; b=FNQiMQEhWSN5P/tISdTyi18MqANsKJsLEtYozpTRDhCJm22vPjnFO9mkkPG+jHIQpyqsUBm9Ea9ult0GVCfNZj2rTcI59uRrjcP+O1oui4xU9oJELp+PDYa7mPtp3sCbkZzUJtvddI8jCRwHZQFoB/qybu5AkwovqYxmuFqMvfQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650399; c=relaxed/simple; bh=VcVsFXVXdBDU/vd/yvD3vUY6K2KW+9nqzUY0BQPByGM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jZOoJqAZMS6hwF32e8qB6drC5ijh3ez8gEyDKhSIileq5zW+53HAMALGsJ+JTS3ukkUHMamK8DwPK4rk5MLdLJtUeCxAsKzcEUyFs0HQMnsP6HLA+/JC5mSeA5D5CuIu7yfh3Zc5iSQB81olfLi83rqSmBhMXEfSmqe46Yv/hMk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w23UG-0005SL-JD; Mon, 16 Mar 2026 09:39:44 +0100 Received: from moin.white.stw.pengutronix.de ([2a0a:edc0:0:b01:1d::7b] helo=bjornoya.blackshift.org) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w23UG-000XVX-0P; Mon, 16 Mar 2026 09:39:44 +0100 Received: from hardanger.blackshift.org (p4ffb2dc6.dip0.t-ipconnect.de [79.251.45.198]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519MLKEM768 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id E19E95049C8; Mon, 16 Mar 2026 08:39:43 +0000 (UTC) From: Marc Kleine-Budde Date: Mon, 16 Mar 2026 09:39:12 +0100 Subject: [PATCH spi-next 11/11] spi: spi-fsl-lpspi: fsl_lpspi_set_bitrate(): don't treat devtype_data->prescale_max == 0 as a special case Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-spi-fsl-lpspi-cleanups-v1-11-1b695607702d@pengutronix.de> References: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> In-Reply-To: <20260316-spi-fsl-lpspi-cleanups-v1-0-1b695607702d@pengutronix.de> To: Frank Li , Mark Brown Cc: linux-spi@vger.kernel.org, imx@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, Marc Kleine-Budde , James Clark X-Mailer: b4 0.15-dev-5154a X-Developer-Signature: v=1; a=openpgp-sha256; l=2974; i=mkl@pengutronix.de; h=from:subject:message-id; bh=VcVsFXVXdBDU/vd/yvD3vUY6K2KW+9nqzUY0BQPByGM=; b=owGbwMvMwCV2xirl17qZay8xnlZLYsjcfvDEq3eWMtlGthmx6/k/fzkZwF285swiLVsRi7c+9 xWu+rqe6ihlYRDjYpAVU2RZ+uOEokCgQ2nvy4RJMHNYmUCGMHBxCsBEjssw/FMzjf3CfaR8QllL Z7hLc8in1Mnbkk8FHzRZyHtMa76Yjg4jwzlVr+u6v0JTPr3e8XHzGsmfxptWnuK8q9Q+WXnrlO8 vs5kA X-Developer-Key: i=mkl@pengutronix.de; a=openpgp; fpr=C1400BA0B3989E6FBC7D5B5C2B5EE211C58AEA54 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org The i.MX93 is affected by erratum ERR051608, the maximum prescaler value is 1 not 7 as in the original datasheet. On unaffected SoC the maximum prescaler is 7. Commit 783bf5d09f86 ("spi: spi-fsl-lpspi: limit PRESCALE bit in TCR register") added struct fsl_lpspi_devtype_data to hold the system dependent prescale_max value. Commit 9bbfb1ec959c ("spi: spi-fsl-lpspi: Treat prescale_max =3D=3D 0 as no erratum") introduced the special value 0 to signal the default and corresponding run-time check with a conditional operator. To simplify the code, set the prescale_max of imx7ulp_lpspi_devtype_data and s32g_lpspi_devtype_data to 7 and in fsl_lpspi_set_bitrate() directly use the fsl_lpspi->devtype_data->prescale_max. On ARM64 this leads to a reduction of the code of 52 bytes: | add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-52 (-52) | Function old new delta | fsl_lpspi_setup_transfer.isra 956 936 -20 | $x 7144 7112 -32 | Total: Before=3D19675, After=3D19623, chg -0.26% This partly reverts commit 9bbfb1ec959ce95f91cfab544f705e5257be3be1. Cc: James Clark Signed-off-by: Marc Kleine-Budde --- drivers/spi/spi-fsl-lpspi.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c index 3a0e9726fa71..f2c7bb3bc4cc 100644 --- a/drivers/spi/spi-fsl-lpspi.c +++ b/drivers/spi/spi-fsl-lpspi.c @@ -96,7 +96,7 @@ #define SR_CLEAR_MASK GENMASK(13, 8) =20 struct fsl_lpspi_devtype_data { - u8 prescale_max : 3; /* 0 =3D=3D no limit */ + u8 prescale_max : 3; bool query_hw_for_num_cs : 1; }; =20 @@ -143,8 +143,10 @@ struct fsl_lpspi_data { }; =20 /* - * Devices with ERR051608 have a max TCR_PRESCALE value of 1, otherwise th= ere is - * no prescale limit: https://www.nxp.com/docs/en/errata/i.MX93_1P87f.pdf + * Devices with ERR051608 have a max TCR_PRESCALE value of 1, otherwise use + * the register limit of 7. + * + * https://www.nxp.com/docs/en/errata/i.MX93_1P87f.pdf */ static const struct fsl_lpspi_devtype_data imx93_lpspi_devtype_data =3D { .prescale_max =3D 1, @@ -152,10 +154,11 @@ static const struct fsl_lpspi_devtype_data imx93_lpsp= i_devtype_data =3D { }; =20 static const struct fsl_lpspi_devtype_data imx7ulp_lpspi_devtype_data =3D { - /* All defaults */ + .prescale_max =3D 7, }; =20 static const struct fsl_lpspi_devtype_data s32g_lpspi_devtype_data =3D { + .prescale_max =3D 7, .query_hw_for_num_cs =3D true, }; =20 @@ -348,7 +351,7 @@ static int fsl_lpspi_set_bitrate(struct fsl_lpspi_data = *fsl_lpspi) int scldiv; =20 perclk_rate =3D clk_get_rate(fsl_lpspi->clk_per); - prescale_max =3D fsl_lpspi->devtype_data->prescale_max ?: 7; + prescale_max =3D fsl_lpspi->devtype_data->prescale_max; =20 if (!config.speed_hz) { dev_err(fsl_lpspi->dev, --=20 2.51.0