From nobody Tue Apr 7 04:21:19 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A994934F462 for ; Mon, 16 Mar 2026 12:28:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773664094; cv=none; b=qSuTRcA1OANvTmRvXkgNNWEm2G0uBbr5UvGbLIMcQWRrTzF7eSIQ6yHG6q80rUFh03eOi17l44sQrW8Kmx/3360Xalp9zA2XcglGRpRSu4n/Uh163VujOybuQbu2pg8EBFZVAlkG1iCN9ZhGlIExLZVibz2LwD1F6LHQH8N/4bE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773664094; c=relaxed/simple; bh=jdgPOEenPrH+BnN3qahgu+WWKGOOmeDRTpXHshbPST4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=O56V6Wz794q7vHzqf8I8JhjBew2Rpd1x+IzYbDhdpmbOSaUThDU35yYZIViG0kioMfYXyCVrbud62VgkpBi9t8OQeCnKpB1noDRqrCdeM5d+iqJAU5Bsk3F4w2ToXl2o9J7TP9DJjgRDpFFXgJuBkd0JzdCLjC/z7xYbSXVopl8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UHAyRGOx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a4VawkFb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UHAyRGOx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a4VawkFb" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GBqokQ538832 for ; Mon, 16 Mar 2026 12:28:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=mlNTVkadnpS2g8Cs4zpmNH W17FU6Ww633NSchLqv76Q=; b=UHAyRGOx9nbwh5rp/EBjj4mgsT/XhWGVPCjr5P Fh6QmDdJL9AsqdSFM2/ublRDFf42dUhwWQeNFrmKpbDArO7unY8R4kve1ZgkoQuv tUkmReYNJ4+Jf4HhEgjAJP1Z6LX9rgjHlZxUZ6BLkwZeZIlbG/palyimJqCkf/aw Px7U/s1Ha2PLXlk8z79p4gIqEU4jVf6OowGALZ65xEZI3iYj8cOb3Cqiu/6iDQ4f R1hgA64uMDkb+yXxWRaSiw65sM6oMrmOetFeGdyIxLAF7UULKz21M21CphfsKasn azN9svbgN0FWb4IPhsbYYzSjU8axhkwCcMePRSIcE9g3wAyA== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvyy5np2p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 12:28:13 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-35449510446so4133698a91.0 for ; Mon, 16 Mar 2026 05:28:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773664092; x=1774268892; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=mlNTVkadnpS2g8Cs4zpmNHW17FU6Ww633NSchLqv76Q=; b=a4VawkFbz4jDfI8rmIVCUm+JEsTT+X0CT0SuDRgiFjjqtxRPsxclZGzqlFvI+IiIEP 998ZDFAiGNEg3V8RU6dpqIMSZidfF/lLyuEXuGb0c2nSv0ks39Op4u366GbLU0nbk1RD hpjEAlYmDhkzfR9AW2T4dW6Rjkpxg/OKTCKP0OZ4IgUD+Hs4wUc6A8WZYmLdaMXA+KvO 6Uq0rrqAP7xI1f+g23Gnx9+6D8gyHcVk0nv+aj7K5g8VIJocwG37ARLkTVmhFm3FMuGR qb9kEpax55ADibNxdBKLLewTXMQ19prVS6LkscJCW4mDocBjlh31pibndCVcFE9V3+hE 3DIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773664092; x=1774268892; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mlNTVkadnpS2g8Cs4zpmNHW17FU6Ww633NSchLqv76Q=; b=a/8fpmNCkONGSYNs2+/QL+Q2XNYgIN5C2uufCr6zSLd0lscwPn2hpPBblFSn0yG9AG D1UGPFntpWvpMPKbbw0zvgAES+Adb+S6xEjysCMeGtSFUFST18wwNiWqOiZedHpeNm25 pb5kVYRlYEWRuIhUNtx61VopQR4FKuJJZ2u04CwWYEn7QGPzH5Mm7SfVNJzIETj0sRav likyKv7rT4fJcqvMlN4DKb5g+AMwmIkqtuwqeRybW6HqTIkq6auoQ6nsbSHlKH7sY0Ml pUoF30XX4F//4BqlQYErwDPCta2BhbHjmuWh5Bw4nPEr/wqW2knAhaMs/pVvtPyxwpLo oOXg== X-Forwarded-Encrypted: i=1; AJvYcCXAo5+B1QYXkiK/vbSBhmdGhYQt2PCiI2CYVfEpN0X/5S7EWrpYCb03IfGQJ6fmGT3YfOrXJ39r4kuXQJw=@vger.kernel.org X-Gm-Message-State: AOJu0Yzbz+eAuvvgpOUe00OVCE8EELkezl3XWCBAbnEXGKV4DHyo2jeS YSEaJmRlbXGMVylybSpcRo5maZ4PENmeme7YJ6DlZGIIqh/osZAx9KVsB/ux7+YFdsf3bZa2sC6 kwL6A6ZYUf1R3gg+fbkpIjq2tcYssCDrSZPXWhf2cPQ6A1jnPzoHZCdfQGeInAODfMWQ= X-Gm-Gg: ATEYQzy3Jl5XI8W+HAxbWNm0mkwqySk6wJkMIbGas/O7trFy42CUHqec3FjyVx9ZjLs DgRS32liaFsEa0Wf2ylPFwj90TT9bAL937RFggjBpPH9WF254UgZAMubTY3aXeJlyyQFPUp6b4a W8MJjMgEWhwQQW0ZMzFxPBzmJH8SFmwl9Ww7OfoCPl1nKDayfWcdIpJ136hMXPr3Pm1r0BDxrnS DRje5xzSD14yeBuQePaRshLFFhA2zeI2M2ZpcybAzIcMJsw3zmF3uGnKo6xXT8QONb27ryUBZuA D9vgzkYf+Kjvz1jrFgnSmeP2ZeP3SMi0+WVBK0ENFrcN68/N06+hOycuYJkLeBAnRsK7fQ3BJoO kr7hre+5OlYO/eYJyhs30sn+OphSdJACHAUcWHZdgUNteONuKvw== X-Received: by 2002:a17:90b:3d05:b0:359:ff8a:ee4c with SMTP id 98e67ed59e1d1-35a21ed3e2bmr10913623a91.11.1773664092386; Mon, 16 Mar 2026 05:28:12 -0700 (PDT) X-Received: by 2002:a17:90b:3d05:b0:359:ff8a:ee4c with SMTP id 98e67ed59e1d1-35a21ed3e2bmr10913601a91.11.1773664091804; Mon, 16 Mar 2026 05:28:11 -0700 (PDT) Received: from hu-wasimn-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35b8e1cb60esm3293429a91.2.2026.03.16.05.28.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 05:28:11 -0700 (PDT) From: Wasim Nazir Date: Mon, 16 Mar 2026 17:57:54 +0530 Subject: [PATCH] remoteproc: qcom: Fix leak when custom dump_segments addition fails Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-rproc-memleak-v1-1-96b1518a1a61@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIAEr3t2kC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDY0Mz3aKCovxk3dzU3JzUxGxdYzPz1DSLVMNEM5MkJaCegqLUtMwKsHn RsbW1AAwtd1xfAAAA X-Change-ID: 20260316-rproc-memleak-367ef8e1a64b To: Bjorn Andersson , Mathieu Poirier Cc: kernel@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Wasim Nazir X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773664088; l=1864; i=wasim.nazir@oss.qualcomm.com; s=20250807; h=from:subject:message-id; bh=jdgPOEenPrH+BnN3qahgu+WWKGOOmeDRTpXHshbPST4=; b=X2/Br6O8Y/+walmutcPBiPVp3+IrMDGWdFDFJ0FaYqdFv5pe/k/isPU52HZXBnlNfwdCRZE/Z Topm7iLHkIUD/F02Bs7YGKIjSp7oGOa9S+W0FC+MdF+4q/HCkzTJ4e5 X-Developer-Key: i=wasim.nazir@oss.qualcomm.com; a=ed25519; pk=4ymqwKogZUOQnbcvSUHyO19kcEVTLEk3Qc4u795hiZM= X-Proofpoint-GUID: 0H3PPDhlUOTy4QDUcMUMhIwY7v626Eso X-Authority-Analysis: v=2.4 cv=QOxlhwLL c=1 sm=1 tr=0 ts=69b7f75d cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=LLE1elOOhh-9SNOzqboA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-ORIG-GUID: 0H3PPDhlUOTy4QDUcMUMhIwY7v626Eso X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDA5NSBTYWx0ZWRfX+fmTzv0H8ode 3HoouZ+839Eh5sSF6/CsFEYczqkpPmwjt5Ao3BIR2N0XUxhKjm5LUC2KGlSkIn1vwXb+2X4Zks5 fZGeU/ejo4q5K+nKDv1XSCCkDGiU8LVqUo7PMi47O0rvRd6MWZkHRN4hRnDm7mG71+ezEPB4N+N U9752zcJB59KS1nY8u+msPE5mZz1HSKklc2Ec9jl33hXZj+mVtdcgK23exXgd0b8WKCMw1i+jQb UvhsfdY3lDNy6RaapYMOYz6oHTD2fi1UkAXqOitH4y+EvWDV8almnwvlfHaivlC/lcOe+FUQ17E G91p4wXtNNXdAWL1RkOMaI/hu2LvUbNVIBL3LRTkjlNS6v+xWiY2jrBsGDMkvMviwPJ+iFBiN9T /TsaPDoJTujs8t+lJwdN5kfh9hejUuAFIaZgBDhY5U1Umtby4uC74q407erG306p5TH6PjIizUV lQ8zUAWxQ2AXmwnU+2w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_04,2026-03-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1011 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160095 Free allocated minidump_region 'name' in qcom_add_minidump_segments() when failing before adding the region to 'dump_segments'. Otherwise, the 'name' is not tracked and is never freed by qcom_minidump_cleanup(). Return error when adding to 'dump_segments' fails. Signed-off-by: Wasim Nazir Reviewed-by: Mukesh Ojha --- drivers/remoteproc/qcom_common.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_com= mon.c index 6c31140268ac..aa93d3324561 100644 --- a/drivers/remoteproc/qcom_common.c +++ b/drivers/remoteproc/qcom_common.c @@ -110,6 +110,7 @@ static int qcom_add_minidump_segments(struct rproc *rpr= oc, struct minidump_subsy struct minidump_region __iomem *ptr; struct minidump_region region; int seg_cnt, i; + int ret =3D 0; dma_addr_t da; size_t size; char *name; @@ -130,17 +131,22 @@ static int qcom_add_minidump_segments(struct rproc *r= proc, struct minidump_subsy if (le32_to_cpu(region.valid) =3D=3D MINIDUMP_REGION_VALID) { name =3D kstrndup(region.name, MAX_REGION_NAME_LENGTH - 1, GFP_KERNEL); if (!name) { - iounmap(ptr); - return -ENOMEM; + ret =3D -ENOMEM; + break; } da =3D le64_to_cpu(region.address); size =3D le64_to_cpu(region.size); - rproc_coredump_add_custom_segment(rproc, da, size, rproc_dumpfn_t, name= ); + ret =3D rproc_coredump_add_custom_segment(rproc, da, size, rproc_dumpfn= _t, + name); + if (ret) { + kfree(name); + break; + } } } =20 iounmap(ptr); - return 0; + return ret; } =20 void qcom_minidump(struct rproc *rproc, unsigned int minidump_id, --- base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900 change-id: 20260316-rproc-memleak-367ef8e1a64b Best regards, --=20 Wasim Nazir