From nobody Tue Apr 7 04:20:36 2026 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BD64328B58; Mon, 16 Mar 2026 19:11:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773688261; cv=none; b=Hh4+P2U9W73KtLa4+gbRfyR/QMepnOqBulbgeHXMWzLPVRXMDsiSmBvjIlnJxZ7NLUeRNDcdISe71yxfXlM6wTkRr85twdu5hWHa3w67ndZY3UIPThWGE/JLH4KM+NWSTQiLxOcAuaDsL1qWGS0xiXhvFH79TXF3efelrF3IBX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773688261; c=relaxed/simple; bh=w3zzCs74SGQRUYAzehdZ2v0RymbokOH6Yl7y89mYD2Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WnJEQ56KtPYPnUBI4wXw/uDSfwxc0YIULiEkEIy1uM1hn5g6b9pEZvPvM7lWnwSIjgqf2l50OEMIXAbZlB0wVe9qri5qPMUC0UpRCPuR/9T3D1n+C1kkKSImus6ijZCQWYflZ/F1fUoRcahO1Nx4nQgQBCG8gbUzS8myKYqqELs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=ZjB10VJT; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="ZjB10VJT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1773688259; bh=w3zzCs74SGQRUYAzehdZ2v0RymbokOH6Yl7y89mYD2Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=ZjB10VJTvA/9MYjJQK1K/9NhLKiMow0ZXNstqYVgTcsckBwc3RuqJQ+2mT+N0tVdH t3kmFqq9JZLRjZPGLQysKpyI8UCc5kTndJbg7Ir59QcSQCiUsipaxKkrgUIyE+aU81 W5zm4N78CyWzfs6i8WtTk18mDmu7ysxiGwiIhgFAMAKlAU+8GdEbbJZ6xZZ5Qy8BtX ujJglQ2SN8ZU4rjCCs0HxkkT68CQ2j1FsHKnbA9T71tDKPiVhBI/ITEg4AZQFM3q6I waO/b1yVYCVp7fVDb2eecCE0NPwJy5j28uwuDhyQhpkl1TqYNURlmIQ+RGeTa7vrDj Y5jP6FWAdUhCg== Received: from jupiter.universe (dyndsl-091-248-189-119.ewe-ip-backbone.de [91.248.189.119]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sre) by bali.collaboradmins.com (Postfix) with ESMTPSA id DD3C617E1330; Mon, 16 Mar 2026 20:10:58 +0100 (CET) Received: by jupiter.universe (Postfix, from userid 1000) id 994B948002C; Mon, 16 Mar 2026 20:10:58 +0100 (CET) From: Sebastian Reichel Date: Mon, 16 Mar 2026 20:10:46 +0100 Subject: [PATCH v5 2/8] PCI: dw-rockchip: Move devm_phy_get out of phy_init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-rockchip-pcie-system-suspend-v5-2-5bb5ad37d643@collabora.com> References: <20260316-rockchip-pcie-system-suspend-v5-0-5bb5ad37d643@collabora.com> In-Reply-To: <20260316-rockchip-pcie-system-suspend-v5-0-5bb5ad37d643@collabora.com> To: Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Heiko Stuebner , Philipp Zabel , Jingoo Han , Shawn Lin , Liam Girdwood , Mark Brown Cc: linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Sebastian Reichel X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1528; i=sebastian.reichel@collabora.com; h=from:subject:message-id; bh=w3zzCs74SGQRUYAzehdZ2v0RymbokOH6Yl7y89mYD2Y=; b=owJ4nAFtApL9kA0DAAoB2O7X88g7+poByyZiAGm4VcJ+m/NxYAzY406hnMCHGjeQh4XYy7xkv 8nI0PVeXsCv5okCMwQAAQoAHRYhBO9mDQdGP4tyanlUE9ju1/PIO/qaBQJpuFXCAAoJENju1/PI O/qa+GUP/Au6HE1sXQJHpSS2LLBDex0LdTykJbvLVll7azXKvQCiiQbVaIwx2lRd6Ix38G9MgrA kIfSjp9PEvgTLx11Q+ycvJTh4/cFDybTINoVaWgQGZQ+niQApOHogPI1wUm7NUjx4KsDl9T8Spe IPCiubGIYw5XORNG9Vxc33ga/7ZEk5RSqU9jaSQDK3X6By52imB9xRj7RG/yXBMbRJlWSq3dafF yk3lGy15VjPsk+H0LyNe4ipAU2KtnR1Y2FqzJbFbX/goU72bMvgY+FBlO28DdJ31G9NJCSepqyC 4lfsVTGwcJwkRInntli+ISbrrrFNcR0BpBz8Qh0voXS8/YmUsbwi4ybTNOuxx7cc+nIFeqyO9fl Xxg6Vf+X0BpjhWIUdJDyFkVz/XhJlxsBFxD992dUQ+Oy5UN+94atVLoKWPWqPalTCx+ayKnk4b0 f+Y1Ao4hwXnVQSIBNQjWV0B2wlMPSnvI2wocXqGkqG9A0X/qCRfcDdOz8QgUuEI1zbKzZDY4Ict +K0GNKRqNpNVpiXlPaC7oeaQvsZM3XTCrLUYTk09Nf3CiU1leK91wc2zxyBJT7IhercEuFqAbxh ky+QirsIIyLEsF7NiGKhohm+eUCys9zvIZYsXxM3yxA0QU1i5PFM2TzzrMFdZ/iBRw3d7BpFQqD 24j+PWy1Hkdstbm7l/AkwPA== X-Developer-Key: i=sebastian.reichel@collabora.com; a=openpgp; fpr=EF660D07463F8B726A795413D8EED7F3C83BFA9A By moving devm_phy_get() to the probe routine, rockchip_pcie_phy_init() can be used to re-initialize the PCIe PHY, which is for example needed after a system suspend/resume cycle. Signed-off-by: Sebastian Reichel --- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/co= ntroller/dwc/pcie-dw-rockchip.c index dd482e74f891..0228f7b6f100 100644 --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c @@ -485,14 +485,8 @@ static int rockchip_pcie_resource_get(struct platform_= device *pdev, =20 static int rockchip_pcie_phy_init(struct rockchip_pcie *rockchip) { - struct device *dev =3D rockchip->pci.dev; int ret; =20 - rockchip->phy =3D devm_phy_get(dev, "pcie-phy"); - if (IS_ERR(rockchip->phy)) - return dev_err_probe(dev, PTR_ERR(rockchip->phy), - "missing PHY\n"); - ret =3D phy_init(rockchip->phy); if (ret < 0) return ret; @@ -680,6 +674,13 @@ static int rockchip_pcie_probe(struct platform_device = *pdev) "failed to enable vpcie3v3 regulator\n"); } =20 + rockchip->phy =3D devm_phy_get(dev, "pcie-phy"); + if (IS_ERR(rockchip->phy)) { + ret =3D PTR_ERR(rockchip->phy); + dev_err_probe(dev, ret, "missing PHY\n"); + goto disable_regulator; + } + ret =3D rockchip_pcie_phy_init(rockchip); if (ret) goto disable_regulator; --=20 2.51.0