From nobody Tue Apr 7 06:19:22 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5110327BFC for ; Mon, 16 Mar 2026 04:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773635276; cv=none; b=lgWvYOVOztNcKICQ2kbuOKNQlOWOfLQD0b3fiubXKzOcxKcNm57Jt5s2IIE9zy6IYr8AcTgv7yXQsQK6Y17t58jaFeZZ+MEKA+moHWdnvUEMyFpqVDNtwDpie7ICLlfB/kvWKJmeXG4OzqO5/4WD0Iw5cx1+Ubt0PZF9wC5hZhg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773635276; c=relaxed/simple; bh=Pwe+hISXxf7UnQW3PsrYTHnib7m2N5HUUsdGQZrsYtM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uda2VT+TvVolkNM2IlYPagOJ6r4Dd2fQ41NHeWVYcW7u0GPqEX3M99Cv5woa3/hgHPyV/PHReMmrWAojMYdac9Vk+3B0htnbJxNIFSLBY+6zEGHek/imr2Ykj5QEHrgu86wzbwdLEG9q8ax8RQupXRpGLwt9bIc6PoewM2hMAKw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hO9jI0uR; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hO9jI0uR" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82a3d3235c9so600986b3a.2 for ; Sun, 15 Mar 2026 21:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773635275; x=1774240075; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=AJCl7LHn28MJC1H9+y+noJgdFBK7VWHZCxMkHXcBrlc=; b=hO9jI0uR0s6EaCERseJJIoZtPDTsTQ9fFS9RSWq5ep4fhI3Oxe4Cx/eQwg/1vFlLvy SktrLB/bRodrnTv11slCZwT3obP0cjQmTSSE9apq4PbtnIdgm0cP3nXOLFDbLjRiJE7s pzXTgMugJITD3HZqfgxg0YfRzCG9AGgrgs9HZhEE+mYZElZx5qTFmh1gEUqYbOovAWJ4 ge8FqVr8fWrPAsGsZn9fFnzEXbDtLacL0BxNMOAyqniXm4uhh6uVe+al3E6HrHMK/eVf q/IAI4Zd2eiKkTBI1ITr+rvuXgScCyXO7yK7vzKlau8iwlJcI+lmXltdYc9R1MW0GdCM xmDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773635275; x=1774240075; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=AJCl7LHn28MJC1H9+y+noJgdFBK7VWHZCxMkHXcBrlc=; b=o0O2IEtYQJV9K17wTpYPGfsvk3r4MP4J4ji5F4ELM+MqBEndOIghqMBBcAsbrecJwO leSTzGvY8jF5ZJz9AHPTmTG0H+VBXri4TPBOH0u1TZTLwfxW/JunwR1jrl/f5WqgzndQ 5LcV55kH0d0V0dT1HfZKBVhEoN+6XnV3d0wAjepU2dhktLfjNEO5euRlumeX6GH4z3PH s2+dCPkRuZkTGSFL+SgidDaOymVUiPpu7Oerw+ksQn5F+SNKrY3rZLrF/dqCJIXtFYeK nBhPNVL17wHaPFa0EsvlsLG4EZac8+9fmpZ7CbZKOnAixOpELTQ/7fgBAVRPHFQ1CFiN gqOg== X-Forwarded-Encrypted: i=1; AJvYcCXGAMlSuvJYl8Zw2NJLq9AV6M1tMjJn0ragK2eGv2dqS39d9BL4RCQsyYoByp0utLGt4eqaU3g0hFyUgMA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywqj/mv3ZhVNIUeT/j10nK7lE6/SZ2ci79gnQHfuvepF42KOo3+ 59a/kuYOTJ+h93kmisxoQzO6mD4uL+bUMeFTA8cAYrTeVBORrbypIYgh X-Gm-Gg: ATEYQzzcr6pge23asbKqxF+aHgq+odFHAEbv9B0dHA8pfoC8bnYtDT8mw/WgZXXrvfR vNQI2wvSAwmBxIH6AO4P0pJSqoEy99F6D++lk9TSrmONjS3Mp8s/scAgfb6j/Mm13PSWEidQs/y HrXBC05ir8nBw1CmRLHRd9+yxPniwQK1Bg7oHGTLa0C8Gte6VEwn4xukYWEpD5korn10t9lPHnx le7dNEya+AzugwZtY/d1mze/vocuKxrNF+56eoyKXuUxmrwhbu6rAOJJpuWSrPMqekbtRKM2dP8 lH7iuHsUoO17O0kqBcBK7YcEM7LDZGhmmwOX8DBXNEaHK6H7LfZBNbe7dVwxBFVBrM4w0R6oced PGRm/GaiUZ8gAsUV1w1yqpc4q3uokOlUsCyOIY6kz5J3K3R/wvesQ704a1DvLki9qZIcexmzuN8 x3OXzBklgkj1Bt193q1GyI+QWhR3Y78pisaQHT153E2C/n23Vq8/CGOMDxxw== X-Received: by 2002:a05:6a00:929f:b0:829:822e:cdc9 with SMTP id d2e1a72fcca58-82a1970498amr10804962b3a.2.1773635275161; Sun, 15 Mar 2026 21:27:55 -0700 (PDT) Received: from 1.0.0.127.in-addr.arpa ([240e:34c:5760:3860:bc29:deed:92d0:823c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0738422esm12180267b3a.55.2026.03.15.21.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 21:27:54 -0700 (PDT) From: Hangbin Liu Date: Mon, 16 Mar 2026 12:26:13 +0800 Subject: [PATCH net-next v3 5/5] net: no need to disable LRO specifically Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-offload_compute-v3-5-a5d4a07d86d3@gmail.com> References: <20260316-offload_compute-v3-0-a5d4a07d86d3@gmail.com> In-Reply-To: <20260316-offload_compute-v3-0-a5d4a07d86d3@gmail.com> To: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Nikolay Aleksandrov , Ido Schimmel , Simon Horman , Sabrina Dubroca , Sridhar Samudrala Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux.dev, Hangbin Liu X-Mailer: b4 0.14.3 In commit "net: use ndo_update_offloads to set offload features for bonding/bridge/team" we called netdev_change_features() in __netdev_upper_dev_link(), which will disable LRO automatically on lower device if upper device doesn't have LRO enabled. So we don't need to dev_disable_lro() again after netdev_upper_dev_link(). Signed-off-by: Hangbin Liu --- drivers/net/bonding/bond_main.c | 3 --- drivers/net/team/team_core.c | 3 --- net/8021q/vlan.c | 2 -- net/bridge/br_if.c | 2 -- net/hsr/hsr_slave.c | 1 - 5 files changed, 11 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_mai= n.c index ea6bb20f9348..f4f6ae02f7ca 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -2221,9 +2221,6 @@ int bond_enslave(struct net_device *bond_dev, struct = net_device *slave_dev, } #endif =20 - if (!(bond_dev->features & NETIF_F_LRO)) - dev_disable_lro(slave_dev); - res =3D netdev_rx_handler_register(slave_dev, bond_handle_frame, new_slave); if (res) { diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c index affbcc6fc130..4f18205dd30d 100644 --- a/drivers/net/team/team_core.c +++ b/drivers/net/team/team_core.c @@ -1191,9 +1191,6 @@ static int team_port_add(struct team *team, struct ne= t_device *port_dev, goto err_enable_netpoll; } =20 - if (!(dev->features & NETIF_F_LRO)) - dev_disable_lro(port_dev); - err =3D netdev_rx_handler_register(port_dev, team_handle_frame, port); if (err) { diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index 2b74ed56eb16..fda3a80e9340 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -193,8 +193,6 @@ int register_vlan_dev(struct net_device *dev, struct ne= tlink_ext_ack *extack) vlan_group_set_device(grp, vlan->vlan_proto, vlan_id, dev); grp->nr_vlan_devs++; =20 - netdev_update_features(dev); - return 0; =20 out_unregister_netdev: diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 030248bc94c5..0aa653a1e651 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -620,8 +620,6 @@ int br_add_if(struct net_bridge *br, struct net_device = *dev, if (err) goto err5; =20 - dev_disable_lro(dev); - list_add_rcu(&p->list, &br->port_list); =20 nbp_update_port_count(br); diff --git a/net/hsr/hsr_slave.c b/net/hsr/hsr_slave.c index 44f83c8c56a7..4b6ab185392b 100644 --- a/net/hsr/hsr_slave.c +++ b/net/hsr/hsr_slave.c @@ -169,7 +169,6 @@ static int hsr_portdev_setup(struct hsr_priv *hsr, stru= ct net_device *dev, res =3D netdev_rx_handler_register(dev, hsr_handle_frame, port); if (res) goto fail_rx_handler; - dev_disable_lro(dev); =20 return 0; =20 --=20 Git-155)