From nobody Tue Apr 7 06:19:22 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AF4F339866 for ; Mon, 16 Mar 2026 04:27:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773635253; cv=none; b=ZCmHDIM/nAUxkT+iCvYeWmVofe+KgnOD/qYQJ1SGC105oRWsP7laor39CUURcqj2sJMiLlLOshp+CnU9z6bFiV5GwpRf+TZFaddXP/SV6x2HRyREWZzWW36/p3tf22h/PKD8yKShvi4dWxVOF9rdeyTxvekGgBKEV74sxJIZSEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773635253; c=relaxed/simple; bh=pbtKIDznCvGEVtQHODrKsx+vVNFY8ZkNIx/vZ7lzIsQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lvxaCH9SQIMWCFR/DdTUlpVyXrZW/3u1GDYbRN5wW+0cwpE7LmxfUNrIIM0Gh7AKfkPhBN9xliYP57qexLIpcMppV9wkTswHuIYt1YtW1RuABUTXPaNaNM1KyOChoJvgYsxVnzOSTuHuRUOq13Jqz1XsMsMwxnZ4eY/X9xGW0NI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SRUbqmgC; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SRUbqmgC" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-82976220e97so2413256b3a.3 for ; Sun, 15 Mar 2026 21:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773635250; x=1774240050; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JPGq7YNOGl3DkR8NTBoIGDJAXGD2GV5oTegfoP6i0Xk=; b=SRUbqmgCkNbCavGRvSw5aN03HhEmlPtqPTWYZmG/Ksx5ZmK5WHW0+6F95Xg/7x31Ra p2kos3qMmPlnEqrn9n4D4Lk1LDw+HQ1EqBt+q4axlc5pGZGlr6nRNVZM1DRAZT6yUD4q l4H5upzafiE6zyks24TE6DQcgDWzVhXQ+na3mO2Tw50eWonWHEvOsllP2p15N55AzMuC npvw9I24a/pMWPD3PigokPRIL5OAPfOy1KJIffMiQ4fZXaG/QLcDdtiwzcbZ8AeaQKER 9MOSoeBCduktbLEZT4jFwUr1YMNVYxlMOWV90DdmsXotnj9tT0jLWJn0+fxFm13NWU4h IgbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773635250; x=1774240050; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JPGq7YNOGl3DkR8NTBoIGDJAXGD2GV5oTegfoP6i0Xk=; b=L1UFuX9d+9gv+zGxpvKoqgp6EwevFjfI94IkVPCmggKpt4tjLHqXwiC8zCvKHg9yCu gi722NnoIwaeibPnSU+Zk0/zdMO3pub0Otgt1nyvIKFDFf7ASlK6YSEIfp02HYy9ntW5 +OrAOVYaToWul8+Ta0BS0F5cbfGIE1qBw5BCt4lhnsrqqdFa32q00WZ23x5g7cJ/Ojxn +3NUMkqDM9B/SqaLpszbBRs1Yr2i/3OmhPpaKxTmknIlRu+hoWLeNyQiAKWSM8xUdSFV +6iAkTi5N8Y/m5Jzu7rn+bkPQw6qVINTYHnb153WDLGDLB5WVIKyqbw3HgnJZ86Igbe1 FoIQ== X-Forwarded-Encrypted: i=1; AJvYcCVjNta5yEUInwgOIR3kYFyDaKqSPqSnIfS/sWnUxFdWu0HvRk/0FxEfNTD8PCFx1YCRALf2EzXFaZweZKo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy+6zLWU8o4kJTrK3daBxx2u64ViOQlUy3bjlPPUYJ3yoAyYCZk dG3kqNUokd39jOJz5HVu4zsFRfib8EEVV4rIfLPrXflDadRQ81soYSBq X-Gm-Gg: ATEYQzwxjL2twsHUvfbX4ppv6Mvp0zXMclKbtdxE+pQwgWv1MFR4ahlMEtV8EOHNaVl k5qYjw90mfWRaz7KysMAi2Rtb8Zjkz0UQOK3ruJMa2VII+7516eBBtOlqxTUpxLRxiyGj1G1Flv zm2Pv4zBnJyd/eQFkyD5uQzdBcHlBrJAQJS2tKm3Qln8V3a6NbPtHZg39QpAfxBkx0ybtAjLVLm srpQg9iK+uTxRNRIsFqzxMhKfRapX8fRCNBORBg3s0BBF2UVvGj+4InHts/HzTbRUmaWpG1gbP6 sh1Ej2ocu0cy+zFSDeh6/EjZn5ekXFXpb/6+YnVcCLuZ5DhqQeURUGeOIotOFCot4jdJgF7eUma VJcVdZckbVgNYNK1KoUHtN6t3NlTIZmDVhXqMwcL5wl8QGG4/jolWPBA8C4z5ZIJ35ogGgQi+SX nQhPtRVw5IY5aluunRerPbsiC7JHbd4z4UpkU1lNgQ899Ksvv5LhJpBOli8jBhl85Z1nfE X-Received: by 2002:a05:6a00:981:b0:82a:110b:e22d with SMTP id d2e1a72fcca58-82a1971e6f9mr10199007b3a.24.1773635249914; Sun, 15 Mar 2026 21:27:29 -0700 (PDT) Received: from 1.0.0.127.in-addr.arpa ([240e:34c:5760:3860:bc29:deed:92d0:823c]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82a0738422esm12180267b3a.55.2026.03.15.21.27.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Mar 2026 21:27:29 -0700 (PDT) From: Hangbin Liu Date: Mon, 16 Mar 2026 12:26:11 +0800 Subject: [PATCH net-next v3 3/5] macsec: move netdev_upper_dev_link() after macsec_changelink_common() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-offload_compute-v3-3-a5d4a07d86d3@gmail.com> References: <20260316-offload_compute-v3-0-a5d4a07d86d3@gmail.com> In-Reply-To: <20260316-offload_compute-v3-0-a5d4a07d86d3@gmail.com> To: Jay Vosburgh , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Pirko , Nikolay Aleksandrov , Ido Schimmel , Simon Horman , Sabrina Dubroca , Sridhar Samudrala Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bridge@lists.linux.dev, Hangbin Liu X-Mailer: b4 0.14.3 After calling netdev_change_features() in __netdev_upper_dev_link(), the call stack looks like: - netdev_upper_dev_link - __netdev_upper_dev_link - netdev_change_features - notifier_call_chain - rtnetlink_event - rtmsg_ifinfo_event - rtmsg_ifinfo_build_skb In macsec, we call netdev_upper_dev_link() before macsec_changelink_common(), which causes the fields of the MACsec Security Entity to be uninitialized. Later, macsec_fill_info() returns -EMSGSIZE and triggers WARN_ON() in rtmsg_ifinfo_build_skb. Fix this by moving netdev_upper_dev_link() after macsec_changelink_common(), and return 0 if secy->key_len is not initialized yet. Suggested-by: Sabrina Dubroca Signed-off-by: Hangbin Liu Reviewed-by: Sabrina Dubroca --- drivers/net/macsec.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index f6cad0746a02..6bb38084bc1e 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -4161,10 +4161,6 @@ static int macsec_newlink(struct net_device *dev, lockdep_set_class(&dev->addr_list_lock, &macsec_netdev_addr_lock_key); =20 - err =3D netdev_upper_dev_link(real_dev, dev, extack); - if (err < 0) - goto unregister; - /* need to be already registered so that ->init has run and * the MAC addr is set */ @@ -4177,12 +4173,12 @@ static int macsec_newlink(struct net_device *dev, =20 if (rx_handler && sci_exists(real_dev, sci)) { err =3D -EBUSY; - goto unlink; + goto unregister; } =20 err =3D macsec_add_dev(dev, sci, icv_len); if (err) - goto unlink; + goto unregister; =20 if (data) { err =3D macsec_changelink_common(dev, data); @@ -4190,6 +4186,10 @@ static int macsec_newlink(struct net_device *dev, goto del_dev; } =20 + err =3D netdev_upper_dev_link(real_dev, dev, extack); + if (err < 0) + goto del_dev; + /* If h/w offloading is available, propagate to the device */ if (macsec_is_offloaded(macsec)) { const struct macsec_ops *ops; @@ -4200,7 +4200,7 @@ static int macsec_newlink(struct net_device *dev, ctx.secy =3D &macsec->secy; err =3D macsec_offload(ops->mdo_add_secy, &ctx); if (err) - goto del_dev; + goto unlink; =20 macsec->insert_tx_tag =3D macsec_needs_tx_tag(macsec, ops); @@ -4209,7 +4209,7 @@ static int macsec_newlink(struct net_device *dev, =20 err =3D register_macsec_dev(real_dev, dev); if (err < 0) - goto del_dev; + goto unlink; =20 netdev_update_features(dev); netif_stacked_transfer_operstate(real_dev, dev); @@ -4219,10 +4219,10 @@ static int macsec_newlink(struct net_device *dev, =20 return 0; =20 -del_dev: - macsec_del_dev(macsec); unlink: netdev_upper_dev_unlink(real_dev, dev); +del_dev: + macsec_del_dev(macsec); unregister: unregister_netdevice(dev); return err; @@ -4337,7 +4337,8 @@ static int macsec_fill_info(struct sk_buff *skb, csid =3D secy->xpn ? MACSEC_CIPHER_ID_GCM_AES_XPN_256 : MACSEC_CIPHER_ID= _GCM_AES_256; break; default: - goto nla_put_failure; + WARN_ON_ONCE(1); + return 0; } =20 if (nla_put_sci(skb, IFLA_MACSEC_SCI, secy->sci, --=20 Git-155)