From nobody Tue Apr 7 05:44:51 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F14013E92A4 for ; Mon, 16 Mar 2026 18:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773687294; cv=none; b=EbB0GMz88M1DFCHzchv6nYs/O9Z4dB5h+pwo6olZMtDQ+6ke6Z2DK15sEnsDT/QT4f0Rlr91gQA6cXqLGWs1bSjqOb7ME8IBvcbZF5mhaI4XhES76FvyKinWAzlg6qWZDzR4Dy7usOl+tthnv9oFUfaywmICYT/aKjUHY7wnynU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773687294; c=relaxed/simple; bh=upK6uBmdFj3L01J2+uso9YhOoCCeQIlN/0kiddAlHQU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tqwE4d2sAPZ7Mc2cPo8BNmhkpJ+7+oNijBdzjtYG64uP/Gvo9w1r2020qfQYtd9drfMCa+9TANQeGRqRED53QPzYO/pxr60e/dIpTCDwIFYLtICt44OBmYDkP5s9dv2wxMz3mjnwZeA0r/Ty9pNhmRGOWX0MwyFmBYZjtNzQeM0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FDWPKvlA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=A8AF4vqO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FDWPKvlA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="A8AF4vqO" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62GDTQnL041943 for ; Mon, 16 Mar 2026 18:54:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= z4EIReUVZDLLFKrNuhEc4keZuSe+ZzG9lS8i32XVEH8=; b=FDWPKvlAHaShaTjk sJM7otLKs33Mbb0iBqtXnZJef7UulujgwKa4hBv9OkIkEZHlcToLTMGnHhjd++Nu vclRcqntQNhBFq08RkTdfJlGpucoiJ2E6oBNQUPNBs4YNCotRwvT/ixbDcJ1lKst tjdQ8hWU3tBbhCSC+55IhfkB7db6L9X5fhe3VMScUmAN5OkJaQ+kcNWHX0I1xF4X dxZ66St4ZhAM5a17XUiW0aP73mTYDS7vud5XLQsmE5bw1cR0IC+Ak/R/WFiyPYlZ 0H2mvGIuKwUDYw+2GZdvfUe9PMuzDi8cVxp/D3VOMxCDDD6x8CGFfnn0de23kaYY FgQ0Lw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cxdt82g2m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Mar 2026 18:54:49 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8cd76ff19d5so183869885a.0 for ; Mon, 16 Mar 2026 11:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773687289; x=1774292089; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=z4EIReUVZDLLFKrNuhEc4keZuSe+ZzG9lS8i32XVEH8=; b=A8AF4vqOpBmKwaxYRFnAqRzJ/7sxcB4B/5pqxKsL2Rn6HNt6KgjJ0yOe6rXPKSEKeU AKB+zbgQABriOi4B2OmHeK2S2kPFMRrGKfEQB6/46aASGy2cyER4Vbu9Y+RSDbJEygva d+dSDXrUolBnuMl041TutA5tGUxArYihKEEFMNvWAT22qfA8RPYuLLiEztKdHwX/QFBH 2Tqf224nIGIqdEOLpULf/nMR7UrBJaG8fx4uFZ1moDNGxmENQC/tykbn0UBgEFZhPxef oJ0xk1Aprn8XAgnNXX6ky5A+9I2VlnRMkRXY5fYWimad4V9VjrntNlw5e+iOrcAqtacR rsmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773687289; x=1774292089; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=z4EIReUVZDLLFKrNuhEc4keZuSe+ZzG9lS8i32XVEH8=; b=IuM2n5qnudqWU1Mc3lt2eZ/jxo1opc/4EB2L1Ty+w6fkhWMpqIYMwCnJMujg/7PEdx 5tvzG7wlvqZDz/M69GU4O07F63RQle52BfRrlFW1PgkFUaTOY1wumZOOJYIeCaA8vpHq b98KergH7evkDW06OrkavAbaAy4TMZcacxUzRvnZES+/Gq8A2thU5oZN1bYSGOvAOg5h +FBbJAD5eLCGuNjWUXxZmv3dgtD7HeYEVQ8S0i+AfRf22/COc2k/rLS4ns5ha24Ygah0 s8BNXTNk07W5lI2yvFhTAliFwW1B1ftmz50KQ0k9OJo8vEsFnTQIjseyf1nKOmZM7xxQ h6EQ== X-Forwarded-Encrypted: i=1; AJvYcCW7sCwclbxyaSiPGVAhoBfpMjgKit3zUpACvK2FrZhXAisq6WKSK9RWbhPO9yceAfQb4UcVX8rpQpSnncM=@vger.kernel.org X-Gm-Message-State: AOJu0YxwAwkt1WVQc4TdCgm2e/rQ4OAz27i5UVRJzUIk+s1sO5lwK+8m +1YT7uiLTjXvpiOsRVPKS9yhYOaYb4RnjqNsZq5hCelvGD0EZcpRD+OdCSDuDwJ19V5Hqd/EEmo AOHU/Y9qZt4ka3EA+Ui2dCj9PNzNUeD2OsLlxnWg2TR+FZr61QTFskEQg0QDQgiS/TJw= X-Gm-Gg: ATEYQzyjme/I6tUpOEpf+z87w0ZC/CRLiJC7pskBnY+/pGMuNW3D+bOwinaRZrbYPSM HGi1JA49A5T69KOMJwS/YNO9IKhexAnBRlzglzhsvJcHXwiHvpSwwsUzWsn5Y7YrZUYqUmTHi3E wNipxdcTEd8tl3XDOCSqlvYWrhbLMPgJW6sVn5ODxVN054PBOrNOI9QTrP3wvfzH5Ved+/mEn3G lMaOhK8KaTeHkBNIjT7bQx9KT+yFw67V17T/ldQRCehNF13i1EegAc3GZf/wQW20FX6V1LmjD/7 NCKNYDvU6nSW3s3mkccSnXCPYX2IaEStuCHyIn3dwt7jMbkeHCx1SHFFf+IqZduJv2OZjaEQ5dU Ha2ONlPHkD3aNqGV77qtHBRl+EO8AGFqv2+dZXXMpP0i0olmnT7xRE4M8BukPasWzCaACVXSTSr gqLlUwaLLIuMSRXdBbUadHy4ndmJ3GXZlXBBE= X-Received: by 2002:a05:620a:44c2:b0:8cd:e162:1ea3 with SMTP id af79cd13be357-8cde16220b0mr94486785a.58.1773687288914; Mon, 16 Mar 2026 11:54:48 -0700 (PDT) X-Received: by 2002:a05:620a:44c2:b0:8cd:e162:1ea3 with SMTP id af79cd13be357-8cde16220b0mr94483285a.58.1773687288460; Mon, 16 Mar 2026 11:54:48 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38a67e6788csm34108041fa.33.2026.03.16.11.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 11:54:47 -0700 (PDT) From: Dmitry Baryshkov Date: Mon, 16 Mar 2026 20:54:39 +0200 Subject: [PATCH v7 1/8] media: qcom: iris: drop pas_id from the iris_platform_data struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-iris-platform-data-v7-1-fc79f003f51c@oss.qualcomm.com> References: <20260316-iris-platform-data-v7-0-fc79f003f51c@oss.qualcomm.com> In-Reply-To: <20260316-iris-platform-data-v7-0-fc79f003f51c@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=6161; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=upK6uBmdFj3L01J2+uso9YhOoCCeQIlN/0kiddAlHQU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpuFH0ubEYFa4Dlx9O6N7trNrYnXRPb4hC0h5oV GkpaBLrE5+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCabhR9AAKCRCLPIo+Aiko 1YUYB/9dBynUJ17hd3OVea60xaYridXh8eeo8m4uvM+awJIOtMSQ3xUcj+PBJN/ssqBaXP59hH/ UtTOGOoYCBhnoT/sVq6P2ePZXPGdkGtc2F2P1iFXO4WQDPzWXryhA01JfiPfc5e1XqF/WHbLtnU A5CTV5WqiFh3mn2n3w/pm/qs3YjDUhX9U3j5namADNbt/I1T4/lsJuHRrG8BVC92ypbIN/gBXeK PLZV7bxBTen+69OoN7diQi9/d+VQM/+snjB1mRNaFob3pxe3eanJ6cPvBRjkBwb7VRr0Ku5MWNm PGyes73Bs4ovJnD/jxhHG5lce48TEP6w7NmpgkBqAUh/e9/2 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: VhBo252a4KLwbWpAhey7VuqN0UTRvoOc X-Authority-Analysis: v=2.4 cv=CKInnBrD c=1 sm=1 tr=0 ts=69b851f9 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=hYMYe-gnznq9qBW6PAEA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: VhBo252a4KLwbWpAhey7VuqN0UTRvoOc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE2MDE1MCBTYWx0ZWRfXy6NwXtiIQIMH bsUTfbsb1apjF+w347MSw6NSnM2kOuJj2UrFKKzrQ1qDSFHgFL09cVogrbxNzOTdoCwRFbSy1A0 JejJ/b3lzVYQBjymKnqxMRSzQ9VDeSQWaJsVO2FIbMlTfXRW8TUdDVC2LVZZMNEbe3AZ6/lWpnQ 1FFLdOsR+DHWPalG6ZCuax2YCvmlJSXAMJoZ+mogxmyQOG7bSc/F5AFegjMRVTar2aE9jg64whY kATGFRPXGfnbLm4Inqlkel3shbGPrkL/utR9VSZcRnhdHLLqkuris0SaT0Z/VZ0z+mWXbfcOB2T AjYvWNMYt/lsMgVBJN2q39fANm+k5pjE5HdcfN9XCmKxarrX4G7Htxv95OY223QMLDwZ4jpDZw1 hIIDYs1R9kQmgSv5b8DyVjAOmytH3iaQTsyGbRzv4ZfVe19Hyb2D16PxoU8xIj0Mt9sOZjcdQeU eqCG8IN/oWERtdYK18Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-16_05,2026-03-16_06,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603160150 The PAS ID, the authentication service ID, used by the Iris is a constant and it is not expected to change anytime. Drop it from the platform data and use the constant instead. Reviewed-by: Dikshita Agarwal Reviewed-by: Konrad Dybcio Signed-off-by: Dmitry Baryshkov Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/iris/iris_firmware.c | 11 ++++++----- drivers/media/platform/qcom/iris/iris_platform_common.h | 2 -- drivers/media/platform/qcom/iris/iris_platform_gen1.c | 2 -- drivers/media/platform/qcom/iris/iris_platform_gen2.c | 4 ---- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/med= ia/platform/qcom/iris/iris_firmware.c index 5f408024e967..bc6c5c3e00c3 100644 --- a/drivers/media/platform/qcom/iris/iris_firmware.c +++ b/drivers/media/platform/qcom/iris/iris_firmware.c @@ -12,11 +12,12 @@ #include "iris_core.h" #include "iris_firmware.h" =20 +#define IRIS_PAS_ID 9 + #define MAX_FIRMWARE_NAME_SIZE 128 =20 static int iris_load_fw_to_memory(struct iris_core *core, const char *fw_n= ame) { - u32 pas_id =3D core->iris_platform_data->pas_id; const struct firmware *firmware =3D NULL; struct device *dev =3D core->dev; struct resource res; @@ -53,7 +54,7 @@ static int iris_load_fw_to_memory(struct iris_core *core,= const char *fw_name) } =20 ret =3D qcom_mdt_load(dev, firmware, fw_name, - pas_id, mem_virt, mem_phys, res_size, NULL); + IRIS_PAS_ID, mem_virt, mem_phys, res_size, NULL); =20 memunmap(mem_virt); err_release_fw: @@ -79,7 +80,7 @@ int iris_fw_load(struct iris_core *core) return -ENOMEM; } =20 - ret =3D qcom_scm_pas_auth_and_reset(core->iris_platform_data->pas_id); + ret =3D qcom_scm_pas_auth_and_reset(IRIS_PAS_ID); if (ret) { dev_err(core->dev, "auth and reset failed: %d\n", ret); return ret; @@ -93,7 +94,7 @@ int iris_fw_load(struct iris_core *core) cp_config->cp_nonpixel_size); if (ret) { dev_err(core->dev, "qcom_scm_mem_protect_video_var failed: %d\n", ret); - qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); + qcom_scm_pas_shutdown(IRIS_PAS_ID); return ret; } } @@ -103,7 +104,7 @@ int iris_fw_load(struct iris_core *core) =20 int iris_fw_unload(struct iris_core *core) { - return qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); + return qcom_scm_pas_shutdown(IRIS_PAS_ID); } =20 int iris_set_hw_state(struct iris_core *core, bool resume) diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/driv= ers/media/platform/qcom/iris/iris_platform_common.h index f42e1798747c..e4eefc646c7f 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -12,7 +12,6 @@ struct iris_core; struct iris_inst; =20 -#define IRIS_PAS_ID 9 #define HW_RESPONSE_TIMEOUT_VALUE (1000) /* milliseconds */ #define AUTOSUSPEND_DELAY_VALUE (HW_RESPONSE_TIMEOUT_VALUE + 500) /* mil= liseconds */ =20 @@ -226,7 +225,6 @@ struct iris_platform_data { unsigned int controller_rst_tbl_size; u64 dma_mask; const char *fwname; - u32 pas_id; struct iris_fmt *inst_iris_fmts; u32 inst_iris_fmts_size; struct platform_inst_caps *inst_caps; diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen1.c b/driver= s/media/platform/qcom/iris/iris_platform_gen1.c index aa71f7f53ee3..07ed572e895b 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen1.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen1.c @@ -360,7 +360,6 @@ const struct iris_platform_data sm8250_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu-1.0/venus.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8250_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8250_dec), .inst_caps =3D &platform_inst_cap_sm8250, @@ -413,7 +412,6 @@ const struct iris_platform_data sc7280_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu20_p1.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8250_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8250_dec), .inst_caps =3D &platform_inst_cap_sm8250, diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/driver= s/media/platform/qcom/iris/iris_platform_gen2.c index a526b50a1cd3..1f23ddb972f0 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c @@ -934,7 +934,6 @@ const struct iris_platform_data sm8550_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu30_p4.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_sm8550, @@ -1038,7 +1037,6 @@ const struct iris_platform_data sm8650_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu33_p4.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_sm8550, @@ -1133,7 +1131,6 @@ const struct iris_platform_data sm8750_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu35_p4.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_sm8550, @@ -1232,7 +1229,6 @@ const struct iris_platform_data qcs8300_data =3D { /* Upper bound of DMA address range */ .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu/vpu30_p4_s6.mbn", - .pas_id =3D IRIS_PAS_ID, .inst_iris_fmts =3D platform_fmts_sm8550_dec, .inst_iris_fmts_size =3D ARRAY_SIZE(platform_fmts_sm8550_dec), .inst_caps =3D &platform_inst_cap_qcs8300, --=20 2.47.3