From nobody Tue Apr 7 03:12:28 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 975EE39EF02 for ; Mon, 16 Mar 2026 15:30:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675015; cv=none; b=qXQjtXn7IPMg+l3qhPrYuutjNMYcNuq8n50KizmxUfIzO9l4YLjBsJZZaUqPNHq1F0NAQ9MHrCKV4u/VS94zllmwEsKLKPdyKffhH8TWrc91h42BFowewdF6JbsRah/48q/CLv5gzGO9Fp5vZzsCOF3cz39kAHgVQ+mo30hq/T0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773675015; c=relaxed/simple; bh=M9kVaC+3Cr459HgO4DubNcbQRmLEGq9666e5ZHFrwxQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=YIhQcjERgzi7PGEB4jAdozABxvuSxNh3HBCrA4qN6cLN8VFIOHdBzcMx5pEf/ZbRYoCnnFS3OgIHUQA2fGDzVS0StSLbAtB9SssQgTsQsKDpQe2kRBnpzIaAS6eg1EeM3ssnp7Clpfl+YT2uwt/5M9SUSvCUStjbzhfbFp2NiCM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T8fPj7/Q; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T8fPj7/Q" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c73fbdd9b53so530898a12.3 for ; Mon, 16 Mar 2026 08:30:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773675014; x=1774279814; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=aiYHquvove0P0QSfsD4NZMy/bqp6mn9Ek+dpN0QYTm0=; b=T8fPj7/Q9iBc8vAcLciiP1ugBuQhcv1gmhhlHwIzdP6WV2vLilp3azaiPGECYjtpo3 GcMP+QdCpFXUDzYO2z7OtJOmrGpByv+nduS28a5hVvharX+6MgRodeBeeRLGwoMOY1e2 u0nuZ0QzJAxi2wp8LpSFE/2ORYkWm/4hJNG+lJu+tPcKdzZim6mb6YfQM2QUqoMwe8sd /QGzQZOBmfaBk/byTTaiRiBuPqKHlRhrbBeU0OqJygQ8Ud70EwGHL3am9jv1umFSmjLG bn4qXGhqU1ojEbTt2cO94SygwqtH+G4Y7AycGniKt3fHHX0e5UxVcAYwBFOG4U4N1Pcz QrMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773675014; x=1774279814; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aiYHquvove0P0QSfsD4NZMy/bqp6mn9Ek+dpN0QYTm0=; b=iXW6qMTLvjG/inB9wpybXRPYrnaPDFyozPoneFqa9A4Qiux6N4gGBu5foXE3sA9zU8 8biwWR6XH5GfOrahPefp/3WQUBfBlWbgly+ePBVwmMjOjceXYICgW3glXsEFBMLZ0sC+ RRQnrjk5lgwZpw0ZAg4GAhPO6khaXYuRjZ5apttV6/Z8lxnNo9mDRdcep5zdz1/HfyjC FylSPGMUqirCU2J6uRNhHet/JxnxFvRhI5kFDptWs1x3VWplKGDhkCtAfTQfX+50v/Xi Qt2ZTz9pqt1t99jGbPUaQbNl+fEwYPJppUNGzOvixL8nJ8NtppN2IrcFLT7QpD0t+S51 1CGg== X-Forwarded-Encrypted: i=1; AJvYcCW8rmKNJQCo9T6fzeBnvkmM9XP6/QGTOZfOps2bWBdBDfEPn3gI90u4q7ydmcVHyi41kHHsFYiF3+Aj7vw=@vger.kernel.org X-Gm-Message-State: AOJu0YyELU4ojzPm2eKNa+DEt8dllb4kfJ2v02skuCLlMCsyIM5dPEgU AEnJN8iJ2sYUWqxAki5NoFG1GtHJX35gSHYOHQghRaVQISE4WTVHX2JjYBWttqKSiQo= X-Gm-Gg: ATEYQzzRIE5L1jie4D2jOEssleZjDCo0nHqACKz/pEz/mg9eCOxR/DbEWLaPdVBOtWi gWBsqt5kxOdxYWBPXp42Kz0MJSheRqtNow74isvLMV8iwVnk9ljDYh8w113/L31/8LvRNUSYuX2 LR2vZkAYFE0o3tvwzEogRcm9AsP1UP/zwfzN03zFNxIoJXaX89i7gSJuzRBUI0KV4b26LKBb8Fy 1nqNGQcuMY69ppQnHGi/9zrWyEHARwvayn4z50WmRhGKOZl6LymL/k8STc1SETVeiVmVMC7EAvQ 5HrmedBh76ZFqE0WQr9oXxZaQVCWGMkzLUXv4+xdhAn+IrelLRJtBWrhKJlLWvPJDDH2XKvLFjs p5tJzIS2IO0t6oogxHtLdQ40KRtBlhCT+UKrSWhcYQwZOrx0Ny60Fn1Wt6IIMqnei2SYB1FGE9X S7kLUGwJwvXMnlOEtQk/HmyGp0Ed+gKnPVH8yI X-Received: by 2002:a05:6a21:7a97:b0:398:9379:d04d with SMTP id adf61e73a8af0-398ecadb5a2mr12165818637.24.1773675013707; Mon, 16 Mar 2026 08:30:13 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.240]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c73eb996257sm9392478a12.9.2026.03.16.08.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 08:30:13 -0700 (PDT) From: Felix Gu Date: Mon, 16 Mar 2026 23:30:06 +0800 Subject: [PATCH] dwc3: google: Fix PM domain leak in dwc3_google_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-dwc3-google-v1-1-c9bde1b02f62@gmail.com> X-B4-Tracking: v=1; b=H4sIAP4huGkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDY0Mz3ZTyZGPd9Pz89JxU3bQUM0PzJOMUQ8s0UyWgjoKi1LTMCrBp0bG 1tQARqXqVXQAAAA== X-Change-ID: 20260316-dwc3-google-fd617b3d19f5 To: Peter Griffin , =?utf-8?q?Andr=C3=A9_Draszik?= , Tudor Ambarus , Thinh Nguyen , Greg Kroah-Hartman , Joy Chakraborty , Roy Luo , Naveen Kumar Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773675009; l=1291; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=M9kVaC+3Cr459HgO4DubNcbQRmLEGq9666e5ZHFrwxQ=; b=xHLSPpZk8SHQGjWfG7//LJvvpOEyszCJ6PrI6sz+mE35M4OL3AD0FVkQB0UX0IaWqxHIQQNTy 1FneRQRqG+nCC6L0vSU1H/byaZtGy+/ZuQ8rHdQkf3v+SDoHlMMHEt2 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= When syscon_regmap_lookup_by_phandle_args() fails, the function was returning directly without cleaning up the power domain initialized earlier by dwc3_google_pm_domain_init(). Fix by jumping to err_deinit_pdom to properly clean up resources. Fixes: 8995a37371bf4 ("usb: dwc3: Add Google Tensor SoC DWC3 glue driver") Signed-off-by: Felix Gu Acked-by: Thinh Nguyen --- drivers/usb/dwc3/dwc3-google.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c index 2105c72af753..4ca567ec01d0 100644 --- a/drivers/usb/dwc3/dwc3-google.c +++ b/drivers/usb/dwc3/dwc3-google.c @@ -385,8 +385,9 @@ static int dwc3_google_probe(struct platform_device *pd= ev) "google,usb-cfg-csr", ARRAY_SIZE(args), args); if (IS_ERR(google->usb_cfg_regmap)) { - return dev_err_probe(dev, PTR_ERR(google->usb_cfg_regmap), - "invalid usb cfg csr\n"); + ret =3D dev_err_probe(dev, PTR_ERR(google->usb_cfg_regmap), + "invalid usb cfg csr\n"); + goto err_deinit_pdom; } =20 google->host_cfg_offset =3D args[0]; --- base-commit: b84a0ebe421ca56995ff78b66307667b62b3a900 change-id: 20260316-dwc3-google-fd617b3d19f5 Best regards, --=20 Felix Gu