From nobody Thu Apr 2 01:51:04 2026 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48FEE384258 for ; Mon, 16 Mar 2026 08:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650418; cv=none; b=iJXaDzM4vsCYUXM1TVt/6QifyXfTSAnqOb4OSVJVI63Eee2JydKpgYNH8TjgOStTz4YQcMBP7X4S4nXHXSeuQEH5OufrNCNdkxTMOawEkLT6sm+pqVpSPo+CoQw9d62UjaomJUBKq3NDqFvAUifFkUdHaIqb/PYZ6RRpE1Iooss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773650418; c=relaxed/simple; bh=9FSuapwL6VYJkBDXuygJF37yB4ZM2TQecc51n0jy4uk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=X6Ym9g+9AjXDRC9In1aGglku2fCQoiTZvbOHDwrXpPkPs6hjCpfTkds/1jAT2lp6/03kd54jnT4tKRXzPDYveT+HjLqF4cNprDtd7PRIlyX8vc1t5XSvmcIkiX0rCBNHe7N3IyGDr95gkk0oOu3p5qwWbCGNuxA24s5/7GtKSOA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FTcYbblg; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FTcYbblg" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c73d7c8d2daso1057242a12.1 for ; Mon, 16 Mar 2026 01:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773650410; x=1774255210; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OUrKY347+cvTpzMzeKy/hfhwRp97bHtF1nhnnAOOMMo=; b=FTcYbblggEWkAtHJZD0mJ415sC4SxzLXZlV483cMyiEcqj1yqogsTXfoy2LYwACX+J N4KOumKjH71qMOxjfUnwvUiDA6qZMTvqyafnCPRlqswIcjPeOlh2R90ENIu3zukYvvZN Z0qp37Z4o3p2qz0vCHP/6csC/J+jZNc31oJshkbBKNuV63IMRu7kvbiziH4fN/0Ubv3m MyMNoEhxprIX6Yxl3pgzhS8TUAiPP0p/uHe9gl9fBtSoCMae9z5MEKF9/1kmvYY6Z9Bs YG+2QovSFYAqwSY9XPI2ujLdJW14BliFU+ivqxjqfiNfG7ke4tQ5X2o0TbK2JMoskf1S V0Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773650410; x=1774255210; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=OUrKY347+cvTpzMzeKy/hfhwRp97bHtF1nhnnAOOMMo=; b=UVNATTIfuRJaUl69VHX/LXFRIey0moDp+aFL7FmsxXOU8YX18AnXl2wmaYMDYAU5MP Yyohg5WLvdHq3zwIzToe4qAMwMgykstERMSw3gfEP125HIvvrd9h7MHDSQvSDib6uqh8 dcSBBtOqsvt4yU7UcZO3P8eM3ZkdS+iesg3gpog+zKOfXfzsDF7ALpAuVwijWWAY+m4j EwuKcN0zjRAN1XyitjKW8rcby4rLGF9znL37CmJE3k9AJp5o24QX2q4P3Mqj3r8Kv+q1 Yt0lJsTvB/3NKH3khfzuBbLOcKScnK3DuMEEeLKnWbi9N8qp30EgBJBRiOxXofruoGDO E/LA== X-Forwarded-Encrypted: i=1; AJvYcCXEbwnANjfEhlpx0Yx/c0I8B2m58qiOqcUzMJlMt3lmvV2crpJZ8XpqTi37pHinTjT26MizcWW5nBgfmAc=@vger.kernel.org X-Gm-Message-State: AOJu0YxxV5cdu0I0o+NTY+a0V3rJTL7QbcezoT7LgvdJAawkpGGQs6IG i7h77E7Sg0R0l85v+te8klAQ1F3zQ/JFQjFbttssJVvAL0y/uA99Nt1j X-Gm-Gg: ATEYQzwL8T8yqqhUARUr5AMUgi9GcLJcOTTVqmWatyq7Lqs2zYPN16u2B0h2xCJgGCT gSHJ5I6eu8us9dqViD32NGi5j7vGF7ivysvQxEt/h0NFzMmewek/K5plry4H6ogyfL4CkmEpudC bNYA9MixFSJfXbB6KDgT2qGTaa1sA4k3zVpRYkDunvFrszVIln8YsHftvt3i0YMtytR60Zy3V1i 6Uc8tgU4V846myOLt+vqq049z8cu5BYl0t6mbWu8dNkgmzjuUxlp0N/7voMahgHJRxKeEg0IQaC KlgpW/AltEH68p0YBnicN4E11RZl4m235/j9sggrA181tOieGgVrI6LDQ3bQhsndN8uzojvLYvN T1DCsm1FjSKIM14rzmaucAu+DNgRZJHGP5i1ZMbJKFM/xQvBhQIYc9YZ7rgN7qSC1MPeWP92fcH EZhsux77ZU8rloTEr0/Ms= X-Received: by 2002:a17:903:3905:b0:2ae:a70a:2af2 with SMTP id d9443c01a7336-2aecab1ed76mr139356135ad.29.1773650410229; Mon, 16 Mar 2026 01:40:10 -0700 (PDT) Received: from [127.0.1.1] ([218.32.81.133]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b0537b663csm45946865ad.51.2026.03.16.01.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2026 01:40:09 -0700 (PDT) From: Colin Huang Date: Mon, 16 Mar 2026 16:39:34 +0800 Subject: [PATCH v2 2/2] hwmon: (pmbus) Add Delta Q54SN120A1 Q54SW120A7 chip Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260316-add-q54sn120a1-q54q54sw120a7-v2-2-60e6182cc4a7@gmail.com> References: <20260316-add-q54sn120a1-q54q54sw120a7-v2-0-60e6182cc4a7@gmail.com> In-Reply-To: <20260316-add-q54sn120a1-q54q54sw120a7-v2-0-60e6182cc4a7@gmail.com> To: Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Corbet Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, Colin.Huang2@amd.com, Carl.Lee@amd.com, Peter.Shen@amd.com, Colin Huang X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1773650402; l=2286; i=u8813345@gmail.com; s=20260202; h=from:subject:message-id; bh=9FSuapwL6VYJkBDXuygJF37yB4ZM2TQecc51n0jy4uk=; b=Huug8Dk3UF2dSWSD4aGaQRdhri2+VHtZ6act3ArJCqCRfIcwBTnyjtymCejwNJNQrSn2wBDD5 3xfUpJ6e+pVCqG2uUY8GjrI3FoLxOpq66Rq/C+6WHcynyd9a0AeAFpX X-Developer-Key: i=u8813345@gmail.com; a=ed25519; pk=Zlg0WqpCw4qbswOqamTBTXIchwR/3SnYZpy7rjaGMdQ= Add the DELTA chips Q54SN120A1, Q54SW120A7 in q54sj108a2, 1/4 Brick DC/DC Regulated Power Module with PMBus support Signed-off-by: Colin Huang --- drivers/hwmon/pmbus/q54sj108a2.c | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/pmbus/q54sj108a2.c b/drivers/hwmon/pmbus/q54sj10= 8a2.c index 4d7086d83aa3..06f9db4912d7 100644 --- a/drivers/hwmon/pmbus/q54sj108a2.c +++ b/drivers/hwmon/pmbus/q54sj108a2.c @@ -269,6 +269,8 @@ static const struct file_operations q54sj108a2_fops =3D= { =20 static const struct i2c_device_id q54sj108a2_id[] =3D { { "q54sj108a2", q54sj108a2 }, + { "q54sn120a1", q54sj108a2 }, + { "q54sw120a7", q54sj108a2 }, { }, }; =20 @@ -278,6 +280,7 @@ static int q54sj108a2_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; u8 buf[I2C_SMBUS_BLOCK_MAX + 1]; + const struct i2c_device_id *mid; enum chips chip_id; int ret, i; struct dentry *debugfs; @@ -314,8 +317,12 @@ static int q54sj108a2_probe(struct i2c_client *client) dev_err(dev, "Failed to read Manufacturer Model\n"); return ret; } - if (ret !=3D 14 || strncmp(buf, "Q54SJ108A2", 10)) { - buf[ret] =3D '\0'; + buf[ret] =3D '\0'; + for (mid =3D q54sj108a2_id; mid->name[0]; mid++) { + if (!strncasecmp(mid->name, buf, strlen(mid->name))) + break; + } + if (!mid->name[0]) { dev_err(dev, "Unsupported Manufacturer Model '%s'\n", buf); return -ENODEV; } @@ -325,7 +332,10 @@ static int q54sj108a2_probe(struct i2c_client *client) dev_err(dev, "Failed to read Manufacturer Revision\n"); return ret; } - if (ret !=3D 4 || buf[0] !=3D 'S') { + /* + * accept manufacturer revision with optional NUL byte + */ + if (!(ret =3D=3D 4 || ret =3D=3D 5) || buf[0] !=3D 'S') { buf[ret] =3D '\0'; dev_err(dev, "Unsupported Manufacturer Revision '%s'\n", buf); return -ENODEV; @@ -402,6 +412,8 @@ static int q54sj108a2_probe(struct i2c_client *client) =20 static const struct of_device_id q54sj108a2_of_match[] =3D { { .compatible =3D "delta,q54sj108a2", .data =3D (void *)q54sj108a2 }, + { .compatible =3D "delta,q54sn120a1", .data =3D (void *)q54sj108a2 }, + { .compatible =3D "delta,q54sw120a7", .data =3D (void *)q54sj108a2 }, { }, }; =20 --=20 2.34.1